@specific.dev/spectest 0.79.2 → 0.81.0

package/src/daemon.ts

@@ -53,9 +53,6 @@ import {
   coverageAdapters,
   coverageReportsMode,
   validateCoverage,
-  nodeCoverageToolsAvailable,
-  nodeCoverageToolsDir,
-  NODE_COVERAGE_TOOLS_CONTAINER_DIR,
   type CoverageAdapter,
   type CoverageCaptureContext,
 } from "./coverage.js";
@@ -93,7 +90,7 @@ import {
 import { pollUntilReady } from "./harness/ready-poll.js";
 import { runWrapperRules } from "./harness/wrapper-rules.js";
 import type { WrapperDiagnostic } from "./harness/wrapper-rules.js";
-import { cpus } from "node:os";
+import { cpus, tmpdir } from "node:os";
 import { APP_DIR, WORKSPACE, resolveExistingProjectPath, resolveProjectPath } from "./project-files.js";
 import { installFetchWrapper, isTransportError } from "./harness/fetch.js";
 import {
@@ -979,16 +976,9 @@ async function ensureCoverage(svc: NamedService): Promise<string[]> {
   const host = coverageHostDir(WORKSPACE, svc.name);
   await fs.mkdir(host, { recursive: true });
   await fs.chmod(host, 0o777);
-  const flags = [`--volume=${host}:${COVERAGE_CONTAINER_DIR}`];
-  // The conversion tools golden ships (`c8` for `coverage.node()`),
-  // read-only, on the same existence check the adapter makes at capture
-  // — so the VM and the container agree on whether they are there. A
-  // plain `--volume`, never a config `volumes` entry: an absolute-source
-  // volume dir is listed in the delta-restore manifest and wiped.
-  if (await nodeCoverageToolsAvailable()) {
-    flags.push(`--volume=${nodeCoverageToolsDir()}:${NODE_COVERAGE_TOOLS_CONTAINER_DIR}:ro`);
-  }
-  return flags;
+  // Nothing else is mounted: no conversion runs in the container (the
+  // c8 tools mount went with SDK 0.80).
+  return [`--volume=${host}:${COVERAGE_CONTAINER_DIR}`];
 }
 
 /** A `user`/`group` pair resolved to the numeric ids the kernel wants.
@@ -4062,6 +4052,21 @@ function coverageCaptureContext(
       await fs.rename(tmp, file);
       written.add(path.relative(reportDir, file));
     },
+    async readContainerFile(containerPath: string) {
+      // `docker cp` rather than `exec cat`: a source map can be tens of
+      // MB, and the exec path buffers stdout as a string. The copy lands
+      // in the VM's tmp, never in the coverage directory (it would ship).
+      const tmp = path.join(tmpdir(), `spectest-cov-${svc.name}-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+      try {
+        const r = await docker(["cp", `${svc.name}:${containerPath}`, tmp], COVERAGE_CAPTURE_TIMEOUT_MS);
+        if (r.code !== 0) return null;
+        return await fs.readFile(tmp);
+      } catch {
+        return null;
+      } finally {
+        await fs.rm(tmp, { force: true, recursive: true }).catch(() => {});
+      }
+    },
   };
 }
 
@@ -6076,8 +6081,7 @@ async function evalCode(
 
 /** Where the baked compiler lives. Overridable so the typecheck — and the
  *  blocking rules, which always use THIS copy rather than the project's own —
- *  can be driven outside a VM (same convention as
- *  `SPECTEST_COVERAGE_TOOLS_DIR`). */
+ *  can be driven outside a VM. */
 const TYPECHECK_DIR = process.env.SPECTEST_TYPECHECK_DIR ?? "/opt/spectest/typecheck";
 /** Cap on errors shipped in the report; `totalErrors` carries the true count. */
 const TYPECHECK_ERROR_CAP = 50;