@sparkelf/dsh-plus 0.1.0-rc.33 → 0.1.0-rc.34

package/lib/bin.js

@@ -426,6 +426,78 @@ function ensureProfile(paths, consumerDirectory) {
 	writeFileSync(manifestPath, JSON.stringify(manifest, null, 2) + "\n");
 	return true;
 }
+/** Run git in one directory, returning undefined instead of throwing when asked to. */
+function git(root, args, acceptFailure = false) {
+	const result = spawnSync("git", args, {
+		cwd: root,
+		encoding: "utf8"
+	});
+	if (result.status === 0) return result.stdout.trim();
+	if (acceptFailure) return void 0;
+	const detail = result.stderr.trim();
+	throw new Error("git " + args.join(" ") + " failed" + (detail === "" ? "" : ": " + detail));
+}
+/**
+* Apply the reviewed npm-target patches to the profile's installed packages.
+*
+* A standalone installation runs no `apply` step: it installs the distribution from
+* the registry, links the consumer's packages, and starts. The npm patches a
+* distribution declares therefore need an owner that does not require an official
+* source checkout — the source half of the apply step needs one, this does not.
+*
+* The work is idempotent: a patch whose reverse already applies is left alone, so a
+* second start neither re-applies nor fails. A reinstall restores the published bytes,
+* which is why this runs on every start rather than once.
+*
+* @param distributionDirectory - the installed `@sparkelf/dsh-plus` directory.
+* @param profileDirectory - the standalone profile directory.
+* @returns the labels of the patches that were applied.
+*/
+function applyProfileNpmPatches(distributionDirectory, profileDirectory) {
+	const names = requireRecord(requireRecord(JSON.parse(readFileSync(join(distributionDirectory, "package.json"), "utf8")), "Plus distribution manifest").dshPlus, "dshPlus").patchPackages;
+	if (!Array.isArray(names)) throw new Error("dshPlus.patchPackages must be an array");
+	const applied = [];
+	for (const value of names) {
+		if (typeof value !== "string" || value === "") throw new Error("dshPlus.patchPackages entries must be non-empty strings");
+		const patchPackage = resolveInstalledPackage(distributionDirectory, value);
+		const variants = requireRecord(patchPackage.manifest.dshPatch, value + " dshPatch").variants;
+		if (!Array.isArray(variants)) throw new Error(value + " dshPatch.variants must be an array");
+		for (const entry of variants) {
+			const variant = requireRecord(entry, value + " variant");
+			const target = requireRecord(variant.target, value + " variant target");
+			if (target.kind !== "npm") continue;
+			const targetName = String(target.name);
+			const patched = resolveInstalledPackage(profileDirectory, targetName);
+			const file = resolve(patchPackage.directory, String(variant.file));
+			if (git(patched.directory, [
+				"apply",
+				"--reverse",
+				"--check",
+				file
+			], true) !== void 0) continue;
+			git(patched.directory, ["apply", file]);
+			applied.push(value + " -> " + targetName);
+		}
+	}
+	return applied;
+}
+/** Resolve one installed package's manifest from a requiring directory. */
+function resolveInstalledPackage(from, packageName) {
+	const requireFrom = createRequire(join(from, "package.json"));
+	let manifestPath;
+	try {
+		manifestPath = requireFrom.resolve(packageName + "/package.json");
+	} catch {
+		throw new Error(packageName + " is not installed under " + from);
+	}
+	const manifest = requireRecord(JSON.parse(readFileSync(manifestPath, "utf8")), packageName + " manifest");
+	return {
+		name: packageName,
+		version: String(manifest.version),
+		directory: dirname(manifestPath),
+		manifest
+	};
+}
 //#endregion
 //#region lib/types/standalone-cli.js
 /**
@@ -529,6 +601,7 @@ async function start(argv) {
 	const paths = resolvePaths(anchor);
 	const created = ensureProfile(paths, installationRoot());
 	console.log(created ? "Created the plus profile at " + paths.profileDirectory : "Using the existing plus profile");
+	for (const label of applyProfileNpmPatches(paths.distributionDirectory, paths.profileDirectory)) console.log("Applied the reviewed patch " + label);
 	const entry = launcherEntry(anchor);
 	if (options.foreground) return runForeground(entry, options.port, options.host, options.open);
 	const existing = readState(paths.home);

package/lib/types/standalone-cli.js

@@ -14,7 +14,7 @@ import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { newerVersion } from "./registry-versions.js";
 import { DEFAULT_PORT, STOP_GRACE_MILLISECONDS, choosePort, clearState, isRunning, portAvailable, readState, spawnServer, stateDirectory, waitForAuthenticatedUrl, waitForServer, writeState, } from "./standalone-server.js";
-import { STANDALONE_PROFILE, ensureProfile, readDistributionProfile, resolvePaths, } from "./standalone-profile.js";
+import { STANDALONE_PROFILE, applyProfileNpmPatches, ensureProfile, readDistributionProfile, resolvePaths, } from "./standalone-profile.js";
 /** Milliseconds a start waits for the server to answer before reporting failure. */
 const READY_TIMEOUT_MILLISECONDS = 90_000;
 function parseStartOptions(argv) {
@@ -104,6 +104,12 @@ async function start(argv) {
     console.log(created
         ? 'Created the ' + STANDALONE_PROFILE + ' profile at ' + paths.profileDirectory
         : 'Using the existing ' + STANDALONE_PROFILE + ' profile');
+    // The profile symlinks the consumer's packages, so a patch lands on the installed
+    // copy the launcher loads. A reinstall restores the published bytes, which is why
+    // this runs on every start rather than only when the profile was created.
+    for (const label of applyProfileNpmPatches(paths.distributionDirectory, paths.profileDirectory)) {
+        console.log('Applied the reviewed patch ' + label);
+    }
     const entry = launcherEntry(anchor);
     if (options.foreground)
         return runForeground(entry, options.port, options.host, options.open);

package/lib/types/standalone-profile.d.ts

@@ -91,4 +91,21 @@ export declare function resolvePaths(anchor: string, env?: NodeJS.ProcessEnv): S
  * @returns whether this call created the manifest.
  */
 export declare function ensureProfile(paths: StandalonePaths, consumerDirectory: string): boolean;
+/**
+ * Apply the reviewed npm-target patches to the profile's installed packages.
+ *
+ * A standalone installation runs no `apply` step: it installs the distribution from
+ * the registry, links the consumer's packages, and starts. The npm patches a
+ * distribution declares therefore need an owner that does not require an official
+ * source checkout — the source half of the apply step needs one, this does not.
+ *
+ * The work is idempotent: a patch whose reverse already applies is left alone, so a
+ * second start neither re-applies nor fails. A reinstall restores the published bytes,
+ * which is why this runs on every start rather than once.
+ *
+ * @param distributionDirectory - the installed `@sparkelf/dsh-plus` directory.
+ * @param profileDirectory - the standalone profile directory.
+ * @returns the labels of the patches that were applied.
+ */
+export declare function applyProfileNpmPatches(distributionDirectory: string, profileDirectory: string): string[];
 //# sourceMappingURL=standalone-profile.d.ts.map

package/lib/types/standalone-profile.js

@@ -8,6 +8,7 @@
  * the launcher mounts exactly the bundles the profile names and nothing expands a
  * bundle's own list.
  */
+import { spawnSync } from 'node:child_process';
 import { existsSync, mkdirSync, readdirSync, readFileSync, symlinkSync, writeFileSync } from 'node:fs';
 import { createRequire } from 'node:module';
 import { homedir } from 'node:os';
@@ -223,4 +224,76 @@ export function ensureProfile(paths, consumerDirectory) {
     writeFileSync(manifestPath, JSON.stringify(manifest, null, 2) + '\n');
     return true;
 }
+/** Run git in one directory, returning undefined instead of throwing when asked to. */
+function git(root, args, acceptFailure = false) {
+    const result = spawnSync('git', args, { cwd: root, encoding: 'utf8' });
+    if (result.status === 0)
+        return result.stdout.trim();
+    if (acceptFailure)
+        return undefined;
+    const detail = result.stderr.trim();
+    throw new Error('git ' + args.join(' ') + ' failed' + (detail === '' ? '' : ': ' + detail));
+}
+/**
+ * Apply the reviewed npm-target patches to the profile's installed packages.
+ *
+ * A standalone installation runs no `apply` step: it installs the distribution from
+ * the registry, links the consumer's packages, and starts. The npm patches a
+ * distribution declares therefore need an owner that does not require an official
+ * source checkout — the source half of the apply step needs one, this does not.
+ *
+ * The work is idempotent: a patch whose reverse already applies is left alone, so a
+ * second start neither re-applies nor fails. A reinstall restores the published bytes,
+ * which is why this runs on every start rather than once.
+ *
+ * @param distributionDirectory - the installed `@sparkelf/dsh-plus` directory.
+ * @param profileDirectory - the standalone profile directory.
+ * @returns the labels of the patches that were applied.
+ */
+export function applyProfileNpmPatches(distributionDirectory, profileDirectory) {
+    const manifest = requireRecord(JSON.parse(readFileSync(join(distributionDirectory, 'package.json'), 'utf8')), 'Plus distribution manifest');
+    const plus = requireRecord(manifest.dshPlus, 'dshPlus');
+    const names = plus.patchPackages;
+    if (!Array.isArray(names))
+        throw new Error('dshPlus.patchPackages must be an array');
+    const applied = [];
+    for (const value of names) {
+        if (typeof value !== 'string' || value === '')
+            throw new Error('dshPlus.patchPackages entries must be non-empty strings');
+        const patchPackage = resolveInstalledPackage(distributionDirectory, value);
+        const declaration = requireRecord(patchPackage.manifest.dshPatch, value + ' dshPatch');
+        const variants = declaration.variants;
+        if (!Array.isArray(variants))
+            throw new Error(value + ' dshPatch.variants must be an array');
+        for (const entry of variants) {
+            const variant = requireRecord(entry, value + ' variant');
+            const target = requireRecord(variant.target, value + ' variant target');
+            // Only npm targets reach an installed package; a source target needs the
+            // official checkout, which a standalone installation does not have.
+            if (target.kind !== 'npm')
+                continue;
+            const targetName = String(target.name);
+            const patched = resolveInstalledPackage(profileDirectory, targetName);
+            const file = resolve(patchPackage.directory, String(variant.file));
+            if (git(patched.directory, ['apply', '--reverse', '--check', file], true) !== undefined)
+                continue;
+            git(patched.directory, ['apply', file]);
+            applied.push(value + ' -> ' + targetName);
+        }
+    }
+    return applied;
+}
+/** Resolve one installed package's manifest from a requiring directory. */
+function resolveInstalledPackage(from, packageName) {
+    const requireFrom = createRequire(join(from, 'package.json'));
+    let manifestPath;
+    try {
+        manifestPath = requireFrom.resolve(packageName + '/package.json');
+    }
+    catch {
+        throw new Error(packageName + ' is not installed under ' + from);
+    }
+    const manifest = requireRecord(JSON.parse(readFileSync(manifestPath, 'utf8')), packageName + ' manifest');
+    return { name: packageName, version: String(manifest.version), directory: dirname(manifestPath), manifest };
+}
 //# sourceMappingURL=standalone-profile.js.map

package/package.json

@@ -140,5 +140,5 @@
   },
   "type": "module",
   "types": "lib/types/index.d.ts",
-  "version": "0.1.0-rc.33"
+  "version": "0.1.0-rc.34"
 }