@spaceflow/review 5.0.1 → 5.0.3

package/CHANGELOG.md

@@ -1,5 +1,35 @@
 # Changelog
 
+## [5.0.2](https://github.com/Lydanne/spaceflow/compare/@spaceflow/review@5.0.1...@spaceflow/review@5.0.2) (2026-04-14)
+
+### 代码重构
+
+* **review:** 重构问题统计逻辑,修正 pending 计算并复用 calculateIssueStats ([23ddcac](https://github.com/Lydanne/spaceflow/commit/23ddcac7f4d8cf59b295b9b370e15d3a7058eecf))
+
+### 其他修改
+
+* **review-summary:** released version 5.0.1 [no ci] ([41d770e](https://github.com/Lydanne/spaceflow/commit/41d770e9800defbf1f37d15de6a889df598d45ae))
+* **scripts:** released version 5.0.1 [no ci] ([f527047](https://github.com/Lydanne/spaceflow/commit/f5270478d4a85ec19c2cc2ad6028972909fd7320))
+* **shell:** released version 5.0.1 [no ci] ([e04c907](https://github.com/Lydanne/spaceflow/commit/e04c907ae9bd38a73506f9f93ca21ee97a05c606))
+
+## [5.0.1](https://github.com/Lydanne/spaceflow/compare/@spaceflow/review@5.0.0...@spaceflow/review@5.0.1) (2026-04-14)
+
+### 修复BUG
+
+* **review:** 修正已解决问题统计逻辑,避免与已修复问题重复计数 ([6d191bb](https://github.com/Lydanne/spaceflow/commit/6d191bbd71b8ce6194ce56a8d008dd966173541b))
+
+### 代码重构
+
+* **shared:** 移除 Claude Code 相关配置和文档,统一使用 OpenAI/Gemini/OpenCode ([b0754d6](https://github.com/Lydanne/spaceflow/commit/b0754d64f8991a10708730c191cf0f335e8aa6ca))
+
+### 其他修改
+
+* **cli:** released version 5.0.1 [no ci] ([f3009ea](https://github.com/Lydanne/spaceflow/commit/f3009eaaf26759d708541f54e707882b4927ebbd))
+* **core:** released version 5.0.1 [no ci] ([7904b9b](https://github.com/Lydanne/spaceflow/commit/7904b9bbc619c91a3a4fa1c8ea04d9dc548495ad))
+* **core:** 移除 @anthropic-ai/claude-agent-sdk 依赖及相关 sharp 图像处理包 ([7b50e06](https://github.com/Lydanne/spaceflow/commit/7b50e066df97d408eb63707eb27273592a28d34d))
+* **publish:** released version 5.0.1 [no ci] ([b14849f](https://github.com/Lydanne/spaceflow/commit/b14849ffafd38f230a3e69c2d63c468cb1946388))
+* **shared:** released version 5.0.1 [no ci] ([f70cd93](https://github.com/Lydanne/spaceflow/commit/f70cd930b01ffa09187f66522c8d6b18f835ec53))
+
 ## [4.0.1](https://github.com/Lydanne/spaceflow/compare/@spaceflow/review@4.0.0...@spaceflow/review@4.0.1) (2026-04-13)
 
 ### 新特性

package/dist/index.js

@@ -2254,7 +2254,7 @@ function generateIssueKey(issue) {
     const fixed = validIssue.filter((i)=>i.fixed).length;
     const resolved = validIssue.filter((i)=>i.resolved).length;
     const invalid = total - validTotal;
-    const pending = validTotal - fixed - resolved;
+    const pending = validTotal - validIssue.filter((i)=>i.fixed || i.resolved).length;
     const fixRate = validTotal > 0 ? Math.round(fixed / validTotal * 100 * 10) / 10 : 0;
     const resolveRate = validTotal > 0 ? Math.round(resolved / validTotal * 100 * 10) / 10 : 0;
     return {
@@ -2544,7 +2544,7 @@ function generateIssueKey(issue) {
                 }
                 try {
                     const reactions = await this.pr.getReviewCommentReactions(comment.id);
-                    if (reactions.length === 0 || !matchedIssue) continue;
+                    if (!reactions || reactions.length === 0 || !matchedIssue) continue;
                     // 按 content 分组，收集每种 reaction 的用户列表
                     const reactionMap = new Map();
                     for (const r of reactions){
@@ -2720,8 +2720,10 @@ function generateIssueKey(issue) {
             outputFormat: "markdown",
             ci: true
         });
-        // 获取 PR 信息以获取 head commit SHA
-        const commitId = await this.pr.getHeadSha();
+        // 获取 PR 信息以获取 head commit SHA（同时缓存 PR 状态，供后续 closed 检查复用）
+        const prInfo = await this.pr.getInfo().catch(()=>null);
+        const prIsClosed = prInfo?.state === "closed" || !!prInfo?.merged;
+        const commitId = prInfo?.head?.sha || "HEAD";
         // 1. 发布或更新主评论（使用 Issue Comment API，支持删除和更新）
         try {
             if (existingComments.length > 0) {
@@ -2747,6 +2749,11 @@ function generateIssueKey(issue) {
             console.warn("⚠️ 发布/更新 AI Review 评论失败:", error);
         }
         // 2. 发布本轮新发现的行级评论（使用 PR Review API）
+        // PR 已关闭/合并时无法提交行级 Review，直接跳过
+        if (prIsClosed) {
+            console.log(`ℹ️  PR #${this.pr.number} 已关闭/合并，跳过行级 Review 提交`);
+            return;
+        }
         // 保留旧轮次的 review 历史，但清理同轮次的旧 AI review（重复触发场景）
         // 如果启用 autoApprove 且所有问题已解决，使用 APPROVE event 合并发布
         await this.cleanupDuplicateRoundReviews(this._result.round, verbose);
@@ -3131,10 +3138,7 @@ function generateIssueKey(issue) {
         if (round > 1) {
             const prevIssues = allIssues.filter((i)=>i.round === round - 1);
             if (prevIssues.length > 0) {
-                const prevFixed = prevIssues.filter((i)=>i.fixed).length;
-                const prevResolved = prevIssues.filter((i)=>i.resolved && !i.fixed).length;
-                const prevInvalid = prevIssues.filter((i)=>i.valid === "false" && !i.fixed && !i.resolved).length;
-                const prevPending = prevIssues.length - prevFixed - prevResolved - prevInvalid;
+                const { fixed: prevFixed, resolved: prevResolved, invalid: prevInvalid, pending: prevPending } = calculateIssueStats(prevIssues);
                 parts.push("");
                 parts.push(`<details><summary>📊 Round ${round - 1} 回顾 (${prevIssues.length} 个问题)</summary>\n`);
                 parts.push(`| 状态 | 数量 |`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spaceflow/review",
-  "version": "5.0.1",
+  "version": "5.0.3",
   "description": "Spaceflow 代码审查插件，使用 LLM 对 PR 代码进行自动审查",
   "license": "MIT",
   "author": "Lydanne",

package/src/review-result-model.ts

@@ -368,7 +368,7 @@ export class ReviewResultModel {
         }
         try {
           const reactions = await this.pr.getReviewCommentReactions(comment.id);
-          if (reactions.length === 0 || !matchedIssue) continue;
+          if (!reactions || reactions.length === 0 || !matchedIssue) continue;
           // 按 content 分组，收集每种 reaction 的用户列表
           const reactionMap = new Map<string, string[]>();
           for (const r of reactions) {
@@ -585,8 +585,10 @@ export class ReviewResultModel {
       ci: true,
     });
 
-    // 获取 PR 信息以获取 head commit SHA
-    const commitId = await this.pr.getHeadSha();
+    // 获取 PR 信息以获取 head commit SHA（同时缓存 PR 状态，供后续 closed 检查复用）
+    const prInfo = await this.pr.getInfo().catch(() => null);
+    const prIsClosed = prInfo?.state === "closed" || !!prInfo?.merged;
+    const commitId = prInfo?.head?.sha || "HEAD";
 
     // 1. 发布或更新主评论（使用 Issue Comment API，支持删除和更新）
     try {
@@ -612,6 +614,12 @@ export class ReviewResultModel {
     }
 
     // 2. 发布本轮新发现的行级评论（使用 PR Review API）
+    // PR 已关闭/合并时无法提交行级 Review，直接跳过
+    if (prIsClosed) {
+      console.log(`ℹ️  PR #${this.pr.number} 已关闭/合并，跳过行级 Review 提交`);
+      return;
+    }
+
     // 保留旧轮次的 review 历史，但清理同轮次的旧 AI review（重复触发场景）
     // 如果启用 autoApprove 且所有问题已解决，使用 APPROVE event 合并发布
     await this.cleanupDuplicateRoundReviews(this._result.round, verbose);
@@ -1069,12 +1077,12 @@ export class ReviewResultModel {
     if (round > 1) {
       const prevIssues = allIssues.filter((i) => i.round === round - 1);
       if (prevIssues.length > 0) {
-        const prevFixed = prevIssues.filter((i) => i.fixed).length;
-        const prevResolved = prevIssues.filter((i) => i.resolved && !i.fixed).length;
-        const prevInvalid = prevIssues.filter(
-          (i) => i.valid === "false" && !i.fixed && !i.resolved,
-        ).length;
-        const prevPending = prevIssues.length - prevFixed - prevResolved - prevInvalid;
+        const {
+          fixed: prevFixed,
+          resolved: prevResolved,
+          invalid: prevInvalid,
+          pending: prevPending,
+        } = calculateIssueStats(prevIssues);
         parts.push("");
         parts.push(
           `<details><summary>📊 Round ${round - 1} 回顾 (${prevIssues.length} 个问题)</summary>\n`,

package/src/utils/review-pr-comment.spec.ts

@@ -27,9 +27,7 @@ describe("utils/review-pr-comment", () => {
 
   describe("extractIssueKeyFromBody", () => {
     it("提取标准格式的 issue key", () => {
-      expect(extractIssueKeyFromBody("<!-- issue-key: src/a.ts:10:R1 -->")).toBe(
-        "src/a.ts:10:R1",
-      );
+      expect(extractIssueKeyFromBody("<!-- issue-key: src/a.ts:10:R1 -->")).toBe("src/a.ts:10:R1");
     });
 
     it("body 不含 issue-key 时返回 null", () => {
@@ -69,9 +67,9 @@ describe("utils/review-pr-comment", () => {
 
   describe("generateIssueKey", () => {
     it("拼接 file:line:ruleId", () => {
-      expect(
-        generateIssueKey({ file: "src/a.ts", line: "10", ruleId: "R1" } as any),
-      ).toBe("src/a.ts:10:R1");
+      expect(generateIssueKey({ file: "src/a.ts", line: "10", ruleId: "R1" } as any)).toBe(
+        "src/a.ts:10:R1",
+      );
     });
   });
 
@@ -129,21 +127,20 @@ describe("utils/review-pr-comment", () => {
     });
 
     it("resolved（非 fixed）计入 resolved，不计入 pending", () => {
-      const issues = [
-        { file: "a.ts", line: "1", ruleId: "R1", resolved: "2024-01-01" },
-      ] as any[];
+      const issues = [{ file: "a.ts", line: "1", ruleId: "R1", resolved: "2024-01-01" }] as any[];
       const stats = calculateIssueStats(issues);
       expect(stats.resolved).toBe(1);
       expect(stats.pending).toBe(0);
     });
 
-    it("fixed 同时有 resolved 时只计入 fixed", () => {
+    it("fixed 和 resolved 同时存在时各自独立计数，pending 不重复减", () => {
       const issues = [
         { file: "a.ts", line: "1", ruleId: "R1", fixed: "2024-01-01", resolved: "2024-01-01" },
       ] as any[];
       const stats = calculateIssueStats(issues);
       expect(stats.fixed).toBe(1);
-      expect(stats.resolved).toBe(0);
+      expect(stats.resolved).toBe(1);
+      expect(stats.pending).toBe(0);
     });
 
     it("fixRate 计算正确（2/4 = 50%）", () => {

package/src/utils/review-pr-comment.ts

@@ -179,7 +179,7 @@ export function calculateIssueStats(issues: ReviewIssue[]): ReviewStats {
   const fixed = validIssue.filter((i) => i.fixed).length;
   const resolved = validIssue.filter((i) => i.resolved).length;
   const invalid = total - validTotal;
-  const pending = validTotal - fixed - resolved;
+  const pending = validTotal - validIssue.filter((i) => i.fixed || i.resolved).length;
   const fixRate = validTotal > 0 ? Math.round((fixed / validTotal) * 100 * 10) / 10 : 0;
   const resolveRate = validTotal > 0 ? Math.round((resolved / validTotal) * 100 * 10) / 10 : 0;
   return { total, validTotal, fixed, resolved, invalid, pending, fixRate, resolveRate };