@spaceflow/review 5.0.0 → 5.0.2

package/src/review.service.spec.ts

@@ -29,9 +29,6 @@ function mockSummary(overrides: Partial<FileSummary> = {}): FileSummary {
 }
 
 vi.mock("c12");
-vi.mock("@anthropic-ai/claude-agent-sdk", () => ({
-  query: vi.fn(),
-}));
 vi.mock("fs/promises");
 vi.mock("child_process");
 vi.mock("@opencode-ai/sdk", () => ({
@@ -98,9 +95,6 @@ class TestReviewService extends ReviewService {
   executeDeletionOnly(context: Partial<ReviewContext>) {
     return super.executeDeletionOnly(context as ReviewContext);
   }
-  ensureClaudeCli(ci?: boolean) {
-    return super.ensureClaudeCli(ci);
-  }
   resolveSourceData(context: Partial<ReviewContext>) {
     return super.resolveSourceData(context as ReviewContext);
   }
@@ -208,7 +202,7 @@ describe("ReviewService", () => {
       chat: vi.fn(),
       chatStream: vi.fn(),
       createSession: vi.fn(),
-      getAvailableAdapters: vi.fn().mockReturnValue(["claude-code", "openai"]),
+      getAvailableAdapters: vi.fn().mockReturnValue(["openai", "open-code"]),
     };
 
     service = new TestReviewService(
@@ -292,7 +286,7 @@ describe("ReviewService", () => {
         specSources: ["/spec/dir"],
         dryRun: true,
         ci: false,
-        llmMode: "claude-code" as const,
+        llmMode: "openai" as const,
       };
 
       const mockPR = {
@@ -358,7 +352,7 @@ describe("ReviewService", () => {
         specSources: ["/spec/dir"],
         dryRun: false,
         ci: true,
-        llmMode: "claude-code" as const,
+        llmMode: "openai" as const,
       } as ReviewContext;
 
       const mockPR = {
@@ -408,7 +402,7 @@ describe("ReviewService", () => {
         specSources: ["/spec/dir"],
         dryRun: false,
         ci: false,
-        llmMode: "claude-code",
+        llmMode: "openai",
       };
 
       gitProvider.getPullRequest.mockRejectedValue(new Error("Gitea API Error"));
@@ -922,13 +916,6 @@ describe("ReviewService", () => {
     });
   });
 
-  describe("ReviewService.ensureClaudeCli", () => {
-    it("should not throw when claude is installed", async () => {
-      vi.spyOn(require("child_process"), "execSync").mockImplementation(() => Buffer.from("1.0.0"));
-      await expect(service.ensureClaudeCli()).resolves.toBeUndefined();
-    });
-  });
-
   describe("ReviewService.resolveSourceData - direct file mode", () => {
     it("should bypass local uncommitted scanning when files are specified", async () => {
       const context: ReviewContext = {
@@ -1273,46 +1260,4 @@ describe("ReviewService", () => {
       expect(gitProvider.updateIssueComment).toHaveBeenCalled();
     });
   });
-
-  describe("ReviewService.ensureClaudeCli", () => {
-    it("should do nothing when claude is already installed", async () => {
-      const consoleSpy = vi.spyOn(console, "log").mockImplementation(() => {});
-      // execSync is already mocked globally
-
-      await service.ensureClaudeCli();
-      expect(consoleSpy).not.toHaveBeenCalledWith("🔧 Claude CLI 未安装，正在安装...");
-      consoleSpy.mockRestore();
-    });
-
-    it("should install claude when not found", async () => {
-      const consoleSpy = vi.spyOn(console, "log").mockImplementation(() => {});
-      // Mock execSync to throw then succeed
-      const execSyncMock = vi.mocked(await import("child_process"));
-      execSyncMock.execSync
-        .mockImplementationOnce(() => {
-          throw new Error("command not found");
-        })
-        .mockImplementationOnce(() => Buffer.from(""));
-
-      await service.ensureClaudeCli();
-      expect(consoleSpy).toHaveBeenCalledWith("🔧 Claude CLI 未安装，正在安装...");
-      expect(consoleSpy).toHaveBeenCalledWith("✅ Claude CLI 安装完成");
-      consoleSpy.mockRestore();
-    });
-
-    it("should throw error when installation fails", async () => {
-      const execSyncMock = vi.mocked(await import("child_process"));
-      execSyncMock.execSync
-        .mockImplementationOnce(() => {
-          throw new Error("command not found");
-        })
-        .mockImplementationOnce(() => {
-          throw new Error("install failed");
-        });
-
-      await expect(service.ensureClaudeCli()).rejects.toThrow(
-        "Claude CLI 安装失败: install failed",
-      );
-    });
-  });
 });

package/src/review.service.ts

@@ -20,7 +20,6 @@ import { MarkdownFormatter, ReviewReportService } from "./review-report";
 import { ReviewOptions } from "./review.config";
 import { IssueVerifyService } from "./issue-verify.service";
 import { DeletionImpactService } from "./deletion-impact.service";
-import { execSync } from "child_process";
 import { ReviewContextBuilder, type ReviewContext } from "./review-context";
 import { ReviewIssueFilter } from "./review-issue-filter";
 import { filterFilesByIncludes } from "./review-includes-filter";
@@ -730,30 +729,4 @@ export class ReviewService {
 
     return result;
   }
-
-  /**
-   * 确保 Claude CLI 已安装
-   */
-  protected async ensureClaudeCli(ci?: boolean): Promise<void> {
-    try {
-      execSync("claude --version", { stdio: "ignore" });
-    } catch {
-      if (ci) {
-        throw new Error(
-          "Claude CLI 未安装。CI 环境请在 workflow 中预装: npm install -g @anthropic-ai/claude-code",
-        );
-      }
-      console.log("🔧 Claude CLI 未安装，正在安装...");
-      try {
-        execSync("npm install -g @anthropic-ai/claude-code", {
-          stdio: "inherit",
-        });
-        console.log("✅ Claude CLI 安装完成");
-      } catch (installError) {
-        throw new Error(
-          `Claude CLI 安装失败: ${installError instanceof Error ? installError.message : String(installError)}`,
-        );
-      }
-    }
-  }
 }

package/src/utils/review-pr-comment.spec.ts

@@ -27,9 +27,7 @@ describe("utils/review-pr-comment", () => {
 
   describe("extractIssueKeyFromBody", () => {
     it("提取标准格式的 issue key", () => {
-      expect(extractIssueKeyFromBody("<!-- issue-key: src/a.ts:10:R1 -->")).toBe(
-        "src/a.ts:10:R1",
-      );
+      expect(extractIssueKeyFromBody("<!-- issue-key: src/a.ts:10:R1 -->")).toBe("src/a.ts:10:R1");
     });
 
     it("body 不含 issue-key 时返回 null", () => {
@@ -69,9 +67,9 @@ describe("utils/review-pr-comment", () => {
 
   describe("generateIssueKey", () => {
     it("拼接 file:line:ruleId", () => {
-      expect(
-        generateIssueKey({ file: "src/a.ts", line: "10", ruleId: "R1" } as any),
-      ).toBe("src/a.ts:10:R1");
+      expect(generateIssueKey({ file: "src/a.ts", line: "10", ruleId: "R1" } as any)).toBe(
+        "src/a.ts:10:R1",
+      );
     });
   });
 
@@ -129,21 +127,20 @@ describe("utils/review-pr-comment", () => {
     });
 
     it("resolved（非 fixed）计入 resolved，不计入 pending", () => {
-      const issues = [
-        { file: "a.ts", line: "1", ruleId: "R1", resolved: "2024-01-01" },
-      ] as any[];
+      const issues = [{ file: "a.ts", line: "1", ruleId: "R1", resolved: "2024-01-01" }] as any[];
       const stats = calculateIssueStats(issues);
       expect(stats.resolved).toBe(1);
       expect(stats.pending).toBe(0);
     });
 
-    it("fixed 同时有 resolved 时只计入 fixed", () => {
+    it("fixed 和 resolved 同时存在时各自独立计数，pending 不重复减", () => {
       const issues = [
         { file: "a.ts", line: "1", ruleId: "R1", fixed: "2024-01-01", resolved: "2024-01-01" },
       ] as any[];
       const stats = calculateIssueStats(issues);
       expect(stats.fixed).toBe(1);
-      expect(stats.resolved).toBe(0);
+      expect(stats.resolved).toBe(1);
+      expect(stats.pending).toBe(0);
     });
 
     it("fixRate 计算正确（2/4 = 50%）", () => {

package/src/utils/review-pr-comment.ts

@@ -177,9 +177,9 @@ export function calculateIssueStats(issues: ReviewIssue[]): ReviewStats {
   const validIssue = issues.filter((i) => i.valid !== "false");
   const validTotal = validIssue.length;
   const fixed = validIssue.filter((i) => i.fixed).length;
-  const resolved = validIssue.filter((i) => i.resolved && !i.fixed).length;
+  const resolved = validIssue.filter((i) => i.resolved).length;
   const invalid = total - validTotal;
-  const pending = validTotal - fixed - resolved;
+  const pending = validTotal - validIssue.filter((i) => i.fixed || i.resolved).length;
   const fixRate = validTotal > 0 ? Math.round((fixed / validTotal) * 100 * 10) / 10 : 0;
   const resolveRate = validTotal > 0 ? Math.round((resolved / validTotal) * 100 * 10) / 10 : 0;
   return { total, validTotal, fixed, resolved, invalid, pending, fixRate, resolveRate };

package/src/coverage/base.css

@@ -1,224 +0,0 @@
-body, html {
-  margin:0; padding: 0;
-  height: 100%;
-}
-body {
-    font-family: Helvetica Neue, Helvetica, Arial;
-    font-size: 14px;
-    color:#333;
-}
-.small { font-size: 12px; }
-*, *:after, *:before {
-  -webkit-box-sizing:border-box;
-     -moz-box-sizing:border-box;
-          box-sizing:border-box;
-  }
-h1 { font-size: 20px; margin: 0;}
-h2 { font-size: 14px; }
-pre {
-    font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace;
-    margin: 0;
-    padding: 0;
-    -moz-tab-size: 2;
-    -o-tab-size:  2;
-    tab-size: 2;
-}
-a { color:#0074D9; text-decoration:none; }
-a:hover { text-decoration:underline; }
-.strong { font-weight: bold; }
-.space-top1 { padding: 10px 0 0 0; }
-.pad2y { padding: 20px 0; }
-.pad1y { padding: 10px 0; }
-.pad2x { padding: 0 20px; }
-.pad2 { padding: 20px; }
-.pad1 { padding: 10px; }
-.space-left2 { padding-left:55px; }
-.space-right2 { padding-right:20px; }
-.center { text-align:center; }
-.clearfix { display:block; }
-.clearfix:after {
-  content:'';
-  display:block;
-  height:0;
-  clear:both;
-  visibility:hidden;
-  }
-.fl { float: left; }
-@media only screen and (max-width:640px) {
-  .col3 { width:100%; max-width:100%; }
-  .hide-mobile { display:none!important; }
-}
-
-.quiet {
-  color: #7f7f7f;
-  color: rgba(0,0,0,0.5);
-}
-.quiet a { opacity: 0.7; }
-
-.fraction {
-  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace;
-  font-size: 10px;
-  color: #555;
-  background: #E8E8E8;
-  padding: 4px 5px;
-  border-radius: 3px;
-  vertical-align: middle;
-}
-
-div.path a:link, div.path a:visited { color: #333; }
-table.coverage {
-  border-collapse: collapse;
-  margin: 10px 0 0 0;
-  padding: 0;
-}
-
-table.coverage td {
-  margin: 0;
-  padding: 0;
-  vertical-align: top;
-}
-table.coverage td.line-count {
-    text-align: right;
-    padding: 0 5px 0 20px;
-}
-table.coverage td.line-coverage {
-    text-align: right;
-    padding-right: 10px;
-    min-width:20px;
-}
-
-table.coverage td span.cline-any {
-    display: inline-block;
-    padding: 0 5px;
-    width: 100%;
-}
-.missing-if-branch {
-    display: inline-block;
-    margin-right: 5px;
-    border-radius: 3px;
-    position: relative;
-    padding: 0 4px;
-    background: #333;
-    color: yellow;
-}
-
-.skip-if-branch {
-    display: none;
-    margin-right: 10px;
-    position: relative;
-    padding: 0 4px;
-    background: #ccc;
-    color: white;
-}
-.missing-if-branch .typ, .skip-if-branch .typ {
-    color: inherit !important;
-}
-.coverage-summary {
-  border-collapse: collapse;
-  width: 100%;
-}
-.coverage-summary tr { border-bottom: 1px solid #bbb; }
-.keyline-all { border: 1px solid #ddd; }
-.coverage-summary td, .coverage-summary th { padding: 10px; }
-.coverage-summary tbody { border: 1px solid #bbb; }
-.coverage-summary td { border-right: 1px solid #bbb; }
-.coverage-summary td:last-child { border-right: none; }
-.coverage-summary th {
-  text-align: left;
-  font-weight: normal;
-  white-space: nowrap;
-}
-.coverage-summary th.file { border-right: none !important; }
-.coverage-summary th.pct { }
-.coverage-summary th.pic,
-.coverage-summary th.abs,
-.coverage-summary td.pct,
-.coverage-summary td.abs { text-align: right; }
-.coverage-summary td.file { white-space: nowrap;  }
-.coverage-summary td.pic { min-width: 120px !important;  }
-.coverage-summary tfoot td { }
-
-.coverage-summary .sorter {
-    height: 10px;
-    width: 7px;
-    display: inline-block;
-    margin-left: 0.5em;
-    background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent;
-}
-.coverage-summary .sorted .sorter {
-    background-position: 0 -20px;
-}
-.coverage-summary .sorted-desc .sorter {
-    background-position: 0 -10px;
-}
-.status-line {  height: 10px; }
-/* yellow */
-.cbranch-no { background: yellow !important; color: #111; }
-/* dark red */
-.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 }
-.low .chart { border:1px solid #C21F39 }
-.highlighted,
-.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{
-  background: #C21F39 !important;
-}
-/* medium red */
-.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE }
-/* light red */
-.low, .cline-no { background:#FCE1E5 }
-/* light green */
-.high, .cline-yes { background:rgb(230,245,208) }
-/* medium green */
-.cstat-yes { background:rgb(161,215,106) }
-/* dark green */
-.status-line.high, .high .cover-fill { background:rgb(77,146,33) }
-.high .chart { border:1px solid rgb(77,146,33) }
-/* dark yellow (gold) */
-.status-line.medium, .medium .cover-fill { background: #f9cd0b; }
-.medium .chart { border:1px solid #f9cd0b; }
-/* light yellow */
-.medium { background: #fff4c2; }
-
-.cstat-skip { background: #ddd; color: #111; }
-.fstat-skip { background: #ddd; color: #111 !important; }
-.cbranch-skip { background: #ddd !important; color: #111; }
-
-span.cline-neutral { background: #eaeaea; }
-
-.coverage-summary td.empty {
-    opacity: .5;
-    padding-top: 4px;
-    padding-bottom: 4px;
-    line-height: 1;
-    color: #888;
-}
-
-.cover-fill, .cover-empty {
-  display:inline-block;
-  height: 12px;
-}
-.chart {
-  line-height: 0;
-}
-.cover-empty {
-    background: white;
-}
-.cover-full {
-    border-right: none !important;
-}
-pre.prettyprint {
-    border: none !important;
-    padding: 0 !important;
-    margin: 0 !important;
-}
-.com { color: #999 !important; }
-.ignore-none { color: #999; font-weight: normal; }
-
-.wrapper {
-  min-height: 100%;
-  height: auto !important;
-  height: 100%;
-  margin: 0 auto -48px;
-}
-.footer, .push {
-  height: 48px;
-}

package/src/coverage/block-navigation.js

@@ -1,87 +0,0 @@
-/* eslint-disable */
-var jumpToCode = (function init() {
-    // Classes of code we would like to highlight in the file view
-    var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
-
-    // Elements to highlight in the file listing view
-    var fileListingElements = ['td.pct.low'];
-
-    // We don't want to select elements that are direct descendants of another match
-    var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
-
-    // Selector that finds elements on the page to which we can jump
-    var selector =
-        fileListingElements.join(', ') +
-        ', ' +
-        notSelector +
-        missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
-
-    // The NodeList of matching elements
-    var missingCoverageElements = document.querySelectorAll(selector);
-
-    var currentIndex;
-
-    function toggleClass(index) {
-        missingCoverageElements
-            .item(currentIndex)
-            .classList.remove('highlighted');
-        missingCoverageElements.item(index).classList.add('highlighted');
-    }
-
-    function makeCurrent(index) {
-        toggleClass(index);
-        currentIndex = index;
-        missingCoverageElements.item(index).scrollIntoView({
-            behavior: 'smooth',
-            block: 'center',
-            inline: 'center'
-        });
-    }
-
-    function goToPrevious() {
-        var nextIndex = 0;
-        if (typeof currentIndex !== 'number' || currentIndex === 0) {
-            nextIndex = missingCoverageElements.length - 1;
-        } else if (missingCoverageElements.length > 1) {
-            nextIndex = currentIndex - 1;
-        }
-
-        makeCurrent(nextIndex);
-    }
-
-    function goToNext() {
-        var nextIndex = 0;
-
-        if (
-            typeof currentIndex === 'number' &&
-            currentIndex < missingCoverageElements.length - 1
-        ) {
-            nextIndex = currentIndex + 1;
-        }
-
-        makeCurrent(nextIndex);
-    }
-
-    return function jump(event) {
-        if (
-            document.getElementById('fileSearch') === document.activeElement &&
-            document.activeElement != null
-        ) {
-            // if we're currently focused on the search input, we don't want to navigate
-            return;
-        }
-
-        switch (event.which) {
-            case 78: // n
-            case 74: // j
-                goToNext();
-                break;
-            case 66: // b
-            case 75: // k
-            case 80: // p
-                goToPrevious();
-                break;
-        }
-    };
-})();
-window.addEventListener('keydown', jumpToCode);