@spaceflow/review 0.76.0 → 0.77.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spaceflow/review",
-  "version": "0.76.0",
+  "version": "0.77.0",
   "description": "Spaceflow 代码审查插件，使用 LLM 对 PR 代码进行自动审查",
   "license": "MIT",
   "author": "Lydanne",
@@ -28,7 +28,7 @@
     "@spaceflow/cli": "0.40.0"
   },
   "peerDependencies": {
-    "@spaceflow/core": "0.29.0"
+    "@spaceflow/core": "0.30.0"
   },
   "spaceflow": {
     "type": "flow",

package/src/deletion-impact.service.ts

@@ -12,6 +12,7 @@ import {
 } from "@spaceflow/core";
 import micromatch from "micromatch";
 import type { DeletionImpactResult } from "./review-spec";
+import { extractGlobsFromIncludes } from "./review-includes-filter";
 import { spawn } from "child_process";
 
 export interface DeletedCodeBlock {
@@ -160,11 +161,12 @@ export class DeletionImpactService {
       console.log(`   📦 发现 ${deletedBlocks.length} 个删除的代码块`);
     }
 
-    // 1.5 使用 includes 过滤文件
+    // 1.5 使用 includes 过滤文件（删除分析模式中只按 glob 匹配，不区分 status）
     if (context.includes && context.includes.length > 0) {
       const beforeCount = deletedBlocks.length;
+      const globs = extractGlobsFromIncludes(context.includes);
       const filenames = deletedBlocks.map((b) => b.file);
-      const matchedFilenames = micromatch(filenames, context.includes);
+      const matchedFilenames = micromatch(filenames, globs);
       deletedBlocks = deletedBlocks.filter((b) => matchedFilenames.includes(b.file));
       if (shouldLog(verbose, 1)) {
         console.log(`   🔍 Includes 过滤: ${beforeCount} -> ${deletedBlocks.length} 个删除块`);

package/src/index.ts

@@ -1,6 +1,9 @@
 import "./locales";
 export * from "./review-spec";
 export * from "./review-report";
+export { PullRequestModel } from "./pull-request-model";
+export { ReviewResultModel } from "./review-result-model";
+export type { ReviewResultModelDeps, ReviewResultSaveOptions } from "./review-result-model";
 import { defineExtension, t } from "@spaceflow/core";
 import type {
   GitProviderService,
@@ -10,7 +13,7 @@ import type {
   LocalReviewMode,
 } from "@spaceflow/core";
 import { parseVerbose } from "@spaceflow/core";
-import { reviewSchema, type AnalyzeDeletionsMode } from "./review.config";
+import { reviewSchema, type AnalyzeDeletionsMode, type ReviewConfig } from "./review.config";
 import { ReviewService } from "./review.service";
 import { ReviewSpecService } from "./review-spec";
 import { ReviewReportService, type ReportFormat } from "./review-report";
@@ -54,6 +57,7 @@ export const extension = defineExtension({
         { flags: "--event-action <action>", description: t("review:options.eventAction") },
         { flags: "--local [mode]", description: t("review:options.local") },
         { flags: "--no-local", description: t("review:options.noLocal") },
+        { flags: "--fail-on-issues [mode]", description: t("review:options.failOnIssues") },
       ],
       run: async (_args, options, ctx) => {
         const isFlush = !!options?.flush;
@@ -113,8 +117,18 @@ export const extension = defineExtension({
           flush: isFlush,
           eventAction: options?.eventAction as string,
           local: parseLocalOption(options?.local),
+          failOnIssues: parseFailOnIssues(options?.failOnIssues),
         };
 
+        function parseFailOnIssues(
+          value: unknown,
+        ): "off" | "warn" | "error" | "warn+error" | undefined {
+          if (value === true || value === "") return "error";
+          if (value === "warn" || value === "error" || value === "off" || value === "warn+error")
+            return value;
+          return undefined;
+        }
+
         function parseLocalOption(value: unknown): LocalReviewMode | undefined {
           if (value === false) return false;
           if (value === true || value === undefined || value === "") return undefined;
@@ -124,7 +138,25 @@ export const extension = defineExtension({
 
         try {
           const context = await reviewService.getContextFromEnv(reviewOptions);
-          await reviewService.execute(context);
+          const result = await reviewService.execute(context);
+          const effectiveFailOnIssues: "off" | "warn" | "error" | "warn+error" =
+            reviewOptions.failOnIssues ??
+            ctx.config.getPluginConfig<ReviewConfig>("review")?.failOnIssues ??
+            "off";
+          if (effectiveFailOnIssues !== "off") {
+            const blockers = result.issues.filter((issue) => {
+              if (issue.fixed || issue.resolved || issue.valid === "false") return false;
+              if (effectiveFailOnIssues === "warn") return issue.severity === "warn";
+              if (effectiveFailOnIssues === "error") return issue.severity === "error";
+              return issue.severity === "error" || issue.severity === "warn"; // warn+error
+            });
+            if (blockers.length > 0) {
+              ctx.output.error(
+                `审核不通过：存在 ${blockers.length} 个未解决的问题（模式: ${effectiveFailOnIssues}）`,
+              );
+              process.exit(1);
+            }
+          }
         } catch (error) {
           if (error instanceof Error) {
             ctx.output.error(t("common.executionFailed", { error: error.message }));

package/src/locales/en/review.json

@@ -4,7 +4,7 @@
   "options.prNumber": "PR number, auto-detected from env if not specified",
   "options.base": "Base branch/tag for diff comparison",
   "options.head": "Head branch/tag for diff comparison",
-  "options.includes": "File glob patterns to review, e.g. *.ts *.js (can be specified multiple times)",
+  "options.includes": "File glob patterns to review, e.g. *.ts *.js (can be specified multiple times). Supports change-type prefixes: added|*.ts (new files only), modified|*.ts (modified only), deleted|*.ts (deleted only)",
   "options.llmMode": "LLM mode: claude-code, openai, gemini",
   "options.files": "Only review specified files (space-separated)",
   "options.commits": "Only review specified commits (space-separated)",
@@ -21,6 +21,7 @@
   "options.eventAction": "PR event type (opened, synchronize, closed, etc.), closed only collects stats without AI review",
   "options.local": "Review local uncommitted code. Mode: 'uncommitted' (default, staged + working) or 'staged' (only staged)",
   "options.noLocal": "Disable local mode, use branch comparison instead",
+  "options.failOnIssues": "Fail the workflow when unresolved issues exist. Mode: warn (warn-level only) / error (error-level only) / warn+error (either warn or error). Passing no mode is equivalent to error",
   "extensionDescription": "Code review command using LLM for automated PR review",
   "mcp.serverDescription": "Code review rules query service",
   "mcp.listRules": "List all code review rules for the current project, returning rule list with ID, title, description, applicable file extensions, etc.",

package/src/locales/zh-cn/review.json

@@ -4,7 +4,7 @@
   "options.prNumber": "PR 编号，如果不指定则从环境变量获取",
   "options.base": "基准分支/tag，用于比较差异",
   "options.head": "目标分支/tag，用于比较差异",
-  "options.includes": "要审查的文件 glob 模式，如 *.ts *.js（可多次指定）",
+  "options.includes": "要审查的文件 glob 模式，如 *.ts *.js（可多次指定）。支持变更类型前缀: added|*.ts（仅新增）、modified|*.ts（仅修改）、deleted|*.ts（仅删除）",
   "options.llmMode": "使用的 LLM 模式: claude-code, openai, gemini",
   "options.files": "仅审查指定的文件（空格分隔）",
   "options.commits": "仅审查指定的 commits（空格分隔）",
@@ -21,6 +21,7 @@
   "options.eventAction": "PR 事件类型（opened, synchronize, closed 等），closed 时仅收集统计不进行 AI 审查",
   "options.local": "审查本地未提交的代码。模式: 'uncommitted'（默认，暂存区+工作区）或 'staged'（仅暂存区）",
   "options.noLocal": "禁用本地模式，使用分支比较",
+  "options.failOnIssues": "存在未解决问题时工作流抛出异常。模式: warn（仅 warn 问题）/ error（仅 error 问题）/ warn&error（warn 或 error 问题）。不加模式等同 error",
   "extensionDescription": "代码审查命令，使用 LLM 对 PR 代码进行自动审查",
   "mcp.serverDescription": "代码审查规则查询服务",
   "mcp.listRules": "获取当前项目的所有代码审查规则，返回规则列表包含 ID、标题、描述、适用的文件扩展名等信息",

package/src/pull-request-model.ts

@@ -0,0 +1,236 @@
+import {
+  GitProviderService,
+  PullRequest,
+  PullRequestCommit,
+  ChangedFile,
+  CommitInfo,
+  IssueComment,
+  CreateIssueCommentOption,
+  CreatePullReviewOption,
+  PullReview,
+  PullReviewComment,
+  EditPullRequestOption,
+  Reaction,
+  ResolvedThread,
+} from "@spaceflow/core";
+
+/**
+ * PR 数据模型映射层
+ * 封装所有 PR 相关的读写操作，消除 owner/repo/prNumber 三元组的散传
+ * 读操作带懒加载缓存，写操作直通 gitProvider
+ */
+export class PullRequestModel {
+  private _info: PullRequest | null = null;
+  private _commits: PullRequestCommit[] | null = null;
+  private _files: ChangedFile[] | null = null;
+  private _diff: string | null = null;
+  private _comments: IssueComment[] | null = null;
+  private _reviews: PullReview[] | null = null;
+
+  constructor(
+    private readonly gitProvider: GitProviderService,
+    readonly owner: string,
+    readonly repo: string,
+    readonly number: number,
+  ) {}
+
+  // ============ 懒加载数据（带缓存） ============
+
+  /** 获取 PR 基本信息（懒加载 + 缓存） */
+  async getInfo(): Promise<PullRequest> {
+    if (!this._info) {
+      this._info = await this.gitProvider.getPullRequest(this.owner, this.repo, this.number);
+    }
+    return this._info;
+  }
+
+  /** 获取 head commit SHA */
+  async getHeadSha(): Promise<string> {
+    const info = await this.getInfo();
+    return info.head?.sha || "HEAD";
+  }
+
+  /** 获取 PR 的所有 commits（懒加载 + 缓存） */
+  async getCommits(): Promise<PullRequestCommit[]> {
+    if (!this._commits) {
+      this._commits = await this.gitProvider.getPullRequestCommits(
+        this.owner,
+        this.repo,
+        this.number,
+      );
+    }
+    return [...this._commits];
+  }
+
+  /** 获取 PR 的变更文件列表（懒加载 + 缓存） */
+  async getFiles(): Promise<ChangedFile[]> {
+    if (!this._files) {
+      this._files = await this.gitProvider.getPullRequestFiles(this.owner, this.repo, this.number);
+    }
+    return [...this._files];
+  }
+
+  /** 获取 PR 的 diff 文本（懒加载 + 缓存） */
+  async getDiff(): Promise<string> {
+    if (!this._diff) {
+      this._diff = await this.gitProvider.getPullRequestDiff(this.owner, this.repo, this.number);
+    }
+    return this._diff;
+  }
+
+  // ============ PR 编辑 ============
+
+  /** 编辑 PR（标题、描述等），自动 invalidate info 缓存 */
+  async edit(options: EditPullRequestOption): Promise<PullRequest> {
+    const result = await this.gitProvider.editPullRequest(
+      this.owner,
+      this.repo,
+      this.number,
+      options,
+    );
+    this._info = result;
+    return result;
+  }
+
+  // ============ Issue Comments（PR 主评论） ============
+
+  /** 列出 PR 的所有 Issue Comments（懒加载 + 缓存） */
+  async getComments(): Promise<IssueComment[]> {
+    if (!this._comments) {
+      this._comments = await this.gitProvider.listIssueComments(this.owner, this.repo, this.number);
+    }
+    return [...this._comments];
+  }
+
+  /** 创建 Issue Comment */
+  async createComment(options: CreateIssueCommentOption): Promise<IssueComment> {
+    const result = await this.gitProvider.createIssueComment(
+      this.owner,
+      this.repo,
+      this.number,
+      options,
+    );
+    this._comments = null; // invalidate
+    return result;
+  }
+
+  /** 更新 Issue Comment */
+  async updateComment(commentId: number, body: string): Promise<IssueComment> {
+    const result = await this.gitProvider.updateIssueComment(
+      this.owner,
+      this.repo,
+      commentId,
+      body,
+    );
+    this._comments = null; // invalidate
+    return result;
+  }
+
+  /** 删除 Issue Comment */
+  async deleteComment(commentId: number): Promise<void> {
+    await this.gitProvider.deleteIssueComment(this.owner, this.repo, commentId);
+    this._comments = null; // invalidate
+  }
+
+  // ============ PR Reviews（行级评论） ============
+
+  /** 列出 PR 的所有 Reviews（懒加载 + 缓存） */
+  async getReviews(): Promise<PullReview[]> {
+    if (!this._reviews) {
+      this._reviews = await this.gitProvider.listPullReviews(this.owner, this.repo, this.number);
+    }
+    return [...this._reviews];
+  }
+
+  /** 创建 PR Review */
+  async createReview(options: CreatePullReviewOption): Promise<PullReview> {
+    const result = await this.gitProvider.createPullReview(
+      this.owner,
+      this.repo,
+      this.number,
+      options,
+    );
+    this._reviews = null; // invalidate
+    return result;
+  }
+
+  /** 删除 PR Review */
+  async deleteReview(reviewId: number): Promise<void> {
+    await this.gitProvider.deletePullReview(this.owner, this.repo, this.number, reviewId);
+    this._reviews = null; // invalidate
+  }
+
+  /** 获取 PR Review 的行级评论列表 */
+  async getReviewComments(reviewId: number): Promise<PullReviewComment[]> {
+    return this.gitProvider.listPullReviewComments(this.owner, this.repo, this.number, reviewId);
+  }
+
+  /** 获取已解决的 review threads */
+  async getResolvedThreads(): Promise<ResolvedThread[]> {
+    return this.gitProvider.listResolvedThreads(this.owner, this.repo, this.number);
+  }
+
+  // ============ Reaction 操作 ============
+
+  /** 获取 PR Review 行级评论的 reactions */
+  async getReviewCommentReactions(commentId: number): Promise<Reaction[]> {
+    return this.gitProvider.getPullReviewCommentReactions(this.owner, this.repo, commentId);
+  }
+
+  // ============ 仓库级操作（需要 owner/repo 但不需要 prNumber） ============
+
+  /** 获取文件内容 */
+  async getFileContent(filepath: string, ref?: string): Promise<string> {
+    return this.gitProvider.getFileContent(this.owner, this.repo, filepath, ref);
+  }
+
+  /** 获取单个 commit 信息 */
+  async getCommit(sha: string): Promise<CommitInfo> {
+    return this.gitProvider.getCommit(this.owner, this.repo, sha);
+  }
+
+  /** 获取单个 commit 的 diff */
+  async getCommitDiff(sha: string): Promise<string> {
+    return this.gitProvider.getCommitDiff(this.owner, this.repo, sha);
+  }
+
+  /** 列出 workflow runs */
+  async listWorkflowRuns(options?: { status?: string; sha?: string }) {
+    return this.gitProvider.listWorkflowRuns(this.owner, this.repo, options);
+  }
+
+  // ============ 缓存控制 ============
+
+  /** 清除指定或所有缓存 */
+  invalidate(key?: "info" | "commits" | "files" | "diff" | "comments" | "reviews"): void {
+    if (key) {
+      switch (key) {
+        case "info":
+          this._info = null;
+          break;
+        case "commits":
+          this._commits = null;
+          break;
+        case "files":
+          this._files = null;
+          break;
+        case "diff":
+          this._diff = null;
+          break;
+        case "comments":
+          this._comments = null;
+          break;
+        case "reviews":
+          this._reviews = null;
+          break;
+      }
+    } else {
+      this._info = null;
+      this._commits = null;
+      this._files = null;
+      this._diff = null;
+      this._comments = null;
+      this._reviews = null;
+    }
+  }
+}