@spaceflow/review 0.29.3 → 0.30.0

package/src/review.service.spec.ts

@@ -1,21 +1,8 @@
-import { vi, type Mocked, type Mock } from "vitest";
-import { Test, TestingModule } from "@nestjs/testing";
-import {
-  ConfigService,
-  ConfigReaderService,
-  GitProviderService,
-  ClaudeSetupService,
-  LlmProxyService,
-  GitSdkService,
-  parseChangedLinesFromPatch,
-} from "@spaceflow/core";
-import { ReviewSpecService } from "./review-spec";
-import { ReviewReportService } from "./review-report";
+import { vi, type Mock } from "vitest";
+import { parseChangedLinesFromPatch } from "@spaceflow/core";
 import { readFile } from "fs/promises";
 import { ReviewService, ReviewContext, ReviewPrompt } from "./review.service";
-import { IssueVerifyService } from "./issue-verify.service";
-import { DeletionImpactService } from "./deletion-impact.service";
-import type { ReviewOptions } from "./review.command";
+import type { ReviewOptions } from "./review.config";
 
 vi.mock("c12");
 vi.mock("@anthropic-ai/claude-agent-sdk", () => ({
@@ -56,14 +43,17 @@ vi.mock("openai", () => {
 
 describe("ReviewService", () => {
   let service: ReviewService;
-  let gitProvider: Mocked<GitProviderService>;
-  let configService: Mocked<ConfigService>;
+  let gitProvider: any;
+  let configService: any;
   let mockReviewSpecService: any;
   let mockDeletionImpactService: any;
   let mockGitSdkService: any;
+  let mockLlmProxyService: any;
+  let mockConfigReaderService: any;
 
-  beforeEach(async () => {
-    const mockGitProvider = {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    gitProvider = {
       validateConfig: vi.fn(),
       getPullRequest: vi.fn(),
       getCommit: vi.fn(),
@@ -80,14 +70,10 @@ describe("ReviewService", () => {
       getIssueCommentReactions: vi.fn().mockResolvedValue([]),
     };
 
-    const mockConfigService = {
+    configService = {
       get: vi.fn(),
     };
 
-    const mockClaudeSetupService = {
-      configure: vi.fn(),
-    };
-
     mockReviewSpecService = {
       resolveSpecSources: vi.fn().mockResolvedValue(["/mock/spec/dir"]),
       loadReviewSpecs: vi.fn().mockResolvedValue([
@@ -139,63 +125,29 @@ describe("ReviewService", () => {
       getCommitDiff: vi.fn().mockReturnValue([]),
     };
 
-    const module: TestingModule = await Test.createTestingModule({
-      providers: [
-        ReviewService,
-        {
-          provide: GitProviderService,
-          useValue: mockGitProvider,
-        },
-        {
-          provide: ConfigService,
-          useValue: mockConfigService,
-        },
-        {
-          provide: ClaudeSetupService,
-          useValue: mockClaudeSetupService,
-        },
-        {
-          provide: ReviewSpecService,
-          useValue: mockReviewSpecService,
-        },
-        {
-          provide: LlmProxyService,
-          useValue: {
-            chat: vi.fn(),
-            chatStream: vi.fn(),
-            createSession: vi.fn(),
-            getAvailableAdapters: vi.fn().mockReturnValue(["claude-code", "openai"]),
-          },
-        },
-        {
-          provide: ReviewReportService,
-          useValue: mockReviewReportService,
-        },
-        {
-          provide: IssueVerifyService,
-          useValue: mockIssueVerifyService,
-        },
-        {
-          provide: DeletionImpactService,
-          useValue: mockDeletionImpactService,
-        },
-        {
-          provide: GitSdkService,
-          useValue: mockGitSdkService,
-        },
-        {
-          provide: ConfigReaderService,
-          useValue: {
-            getPluginConfig: vi.fn().mockReturnValue({}),
-            getSystemConfig: vi.fn().mockReturnValue({}),
-          },
-        },
-      ],
-    }).compile();
+    mockLlmProxyService = {
+      chat: vi.fn(),
+      chatStream: vi.fn(),
+      createSession: vi.fn(),
+      getAvailableAdapters: vi.fn().mockReturnValue(["claude-code", "openai"]),
+    };
+
+    mockConfigReaderService = {
+      getPluginConfig: vi.fn().mockReturnValue({}),
+      getSystemConfig: vi.fn().mockReturnValue({}),
+    };
 
-    service = module.get<ReviewService>(ReviewService);
-    gitProvider = module.get(GitProviderService) as Mocked<GitProviderService>;
-    configService = module.get(ConfigService) as Mocked<ConfigService>;
+    service = new ReviewService(
+      gitProvider as any,
+      configService as any,
+      mockConfigReaderService as any,
+      mockReviewSpecService as any,
+      mockLlmProxyService as any,
+      mockReviewReportService as any,
+      mockIssueVerifyService as any,
+      mockDeletionImpactService as any,
+      mockGitSdkService as any,
+    );
   });
 
   afterEach(() => {

package/src/review.service.ts

@@ -1,6 +1,4 @@
 import {
-  Injectable,
-  ConfigService,
   ConfigReaderService,
   GitProviderService,
   PullRequest,
@@ -24,6 +22,7 @@ import {
   parseHunksFromPatch,
   calculateNewLineNumber,
 } from "@spaceflow/core";
+import type { IConfigReader } from "@spaceflow/core";
 import { type AnalyzeDeletionsMode, type ReviewConfig } from "./review.config";
 import {
   ReviewSpecService,
@@ -41,7 +40,7 @@ import { execSync } from "child_process";
 import { readFile, readdir } from "fs/promises";
 import { join, dirname, extname, relative, isAbsolute } from "path";
 import micromatch from "micromatch";
-import { ReviewOptions } from "./review.command";
+import { ReviewOptions } from "./review.config";
 import { IssueVerifyService } from "./issue-verify.service";
 import { DeletionImpactService } from "./deletion-impact.service";
 import { parseTitleOptions } from "./parse-title-options";
@@ -138,13 +137,12 @@ const REVIEW_SCHEMA: LlmJsonPutSchema = {
   additionalProperties: false,
 };
 
-@Injectable()
 export class ReviewService {
   protected readonly llmJsonPut: LlmJsonPut<ReviewResult>;
 
   constructor(
     protected readonly gitProvider: GitProviderService,
-    protected readonly configService: ConfigService,
+    protected readonly config: IConfigReader,
     protected readonly configReader: ConfigReaderService,
     protected readonly reviewSpecService: ReviewSpecService,
     protected readonly llmProxyService: LlmProxyService,
@@ -172,7 +170,7 @@ export class ReviewService {
 
   async getContextFromEnv(options: ReviewOptions): Promise<ReviewContext> {
     const reviewConf = this.configReader.getPluginConfig<ReviewConfig>("review");
-    const ciConf = this.configService.get<CiConfig>("ci");
+    const ciConf = this.config.get<CiConfig>("ci");
     const repository = ciConf?.repository;
 
     if (options.ci) {

package/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../core/tsconfig.skill.json",
+  "extends": "../../packages/core/tsconfig.skill.json",
   "compilerOptions": {
     "types": ["vitest/globals"]
   },

package/src/dto/mcp.dto.ts

@@ -1,42 +0,0 @@
-import {
-  ApiProperty,
-  ApiPropertyOptional,
-  IsString,
-  IsBoolean,
-  IsOptional,
-  t,
-} from "@spaceflow/core";
-
-export class ListRulesInput {
-  @ApiPropertyOptional({ description: t("review:mcp.dto.cwd") })
-  @IsString()
-  @IsOptional()
-  cwd?: string;
-}
-
-export class GetRulesForFileInput {
-  @ApiProperty({ description: t("review:mcp.dto.filePath") })
-  @IsString()
-  filePath!: string;
-
-  @ApiPropertyOptional({ description: t("review:mcp.dto.cwd") })
-  @IsString()
-  @IsOptional()
-  cwd?: string;
-
-  @ApiPropertyOptional({ description: t("review:mcp.dto.includeExamples") })
-  @IsBoolean()
-  @IsOptional()
-  includeExamples?: boolean;
-}
-
-export class GetRuleDetailInput {
-  @ApiProperty({ description: t("review:mcp.dto.ruleId") })
-  @IsString()
-  ruleId!: string;
-
-  @ApiPropertyOptional({ description: t("review:mcp.dto.cwd") })
-  @IsString()
-  @IsOptional()
-  cwd?: string;
-}

package/src/review-report/review-report.module.ts

@@ -1,8 +0,0 @@
-import { Module } from "@nestjs/common";
-import { ReviewReportService } from "./review-report.service";
-
-@Module({
-  providers: [ReviewReportService],
-  exports: [ReviewReportService],
-})
-export class ReviewReportModule {}

package/src/review-spec/review-spec.module.ts

@@ -1,10 +0,0 @@
-import { Module } from "@nestjs/common";
-import { GitProviderModule } from "@spaceflow/core";
-import { ReviewSpecService } from "./review-spec.service";
-
-@Module({
-  imports: [GitProviderModule.forFeature()],
-  providers: [ReviewSpecService],
-  exports: [ReviewSpecService],
-})
-export class ReviewSpecModule {}

package/src/review.command.ts

@@ -1,244 +0,0 @@
-import { Command, CommandRunner, Option, t } from "@spaceflow/core";
-import type { LLMMode, VerboseLevel } from "@spaceflow/core";
-import type { AnalyzeDeletionsMode } from "./review.config";
-import type { ReportFormat } from "./review-report";
-import { ReviewService } from "./review.service";
-
-export interface ReviewOptions {
-  dryRun: boolean;
-  ci: boolean;
-  prNumber?: number;
-  base?: string;
-  head?: string;
-  references?: string[];
-  verbose?: VerboseLevel;
-  includes?: string[];
-  llmMode?: LLMMode;
-  files?: string[];
-  commits?: string[];
-  verifyFixes?: boolean;
-  verifyConcurrency?: number;
-  analyzeDeletions?: AnalyzeDeletionsMode;
-  /** 仅执行删除代码分析，跳过常规代码审查 */
-  deletionOnly?: boolean;
-  /** 删除代码分析模式：openai 使用标准模式，claude-agent 使用 Agent 模式 */
-  deletionAnalysisMode?: LLMMode;
-  /** 输出格式：markdown, terminal, json。不指定则智能选择 */
-  outputFormat?: ReportFormat;
-  /** 是否使用 AI 生成 PR 功能描述 */
-  generateDescription?: boolean;
-  /** 显示所有问题，不过滤非变更行的问题 */
-  showAll?: boolean;
-  /** PR 事件类型（opened, synchronize, closed 等） */
-  eventAction?: string;
-  concurrency?: number;
-  timeout?: number;
-  retries?: number;
-  retryDelay?: number;
-}
-
-/**
- * Review 命令
- *
- * 在 GitHub Actions 中执行，用于自动代码审查
- *
- * 环境变量：
- * - GITHUB_TOKEN: GitHub API Token
- * - GITHUB_REPOSITORY: 仓库名称 (owner/repo 格式)
- * - GITHUB_REF_NAME: 当前分支名称
- * - GITHUB_EVENT_PATH: 事件文件路径（包含 PR 信息）
- */
-@Command({
-  name: "review",
-  description: t("review:description"),
-})
-export class ReviewCommand extends CommandRunner {
-  constructor(protected readonly reviewService: ReviewService) {
-    super();
-  }
-
-  async run(_passedParams: string[], options: ReviewOptions): Promise<void> {
-    try {
-      const context = await this.reviewService.getContextFromEnv(options);
-      await this.reviewService.execute(context);
-    } catch (error) {
-      if (error instanceof Error) {
-        console.error(t("common.executionFailed", { error: error.message }));
-        if (error.stack) {
-          console.error(t("common.stackTrace", { stack: error.stack }));
-        }
-      } else {
-        console.error(t("common.executionFailed", { error }));
-      }
-      process.exit(1);
-    }
-  }
-
-  @Option({
-    flags: "-d, --dry-run",
-    description: t("review:options.dryRun"),
-  })
-  parseDryRun(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "-c, --ci",
-    description: t("common.options.ci"),
-  })
-  parseCi(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "-p, --pr-number <number>",
-    description: t("review:options.prNumber"),
-  })
-  parsePrNumber(val: string): number {
-    return parseInt(val, 10);
-  }
-
-  @Option({
-    flags: "-b, --base <ref>",
-    description: t("review:options.base"),
-  })
-  parseBase(val: string): string {
-    return val;
-  }
-
-  @Option({
-    flags: "--head <ref>",
-    description: t("review:options.head"),
-  })
-  parseHead(val: string): string {
-    return val;
-  }
-
-  @Option({
-    flags: "-v, --verbose",
-    description: t("common.options.verboseDebug"),
-  })
-  parseVerbose(_val: string, previous: VerboseLevel = 0): VerboseLevel {
-    const current = typeof previous === "number" ? previous : previous ? 1 : 0;
-    return Math.min(current + 1, 3) as VerboseLevel;
-  }
-
-  @Option({
-    flags: "-i, --includes <patterns...>",
-    description: t("review:options.includes"),
-  })
-  parseIncludes(val: string, previous: string[] = []): string[] {
-    return [...previous, val];
-  }
-
-  @Option({
-    flags: "-l, --llm-mode <mode>",
-    description: t("review:options.llmMode"),
-    choices: ["claude-code", "openai", "gemini"],
-  })
-  parseLlmMode(val: string): LLMMode {
-    return val as LLMMode;
-  }
-
-  @Option({
-    flags: "-f, --files <files...>",
-    description: t("review:options.files"),
-  })
-  parseFiles(val: string, previous: string[] = []): string[] {
-    return [...previous, val];
-  }
-
-  @Option({
-    flags: "--commits <commits...>",
-    description: t("review:options.commits"),
-  })
-  parseCommits(val: string, previous: string[] = []): string[] {
-    return [...previous, val];
-  }
-
-  @Option({
-    flags: "--verify-fixes",
-    description: t("review:options.verifyFixes"),
-  })
-  parseVerifyFixes(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "--no-verify-fixes",
-    description: t("review:options.noVerifyFixes"),
-  })
-  parseNoVerifyFixes(val: boolean): boolean {
-    return !val;
-  }
-
-  @Option({
-    flags: "--verify-concurrency <number>",
-    description: t("review:options.verifyConcurrency"),
-  })
-  parseVerifyConcurrency(val: string): number {
-    return parseInt(val, 10);
-  }
-
-  @Option({
-    flags: "--analyze-deletions [mode]",
-    description: t("review:options.analyzeDeletions"),
-  })
-  parseAnalyzeDeletions(val: string | boolean): AnalyzeDeletionsMode {
-    if (val === true || val === "true") return true;
-    if (val === false || val === "false") return false;
-    if (val === "ci" || val === "pr" || val === "terminal") return val;
-    // 默认为 true（当只传 --analyze-deletions 不带值时）
-    return true;
-  }
-
-  @Option({
-    flags: "--deletion-analysis-mode <mode>",
-    description: t("review:options.deletionAnalysisMode"),
-    choices: ["openai", "claude-code"],
-  })
-  parseDeletionAnalysisMode(val: string): LLMMode {
-    return val as LLMMode;
-  }
-
-  @Option({
-    flags: "--deletion-only",
-    description: t("review:options.deletionOnly"),
-  })
-  parseDeletionOnly(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "-o, --output-format <format>",
-    description: t("review:options.outputFormat"),
-    choices: ["markdown", "terminal", "json"],
-  })
-  parseOutputFormat(val: string): ReportFormat {
-    return val as ReportFormat;
-  }
-
-  @Option({
-    flags: "--generate-description",
-    description: t("review:options.generateDescription"),
-  })
-  parseGenerateDescription(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "--show-all",
-    description: t("review:options.showAll"),
-  })
-  parseShowAll(val: boolean): boolean {
-    return val;
-  }
-
-  @Option({
-    flags: "--event-action <action>",
-    description: t("review:options.eventAction"),
-  })
-  parseEventAction(val: string): string {
-    return val;
-  }
-}

package/src/review.mcp.ts

@@ -1,184 +0,0 @@
-/**
- * Review MCP 服务
- * 提供代码审查规则查询的 MCP 工具
- */
-
-import { McpServer, McpTool, ConfigReaderService, t } from "@spaceflow/core";
-import { ReviewSpecService } from "./review-spec/review-spec.service";
-import { join } from "path";
-import { existsSync } from "fs";
-import { ListRulesInput, GetRulesForFileInput, GetRuleDetailInput } from "./dto/mcp.dto";
-import type { ReviewConfig } from "./review.config";
-
-@McpServer({ name: "review-mcp", version: "1.0.0", description: t("review:mcp.serverDescription") })
-export class ReviewMcp {
-  constructor(
-    private readonly specService: ReviewSpecService,
-    private readonly configReader: ConfigReaderService,
-  ) {}
-
-  /**
-   * 获取项目的规则目录
-   */
-  private async getSpecDirs(cwd: string): Promise<string[]> {
-    const dirs: string[] = [];
-
-    // 1. 通过 ConfigReaderService 读取 review 配置
-    try {
-      const reviewConfig = this.configReader.getPluginConfig<ReviewConfig>("review");
-      if (reviewConfig?.references?.length) {
-        const resolved = await this.specService.resolveSpecSources(reviewConfig.references);
-        dirs.push(...resolved);
-      }
-    } catch {
-      // 忽略配置读取错误
-    }
-
-    // 2. 检查默认目录
-    const defaultDirs = [
-      join(cwd, ".claude", "skills"),
-      join(cwd, ".cursor", "skills"),
-      join(cwd, "review-specs"),
-    ];
-
-    for (const dir of defaultDirs) {
-      if (existsSync(dir)) {
-        dirs.push(dir);
-      }
-    }
-
-    return [...new Set(dirs)]; // 去重
-  }
-
-  /**
-   * 加载所有规则
-   */
-  private async loadAllSpecs(cwd: string) {
-    const specDirs = await this.getSpecDirs(cwd);
-    const allSpecs = [];
-
-    for (const dir of specDirs) {
-      const specs = await this.specService.loadReviewSpecs(dir);
-      allSpecs.push(...specs);
-    }
-
-    // 只去重，不应用 override（MCP 工具应返回所有规则，override 在实际审查时应用）
-    return this.specService.deduplicateSpecs(allSpecs);
-  }
-
-  @McpTool({
-    name: "list_rules",
-    description: t("review:mcp.listRules"),
-    dto: ListRulesInput,
-  })
-  async listRules(input: ListRulesInput) {
-    const workDir = input.cwd || process.cwd();
-    const specs = await this.loadAllSpecs(workDir);
-
-    const rules = specs.flatMap((spec) =>
-      spec.rules.map((rule) => ({
-        id: rule.id,
-        title: rule.title,
-        description: rule.description.slice(0, 200) + (rule.description.length > 200 ? "..." : ""),
-        severity: rule.severity || spec.severity,
-        extensions: spec.extensions,
-        specFile: spec.filename,
-        includes: spec.includes,
-        hasExamples: rule.examples.length > 0,
-      })),
-    );
-
-    return {
-      total: rules.length,
-      rules,
-    };
-  }
-
-  @McpTool({
-    name: "get_rules_for_file",
-    description: t("review:mcp.getRulesForFile"),
-    dto: GetRulesForFileInput,
-  })
-  async getRulesForFile(input: GetRulesForFileInput) {
-    const workDir = input.cwd || process.cwd();
-    const allSpecs = await this.loadAllSpecs(workDir);
-
-    // 根据文件过滤适用的规则
-    const applicableSpecs = this.specService.filterApplicableSpecs(allSpecs, [
-      { filename: input.filePath },
-    ]);
-
-    // 进一步根据 includes 过滤（支持规则级 includes 覆盖文件级）
-    const micromatchModule = await import("micromatch");
-    const micromatch = micromatchModule.default || micromatchModule;
-
-    const rules = applicableSpecs.flatMap((spec) =>
-      spec.rules
-        .filter((rule) => {
-          // 规则级 includes 优先于文件级
-          const includes = rule.includes || spec.includes;
-          if (includes.length === 0) return true;
-          return micromatch.isMatch(input.filePath, includes, { matchBase: true });
-        })
-        .map((rule) => ({
-          id: rule.id,
-          title: rule.title,
-          description: rule.description,
-          severity: rule.severity || spec.severity,
-          specFile: spec.filename,
-          ...(input.includeExamples && rule.examples.length > 0
-            ? {
-                examples: rule.examples.map((ex) => ({
-                  type: ex.type,
-                  lang: ex.lang,
-                  code: ex.code,
-                })),
-              }
-            : {}),
-        })),
-    );
-
-    return {
-      file: input.filePath,
-      total: rules.length,
-      rules,
-    };
-  }
-
-  @McpTool({
-    name: "get_rule_detail",
-    description: t("review:mcp.getRuleDetail"),
-    dto: GetRuleDetailInput,
-  })
-  async getRuleDetail(input: GetRuleDetailInput) {
-    const workDir = input.cwd || process.cwd();
-    const specs = await this.loadAllSpecs(workDir);
-
-    const result = this.specService.findRuleById(input.ruleId, specs);
-
-    if (!result) {
-      return { error: t("review:mcp.ruleNotFound", { ruleId: input.ruleId }) };
-    }
-
-    const { rule, spec } = result;
-
-    return {
-      id: rule.id,
-      title: rule.title,
-      description: rule.description,
-      severity: rule.severity || spec.severity,
-      specFile: spec.filename,
-      extensions: spec.extensions,
-      includes: spec.includes,
-      overrides: rule.overrides,
-      examples: rule.examples.map((ex) => ({
-        type: ex.type,
-        lang: ex.lang,
-        code: ex.code,
-      })),
-    };
-  }
-}
-
-// ReviewMcpService 类已通过 @McpServer 装饰器标记
-// CLI 的 `spaceflow mcp` 命令会自动扫描并发现该类