@spaceflow/core 0.1.3 → 0.3.0

package/src/shared/feishu-sdk/feishu-sdk.service.ts

@@ -1,9 +1,7 @@
-import { Inject, Injectable, type OnModuleDestroy, type OnModuleInit } from "@nestjs/common";
-import { EventEmitter2 } from "@nestjs/event-emitter";
+import { EventEmitter } from "events";
 import * as lark from "@larksuiteoapi/node-sdk";
 import {
   FeishuModuleOptions,
-  FEISHU_MODULE_OPTIONS,
   FeishuUser,
   GetUserParams,
   FEISHU_CARD_ACTION_TRIGGER,
@@ -15,12 +13,39 @@ import {
 /**
  * 飞书 API 服务
  */
-@Injectable()
-export class FeishuSdkService implements OnModuleInit, OnModuleDestroy {
+export class FeishuSdkService {
   protected readonly client: lark.Client;
+  protected readonly eventEmitter: EventEmitter;
+  private eventDispatcher: lark.EventDispatcher | null = null;
 
-  onModuleInit(): void {
-    const eventDispatcher = new lark.EventDispatcher({
+  constructor(protected readonly options: FeishuModuleOptions) {
+    this.eventEmitter = new EventEmitter();
+    this.client = new lark.Client({
+      appId: options.appId,
+      appSecret: options.appSecret,
+      appType: options.appType === "store" ? lark.AppType.ISV : lark.AppType.SelfBuild,
+      domain: options.domain === "lark" ? lark.Domain.Lark : lark.Domain.Feishu,
+    });
+
+    this.initEventDispatcher();
+  }
+
+  /**
+   * 注册事件监听器
+   */
+  on(eventName: string, listener: (...args: any[]) => void): void {
+    this.eventEmitter.on(eventName, listener);
+  }
+
+  /**
+   * 移除事件监听器
+   */
+  off(eventName: string, listener: (...args: any[]) => void): void {
+    this.eventEmitter.off(eventName, listener);
+  }
+
+  private initEventDispatcher(): void {
+    this.eventDispatcher = new lark.EventDispatcher({
       encryptKey: "encrypt key",
     }).register<CardEvents>({
       [FEISHU_CARD_ACTION_TRIGGER]: async (data) => {
@@ -41,23 +66,10 @@ export class FeishuSdkService implements OnModuleInit, OnModuleDestroy {
     });
   }
 
-  onModuleDestroy(): void {
+  destroy(): void {
     this.eventEmitter.removeAllListeners();
   }
 
-  constructor(
-    @Inject(FEISHU_MODULE_OPTIONS)
-    protected readonly options: FeishuModuleOptions,
-    protected readonly eventEmitter: EventEmitter2,
-  ) {
-    this.client = new lark.Client({
-      appId: options.appId,
-      appSecret: options.appSecret,
-      appType: options.appType === "store" ? lark.AppType.ISV : lark.AppType.SelfBuild,
-      domain: options.domain === "lark" ? lark.Domain.Lark : lark.Domain.Feishu,
-    });
-  }
-
   /**
    * 验证飞书配置
    */

package/src/shared/feishu-sdk/fieshu-card.service.ts

@@ -1,4 +1,3 @@
-import { Injectable } from "@nestjs/common";
 import { FeishuSdkService } from "./feishu-sdk.service";
 import {
   SendCardParams,
@@ -8,25 +7,24 @@ import {
   CardContent,
   type CardActionTriggerCallback,
 } from "./types";
-import { OnEvent, type EventEmitter2 } from "@nestjs/event-emitter";
 import { FEISHU_CARD_ACTION_TRIGGER } from "./types";
 
 /**
  * 飞书卡片消息服务
  * 提供卡片消息的发送、回复、更新功能
  */
-@Injectable()
 export class FeishuCardService {
-  constructor(
-    protected readonly feishuSdkService: FeishuSdkService,
-    protected readonly eventEmitter: EventEmitter2,
-  ) {}
+  constructor(protected readonly feishuSdkService: FeishuSdkService) {
+    // 监听卡片动作触发事件
+    feishuSdkService.on(FEISHU_CARD_ACTION_TRIGGER, (event) => {
+      this.handleCardActionTrigger(event);
+    });
+  }
 
-  @OnEvent(FEISHU_CARD_ACTION_TRIGGER)
-  async handleCardActionTrigger(event: CardActionTriggerCallback) {
-    const event_hook = event.header.event_type ?? event.event.action.tag;
+  async handleCardActionTrigger(event: CardActionTriggerCallback): Promise<void> {
+    const _eventHook = event.header.event_type ?? event.event.action.tag;
 
-    // console.log(event_hook);
+    // console.log(_eventHook);
   }
 
   /**

package/src/shared/feishu-sdk/index.ts

@@ -1,4 +1,3 @@
-export * from "./feishu-sdk.module";
 export * from "./feishu-sdk.service";
 export * from "./fieshu-card.service";
 export * from "./types/index";

package/src/shared/git-provider/adapters/gitea.adapter.ts

@@ -5,28 +5,30 @@ import type {
   LockBranchOptions,
   ListPullRequestsOptions,
 } from "../git-provider.interface";
-import type {
-  GitProviderModuleOptions,
-  BranchProtection,
-  CreateBranchProtectionOption,
-  EditBranchProtectionOption,
-  Branch,
-  Repository,
-  PullRequest,
-  PullRequestCommit,
-  ChangedFile,
-  CommitInfo,
-  IssueComment,
-  CreateIssueCommentOption,
-  CreateIssueOption,
-  Issue,
-  CreatePullReviewOption,
-  PullReview,
-  PullReviewComment,
-  Reaction,
-  EditPullRequestOption,
-  User,
-  RepositoryContent,
+import {
+  REVIEW_STATE,
+  type GitProviderModuleOptions,
+  type BranchProtection,
+  type CreateBranchProtectionOption,
+  type EditBranchProtectionOption,
+  type Branch,
+  type Repository,
+  type PullRequest,
+  type PullRequestCommit,
+  type ChangedFile,
+  type CommitInfo,
+  type IssueComment,
+  type CreateIssueCommentOption,
+  type CreateIssueOption,
+  type Issue,
+  type CreatePullReviewOption,
+  type PullReview,
+  type PullReviewComment,
+  type Reaction,
+  type EditPullRequestOption,
+  type User,
+  type RepositoryContent,
+  type ResolvedThread,
 } from "../types";
 
 /**
@@ -439,6 +441,21 @@ export class GiteaAdapter implements GitProvider {
     return this.request<PullReview[]>("GET", `/repos/${owner}/${repo}/pulls/${index}/reviews`);
   }
 
+  async updatePullReview(
+    owner: string,
+    repo: string,
+    index: number,
+    reviewId: number,
+    body: string,
+  ): Promise<PullReview> {
+    // Gitea 不支持更新 review，使用删除+创建的方式模拟
+    await this.deletePullReview(owner, repo, index, reviewId);
+    return this.createPullReview(owner, repo, index, {
+      event: REVIEW_STATE.COMMENT,
+      body,
+    });
+  }
+
   async deletePullReview(
     owner: string,
     repo: string,
@@ -463,6 +480,14 @@ export class GiteaAdapter implements GitProvider {
     );
   }
 
+  async deletePullReviewComment(owner: string, repo: string, commentId: number): Promise<void> {
+    await this.request<void>("DELETE", `/repos/${owner}/${repo}/pulls/comments/${commentId}`);
+  }
+
+  async listResolvedThreads(): Promise<ResolvedThread[]> {
+    return [];
+  }
+
   // ============ Reaction 操作 ============
 
   async getIssueCommentReactions(
@@ -476,6 +501,18 @@ export class GiteaAdapter implements GitProvider {
     );
   }
 
+  async getPullReviewCommentReactions(
+    owner: string,
+    repo: string,
+    commentId: number,
+  ): Promise<Reaction[]> {
+    // Gitea: PR review comment reactions 使用与 issue comment 相同的路径
+    return this.request<Reaction[]>(
+      "GET",
+      `/repos/${owner}/${repo}/issues/comments/${commentId}/reactions`,
+    );
+  }
+
   async getIssueReactions(owner: string, repo: string, index: number): Promise<Reaction[]> {
     return this.request<Reaction[]>("GET", `/repos/${owner}/${repo}/issues/${index}/reactions`);
   }

package/src/shared/git-provider/adapters/github.adapter.spec.ts

@@ -300,7 +300,8 @@ describe("GithubAdapter", () => {
       });
       const body = JSON.parse(fetchSpy.mock.calls[0][1].body);
       expect(body.event).toBe("COMMENT");
-      expect(body.comments[0].position).toBe(10);
+      expect(body.comments[0].line).toBe(10);
+      expect(body.comments[0].side).toBe("RIGHT");
       expect(body.comments[0].path).toBe("a.ts");
     });
   });

package/src/shared/git-provider/adapters/github.adapter.ts

@@ -4,30 +4,42 @@ import type {
   LockBranchOptions,
   ListPullRequestsOptions,
 } from "../git-provider.interface";
-import type {
-  GitProviderModuleOptions,
-  BranchProtection,
-  CreateBranchProtectionOption,
-  EditBranchProtectionOption,
-  Branch,
-  Repository,
-  PullRequest,
-  PullRequestCommit,
-  ChangedFile,
-  CommitInfo,
-  IssueComment,
-  CreateIssueCommentOption,
-  CreateIssueOption,
-  Issue,
-  CreatePullReviewOption,
-  PullReview,
-  PullReviewComment,
-  Reaction,
-  EditPullRequestOption,
-  User,
-  RepositoryContent,
+import {
+  REVIEW_STATE,
+  DIFF_SIDE,
+  type GitProviderModuleOptions,
+  type BranchProtection,
+  type CreateBranchProtectionOption,
+  type EditBranchProtectionOption,
+  type Branch,
+  type Repository,
+  type PullRequest,
+  type PullRequestCommit,
+  type ChangedFile,
+  type CommitInfo,
+  type IssueComment,
+  type CreateIssueCommentOption,
+  type CreateIssueOption,
+  type Issue,
+  type CreatePullReviewOption,
+  type PullReview,
+  type PullReviewComment,
+  type Reaction,
+  type EditPullRequestOption,
+  type User,
+  type RepositoryContent,
+  type ResolvedThread,
 } from "../types";
 
+/** GraphQL review thread 节点类型 */
+interface GraphQLReviewThread {
+  isResolved: boolean;
+  resolvedBy?: { login: string; databaseId: number } | null;
+  path?: string | null;
+  line?: number | null;
+  comments: { nodes: Array<{ databaseId: number }> };
+}
+
 /**
  * GitHub 平台适配器
  */
@@ -72,6 +84,31 @@ export class GithubAdapter implements GitProvider {
     return response.json() as Promise<T>;
   }
 
+  protected async requestGraphQL<T>(
+    query: string,
+    variables?: Record<string, unknown>,
+  ): Promise<T> {
+    const graphqlUrl =
+      this.baseUrl.replace(/\/v3\/?$/, "").replace(/\/api\/v3\/?$/, "") + "/graphql";
+    const response = await fetch(graphqlUrl, {
+      method: "POST",
+      headers: {
+        Authorization: `Bearer ${this.token}`,
+        "Content-Type": "application/json",
+      },
+      body: JSON.stringify({ query, variables }),
+    });
+    if (!response.ok) {
+      const errorText = await response.text();
+      throw new Error(`GitHub GraphQL error: ${response.status} - ${errorText}`);
+    }
+    const json = (await response.json()) as { data: T; errors?: unknown[] };
+    if (json.errors) {
+      throw new Error(`GitHub GraphQL errors: ${JSON.stringify(json.errors)}`);
+    }
+    return json.data;
+  }
+
   protected async fetchText(url: string): Promise<string> {
     const response = await fetch(url, {
       headers: {
@@ -468,7 +505,8 @@ export class GithubAdapter implements GitProvider {
       body.comments = options.comments.map((c) => ({
         path: c.path,
         body: c.body,
-        position: c.new_position,
+        line: c.new_position,
+        side: DIFF_SIDE.RIGHT,
       }));
     }
     const result = await this.request<Record<string, unknown>>(
@@ -487,6 +525,26 @@ export class GithubAdapter implements GitProvider {
     return results.map((r) => this.mapPullReview(r));
   }
 
+  async updatePullReview(
+    owner: string,
+    repo: string,
+    index: number,
+    reviewId: number,
+    body: string,
+  ): Promise<PullReview> {
+    // GitHub 的 updatePullReview 只能更新 PENDING 状态的 review
+    // 已提交的 review 无法更新，所以使用删除+创建的方式
+    try {
+      await this.deletePullReview(owner, repo, index, reviewId);
+    } catch {
+      // 已提交的 review 无法删除，忽略错误
+    }
+    return this.createPullReview(owner, repo, index, {
+      event: REVIEW_STATE.COMMENT,
+      body,
+    });
+  }
+
   async deletePullReview(
     owner: string,
     repo: string,
@@ -509,7 +567,23 @@ export class GithubAdapter implements GitProvider {
       "GET",
       `/repos/${owner}/${repo}/pulls/${index}/reviews/${reviewId}/comments`,
     );
-    return results.map((c) => this.mapPullReviewComment(c));
+    const comments = results.map((c) => this.mapPullReviewComment(c));
+    // 通过 GraphQL 补充 resolved 状态
+    try {
+      const resolvedMap = await this.fetchResolvedThreads(owner, repo, index);
+      for (const comment of comments) {
+        if (comment.id && resolvedMap.has(comment.id)) {
+          comment.resolver = resolvedMap.get(comment.id) ?? null;
+        }
+      }
+    } catch {
+      // GraphQL 查询失败不影响主流程
+    }
+    return comments;
+  }
+
+  async deletePullReviewComment(owner: string, repo: string, commentId: number): Promise<void> {
+    await this.request<void>("DELETE", `/repos/${owner}/${repo}/pulls/comments/${commentId}`);
   }
 
   // ============ Reaction 操作 ============
@@ -526,6 +600,18 @@ export class GithubAdapter implements GitProvider {
     return results.map((r) => this.mapReaction(r));
   }
 
+  async getPullReviewCommentReactions(
+    owner: string,
+    repo: string,
+    commentId: number,
+  ): Promise<Reaction[]> {
+    const results = await this.request<Array<Record<string, unknown>>>(
+      "GET",
+      `/repos/${owner}/${repo}/pulls/comments/${commentId}/reactions`,
+    );
+    return results.map((r) => this.mapReaction(r));
+  }
+
   async getIssueReactions(owner: string, repo: string, index: number): Promise<Reaction[]> {
     const results = await this.request<Array<Record<string, unknown>>>(
       "GET",
@@ -722,6 +808,91 @@ export class GithubAdapter implements GitProvider {
     };
   }
 
+  /**
+   * 通过 GraphQL 查询 PR 的 review threads resolved 状态
+   * 返回 Map<commentId, resolver>（用于 listPullReviewComments 内部补充 resolver）
+   */
+  protected async fetchResolvedThreads(
+    owner: string,
+    repo: string,
+    prNumber: number,
+  ): Promise<Map<number, { id?: number; login?: string } | null>> {
+    const threads = await this.queryReviewThreads(owner, repo, prNumber);
+    const resolvedMap = new Map<number, { id?: number; login?: string } | null>();
+    for (const thread of threads) {
+      if (!thread.isResolved) continue;
+      const firstComment = thread.comments.nodes[0];
+      if (!firstComment?.databaseId) continue;
+      resolvedMap.set(
+        firstComment.databaseId,
+        thread.resolvedBy
+          ? { id: thread.resolvedBy.databaseId, login: thread.resolvedBy.login }
+          : null,
+      );
+    }
+    return resolvedMap;
+  }
+
+  async listResolvedThreads(owner: string, repo: string, index: number): Promise<ResolvedThread[]> {
+    const threads = await this.queryReviewThreads(owner, repo, index);
+    const result: ResolvedThread[] = [];
+    for (const thread of threads) {
+      if (!thread.isResolved) continue;
+      result.push({
+        path: thread.path ?? undefined,
+        line: thread.line ?? undefined,
+        resolvedBy: thread.resolvedBy
+          ? { id: thread.resolvedBy.databaseId, login: thread.resolvedBy.login }
+          : null,
+      });
+    }
+    return result;
+  }
+
+  /**
+   * GraphQL 查询 PR 的所有 review threads
+   */
+  protected async queryReviewThreads(
+    owner: string,
+    repo: string,
+    prNumber: number,
+  ): Promise<GraphQLReviewThread[]> {
+    const QUERY = `
+      query($owner: String!, $repo: String!, $prNumber: Int!) {
+        repository(owner: $owner, name: $repo) {
+          pullRequest(number: $prNumber) {
+            reviewThreads(first: 100) {
+              nodes {
+                isResolved
+                resolvedBy { login databaseId }
+                path
+                line
+                comments(first: 1) {
+                  nodes { databaseId }
+                }
+              }
+            }
+          }
+        }
+      }
+    `;
+    interface GraphQLResult {
+      repository: {
+        pullRequest: {
+          reviewThreads: {
+            nodes: GraphQLReviewThread[];
+          };
+        };
+      };
+    }
+    const data = await this.requestGraphQL<GraphQLResult>(QUERY, {
+      owner,
+      repo,
+      prNumber,
+    });
+    return data.repository.pullRequest.reviewThreads.nodes;
+  }
+
   protected mapPullReviewComment(data: Record<string, unknown>): PullReviewComment {
     const user = data.user as Record<string, unknown> | undefined;
     return {
@@ -809,12 +980,12 @@ export class GithubAdapter implements GitProvider {
 
   protected mapReviewEvent(event?: string): string {
     const eventMap: Record<string, string> = {
-      APPROVE: "APPROVE",
-      REQUEST_CHANGES: "REQUEST_CHANGES",
-      COMMENT: "COMMENT",
-      PENDING: "PENDING",
+      [REVIEW_STATE.APPROVE]: REVIEW_STATE.APPROVE,
+      [REVIEW_STATE.REQUEST_CHANGES]: REVIEW_STATE.REQUEST_CHANGES,
+      [REVIEW_STATE.COMMENT]: REVIEW_STATE.COMMENT,
+      [REVIEW_STATE.PENDING]: REVIEW_STATE.PENDING,
     };
-    return event ? eventMap[event] || event : "COMMENT";
+    return event ? eventMap[event] || event : REVIEW_STATE.COMMENT;
   }
 
   protected mapSortParam(sort: string): string {

package/src/shared/git-provider/adapters/gitlab.adapter.ts

@@ -4,28 +4,30 @@ import type {
   LockBranchOptions,
   ListPullRequestsOptions,
 } from "../git-provider.interface";
-import type {
-  GitProviderModuleOptions,
-  BranchProtection,
-  CreateBranchProtectionOption,
-  EditBranchProtectionOption,
-  Branch,
-  Repository,
-  PullRequest,
-  PullRequestCommit,
-  ChangedFile,
-  CommitInfo,
-  IssueComment,
-  CreateIssueCommentOption,
-  CreateIssueOption,
-  Issue,
-  CreatePullReviewOption,
-  PullReview,
-  PullReviewComment,
-  Reaction,
-  EditPullRequestOption,
-  User,
-  RepositoryContent,
+import {
+  REVIEW_STATE,
+  type GitProviderModuleOptions,
+  type BranchProtection,
+  type CreateBranchProtectionOption,
+  type EditBranchProtectionOption,
+  type Branch,
+  type Repository,
+  type PullRequest,
+  type PullRequestCommit,
+  type ChangedFile,
+  type CommitInfo,
+  type IssueComment,
+  type CreateIssueCommentOption,
+  type CreateIssueOption,
+  type Issue,
+  type CreatePullReviewOption,
+  type PullReview,
+  type PullReviewComment,
+  type Reaction,
+  type EditPullRequestOption,
+  type User,
+  type RepositoryContent,
+  type ResolvedThread,
 } from "../types";
 
 /**
@@ -553,7 +555,7 @@ export class GitlabAdapter implements GitProvider {
       return {
         id: note.id,
         body: note.body,
-        state: options.event || "COMMENT",
+        state: options.event || REVIEW_STATE.COMMENT,
         user: note.user,
         created_at: note.created_at,
         updated_at: note.updated_at,
@@ -570,13 +572,13 @@ export class GitlabAdapter implements GitProvider {
       }
     }
     // 如果是 APPROVE 事件，调用 approve API
-    if (options.event === "APPROVE") {
+    if (options.event === REVIEW_STATE.APPROVE) {
       await this.request<void>("POST", `/projects/${project}/merge_requests/${index}/approve`);
     }
     return {
       id: 0,
       body: options.body || "",
-      state: options.event || "COMMENT",
+      state: options.event || REVIEW_STATE.COMMENT,
     };
   }
 
@@ -594,7 +596,7 @@ export class GitlabAdapter implements GitProvider {
         return {
           id: note.id,
           body: note.body,
-          state: "COMMENT",
+          state: REVIEW_STATE.COMMENT,
           user: note.user,
           created_at: note.created_at,
           updated_at: note.updated_at,
@@ -602,6 +604,32 @@ export class GitlabAdapter implements GitProvider {
       });
   }
 
+  async updatePullReview(
+    owner: string,
+    repo: string,
+    index: number,
+    reviewId: number,
+    body: string,
+  ): Promise<PullReview> {
+    const project = this.encodeProject(owner, repo);
+    const result = await this.request<Record<string, unknown>>(
+      "PUT",
+      `/projects/${project}/merge_requests/${index}/notes/${reviewId}`,
+      { body },
+    );
+    return {
+      id: result.id as number,
+      body: result.body as string,
+      state: REVIEW_STATE.COMMENT,
+      user: result.author
+        ? {
+            id: (result.author as Record<string, unknown>).id as number,
+            login: (result.author as Record<string, unknown>).username as string,
+          }
+        : undefined,
+    };
+  }
+
   async deletePullReview(
     owner: string,
     repo: string,
@@ -645,6 +673,21 @@ export class GitlabAdapter implements GitProvider {
       });
   }
 
+  async deletePullReviewComment(owner: string, repo: string, commentId: number): Promise<void> {
+    // GitLab: 删除 MR note
+    const project = this.encodeProject(owner, repo);
+    // GitLab 删除 note 需要 merge_request_iid，但此处只有 commentId（note_id）
+    // 使用全局 note 删除不可行，需要通过其他方式获取 MR iid
+    // 暂时忽略，GitLab 场景下行级评论删除不常用
+    console.warn(
+      `⚠️ GitLab 暂不支持删除单条 review comment (id: ${commentId}, project: ${project})`,
+    );
+  }
+
+  async listResolvedThreads(): Promise<ResolvedThread[]> {
+    return [];
+  }
+
   // ============ Reaction 操作 ============
 
   async getIssueCommentReactions(
@@ -656,6 +699,15 @@ export class GitlabAdapter implements GitProvider {
     return [];
   }
 
+  async getPullReviewCommentReactions(
+    _owner: string,
+    _repo: string,
+    _commentId: number,
+  ): Promise<Reaction[]> {
+    // GitLab: award emoji on notes（需要 noteable_iid，此处简化返回空）
+    return [];
+  }
+
   async getIssueReactions(owner: string, repo: string, index: number): Promise<Reaction[]> {
     const project = this.encodeProject(owner, repo);
     try {