npm - @sourceregistry/sveltekit-oidc - Versions diffs - 2.1.0 → 3.0.0 - Mend

@sourceregistry/sveltekit-oidc 2.1.0 → 3.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (15) hide show

package/README.md +125 -69
package/dist/client/OIDCContext.svelte +217 -5
package/dist/client/OIDCContext.svelte.d.ts +30 -2
package/dist/client/idle.d.ts +7 -0
package/dist/client/idle.js +22 -0
package/dist/server/cookies.d.ts +1 -1
package/dist/server/cookies.js +28 -7
package/dist/server/index.js +346 -91
package/dist/server/jwt.js +13 -3
package/dist/server/store.d.ts +3 -1
package/dist/server/store.js +27 -7
package/dist/server/types.d.ts +41 -2
package/dist/server/utils.d.ts +32 -1
package/dist/server/utils.js +97 -4
package/package.json +2 -2

package/dist/server/index.js CHANGED Viewed

@@ -1,18 +1,24 @@
 import { error, redirect } from '@sveltejs/kit';
-import { randomBytes } from 'node:crypto';
-import { decode, fromWeb, verify } from '@sourceregistry/node-jwt/promises';
+import { createHash, randomBytes } from 'node:crypto';
+import { fromWeb } from '@sourceregistry/node-jwt/promises';
+import { decode as decodeJwt, verify as verifyJwt } from '@sourceregistry/node-jwt';
 import { createOIDCCookieStore } from './cookies.js';
 import { asAuthorizationHeader, createClientSecretJwtAssertion, createPrivateKeyJwtAssertion, fetchJson } from './jwt.js';
 import { isSessionExpired, normalizeTokens, shouldRefresh } from './session.js';
-import { absoluteUrl, base64UrlEncode, buildCookieOptions, collectGroups, createPKCEPair, internalRedirectPath, normalizeIssuer, normalizeScope, parseProviderError, toPublicSession, validateIdTokenClaims, validateUserInfoSubject } from './utils.js';
+import { absoluteUrl, base64UrlEncode, buildCookieOptions, collectGroups, createPKCEPair, decodeOAuthState, encodeOAuthState, internalRedirectPath, normalizeIssuer, normalizeScope, parseProviderError, toPublicSession, validateIdTokenClaims, validateRefreshedIdTokenClaims, validateUserInfoSubject } from './utils.js';
 import { createInMemoryBackChannelLogoutStore, createInMemorySessionStore } from './store.js';
 export { createInMemoryBackChannelLogoutStore, createInMemorySessionStore } from './store.js';
 const OIDC_SESSION_REVALIDATION_DEPENDENCY = 'oidc:session';
-const LOGIN_PROMPTS = new Set([
-    'login',
-    'consent',
-    'none',
-    'select_account'
+const LOGIN_PROMPTS = new Set(['login', 'consent', 'none', 'select_account']);
+const RESERVED_AUTHORIZATION_PARAMETERS = new Set([
+    'client_id',
+    'response_type',
+    'redirect_uri',
+    'scope',
+    'state',
+    'nonce',
+    'code_challenge',
+    'code_challenge_method'
 ]);
 function silentReauthenticationResponse(status) {
     return new Response(`<!doctype html><html lang="en" data-oidc-silent-reauth="${status}"><head><meta charset="utf-8"><title>OIDC session check</title></head><body></body></html>`, {
@@ -44,17 +50,36 @@ function buildLogger(logger) {
 }
 export function createOIDC(options) {
     const log = buildLogger(options.logger);
-    const sessionStore = options.sessionStore === 'memory' ? createInMemorySessionStore() : options.sessionStore;
-    const backChannelLogoutStore = options.backChannelLogoutStore === 'memory'
-        ? createInMemoryBackChannelLogoutStore()
-        : options.backChannelLogoutStore;
     const cookieOptions = buildCookieOptions(options.cookieOptions);
     const clockSkewSeconds = options.clockSkewSeconds ?? 30;
     const refreshToleranceSeconds = options.refreshToleranceSeconds ?? 30;
     const sessionMaxAgeSeconds = options.sessionMaxAgeSeconds ?? 60 * 60 * 8;
+    if (Buffer.byteLength(options.cookieSecret, 'utf8') < 32) {
+        throw new TypeError('cookieSecret must contain at least 32 bytes of entropy');
+    }
+    if (!Number.isFinite(clockSkewSeconds) || clockSkewSeconds < 0) {
+        throw new TypeError('clockSkewSeconds must be a non-negative finite number');
+    }
+    if (!Number.isFinite(refreshToleranceSeconds) || refreshToleranceSeconds < 0) {
+        throw new TypeError('refreshToleranceSeconds must be a non-negative finite number');
+    }
     if (!Number.isFinite(sessionMaxAgeSeconds) || sessionMaxAgeSeconds <= 0) {
         throw new TypeError('sessionMaxAgeSeconds must be a positive finite number');
     }
+    const stateMaxAgeSeconds = options.stateMaxAgeSeconds ?? 60 * 10;
+    if (!Number.isFinite(stateMaxAgeSeconds) || stateMaxAgeSeconds <= 0) {
+        throw new TypeError('stateMaxAgeSeconds must be a positive finite number');
+    }
+    const maxCookieSizeBytes = options.maxCookieSizeBytes ?? 3800;
+    if (!Number.isFinite(maxCookieSizeBytes) || maxCookieSizeBytes <= 0) {
+        throw new TypeError('maxCookieSizeBytes must be a positive finite number');
+    }
+    const sessionStore = options.sessionStore === 'memory' ? createInMemorySessionStore() : options.sessionStore;
+    const backChannelLogoutStore = options.backChannelLogoutStore === 'memory'
+        ? createInMemoryBackChannelLogoutStore({
+            retentionSeconds: sessionMaxAgeSeconds
+        })
+        : options.backChannelLogoutStore;
     const sessionCookieName = options.sessionCookieName ?? 'oidc_session';
     const stateCookieName = options.stateCookieName ?? 'oidc_auth_state';
     const defaultScope = normalizeScope(options.scope);
@@ -63,9 +88,45 @@ export function createOIDC(options) {
     const redirectPath = options.redirectPath ?? '/auth/callback';
     const clientAuthMethod = options.clientAuthMethod ?? (options.clientSecret ? 'client_secret_basic' : 'none');
     const fetchImpl = options.fetch ?? fetch;
-    const cookieStore = createOIDCCookieStore(options.cookieSecret, sessionCookieName, stateCookieName, cookieOptions);
+    const cookieStore = createOIDCCookieStore(options.cookieSecret, sessionCookieName, stateCookieName, cookieOptions, stateMaxAgeSeconds, maxCookieSizeBytes);
     let metadataPromise;
     let jwksPromise;
+    const configuredIssuer = options.issuer ? normalizeIssuer(options.issuer) : undefined;
+    function validateProtocolUrl(name, value, issuer = false) {
+        let url;
+        try {
+            url = new URL(value);
+        }
+        catch {
+            throw error(500, { message: `OIDC ${name} must be an absolute URL` });
+        }
+        if (!options.allowInsecureHttp && url.protocol !== 'https:') {
+            throw error(500, { message: `OIDC ${name} must use HTTPS` });
+        }
+        if (url.hash || (issuer && url.search)) {
+            throw error(500, {
+                message: `OIDC ${name} must not contain a query or fragment`
+            });
+        }
+    }
+    function validateMetadata(document, expectedIssuer) {
+        const issuer = normalizeIssuer(document.issuer ?? '');
+        if (!issuer || (expectedIssuer && issuer !== expectedIssuer)) {
+            throw error(500, {
+                message: 'OIDC discovery issuer does not match the configured issuer'
+            });
+        }
+        validateProtocolUrl('issuer', issuer, true);
+        validateProtocolUrl('authorization_endpoint', document.authorization_endpoint);
+        validateProtocolUrl('token_endpoint', document.token_endpoint);
+        if (document.jwks_uri)
+            validateProtocolUrl('jwks_uri', document.jwks_uri);
+        if (document.userinfo_endpoint)
+            validateProtocolUrl('userinfo_endpoint', document.userinfo_endpoint);
+        if (document.end_session_endpoint)
+            validateProtocolUrl('end_session_endpoint', document.end_session_endpoint);
+        return { ...document, issuer };
+    }
     function hasCurrentSessionShape(session) {
         return Boolean(session?.identity?.sub && session.idTokenClaims?.sub);
     }
@@ -127,32 +188,37 @@ export function createOIDC(options) {
         if (!metadataPromise) {
             metadataPromise = (async () => {
                 if (options.endpoints?.authorization_endpoint && options.endpoints?.token_endpoint) {
-                    return {
-                        issuer: normalizeIssuer(options.issuer ?? options.endpoints.issuer ?? ''),
+                    return validateMetadata({
                         jwks_uri: options.endpoints.jwks_uri ?? '',
-                        ...options.endpoints
-                    };
+                        ...options.endpoints,
+                        issuer: configuredIssuer ?? normalizeIssuer(options.endpoints.issuer ?? '')
+                    }, configuredIssuer);
                 }
-                const issuer = options.issuer ? normalizeIssuer(options.issuer) : undefined;
-                const discoveryUrl = options.discoveryUrl ?? (issuer ? `${issuer}/.well-known/openid-configuration` : undefined);
+                const discoveryUrl = options.discoveryUrl ??
+                    (configuredIssuer ? `${configuredIssuer}/.well-known/openid-configuration` : undefined);
                 if (!discoveryUrl) {
                     throw error(500, {
                         message: 'OIDC issuer or discoveryUrl must be configured'
                     });
                 }
+                validateProtocolUrl('discoveryUrl', discoveryUrl);
                 const document = await fetchJson(discoveryUrl, undefined, fetchImpl);
-                return {
+                return validateMetadata({
                     ...document,
                     ...options.endpoints,
                     issuer: normalizeIssuer(document.issuer)
-                };
-            })();
+                }, configuredIssuer);
+            })().catch((err) => {
+                metadataPromise = undefined;
+                throw err;
+            });
         }
         return metadataPromise;
     }
     async function getJwks() {
         if (!jwksPromise) {
-            jwksPromise = getMetadata().then((metadata) => {
+            jwksPromise = getMetadata()
+                .then((metadata) => {
                 if (!metadata.jwks_uri) {
                     throw error(500, {
                         message: 'OIDC jwks_uri is required to validate id_token values'
@@ -162,32 +228,74 @@ export function createOIDC(options) {
                     overrideEndpointCheck: true,
                     fetch: fetchImpl
                 });
+            })
+                .catch((err) => {
+                jwksPromise = undefined;
+                throw err;
             });
         }
         return jwksPromise;
     }
     async function verifyJwtWithJwks(token, verifyOptions) {
-        let decoded;
+        let header;
         try {
-            decoded = await decode(token);
+            header = decodeJwt(token).header;
         }
         catch {
             throw error(400, { message: 'Invalid JWT format' });
         }
-        const jwks = await getJwks();
-        const key = decoded.header.kid ? await jwks.key(decoded.header.kid) : (await jwks.list())[0];
-        if (!key) {
+        const algorithms = verifyOptions.algorithms?.length
+            ? verifyOptions.algorithms
+            : ['RS256'];
+        if (!header.alg || !algorithms.includes(header.alg)) {
             throw error(401, {
-                message: 'Unable to resolve a signing key from JWKS'
+                message: `JWT algorithm '${header.alg ?? 'missing'}' is not allowed`
             });
         }
-        try {
-            const result = await verify(token, key.toKeyObject(), verifyOptions);
+        if (header.typ && verifyOptions.types && !verifyOptions.types.includes(header.typ)) {
+            throw error(401, { message: `JWT type '${header.typ}' is not allowed` });
+        }
+        const nodeJwtOptions = {
+            issuer: verifyOptions.issuer,
+            audience: verifyOptions.audience,
+            algorithms,
+            clockSkew: verifyOptions.clockSkew ?? 0,
+            tokenTypes: verifyOptions.types ?? ['JWT']
+        };
+        const verifyWithKey = (key) => {
+            const result = verifyJwt(token, key, nodeJwtOptions);
+            if (!result.valid)
+                throw new Error(result.error.reason);
             return result.payload;
+        };
+        try {
+            if (header.alg.startsWith('HS')) {
+                if (!options.clientSecret)
+                    throw new Error('clientSecret is required for HMAC-signed ID tokens');
+                return verifyWithKey(options.clientSecret);
+            }
+            const jwks = await getJwks();
+            let keys = header.kid ? [await jwks.key(header.kid)] : await jwks.list();
+            if (header.kid && !keys[0]) {
+                await jwks.refresh();
+                keys = [await jwks.key(header.kid)];
+            }
+            let lastError;
+            for (const key of keys) {
+                if (!key)
+                    continue;
+                try {
+                    return verifyWithKey(key.toKeyObject());
+                }
+                catch (err) {
+                    lastError = err;
+                }
+            }
+            throw lastError ?? new Error('Unable to resolve a signing key from JWKS');
         }
         catch (err) {
             throw error(401, {
-                message: typeof err === 'object' && err && 'reason' in err ? String(err.reason) : 'JWT verification failed'
+                message: err instanceof Error ? err.message : 'JWT verification failed'
             });
         }
     }
@@ -271,15 +379,56 @@ export function createOIDC(options) {
             body: auth.body
         }, fetchImpl);
     }
+    function idTokenAlgorithms(metadata) {
+        const supported = new Set([
+            'HS256',
+            'HS384',
+            'HS512',
+            'RS256',
+            'RS384',
+            'RS512',
+            'ES256',
+            'ES384',
+            'ES512',
+            'ES256K',
+            'PS256',
+            'PS384',
+            'PS512',
+            'EdDSA'
+        ]);
+        const configured = options.idTokenSigningAlgorithms ?? metadata.id_token_signing_alg_values_supported;
+        if (!configured?.length)
+            return ['RS256'];
+        const algorithms = configured.filter((algorithm) => supported.has(algorithm));
+        if (!algorithms.length)
+            throw error(500, {
+                message: 'Provider has no supported ID-token signing algorithm'
+            });
+        return algorithms;
+    }
     async function validateIdToken(idToken, nonce) {
         const metadata = await getMetadata();
         const claims = await verifyJwtWithJwks(idToken, {
             issuer: metadata.issuer,
             audience: options.clientId,
-            algorithms: metadata.id_token_signing_alg_values_supported,
+            algorithms: idTokenAlgorithms(metadata),
+            types: ['JWT'],
             clockSkew: clockSkewSeconds
         });
-        validateIdTokenClaims(claims, nonce);
+        validateIdTokenClaims(claims, nonce, options.clientId, options.trustedIdTokenAudiences);
+        return claims;
+    }
+    async function validateRefreshedIdToken(idToken, previous) {
+        const metadata = await getMetadata();
+        const claims = await verifyJwtWithJwks(idToken, {
+            issuer: metadata.issuer,
+            audience: options.clientId,
+            algorithms: idTokenAlgorithms(metadata),
+            types: ['JWT'],
+            clockSkew: clockSkewSeconds
+        });
+        validateIdTokenClaims(claims, previous.nonce, options.clientId, options.trustedIdTokenAudiences, false);
+        validateRefreshedIdTokenClaims(previous, claims);
         return claims;
     }
     async function resolveIdentity(idTokenClaims, userInfo, reason) {
@@ -297,9 +446,20 @@ export function createOIDC(options) {
         const claims = await verifyJwtWithJwks(logoutToken, {
             issuer: metadata.issuer,
             audience: options.clientId,
+            algorithms: idTokenAlgorithms(metadata),
+            types: ['JWT', 'logout+jwt'],
             clockSkew: clockSkewSeconds
         });
-        if (!claims.events?.['http://schemas.openid.net/event/backchannel-logout']) {
+        if (!Number.isFinite(claims.iat) ||
+            !Number.isFinite(claims.exp) ||
+            typeof claims.jti !== 'string' ||
+            !claims.jti) {
+            throw error(400, {
+                message: 'logout_token must contain valid iat, exp, and jti claims'
+            });
+        }
+        const event = claims.events?.['http://schemas.openid.net/event/backchannel-logout'];
+        if (!event || typeof event !== 'object' || Array.isArray(event)) {
             throw error(400, { message: 'Invalid logout_token events claim' });
         }
         if (!claims.sid && !claims.sub) {
@@ -327,6 +487,36 @@ export function createOIDC(options) {
         }
         return backChannelLogoutStore.isRevoked(session);
     }
+    const refreshTasks = new Map();
+    async function refreshSessionTokens(session, event) {
+        const tokenResponse = await refreshTokens(session.tokens.refreshToken);
+        const idTokenClaims = tokenResponse.id_token
+            ? await validateRefreshedIdToken(tokenResponse.id_token, session.idTokenClaims)
+            : session.idTokenClaims;
+        const userInfo = options.fetchUserInfo !== false && tokenResponse.access_token
+            ? await fetchUserInfo(tokenResponse.access_token)
+            : session.userInfo;
+        validateUserInfoSubject(idTokenClaims, userInfo);
+        const identity = await resolveIdentity(idTokenClaims, userInfo, 'refresh');
+        const nextSession = {
+            ...session,
+            sub: idTokenClaims.sub,
+            sid: idTokenClaims.sid ?? session.sid,
+            groups: collectGroups(idTokenClaims, userInfo, identity),
+            idTokenClaims,
+            userInfo,
+            identity,
+            sessionState: tokenResponse.session_state ?? session.sessionState,
+            tokens: normalizeTokens(tokenResponse, defaultScope, session.tokens),
+            refreshedAt: Math.floor(Date.now() / 1000)
+        };
+        return ((await options.beforeSessionPersist?.({
+            session: nextSession,
+            reason: 'refresh',
+            event,
+            tokenResponse
+        })) ?? nextSession);
+    }
     async function maybeRefreshSession(cookies, persisted, event) {
         const session = persisted?.session ?? null;
         if (!session) {
@@ -357,49 +547,61 @@ export function createOIDC(options) {
         if (!shouldRefresh(session, refreshToleranceSeconds)) {
             return session;
         }
-        try {
-            log.debug('Refreshing OIDC session tokens', {
-                expiresAt: session.tokens.expiresAt,
-                refreshExpiresAt: session.tokens.refreshExpiresAt
-            });
-            const tokenResponse = await refreshTokens(session.tokens.refreshToken);
-            const idTokenClaims = tokenResponse.id_token
-                ? await validateIdToken(tokenResponse.id_token, session.nonce)
-                : session.idTokenClaims;
-            const userInfo = options.fetchUserInfo !== false ? await fetchUserInfo(tokenResponse.access_token) : session.userInfo;
-            validateUserInfoSubject(idTokenClaims, userInfo);
-            const identity = await resolveIdentity(idTokenClaims, userInfo, 'refresh');
-            const nextSession = {
-                ...session,
-                sub: idTokenClaims.sub,
-                sid: idTokenClaims.sid ?? session.sid,
-                groups: collectGroups(idTokenClaims, userInfo, identity),
-                idTokenClaims,
-                userInfo,
-                identity,
-                sessionState: tokenResponse.session_state ?? session.sessionState,
-                tokens: normalizeTokens(tokenResponse, defaultScope, session.tokens),
-                refreshedAt: Math.floor(Date.now() / 1000)
+        const refreshKey = persisted?.id ??
+            createHash('sha256')
+                .update(session.tokens.refreshToken)
+                .digest('base64url');
+        let task = refreshTasks.get(refreshKey);
+        if (!task) {
+            const execute = async () => {
+                let current = session;
+                if (sessionStore && persisted?.id) {
+                    current = (await sessionStore.get(persisted.id)) ?? session;
+                    if (!shouldRefresh(current, refreshToleranceSeconds))
+                        return current;
+                }
+                try {
+                    log.debug('Refreshing OIDC session tokens', {
+                        expiresAt: current.tokens.expiresAt,
+                        refreshExpiresAt: current.tokens.refreshExpiresAt
+                    });
+                    const refreshed = await refreshSessionTokens(current, event);
+                    if (sessionStore)
+                        await writePersistedSession(cookies, refreshed, persisted?.id);
+                    return refreshed;
+                }
+                catch (err) {
+                    log.error('Token refresh failed — clearing session', err);
+                    if (sessionStore && persisted?.id) {
+                        const latest = await sessionStore.get(persisted.id);
+                        if (latest?.tokens.refreshToken !== current.tokens.refreshToken)
+                            return latest;
+                        await sessionStore.delete(persisted.id);
+                    }
+                    return null;
+                }
             };
-            const persistedSession = (await options.beforeSessionPersist?.({
-                session: nextSession,
-                reason: 'refresh',
-                event,
-                tokenResponse
-            })) ?? nextSession;
-            await writePersistedSession(cookies, persistedSession, persisted?.id);
-            log.debug('OIDC session tokens refreshed', {
-                expiresAt: persistedSession.tokens.expiresAt,
-                refreshExpiresAt: persistedSession.tokens.refreshExpiresAt,
-                hasRefreshToken: Boolean(persistedSession.tokens.refreshToken)
+            task = (options.refreshLock ? options.refreshLock.runExclusive(refreshKey, execute) : execute()).finally(() => {
+                refreshTasks.delete(refreshKey);
             });
-            return persistedSession;
+            refreshTasks.set(refreshKey, task);
         }
-        catch (err) {
-            log.error('Token refresh failed — clearing session', err);
-            await clearPersistedSession(cookies, persisted?.id);
+        const refreshed = await task;
+        if (!refreshed) {
+            if (sessionStore)
+                cookieStore.clearSessionReference(cookies);
+            else
+                cookieStore.clearSession(cookies);
             return null;
         }
+        if (!sessionStore)
+            await writePersistedSession(cookies, refreshed);
+        log.debug('OIDC session tokens refreshed', {
+            expiresAt: refreshed.tokens.expiresAt,
+            refreshExpiresAt: refreshed.tokens.refreshExpiresAt,
+            hasRefreshToken: Boolean(refreshed.tokens.refreshToken)
+        });
+        return refreshed;
     }
     async function getSession(event) {
         return maybeRefreshSession(event.cookies, await readPersistedSession(event.cookies), 'url' in event && 'request' in event ? event : undefined);
@@ -407,12 +609,19 @@ export function createOIDC(options) {
     async function signIn(event, loginOptions = {}) {
         const metadata = await getMetadata();
         const pkce = createPKCEPair();
-        const state = base64UrlEncode(randomBytes(24));
+        // `token` is the value actually compared against the state cookie on
+        // callback (unchanged from before). `state` - what's sent to the
+        // provider - additionally carries an encrypted `returnTo`, so it survives
+        // purely as a round-tripped query parameter even if the state cookie
+        // itself doesn't make it back (expired or removed by browser policy).
+        // See handleCallback's restart-on-mismatch branch.
+        const token = base64UrlEncode(randomBytes(24));
         const nonce = base64UrlEncode(randomBytes(24));
         const returnTo = internalRedirectPath(event, loginOptions.returnTo ?? options.defaultLoginRedirect, '/');
+        const state = encodeOAuthState(token, returnTo, options.cookieSecret);
         const existingSession = loginOptions.prompt === 'none' ? await readPersistedSession(event.cookies) : null;
         cookieStore.writeState(event.cookies, {
-            state,
+            state: token,
             nonce,
             codeVerifier: pkce.verifier,
             returnTo,
@@ -440,29 +649,61 @@ export function createOIDC(options) {
             authorizationUrl.searchParams.set('id_token_hint', existingSession.session.tokens.idToken);
         }
         for (const [key, value] of Object.entries(loginOptions.extraParams ?? {})) {
+            if (RESERVED_AUTHORIZATION_PARAMETERS.has(key)) {
+                throw error(500, {
+                    message: `extraParams must not override reserved parameter '${key}'`
+                });
+            }
             authorizationUrl.searchParams.set(key, value);
         }
         throw redirect(302, authorizationUrl.toString());
     }
     async function handleCallback(event) {
+        const rawState = event.url.searchParams.get('state');
+        const code = event.url.searchParams.get('code');
+        const decodedState = decodeOAuthState(rawState, options.cookieSecret);
+        const stateCookie = cookieStore.readState(event.cookies, decodedState.token);
+        const now = Math.floor(Date.now() / 1000);
+        const stateMatches = Boolean(stateCookie &&
+            rawState &&
+            stateCookie.state === decodedState.token &&
+            Number.isFinite(stateCookie.createdAt) &&
+            stateCookie.createdAt <= now + clockSkewSeconds &&
+            stateCookie.createdAt + stateMaxAgeSeconds >= now);
         const providerError = parseProviderError(event);
         if (providerError) {
+            if (!stateMatches)
+                throw error(400, { message: 'Invalid or expired callback state' });
+            cookieStore.clearState(event.cookies, decodedState.token);
             throw providerError;
         }
-        const stateCookie = cookieStore.readState(event.cookies);
-        const state = event.url.searchParams.get('state');
-        const code = event.url.searchParams.get('code');
-        if (!stateCookie || !state || !code || stateCookie.state !== state) {
-            cookieStore.clearState(event.cookies);
-            log.warn('Invalid or expired callback state — restarting login flow');
-            return signIn(event);
+        if (!stateCookie || !code || !stateMatches) {
+            cookieStore.clearState(event.cookies, decodedState.token);
+            // The state cookie didn't make it back (expired past
+            // stateMaxAgeSeconds or removed by browser policy). Restarting is
+            // still correct (there's nothing left to
+            // verify a code exchange against), but `returnTo` doesn't have
+            // to be lost: it travels encrypted inside `state` itself
+            // (see encodeOAuthState), independent of the cookie.
+            log.warn('Invalid or expired callback state — restarting login flow', {
+                recoveredReturnTo: decodedState.returnTo !== undefined
+            });
+            return signIn(event, decodedState.returnTo !== undefined ? { returnTo: decodedState.returnTo } : undefined);
         }
-        cookieStore.clearState(event.cookies);
+        cookieStore.clearState(event.cookies, decodedState.token);
         const tokenResponse = await exchangeCode({
             code,
             redirectUri: absoluteUrl(event, redirectPath),
             codeVerifier: stateCookie.codeVerifier
         });
+        if (typeof tokenResponse.access_token !== 'string' ||
+            !tokenResponse.access_token ||
+            typeof tokenResponse.token_type !== 'string' ||
+            !tokenResponse.token_type) {
+            throw error(401, {
+                message: 'OIDC callback response must include access_token and token_type'
+            });
+        }
         if (!tokenResponse.id_token) {
             throw error(401, {
                 message: 'OIDC callback response must include an id_token'
@@ -470,7 +711,9 @@ export function createOIDC(options) {
         }
         const idTokenClaims = await validateIdToken(tokenResponse.id_token, stateCookie.nonce);
         if (stateCookie.prompt === 'none' && stateCookie.originalSub && idTokenClaims.sub !== stateCookie.originalSub) {
-            throw error(401, { message: 'Silent re-authentication returned a different End-User' });
+            throw error(401, {
+                message: 'Silent re-authentication returned a different End-User'
+            });
         }
         const userInfo = options.fetchUserInfo === false
             ? undefined
@@ -478,7 +721,6 @@ export function createOIDC(options) {
         validateUserInfoSubject(idTokenClaims, userInfo);
         const identity = await resolveIdentity(idTokenClaims, userInfo, 'login');
         const metadata = await getMetadata();
-        const now = Math.floor(Date.now() / 1000);
         const session = {
             issuer: metadata.issuer,
             clientId: options.clientId,
@@ -508,15 +750,24 @@ export function createOIDC(options) {
         };
     }
     async function signOut(event, logoutOptions = {}) {
-        const metadata = await getMetadata();
         const persisted = await readPersistedSession(event.cookies);
         const session = persisted?.session ?? null;
         cookieStore.clearState(event.cookies);
         await clearPersistedSession(event.cookies, persisted?.id);
         const postLogoutRedirectPath = internalRedirectPath(event, logoutOptions.postLogoutRedirectUri ?? options.defaultLogoutRedirect ?? options.postLogoutRedirectUri, '/');
-        if (logoutOptions.clearSessionOnly || !metadata.end_session_endpoint) {
+        if (logoutOptions.clearSessionOnly) {
             throw redirect(302, postLogoutRedirectPath);
         }
+        let metadata;
+        try {
+            metadata = await getMetadata();
+        }
+        catch (err) {
+            log.warn('Provider metadata unavailable during logout; local session was cleared', err);
+            throw redirect(302, postLogoutRedirectPath);
+        }
+        if (!metadata.end_session_endpoint)
+            throw redirect(302, postLogoutRedirectPath);
         const url = new URL(metadata.end_session_endpoint);
         if (session?.tokens.idToken) {
             url.searchParams.set('id_token_hint', session.tokens.idToken);
@@ -600,9 +851,13 @@ export function createOIDC(options) {
     }
     function callbackHandler(handlerOptions = {}) {
         return async (event) => {
-            const stateCookie = cookieStore.readState(event.cookies);
-            const callbackState = event.url.searchParams.get('state');
-            const isSilentReauthentication = Boolean(stateCookie?.prompt === 'none' && callbackState && callbackState === stateCookie.state);
+            // `state` now carries a signed `returnTo` suffix (see
+            // encodeOAuthState in signIn), so it's no longer directly equal
+            // to the bare token stored in the cookie - decode it the same
+            // way handleCallback does before comparing.
+            const callbackToken = decodeOAuthState(event.url.searchParams.get('state'), options.cookieSecret).token;
+            const stateCookie = cookieStore.readState(event.cookies, callbackToken);
+            const isSilentReauthentication = Boolean(stateCookie?.prompt === 'none' && callbackToken && callbackToken === stateCookie.state);
             try {
                 const result = await handleCallback(event);
                 if (isSilentReauthentication) {
@@ -615,7 +870,7 @@ export function createOIDC(options) {
             }
             catch (err) {
                 if (isSilentReauthentication) {
-                    cookieStore.clearState(event.cookies);
+                    cookieStore.clearState(event.cookies, callbackToken);
                     const persisted = await readPersistedSession(event.cookies);
                     await clearPersistedSession(event.cookies, persisted?.id);
                     log.debug('Silent OIDC re-authentication failed — clearing local session');

package/dist/server/jwt.js CHANGED Viewed

@@ -13,11 +13,17 @@ export async function fetchJson(url, init, fetchImpl = fetch) {
     return (await response.json());
 }
 export function asAuthorizationHeader(clientId, clientSecret) {
-    return `Basic ${Buffer.from(`${clientId}:${clientSecret}`).toString('base64')}`;
+    const encode = (value) => {
+        const encoded = new URLSearchParams({ value }).toString();
+        return encoded.slice('value='.length);
+    };
+    return `Basic ${Buffer.from(`${encode(clientId)}:${encode(clientSecret)}`).toString('base64')}`;
 }
 export async function createClientSecretJwtAssertion(options) {
     if (!options.clientSecret) {
-        throw error(500, { message: 'clientSecret is required for client_secret_jwt' });
+        throw error(500, {
+            message: 'clientSecret is required for client_secret_jwt'
+        });
     }
     const algorithm = options.algorithm ?? 'HS256';
     const now = Math.floor(Date.now() / 1000);
@@ -40,5 +46,9 @@ export async function createPrivateKeyJwtAssertion(options) {
         jti: base64UrlEncode(randomBytes(24)),
         iat: now,
         exp: now + (options.expiresInSeconds ?? 60)
-    }, options.privateKey, { alg: algorithm, typ: 'JWT', ...(options.keyId ? { kid: options.keyId } : {}) });
+    }, options.privateKey, {
+        alg: algorithm,
+        typ: 'JWT',
+        ...(options.keyId ? { kid: options.keyId } : {})
+    });
 }