@soundworks/core 4.0.0-alpha.25 → 4.0.0-alpha.27

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v4.0.0-alpha.27 - 06/09/2025
+
+- Fix: assign to `const`
+
+## v4.0.0-alpha.26 - 05/09/2025
+
+- Fix: improve reconnect strategy in case of socket connection failure
+
 ## v4.0.0-alpha.25 - 24/05/2025
 
 - Fix: better default behavior for websocket connection URL

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soundworks/core",
-  "version": "4.0.0-alpha.25",
+  "version": "4.0.0-alpha.27",
   "description": "Open-source creative coding framework for distributed applications based on Web technologies",
   "authors": [
     "Benjamin Matuszewski",

package/src/client/Socket.js

@@ -91,6 +91,8 @@ class Socket {
       }
 
       webSocketOptions = {
+        // handshakeTimeout: 2000,
+        // do not reject self-signed certificates
         rejectUnauthorized: false,
       };
     }
@@ -107,8 +109,6 @@ class Socket {
     // Init socket
     // ----------------------------------------------------------
     return new Promise(resolve => {
-      let connectionRefusedLogged = false;
-
       const trySocket = async () => {
         const ws = new WebSocket(url, webSocketOptions);
 
@@ -118,7 +118,6 @@ class Socket {
 
           this.#socket.addEventListener('message', e => {
             if (e.data === PING_MESSAGE) {
-              // heartbeat();
               this.#socket.send(PONG_MESSAGE);
               // do not propagate ping / pong messages
               return;
@@ -161,26 +160,20 @@ class Socket {
 
         // cf. https://github.com/collective-soundworks/soundworks/issues/17
         ws.addEventListener('error', e => {
-          if (e.type === 'error') {
-            if (ws.terminate) {
-              ws.terminate();
-            } else {
-              ws.close();
-            }
+          if (ws.terminate) {
+            ws.terminate();
+          } else {
+            ws.close();
+          }
 
-            // for node clients, retry connection
-            if (e.error && e.error.code === 'ECONNREFUSED') {
-              // we want to log the warning just once
-              if (!connectionRefusedLogged) {
-                logger.log('[soundworks.Socket] Connection refused, waiting for the server to start');
-                // console.log(e.error);
-                connectionRefusedLogged = true;
-              }
-
-              // retry in 1 second
-              setTimeout(trySocket, 1000);
-            }
+          if (e.error) {
+            const msg = `[Socket Error] code: ${e.error.code}, message: ${e.error.message}`;
+            logger.log(msg);
           }
+
+          // Try reconnect in all cases, note that if the socket has been connected the
+          // close event will be propagated and the launcher will restart the process.
+          setTimeout(trySocket, 1000);
         });
       };
 

package/src/common/version.js

@@ -1,2 +1,2 @@
 // [WARNING] This file is generated, do not edit
-export default '4.0.0-alpha.25';
+export default '4.0.0-alpha.27';

package/src/server/Sockets.js

@@ -173,7 +173,7 @@ class Sockets {
    *  JSON compatible data types (i.e. string, number, boolean, object, array and null).
    */
   broadcast(roomIds, excludeSocket, channel, ...args) {
-    const targets = new Set();
+    let targets = new Set();
 
     if (typeof roomIds === 'string' || Array.isArray(roomIds)) {
       if (typeof roomIds === 'string') {