@soundworks/core 4.0.0-alpha.23 → 4.0.0-alpha.24

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v4.0.0-alpha.24 - 24/05/2025
+
+- Fix: unexpected behavior with new `serverAddress` behavior on browser clients and self-signed certificates
+
 ## v4.0.0-alpha.23 - 24/05/2025
 
 - Breaking: remove binary socket

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soundworks/core",
-  "version": "4.0.0-alpha.23",
+  "version": "4.0.0-alpha.24",
   "description": "Open-source creative coding framework for distributed applications based on Web technologies",
   "authors": [
     "Benjamin Matuszewski",

package/src/client/Socket.js

@@ -61,13 +61,27 @@ class Socket {
     let webSocketOptions;
 
     if (isBrowser()) {
+      const hostname = window.location.hostname;
       // if a server address is given in config, use it, else fallback to URL hostname
       if (config.env.serverAddress !== '') {
         serverAddress = config.env.serverAddress;
       } else {
+        serverAddress = hostname;
+      }
+
+      // when in https with self-signed certificates, we don't want to use
+      // the serverAddress defined in config as the socket would be blocked, so we
+      // just override serverAddress with hostname in this case
+      const localhosts = ['127.0.0.1', 'localhost'];
+
+      if (config.env.useHttps && localhosts.includes(hostname)) {
         serverAddress = window.location.hostname;
       }
 
+      if (config.env.useHttps && window.location.hostname !== serverAddress) {
+        console.warn(`The WebSocket will try to connect at ${serverAddress} as defined in environment configuration while the page is accessed from ${hostname}. If you run the application with self-signed certificates, this can lead to socket errors as the certificate may not have been accepted for ${serverAddress}. In such case you should rather access the page from ${serverAddress}.`);
+      }
+
       webSocketOptions = [];
     } else {
       serverAddress = config.env.serverAddress;
@@ -155,6 +169,7 @@ class Socket {
               // we want to log the warning just once
               if (!connectionRefusedLogged) {
                 logger.log('[soundworks.Socket] Connection refused, waiting for the server to start');
+                console.log(e.error);
                 connectionRefusedLogged = true;
               }
 

package/src/common/version.js

@@ -1,2 +1,2 @@
 // [WARNING] This file is generated, do not edit
-export default '4.0.0-alpha.23';
+export default '4.0.0-alpha.24';