@soundworks/core 4.0.0-alpha.1 → 4.0.0-alpha.3

package/.eslintrc

@@ -1,7 +1,6 @@
 {
   "extends": [
     "@ircam",
-    "plugin:jsdoc/recommended"
   ],
   "settings": {
     "jsdoc": {

package/README.md

@@ -1,6 +1,7 @@
 # `soundworks`
 
 [![npm version](https://badge.fury.io/js/@soundworks%2Fcore.svg)](https://badge.fury.io/js/@soundworks%2Fcore)
+[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 
 ![soundworks-logo](./assets/logo-200x200.png)
 
@@ -18,6 +19,8 @@ The best and most simple way to start using `soundworks` is to use the `@soundwo
 npx @soundworks/create@latest
 ```
 
+![./assets/soundworks-create-min.gif](./assets/soundworks-create-min.gif)
+
 See [https://soundworks.dev/guides/getting-started.html](https://soundworks.dev/guides/getting-started.html) for more informations on the wizard and how to start with `soundworks`.
 
 <!--
@@ -38,11 +41,17 @@ git checkout v4
 serve docs
 ```
 
+Feel welcome to open an [issue](https://github.com/collective-soundworks/soundworks/issues) or a PR if you find any inconsistency, error or missing information in the documentation.
+
+## Share with Us
+
+If you made an application using `soundworks` please let us know here: https://github.com/collective-soundworks/soundworks/discussions/61
+
 ## TypeScript Support
 
 Basic TypeScript support will be proposed in a (hopefully) near future. 
 
-However, as we aim to follow the TC39 and W3C specifications as close as possible, we will wait for the https://github.com/tc39/proposal-type-annotations proposal to reach stage 3 to update the source code in a more integrated manner.
+However, for maintenance reasons, we aim at following the TC39 and W3C specifications as close as possible. Therefore, we will wait for the https://github.com/tc39/proposal-type-annotations proposal to reach stage 3 to update the source code in a more integrated manner.
 
 ## Install
 
@@ -52,27 +61,28 @@ Note that the `@soundworks/core` package is automatically installed when creatin
 npm install @soundworks/core
 ```
 
-## Share with Us
-
-If you made an application using `soundworks` please let us know here: https://github.com/collective-soundworks/soundworks/discussions/61
+## Credits
 
-## Academic Papers
+`soundworks` has been initiated by [Norbert Schnell](https://github.com/NorbertSchnell), [Sébastien Robaszkiewicz](https://github.com/i-Robi), and [Benjamin Matuszewski](https://github.com/b-ma) at the [ISMM](http://ismm.ircam.fr/) team at [Ircam - Centre Pompidou](http://www.ircam.fr/) in the context of the [CoSiMa](http://cosima.ircam.fr/) research project founded by the French National Research Agency (ANR).
 
-- Benjamin Matuszewski. A Web-Based Framework for Distributed Music System Research and Creation. AES - Journal of the Audio Engineering Society Audio-Accoustics-Application, Audio Engineering Society Inc, 2020. <[hal-03033143](https://hal.archives-ouvertes.fr/hal-03033143)>
-- Benjamin Matuszewski. Soundworks - A Framework for Networked Music Systems on the Web - State of Affairs and New Developments. Proceedings of the Web Audio Conference (WAC) 2019, Dec 2019, Trondheim, Norway. <[hal-02387783](https://hal.archives-ouvertes.fr/hal-02387783)>
-- Benjamin Matuszewski, Norbert Schnell, Frédéric Bevilacqua. Interaction Topologies in Mobile-Based Situated Networked Music Systems. Wireless Communications and Mobile Computing, Hindawi Publishing Corporation, 2019, 2019, pp.9142490. ⟨10.1155/2019/9142490⟩. <[hal-02086673](https://hal.archives-ouvertes.fr/hal-02086673)>
-- Norbert Schnell, Sébastien Robaszkiewicz. Soundworks – A playground for artists and developers to create collaborative mobile web performances. `Proceedings of the Web Audio Conference (WAC'15), 2015, Paris, France. <[hal-01580797](https://hal.archives-ouvertes.fr/hal-01580797)>
+Development is now led by Benjamin Matuszewski, in the [Sound Music Movement Interaction Team](https://www.stms-lab.fr/team/interaction-son-musique-mouvement/) from the Ircam's STMS-LAB.
 
-## Credits
+### Supporting Research Projects
 
-`soundworks` has been initiated by [Norbert Schnell](https://github.com/NorbertSchnell), [Sébastien Robaszkiewicz](https://github.com/i-Robi), and [Benjamin Matuszewski](https://github.com/b-ma) at the [ISMM](http://ismm.ircam.fr/) team at [Ircam - Centre Pompidou](http://www.ircam.fr/) in the framework of the [*CoSiMa*](http://cosima.ircam.fr/) research project supported by the [French National Research Agency (ANR)](http://www.agence-nationale-recherche.fr/en/).
+Initial and futher developments has been supported by the following research projects:
 
-Futher developments has been supported in the framework of:
-- The [RAPID-MIX project](http://rapidmix.goldsmithsdigital.com/), funded by the European Union’s Horizon 2020 research and innovation program
+- The [DOTS](http://dots.ircam.fr/) project, funded by the French National Research Agency (ANR)
 - The Ircam projects _BeCoMe_ and _SO(a)P_
-- The _Constella(c)tions_ residency of the STARTS program of the European Commission.
+- The _Constella(c)tions_ residency, funded by the STARTS program of the European Commission
+- The [RAPID-MIX project](http://rapidmix.goldsmithsdigital.com/), funded by the European Union’s Horizon 2020 research and innovation program
+- The [CoSiMa](http://cosima.ircam.fr/) project, funded by the French National Research Agency (ANR)
 
-Development is pursued, led by Benjamin Matuszewski, in the [Interaction Music Movement Team](https://www.stms-lab.fr/team/interaction-son-musique-mouvement/) from the Ircam's STMS-LAB.
+### Academic Papers
+
+- Benjamin Matuszewski. A Web-Based Framework for Distributed Music System Research and Creation. AES - Journal of the Audio Engineering Society Audio-Accoustics-Application, Audio Engineering Society Inc, 2020. <[hal-03033143](https://hal.archives-ouvertes.fr/hal-03033143)>
+- Benjamin Matuszewski. Soundworks - A Framework for Networked Music Systems on the Web - State of Affairs and New Developments. Proceedings of the Web Audio Conference (WAC) 2019, Dec 2019, Trondheim, Norway. <[hal-02387783](https://hal.archives-ouvertes.fr/hal-02387783)>
+- Benjamin Matuszewski, Norbert Schnell, Frédéric Bevilacqua. Interaction Topologies in Mobile-Based Situated Networked Music Systems. Wireless Communications and Mobile Computing, Hindawi Publishing Corporation, 2019, 2019, pp.9142490. ⟨10.1155/2019/9142490⟩. <[hal-02086673](https://hal.archives-ouvertes.fr/hal-02086673)>
+- Norbert Schnell, Sébastien Robaszkiewicz. Soundworks – A playground for artists and developers to create collaborative mobile web performances. `Proceedings of the Web Audio Conference (WAC'15), 2015, Paris, France. <[hal-01580797](https://hal.archives-ouvertes.fr/hal-01580797)>
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soundworks/core",
-  "version": "4.0.0-alpha.1",
+  "version": "4.0.0-alpha.3",
   "description": "Open-source creative coding framework for distributed applications based on Web technologies",
   "authors": [
     "Benjamin Matuszewski",
@@ -43,7 +43,7 @@
     "node": ">=16.0.0"
   },
   "scripts": {
-    "doc": "npm run jsdoc && npm run types",
+    "doc": "npm run jsdoc",
     "jsdoc": "rm -Rf docs && jsdoc -c .jsdoc.json --verbose && cp -R assets docs/",
     "lint": "npx eslint src",
     "test": "mocha",

package/src/client/Client.js

@@ -14,7 +14,40 @@ import { isBrowser } from '../common/utils.js';
 import logger from '../common/logger.js';
 
 /**
- * The `Client` class is the main entry point for  the client-side of soundworks
+ * Configuration object for a client running in a browser runtime.
+ *
+ * @typedef BrowserClientConfig
+ * @memberof client
+ * @type {object}
+ * @property {string} role - Role of the client in the application (e.g. 'player', 'controller').
+ * @property {object} [app] - Application configration object.
+ * @property {string} [app.name=''] - Name of the application.
+ * @property {string} [app.author=''] - Name of the author.
+ * @property {object} [env] - Environment configration object.
+ * @property {string} [env.websockets={}] - Configuration options for websockets.
+ * @property {string} [env.subpath=''] - If running behind a proxy, path to the application.
+ */
+
+/**
+ * Configuration object for a client running in a node runtime.
+ *
+ * @typedef NodeClientConfig
+ * @memberof client
+ * @type {object}
+ * @property {string} role - Role of the client in the application (e.g. 'player', 'controller').
+ * @property {object} [app] - Application configration object.
+ * @property {string} [app.name=''] - Name of the application.
+ * @property {string} [app.author=''] - Name of the author.
+ * @property {object} env - Environment configration object.
+ * @property {boolean} env.serverAddress - Domain name or IP of the server.
+ * @property {boolean} env.useHttps - Define is the server run in http or in https.
+ * @property {boolean} env.port - Port on which the server is listening.
+ * @property {string} [env.websockets={}] - Configuration options for websockets.
+ * @property {string} [env.subpath=''] - If running behind a proxy, path to the application.
+ */
+
+/**
+ * The `Client` class is the main entry point for the client-side of a soundworks
  * application.
  *
  * A `Client` instance allows to access soundworks components such as {@link client.StateManager},
@@ -269,8 +302,9 @@ class Client {
    * method if it has not been called manually.
    *
    * What it does:
-   * - optionnaly call {@link client.Client#init}
-   * - starts all the already created contexts (see {@link client.Context})
+   * - implicitly call {@link client.Client#init} if not done manually
+   * - start all created contexts. For that to happen, you will have to call `client.init`
+   * manually and instantiate the contexts between `client.init()` and `client.start()`
    *
    * @example
    * import { Client } from '@soundworks/core/client.js'

package/src/client/Context.js

@@ -69,11 +69,15 @@ class Context {
 
     /**
      * The soundworks client instance.
+     * @type {client.Client}
+     * @readonly
      */
     this.client = client;
 
     /**
      * Status of the context, i.e. 'idle', 'inited', 'started', 'errored'
+     * @type {string}
+     * @readonly
      */
     this.status = 'idle';
 
@@ -113,10 +117,16 @@ class Context {
   }
 
   /**
-   * Name of the context. Defaults to the class name, override to use a user-defined name.
+   * Optionnal user-defined name of the context (defaults to the class name).
    *
-   * @returns {string} - Name of the context.
+   * The context manager will match the client-side and server-side contexts based
+   * on this name. If the {@link server.ContextManager} don't find a corresponding
+   * user-defined context with the same name, it will use a default (noop) context.
+   *
+   * @readonly
+   * @type {string}
    * @example
+   * // server-side and client-side contexts are matched based on their respective `name`
    * class MyContext extends Context {
    *   get name() {
    *     return 'my-user-defined-context-name';
@@ -128,21 +138,38 @@ class Context {
   }
 
   /**
-   * Start the context. This method is automatically called when `await client.start()`
-   * is called, or lazilly called when entering the context (i.e. `context.enter()`)
-   * if the context has been created after `client.start()`.
+   * Start the context. This method is lazilly called when the client enters the
+   * context for the first time (cf. ${client.Context#enter}). If you know some
+   * some heavy and/or potentially long job has to be done  when starting the context
+   * (e.g. call to a web service) it may be a good practice to call it explicitely.
+   *
+   * This method should be implemented to perform operations that are valid for the
+   * whole lifetime of the context, regardless the client enters or exits the context.
+   *
+   * @example
+   * import { Context } from '@soundworks/core/client.js';
+   *
+   * class MyContext extends Context {
+   *   async start() {
+   *     await super.start();
+   *     await this.doSomeLongJob();
+   *   }
+   * }
    *
-   * In some situation, you might want to implement this method to handle application
-   * wise behavior regardeless the client enters or exists the context.
+   * // Instantiate the context
+   * const myContext = new Context(client);
+   * // manually start the context to perform the long operation before the client
+   * // enters the context.
+   * await myContext.start();
    */
   async start() {}
 
   /**
    * Stop the context. This method is automatically called when `await client.stop()`
-   * is called.
+   * is called. It should be used to cleanup context wise operations made in `start()`
+   * (e.g. destroy the reusable audio graph).
    *
-   * In some situation, you might want to implement this method to handle application
-   * wise behavior regardeless the client enters or exists the context.
+   * _WARNING: this method should never be called manually._
    */
   async stop() {}
 

package/src/client/Plugin.js

@@ -14,7 +14,8 @@ import BasePlugin from '../common/BasePlugin.js';
  */
 
 /**
- * Base class to extend in order to create new `soundworks` plugins.
+ * Base class to extend in order to create the client-side counterpart of a
+ * `soundworks` plugin.
  *
  * In the `soundworks` paradigm, a plugin is a component that allows to extend
  * the framework capabilities by encapsulating common and reusable logic in

package/src/client/PluginManager.js

@@ -23,7 +23,7 @@ import Client from './Client.js';
  *
  * Plugins should always be registered both client-side and server-side,
  * and before {@link client.Client#start} or {@link server.Server#start}
- * are called for proper initialization.
+ * to be properly initialized.
  *
  * In some sitautions, you might want to register the same plugin factory several times
  * using different ids (e.g. for watching several parts of the file system, etc.).
@@ -35,12 +35,13 @@ import Client from './Client.js';
  * See {@link client.Client#pluginManager}
  *
  * ```
+ * // client-side
  * import { Client } from '@soundworks/core/client.js';
- * import platformPlugin from '@soundworks/plugin-sync/client.js';
+ * import syncPlugin from '@soundworks/plugin-sync/client.js';
  *
  * const client = new Client(config);
  * // register the plugin before `client.start()`
- * client.pluginManager.register('sync', pluginSync);
+ * client.pluginManager.register('sync', syncPlugin);
  *
  * await client.start();
  *
@@ -52,6 +53,25 @@ import Client from './Client.js';
  * }, 1000);
  * ```
  *
+ * ```
+ * // server-side
+ * import { Server } from '@soundworks/core/server.js';
+ * import syncPlugin from '@soundworks/plugin-sync/server.js';
+ *
+ * const server = new Server(config);
+ * // register the plugin before `server.start()`
+ * server.pluginManager.register('sync', syncPlugin);
+ *
+ * await server.start();
+ *
+ * const sync = await server.pluginManager.get('sync');
+ *
+ * setInterval(() => {
+ *   // log the estimated global synced clock alongside the local clock.
+ *   console.log(sync.getSyncTime(), sync.getLocalTime());
+ * }, 1000);
+ * ```
+ *
  * @memberof client
  * @extends BasePluginManager
  * @inheritdoc
@@ -91,8 +111,8 @@ class PluginManager extends BasePluginManager {
    * initialization (e.g. to display initialization screen, etc.), you should rely
    * on the `onStateChange` method.
    *
-   * _Note: the async API is designed to enable the dynamic creation of plugins (hopefully
-   * without brealing changes) in a future release._
+   * _Note: the async API is designed to enable the dynamic creation of plugins
+   * (hopefully without brealing changes) in a future release._
    *
    * @param {client.Plugin#id} id - Id of the plugin as defined when registered.
    * @returns {client.Plugin}
@@ -105,18 +125,7 @@ class PluginManager extends BasePluginManager {
       throw new Error(`[soundworks.PluginManager] Cannot get plugin before "client.init()"`);
     }
 
-    return super.getUnsafe(id);
-  }
-
-  // client only methods
-  // ------------------------------------------------------------
-
-  /**
-   * @protected
-   * @ignore
-   */
-  getRegisteredPlugins() {
-    return Array.from(this._registeredPlugins.keys());
+    return super.unsafeGet(id);
   }
 }
 

package/src/client/Socket.js

@@ -28,35 +28,34 @@ import { isBrowser } from '../common/utils.js';
 /**
  * The Socket class is a simple publish / subscribe wrapper built on top of the
  * [isomorphic-ws](https://github.com/heineiuo/isomorphic-ws) library.
- * An instance of `Socket` is automatically created by the `soundworks.Client`.
+ * An instance of `Socket` is automatically created by the `soundworks.Client`
+ * (see {@link client.Client#socket}).
  *
- * _Important: In most cases, you should consider using a {@link client.SharedState} rather than
- * sending messages directly through the sockets._
+ * _Important: In most cases, you should consider using a {@link client.SharedState}
+ * rather than directly using the sockets._
  *
  * The Socket class concurrently opens two different WebSockets:
- * - a socket configured with `binaryType = 'string'` for JSON compatible string
- *  messages.
- * - a socket configured with `binaryType=arraybuffer` for efficient streaming
+ * - a socket configured with `binaryType = 'blob'` for JSON compatible data
+ *  types (i.e. string, number, boolean, object, array and null).
+ * - a socket configured with `binaryType= 'arraybuffer'` for efficient streaming
  *  of binary data.
  *
  * Both sockets re-emits all "native" ws events ('open', 'upgrade', 'close', 'error'
  *  and 'message'.
  *
- * See {@link client.Client#socket}
- *
  * @memberof client
  * @hideconstructor
  */
 class Socket {
   constructor() {
     /**
-     * WebSocket instance w/ string protocol, i.e. `binaryType = 'string'`.
+     * WebSocket instance configured with `binaryType = 'blob'`.
      *
      * @private
      */
     this.ws = null;
     /**
-     * WebSocket instance w/ binary protocol, i.e. `binaryType = 'arraybuffer'`.
+     * WebSocket instance configured with `binaryType = 'arraybuffer'`.
      *
      * @private
      */
@@ -231,6 +230,22 @@ class Socket {
     return Promise.resolve();
   }
 
+  /**
+   * Removes all listeners and immediately close the two sockets. Is automatically
+   * called on `client.stop()`
+   *
+   * @private
+   */
+  async terminate() {
+    this.removeAllListeners();
+    this.removeAllBinaryListeners();
+
+    this.ws.close();
+    this.binaryWs.close();
+
+    return Promise.resolve();
+  }
+
   /**
    * @param {boolean} binary - Emit to either the string or binary socket.
    * @param {string} channel - Channel name.
@@ -293,10 +308,11 @@ class Socket {
   }
 
   /**
-   * Send JSON compatible messages on a given channel.
+   * Send messages with JSON compatible data types on a given channel.
    *
-   * @param {string} channel - Channel name of the message.
-   * @param {...*} args - Message list, as many as needed, of any serializable type).
+   * @param {string} channel - Channel name.
+   * @param {...*} args - Payload of the message. As many arguments as needed, of
+   *  JSON compatible data types (i.e. string, number, boolean, object, array and null).
    */
   send(channel, ...args) {
     const msg = packStringMessage(channel, ...args);
@@ -304,10 +320,12 @@ class Socket {
   }
 
   /**
-   * Listen to JSON compatible messages on a given channel.
+   * Listen messages with JSON compatible data types on a given channel.
    *
-   * @param {string} channel - Channel name of the message.
-   * @param {Function} callback - Callback to execute when a message is received.
+   * @param {string} channel - Channel name.
+   * @param {Function} callback - Callback to execute when a message is received,
+   *  arguments of the callback function will match the arguments sent using the
+   *  {@link server.Socket#send} method.
    */
   addListener(channel, callback) {
     this._addListener(this._stringListeners, channel, callback);
@@ -316,7 +334,7 @@ class Socket {
   /**
    * Remove a listener from JSON compatible messages on a given channel.
    *
-   * @param {string} channel - Channel name of the message.
+   * @param {string} channel - Channel name.
    * @param {Function} callback - Callback to remove.
    */
   removeListener(channel, callback) {
@@ -324,9 +342,9 @@ class Socket {
   }
 
   /**
-   * Remove all listeners from JSON compatible messages on a given channel.
+   * Remove all listeners of messages with JSON compatible data types.
    *
-   * @param {string} channel - Channel name of the message.
+   * @param {string} channel - Channel name.
    */
   removeAllListeners(channel = null) {
     this._removeAllListeners(this._stringListeners, channel);
@@ -335,7 +353,7 @@ class Socket {
   /**
    * Send binary messages on a given channel.
    *
-   * @param {string} channel - Channel name of the message.
+   * @param {string} channel - Channel name.
    * @param {TypedArray} typedArray - Binary data to be sent.
    */
   sendBinary(channel, typedArray) {
@@ -344,9 +362,9 @@ class Socket {
   }
 
   /**
-   * Listen binary messages on a given channel.
+   * Listen binary messages on a given channel
    *
-   * @param {string} channel - Channel name of the message.
+   * @param {string} channel - Channel name.
    * @param {Function} callback - Callback to execute when a message is received.
    */
   addBinaryListener(channel, callback) {
@@ -354,36 +372,23 @@ class Socket {
   }
 
   /**
-   * Remove a listener from binary compatible messages on a given channel
+   * Remove a listener of binary compatible messages from a given channel
    *
-   * @param {string} channel - Channel of the message.
-   * @param {Function} callback - Callback to cancel.
+   * @param {string} channel - Channel name.
+   * @param {Function} callback - Callback to remove.
    */
   removeBinaryListener(channel, callback) {
     this._removeListener(this._binaryListeners, channel, callback);
   }
 
   /**
-   * Remove all listeners from binary compatible messages on a given channel
+   * Remove all listeners of binary compatible messages on a given channel
    *
    * @param {string} channel - Channel of the message.
    */
   removeAllBinaryListeners(channel = null) {
     this._removeAllListeners(this._binaryListeners, channel);
   }
-
-  /**
-   * Removes all listeners and immediately close the two sockets.
-   */
-  async terminate() {
-    this.removeAllListeners();
-    this.removeAllBinaryListeners();
-
-    this.ws.close();
-    this.binaryWs.close();
-
-    return Promise.resolve();
-  }
 }
 
 export default Socket;

package/src/client/index.js

@@ -1,36 +1,3 @@
-/**
- * Configuration object for a client running in a browser runtime.
- *
- * @typedef BrowserClientConfig
- * @memberof client
- * @type {object}
- * @property {string} role - Role of the client in the application (e.g. 'player', 'controller').
- * @property {object} [app] - Application configration object.
- * @property {string} [app.name=''] - Name of the application.
- * @property {string} [app.author=''] - Name of the author.
- * @property {object} [env] - Environment configration object.
- * @property {string} [env.websockets={}] - Configuration options for websockets.
- * @property {string} [env.subpath=''] - If running behind a proxy, path to the application.
- */
-
-/**
- * Configuration object for a client running in a node runtime.
- *
- * @typedef NodeClientConfig
- * @memberof client
- * @type {object}
- * @property {string} role - Role of the client in the application (e.g. 'player', 'controller').
- * @property {object} [app] - Application configration object.
- * @property {string} [app.name=''] - Name of the application.
- * @property {string} [app.author=''] - Name of the author.
- * @property {object} env - Environment configration object.
- * @property {boolean} env.serverAddress - Domain name or IP of the server.
- * @property {boolean} env.useHttps - Define is the server run in http or in https.
- * @property {boolean} env.port - Port on which the server is listening.
- * @property {string} [env.websockets={}] - Configuration options for websockets.
- * @property {string} [env.subpath=''] - If running behind a proxy, path to the application.
- */
-
 /**
  * Client-side part of the `soundworks` framework.
  *

package/src/common/BasePluginManager.js

@@ -75,6 +75,14 @@ class BasePluginManager {
     this._registeredPlugins.set(id, { ctor, options, deps });
   }
 
+  /**
+   * Returns the list of the registered plugins ids
+   * @returns {string[]}
+   */
+  getRegisteredPlugins() {
+    return Array.from(this._registeredPlugins.keys());
+  }
+
   /**
    * Initialize all the registered plugin. Executed during the `Client.init()` or
    * `Server.init()` initialization step.
@@ -98,7 +106,7 @@ class BasePluginManager {
     // propagate all 'idle' statuses before start
     this._propagateStateChange();
 
-    const promises = Array.from(this._registeredPlugins.keys()).map(id => this.getUnsafe(id));
+    const promises = Array.from(this._registeredPlugins.keys()).map(id => this.unsafeGet(id));
 
     try {
       await Promise.all(promises);
@@ -109,6 +117,7 @@ class BasePluginManager {
     }
   }
 
+  /** @private */
   async stop() {
     for (let instance of this._instances.values()) {
       await instance.stop();
@@ -122,7 +131,7 @@ class BasePluginManager {
    *
    * @private
    */
-  async getUnsafe(id) {
+  async unsafeGet(id) {
     if (!isString(id)) {
       throw new Error(`[soundworks.PluginManager] Invalid argument, "pluginManager.get(name)" argument should be a string`);
     }
@@ -145,7 +154,7 @@ class BasePluginManager {
 
     // recursively get the dependency chain
     const { deps } = this._registeredPlugins.get(id);
-    const promises = deps.map(id => this.getUnsafe(id));
+    const promises = deps.map(id => this.unsafeGet(id));
 
     await Promise.all(promises);