@soundworks/core 3.2.0 → 3.2.1

package/client/Socket.js

@@ -91,6 +91,7 @@ class Socket {
     }
 
     let url;
+    let webSocketOptions;
 
     if (isBrowser()) {
       const protocol = window.location.protocol.replace(/^http?/, 'ws');
@@ -99,13 +100,17 @@ class Socket {
         port
       } = window.location;
       url = `${protocol}//${hostname}:${port}/${path}`;
+      webSocketOptions = {};
     } else {
-      const protocol = config.useHttps ? 'wss:' : 'ws:';
+      const protocol = config.env.useHttps ? 'wss:' : 'ws:';
       const {
         serverIp,
         port
       } = config.env;
       url = `${protocol}//${serverIp}:${port}/${path}`;
+      webSocketOptions = {
+        rejectUnauthorized: false
+      };
     }
 
     const queryParams = `clientType=${clientType}&key=${key}`; // ----------------------------------------------------------
@@ -116,7 +121,7 @@ class Socket {
     await new Promise((resolve, reject) => {
       const trySocket = async () => {
         log(`[string socket] trying connection - url: ${stringSocketUrl}`);
-        const ws = new _isomorphicWs.default(stringSocketUrl);
+        const ws = new _isomorphicWs.default(stringSocketUrl, webSocketOptions);
         ws.addEventListener('open', connectEvent => {
           // parse incoming messages for pubsub
           this.ws = ws;
@@ -154,7 +159,7 @@ class Socket {
     const binarySocketUrl = `${url}?binary=1&${queryParams}`;
     await new Promise((resolve, reject) => {
       log(`[binary socket] trying connection - url: ${binarySocketUrl}`);
-      const ws = new _isomorphicWs.default(binarySocketUrl);
+      const ws = new _isomorphicWs.default(binarySocketUrl, webSocketOptions);
       ws.binaryType = 'arraybuffer';
       ws.addEventListener('open', connectEvent => {
         // parse incoming messages for pubsub

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soundworks/core",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "full-stack javascript framework for distributed audio visual experiences on the web",
   "authors": [
     "Benjamin Matuszewski",

package/server/Server.js

@@ -310,6 +310,8 @@ class Server {
       // ------------------------------------------------------------
       // init acitvities
       // ------------------------------------------------------------
+      // we should at least have one activity registered for each client here
+      // i.e. the Experience so it's ok
       this.activities.forEach(activity => {
         activity.clientTypes.forEach(clientType => {
           if (!this._clientTypeActivitiesMap[clientType]) {
@@ -572,6 +574,11 @@ class Server {
   _onSocketConnection(clientType, socket) {
     const client = new _Client.default(clientType, socket);
     const activities = this._clientTypeActivitiesMap[clientType];
+
+    if (activities == undefined) {
+      throw new Error(`No activity registered for "${clientType}" clients, make sure an Experience has been initialized for this client (see src/server/index.js)`);
+    }
+
     socket.addListener('close', () => {
       // clean sockets
       socket.terminate(); // remove client from activities