@soulcraft/brainy 4.8.0 → 4.8.1

package/dist/storage/adapters/fileSystemStorage.js

@@ -1135,11 +1135,9 @@ export class FileSystemStorage extends BaseStorage {
                     const edge = JSON.parse(data);
                     // Get metadata which contains the actual verb information
                     const metadata = await this.getVerbMetadata(id);
-                    // v4.0.0: No fallbacks - skip verbs without metadata
-                    if (!metadata) {
-                        console.warn(`Verb ${id} has no metadata, skipping`);
-                        continue;
-                    }
+                    // v4.8.1: Don't skip verbs without metadata - metadata is optional
+                    // FIX: This was the root cause of the VFS bug (11 versions)
+                    // Verbs can exist without metadata files (e.g., from imports/migrations)
                     // Convert connections Map to proper format if needed
                     let connections = edge.connections;
                     if (connections && typeof connections === 'object' && !(connections instanceof Map)) {
@@ -1150,7 +1148,7 @@ export class FileSystemStorage extends BaseStorage {
                         connections = connectionsMap;
                     }
                     // v4.8.0: Extract standard fields from metadata to top-level
-                    const metadataObj = metadata;
+                    const metadataObj = (metadata || {});
                     const { createdAt, updatedAt, confidence, weight, service, data: dataField, createdBy, ...customMetadata } = metadataObj;
                     const verbWithMetadata = {
                         id: edge.id,
@@ -2025,11 +2023,9 @@ export class FileSystemStorage extends BaseStorage {
                     const data = await fs.promises.readFile(filePath, 'utf-8');
                     const edge = JSON.parse(data);
                     const metadata = await this.getVerbMetadata(id);
-                    // v4.0.0: No fallbacks - skip verbs without metadata
-                    if (!metadata) {
-                        processedCount++;
-                        return true; // continue, skip this verb
-                    }
+                    // v4.8.1: Don't skip verbs without metadata - metadata is optional
+                    // FIX: This was the root cause of the VFS bug (11 versions)
+                    // Verbs can exist without metadata files (e.g., from imports/migrations)
                     // Convert connections if needed
                     let connections = edge.connections;
                     if (connections && typeof connections === 'object' && !(connections instanceof Map)) {
@@ -2040,7 +2036,7 @@ export class FileSystemStorage extends BaseStorage {
                         connections = connectionsMap;
                     }
                     // v4.8.0: Extract standard fields from metadata to top-level
-                    const metadataObj = metadata;
+                    const metadataObj = (metadata || {});
                     const { createdAt, updatedAt, confidence, weight, service, data: dataField, createdBy, ...customMetadata } = metadataObj;
                     const verbWithMetadata = {
                         id: edge.id,

package/dist/storage/adapters/typeAwareStorageAdapter.js

@@ -335,125 +335,27 @@ export class TypeAwareStorageAdapter extends BaseStorage {
      * Get verbs by source
      */
     async getVerbsBySource_internal(sourceId) {
-        // Need to search across all verb types
-        // TODO: Optimize with metadata index in Phase 1b
-        const verbs = [];
-        for (let i = 0; i < VERB_TYPE_COUNT; i++) {
-            const type = TypeUtils.getVerbFromIndex(i);
-            const prefix = `entities/verbs/${type}/vectors/`;
-            const paths = await this.u.listObjectsUnderPath(prefix);
-            for (const path of paths) {
-                try {
-                    const id = path.split('/').pop()?.replace('.json', '');
-                    if (!id)
-                        continue;
-                    // Load the HNSWVerb
-                    const hnswVerb = await this.u.readObjectFromPath(path);
-                    if (!hnswVerb)
-                        continue;
-                    // Check sourceId from HNSWVerb (v4.0.0: core fields are in HNSWVerb)
-                    if (hnswVerb.sourceId !== sourceId)
-                        continue;
-                    // Load metadata separately (optional in v4.0.0!)
-                    // FIX: Don't skip verbs without metadata - metadata is optional!
-                    // VFS relationships often have NO metadata (just verb/source/target)
-                    const metadata = await this.getVerbMetadata(id);
-                    // Create HNSWVerbWithMetadata (verbs don't have level field)
-                    // Convert connections from plain object to Map<number, Set<string>>
-                    const connectionsMap = new Map();
-                    if (hnswVerb.connections && typeof hnswVerb.connections === 'object') {
-                        for (const [level, ids] of Object.entries(hnswVerb.connections)) {
-                            connectionsMap.set(Number(level), new Set(ids));
-                        }
-                    }
-                    // v4.8.0: Extract standard fields from metadata to top-level
-                    const metadataObj = (metadata || {});
-                    const { createdAt, updatedAt, confidence, weight, service, data, createdBy, ...customMetadata } = metadataObj;
-                    const verbWithMetadata = {
-                        id: hnswVerb.id,
-                        vector: [...hnswVerb.vector],
-                        connections: connectionsMap,
-                        verb: hnswVerb.verb,
-                        sourceId: hnswVerb.sourceId,
-                        targetId: hnswVerb.targetId,
-                        createdAt: createdAt || Date.now(),
-                        updatedAt: updatedAt || Date.now(),
-                        confidence: confidence,
-                        weight: weight,
-                        service: service,
-                        data: data,
-                        createdBy,
-                        metadata: customMetadata
-                    };
-                    verbs.push(verbWithMetadata);
-                }
-                catch (error) {
-                    // Continue searching
-                }
-            }
-        }
-        return verbs;
+        // v4.8.1 PERFORMANCE FIX: Delegate to underlying storage instead of scanning all files
+        // Previous implementation was O(total_verbs) - scanned ALL 40 verb types and ALL verb files
+        // This was the root cause of the 11-version VFS bug (timeouts/zero results)
+        //
+        // Underlying storage adapters have optimized implementations:
+        // - FileSystemStorage: Uses getVerbsWithPagination with sourceId filter
+        // - GcsStorage: Uses batch queries with prefix filtering
+        // - S3Storage: Uses listObjects with sourceId-based filtering
+        //
+        // Phase 1b TODO: Add graph adjacency index query for O(1) lookups:
+        // const verbIds = await this.graphIndex?.getOutgoingEdges(sourceId) || []
+        // return Promise.all(verbIds.map(id => this.getVerb(id)))
+        return this.underlying.getVerbsBySource(sourceId);
     }
     /**
      * Get verbs by target
      */
     async getVerbsByTarget_internal(targetId) {
-        // Similar to getVerbsBySource_internal
-        const verbs = [];
-        for (let i = 0; i < VERB_TYPE_COUNT; i++) {
-            const type = TypeUtils.getVerbFromIndex(i);
-            const prefix = `entities/verbs/${type}/vectors/`;
-            const paths = await this.u.listObjectsUnderPath(prefix);
-            for (const path of paths) {
-                try {
-                    const id = path.split('/').pop()?.replace('.json', '');
-                    if (!id)
-                        continue;
-                    // Load the HNSWVerb
-                    const hnswVerb = await this.u.readObjectFromPath(path);
-                    if (!hnswVerb)
-                        continue;
-                    // Check targetId from HNSWVerb (v4.0.0: core fields are in HNSWVerb)
-                    if (hnswVerb.targetId !== targetId)
-                        continue;
-                    // Load metadata separately (optional in v4.0.0!)
-                    // FIX: Don't skip verbs without metadata - metadata is optional!
-                    const metadata = await this.getVerbMetadata(id);
-                    // Create HNSWVerbWithMetadata (verbs don't have level field)
-                    // Convert connections from plain object to Map<number, Set<string>>
-                    const connectionsMap = new Map();
-                    if (hnswVerb.connections && typeof hnswVerb.connections === 'object') {
-                        for (const [level, ids] of Object.entries(hnswVerb.connections)) {
-                            connectionsMap.set(Number(level), new Set(ids));
-                        }
-                    }
-                    // v4.8.0: Extract standard fields from metadata to top-level
-                    const metadataObj = (metadata || {});
-                    const { createdAt, updatedAt, confidence, weight, service, data, createdBy, ...customMetadata } = metadataObj;
-                    const verbWithMetadata = {
-                        id: hnswVerb.id,
-                        vector: [...hnswVerb.vector],
-                        connections: connectionsMap,
-                        verb: hnswVerb.verb,
-                        sourceId: hnswVerb.sourceId,
-                        targetId: hnswVerb.targetId,
-                        createdAt: createdAt || Date.now(),
-                        updatedAt: updatedAt || Date.now(),
-                        confidence: confidence,
-                        weight: weight,
-                        service: service,
-                        data: data,
-                        createdBy,
-                        metadata: customMetadata
-                    };
-                    verbs.push(verbWithMetadata);
-                }
-                catch (error) {
-                    // Continue
-                }
-            }
-        }
-        return verbs;
+        // v4.8.1 PERFORMANCE FIX: Delegate to underlying storage (same as getVerbsBySource fix)
+        // Previous implementation was O(total_verbs) - scanned ALL 40 verb types and ALL verb files
+        return this.underlying.getVerbsByTarget(targetId);
     }
     /**
      * Get verbs by type (O(1) with type-first paths!)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulcraft/brainy",
-  "version": "4.8.0",
+  "version": "4.8.1",
   "description": "Universal Knowledge Protocol™ - World's first Triple Intelligence database unifying vector, graph, and document search in one API. 31 nouns × 40 verbs for infinite expressiveness.",
   "main": "dist/index.js",
   "module": "dist/index.js",