@soulcraft/brainy 3.37.6 → 3.37.7

package/dist/storage/adapters/gcsStorage.js

@@ -146,6 +146,12 @@ export class GcsStorage extends BaseStorage {
             });
             // Initialize counts from storage
             await this.initializeCounts();
+            // CRITICAL FIX (v3.37.7): Clear any stale cache entries from previous runs
+            // This prevents cache poisoning from causing silent failures on container restart
+            prodLog.info('🧹 Clearing cache from previous run to prevent cache poisoning');
+            this.nounCacheManager.clear();
+            this.verbCacheManager.clear();
+            prodLog.info('✅ Cache cleared - starting fresh');
             this.isInitialized = true;
         }
         catch (error) {
@@ -380,12 +386,27 @@ export class GcsStorage extends BaseStorage {
      */
     async getNode(id) {
         await this.ensureInitialized();
-        // Check cache first
+        // Check cache first WITH LOGGING
         const cached = this.nounCacheManager.get(id);
-        if (cached) {
+        // DIAGNOSTIC LOGGING: Reveal cache poisoning
+        prodLog.info(`[getNode] 🔍 Cache check for ${id.substring(0, 8)}...:`, {
+            hasCached: cached !== undefined,
+            isNull: cached === null,
+            isObject: cached !== null && typeof cached === 'object',
+            type: typeof cached
+        });
+        // CRITICAL FIX: Only return cached value if it's valid (not null/undefined)
+        if (cached !== undefined && cached !== null) {
+            prodLog.info(`[getNode] ✅ Cache HIT - returning cached node for ${id.substring(0, 8)}...`);
             this.logger.trace(`Cache hit for noun ${id}`);
             return cached;
         }
+        else if (cached === null) {
+            prodLog.warn(`[getNode] ⚠️ Cache contains NULL for ${id.substring(0, 8)}... - ignoring and loading from GCS`);
+        }
+        else {
+            prodLog.info(`[getNode] ❌ Cache MISS - loading from GCS for ${id.substring(0, 8)}...`);
+        }
         // Apply backpressure
         const requestId = await this.applyBackpressure();
         try {
@@ -420,8 +441,14 @@ export class GcsStorage extends BaseStorage {
                 level: data.level || 0
                 // NO metadata field - retrieved separately for scalability
             };
-            // Update cache
-            this.nounCacheManager.set(id, node);
+            // CRITICAL FIX: Only cache valid nodes (never cache null)
+            if (node && node.id && node.vector && Array.isArray(node.vector)) {
+                this.nounCacheManager.set(id, node);
+                prodLog.info(`[getNode] 💾 Cached node ${id.substring(0, 8)}... successfully`);
+            }
+            else {
+                prodLog.warn(`[getNode] ⚠️ NOT caching invalid node for ${id.substring(0, 8)}...`);
+            }
             this.logger.trace(`Successfully retrieved node ${id}`);
             this.releaseBackpressure(true, requestId);
             return node;
@@ -440,7 +467,8 @@ export class GcsStorage extends BaseStorage {
             prodLog.error(`[getNode]   Error object:`, JSON.stringify(error, null, 2));
             // Check if this is a "not found" error
             if (error.code === 404) {
-                prodLog.warn(`[getNode] Identified as 404 error - returning null`);
+                prodLog.warn(`[getNode] Identified as 404 error - returning null WITHOUT caching`);
+                // CRITICAL FIX: Do NOT cache null values
                 return null;
             }
             // Handle throttling

package/dist/storage/adapters/s3CompatibleStorage.js

@@ -237,6 +237,16 @@ export class S3CompatibleStorage extends BaseStorage {
             await this.cleanupLegacyIndexFolder();
             // Initialize counts from storage
             await this.initializeCounts();
+            // CRITICAL FIX (v3.37.7): Clear any stale cache entries from previous runs
+            // This prevents cache poisoning from causing silent failures on container restart
+            const nodeCacheSize = this.nodeCache?.size || 0;
+            if (nodeCacheSize > 0) {
+                prodLog.info(`🧹 Clearing ${nodeCacheSize} cached node entries from previous run`);
+                this.nodeCache.clear();
+            }
+            else {
+                prodLog.info('🧹 Node cache is empty - starting fresh');
+            }
             this.isInitialized = true;
             this.logger.info(`Initialized ${this.serviceType} storage with bucket ${this.bucketName}`);
         }
@@ -808,6 +818,27 @@ export class S3CompatibleStorage extends BaseStorage {
      */
     async getNode(id) {
         await this.ensureInitialized();
+        // Check cache first WITH LOGGING
+        const cached = this.nodeCache.get(id);
+        // DIAGNOSTIC LOGGING: Reveal cache poisoning
+        prodLog.info(`[getNode] 🔍 Cache check for ${id.substring(0, 8)}...:`, {
+            hasCached: cached !== undefined,
+            isNull: cached === null,
+            isObject: cached !== null && typeof cached === 'object',
+            type: typeof cached
+        });
+        // CRITICAL FIX: Only return cached value if it's valid (not null/undefined)
+        if (cached !== undefined && cached !== null) {
+            prodLog.info(`[getNode] ✅ Cache HIT - returning cached node for ${id.substring(0, 8)}...`);
+            this.logger.trace(`Cache hit for node ${id}`);
+            return cached;
+        }
+        else if (cached === null) {
+            prodLog.warn(`[getNode] ⚠️ Cache contains NULL for ${id.substring(0, 8)}... - ignoring and loading from S3`);
+        }
+        else {
+            prodLog.info(`[getNode] ❌ Cache MISS - loading from S3 for ${id.substring(0, 8)}...`);
+        }
         try {
             // Import the GetObjectCommand only when needed
             const { GetObjectCommand } = await import('@aws-sdk/client-s3');
@@ -858,6 +889,14 @@ export class S3CompatibleStorage extends BaseStorage {
                 connections,
                 level: parsedNode.level || 0
             };
+            // CRITICAL FIX: Only cache valid nodes (never cache null)
+            if (node && node.id && node.vector && Array.isArray(node.vector)) {
+                this.nodeCache.set(id, node);
+                prodLog.info(`[getNode] 💾 Cached node ${id.substring(0, 8)}... successfully`);
+            }
+            else {
+                prodLog.warn(`[getNode] ⚠️ NOT caching invalid node for ${id.substring(0, 8)}...`);
+            }
             this.logger.trace(`Successfully retrieved node ${id}`);
             return node;
         }
@@ -876,7 +915,8 @@ export class S3CompatibleStorage extends BaseStorage {
             prodLog.error(`[getNode]   Error object:`, JSON.stringify(error, null, 2));
             // Check if this is a "not found" error (S3 uses "NoSuchKey")
             if (error?.name === 'NoSuchKey' || error?.Code === 'NoSuchKey' || error?.$metadata?.httpStatusCode === 404) {
-                prodLog.warn(`[getNode] Identified as 404/NoSuchKey error - returning null`);
+                prodLog.warn(`[getNode] Identified as 404/NoSuchKey error - returning null WITHOUT caching`);
+                // CRITICAL FIX: Do NOT cache null values
                 return null;
             }
             // Handle throttling

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulcraft/brainy",
-  "version": "3.37.6",
+  "version": "3.37.7",
   "description": "Universal Knowledge Protocol™ - World's first Triple Intelligence database unifying vector, graph, and document search in one API. 31 nouns × 40 verbs for infinite expressiveness.",
   "main": "dist/index.js",
   "module": "dist/index.js",