@soulcraft/brainy 3.32.1 → 3.32.2

package/CHANGELOG.md

@@ -2,6 +2,49 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.32.2](https://github.com/soulcraftlabs/brainy/compare/v3.32.1...v3.32.2) (2025-10-09)
+
+### 🐛 Critical Bug Fixes - Container Restart Persistence
+
+**Fixed: brain.find({ where: {...} }) returns empty array after restart**
+**Fixed: brain.init() returns 0 entities after container restart**
+
+#### Root Cause
+Count persistence was optimized to save only every 10 operations. If <10 entities were added before container restart, counts were never persisted to storage. After restart: `totalNounCount = 0`, causing empty query results.
+
+#### Impact
+Critical for serverless/containerized deployments (Cloud Run, Fargate, Lambda) where containers restart frequently. The basic write→restart→read scenario was broken.
+
+#### Changes
+- `baseStorageAdapter.ts`: Persist counts on EVERY operation (not every 10)
+  - `incrementEntityCountSafe()`: Now persists immediately
+  - `decrementEntityCountSafe()`: Now persists immediately
+  - `incrementVerbCount()`: Now persists immediately
+  - `decrementVerbCount()`: Now persists immediately
+
+- `gcsStorage.ts`: Better error handling for count initialization
+  - `initializeCounts()`: Fail loudly on network/permission errors
+  - `initializeCountsFromScan()`: Throw on scan failures instead of silent fail
+  - Added recovery logic with bucket scan fallback
+
+#### Test Scenario (Now Fixed)
+```typescript
+// Service A: Add 2 entities
+await brain.add({ data: 'Entity 1' })
+await brain.add({ data: 'Entity 2' })
+
+// Container restarts (Cloud Run, Fargate, etc.)
+
+// Service B: Query data
+const stats = await brain.getStats()
+console.log(stats.entities.total) // Was: 0 ❌ | Now: 2 ✅
+
+const results = await brain.find({ where: { status: 'active' }})
+console.log(results.length) // Was: 0 ❌ | Now: 2 ✅
+```
+
+---
+
 ## [3.31.0](https://github.com/soulcraftlabs/brainy/compare/v3.30.2...v3.31.0) (2025-10-09)
 
 ### 🐛 Critical Bug Fixes - Production-Scale Import Performance

package/dist/storage/adapters/baseStorageAdapter.js

@@ -659,10 +659,10 @@ export class BaseStorageAdapter {
         const mutex = getGlobalMutex();
         await mutex.runExclusive(`count-entity-${type}`, async () => {
             this.incrementEntityCount(type);
-            // Persist counts periodically
-            if (this.totalNounCount % 10 === 0) {
-                await this.persistCounts();
-            }
+            // CRITICAL FIX: Persist counts on EVERY change for cloud storage adapters
+            // This ensures counts survive container restarts (GCS, S3, etc.)
+            // For memory/file storage, this is fast; for cloud storage, it's essential
+            await this.persistCounts();
         });
     }
     /**
@@ -693,9 +693,8 @@ export class BaseStorageAdapter {
         const mutex = getGlobalMutex();
         await mutex.runExclusive(`count-entity-${type}`, async () => {
             this.decrementEntityCount(type);
-            if (this.totalNounCount % 10 === 0) {
-                await this.persistCounts();
-            }
+            // CRITICAL FIX: Persist counts on EVERY change for cloud storage adapters
+            await this.persistCounts();
         });
     }
     /**
@@ -712,10 +711,8 @@ export class BaseStorageAdapter {
                 count: this.totalVerbCount,
                 timestamp: Date.now()
             });
-            // Persist counts immediately for consistency
-            if (this.totalVerbCount % 10 === 0) {
-                await this.persistCounts();
-            }
+            // CRITICAL FIX: Persist counts on EVERY change for cloud storage adapters
+            await this.persistCounts();
         });
     }
     /**
@@ -740,10 +737,8 @@ export class BaseStorageAdapter {
                 count: this.totalVerbCount,
                 timestamp: Date.now()
             });
-            // Persist counts immediately for consistency
-            if (this.totalVerbCount % 10 === 0) {
-                await this.persistCounts();
-            }
+            // CRITICAL FIX: Persist counts on EVERY change for cloud storage adapters
+            await this.persistCounts();
         });
     }
 }

package/dist/storage/adapters/gcsStorage.js

@@ -1095,8 +1095,8 @@ export class GcsStorage extends BaseStorage {
      * Initialize counts from storage
      */
     async initializeCounts() {
+        const key = `${this.systemPrefix}counts.json`;
         try {
-            const key = `${this.systemPrefix}counts.json`;
             const file = this.bucket.file(key);
             const [contents] = await file.download();
             const counts = JSON.parse(contents.toString());
@@ -1104,16 +1104,21 @@ export class GcsStorage extends BaseStorage {
             this.totalVerbCount = counts.totalVerbCount || 0;
             this.entityCounts = new Map(Object.entries(counts.entityCounts || {}));
             this.verbCounts = new Map(Object.entries(counts.verbCounts || {}));
-            prodLog.info(`📊 Loaded counts: ${this.totalNounCount} nouns, ${this.totalVerbCount} verbs`);
+            prodLog.info(`📊 Loaded counts from storage: ${this.totalNounCount} nouns, ${this.totalVerbCount} verbs`);
         }
         catch (error) {
             if (error.code === 404) {
-                // No counts file yet - initialize from scan
-                prodLog.info('📊 No counts file found - initializing from storage scan...');
+                // No counts file yet - initialize from scan (first-time setup or counts not persisted)
+                prodLog.info('📊 No counts file found - this is normal for first init or if <10 entities were added');
                 await this.initializeCountsFromScan();
             }
             else {
-                this.logger.error('Error loading counts:', error);
+                // CRITICAL FIX: Don't silently fail on network/permission errors
+                this.logger.error('❌ CRITICAL: Failed to load counts from GCS:', error);
+                prodLog.error(`❌ Error loading ${key}: ${error.message}`);
+                // Try to recover by scanning the bucket
+                prodLog.warn('⚠️  Attempting recovery by scanning GCS bucket...');
+                await this.initializeCountsFromScan();
             }
         }
     }
@@ -1122,6 +1127,7 @@ export class GcsStorage extends BaseStorage {
      */
     async initializeCountsFromScan() {
         try {
+            prodLog.info('📊 Scanning GCS bucket to initialize counts...');
             // Count nouns
             const [nounFiles] = await this.bucket.getFiles({ prefix: this.nounPrefix });
             this.totalNounCount = nounFiles?.filter((f) => f.name?.endsWith('.json')).length || 0;
@@ -1130,10 +1136,12 @@ export class GcsStorage extends BaseStorage {
             this.totalVerbCount = verbFiles?.filter((f) => f.name?.endsWith('.json')).length || 0;
             // Save initial counts
             await this.persistCounts();
-            prodLog.info(`✅ Initialized counts: ${this.totalNounCount} nouns, ${this.totalVerbCount} verbs`);
+            prodLog.info(`✅ Initialized counts from scan: ${this.totalNounCount} nouns, ${this.totalVerbCount} verbs`);
         }
         catch (error) {
-            this.logger.error('Error initializing counts from scan:', error);
+            // CRITICAL FIX: Don't silently fail - this prevents data loss scenarios
+            this.logger.error('❌ CRITICAL: Failed to initialize counts from GCS bucket scan:', error);
+            throw new Error(`Failed to initialize GCS storage counts: ${error}. This prevents container restarts from working correctly.`);
         }
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulcraft/brainy",
-  "version": "3.32.1",
+  "version": "3.32.2",
   "description": "Universal Knowledge Protocol™ - World's first Triple Intelligence database unifying vector, graph, and document search in one API. 31 nouns × 40 verbs for infinite expressiveness.",
   "main": "dist/index.js",
   "module": "dist/index.js",