@soulbatical/tetra-dev-toolkit 1.8.2 → 1.8.4

package/lib/checks/health/naming-conventions.js

@@ -47,6 +47,7 @@ function scanDatabaseNaming(projectPath, options = {}) {
 
   // First pass: collect all renames and late-added columns from ALL migration files.
   // These are used to suppress violations from earlier migrations.
+  const renamedTables = new Map()   // "old_table" → "new_table"
   const renamedColumns = new Map()  // "table.old_col" → "new_col"
   const renamedIndexes = new Map()  // "old_index" → "new_index"
   const lateAddedColumns = new Map() // "table.col" → true (columns added via ALTER TABLE ADD COLUMN)
@@ -55,9 +56,15 @@ function scanDatabaseNaming(projectPath, options = {}) {
     let content
     try { content = readFileSync(filePath, 'utf-8') } catch { continue }
 
+    // Track RENAME TABLE: ALTER TABLE old RENAME TO new
+    const renameTableRegex = /ALTER\s+TABLE\s+(?:IF\s+EXISTS\s+)?(?:public\.)?["']?(\w+)["']?\s+RENAME\s+TO\s+["']?(\w+)["']?/gi
+    let m
+    while ((m = renameTableRegex.exec(content)) !== null) {
+      renamedTables.set(m[1], m[2])
+    }
+
     // Track RENAME COLUMN: ALTER TABLE x RENAME COLUMN old TO new
     const renameColRegex = /ALTER\s+TABLE\s+(?:IF\s+EXISTS\s+)?(?:public\.)?["']?(\w+)["']?\s+RENAME\s+COLUMN\s+["']?(\w+)["']?\s+TO\s+["']?(\w+)["']?/gi
-    let m
     while ((m = renameColRegex.exec(content)) !== null) {
       renamedColumns.set(`${m[1]}.${m[2]}`, m[3])
     }
@@ -175,44 +182,81 @@ function scanDatabaseNaming(projectPath, options = {}) {
 
   // ── Filter violations resolved by later migrations ──
 
-  // Helper: check if a column was renamed to a compliant name in a later migration
+  // Resolve a table name through renames: la_reflections → stella_reflections
+  const resolveTable = (table) => {
+    return renamedTables.get(table) || table
+  }
+
+  // Helper: check if a column was renamed (on original or renamed table)
   const isColumnRenamed = (table, col) => {
-    const key = `${table}.${col}`
-    return renamedColumns.has(key)
+    if (renamedColumns.has(`${table}.${col}`)) return true
+    const resolved = resolveTable(table)
+    if (resolved !== table && renamedColumns.has(`${resolved}.${col}`)) return true
+    return false
   }
 
-  // Helper: check if an index was renamed to a compliant name in a later migration
+  // Helper: check if an index was renamed
   const isIndexRenamed = (indexName) => {
     return renamedIndexes.has(indexName)
   }
 
-  // Helper: check if a missing timestamp was added in a later migration
+  // Helper: check if a missing timestamp was added (on original or renamed table)
   const isTimestampAddedLater = (table, col) => {
-    return lateAddedColumns.has(`${table}.${col}`)
+    if (lateAddedColumns.has(`${table}.${col}`)) return true
+    const resolved = resolveTable(table)
+    if (resolved !== table && lateAddedColumns.has(`${resolved}.${col}`)) return true
+    return false
+  }
+
+  // Helper: check if a table was renamed (violations on old name are resolved)
+  const isTableRenamed = (table) => {
+    return renamedTables.has(table)
   }
 
   // Filter out resolved violations
   const unresolvedViolations = violations.filter(v => {
-    // Column violations: "Boolean/JSON/Column "table.col" ..."
-    const colMatch = v.match(/(?:Boolean|JSON|Column|PK|FK)\s+"(\w+)\.(\w+)"/)
-    if (colMatch && isColumnRenamed(colMatch[1], colMatch[2])) {
-      compliant++ // was a violation, now fixed
+    // Extract table name from any violation that mentions "table.col" or Table "name"
+    const tableColMatch = v.match(/"(\w+)\.(\w+)"/)
+    const tableOnlyMatch = v.match(/Table\s+"(\w+)"/)
+    const table = tableColMatch ? tableColMatch[1] : (tableOnlyMatch ? tableOnlyMatch[1] : null)
+
+    // If the table itself was renamed, ALL violations on the old name are resolved
+    // (the new table name will be checked separately if it appears in a CREATE TABLE)
+    if (table && isTableRenamed(table)) {
+      compliant++
       return false
     }
 
-    // Index violations: 'Index "name" should use idx_...'
-    const idxMatch = v.match(/Index\s+"(\w+)"\s+should/)
-    if (idxMatch && isIndexRenamed(idxMatch[1])) {
+    // Column violations: "Boolean/JSON/Column/PK/FK "table.col" ..."
+    if (tableColMatch && isColumnRenamed(tableColMatch[1], tableColMatch[2])) {
       compliant++
       return false
     }
 
+    // Index violations: 'Index "name" should use idx_...'
+    const idxMatch = v.match(/Index\s+"(\w+)"\s+should/)
+    if (idxMatch) {
+      const idxName = idxMatch[1]
+      // Direct rename match
+      if (isIndexRenamed(idxName)) {
+        compliant++
+        return false
+      }
+      // If the index name starts with a renamed table prefix, it's implicitly resolved
+      for (const [oldTable] of renamedTables) {
+        if (idxName.startsWith(oldTable + '_')) {
+          compliant++
+          return false
+        }
+      }
+    }
+
     // Missing timestamp violations: 'Table "x" missing created_at, updated_at'
     const tsMatch = v.match(/Table\s+"(\w+)"\s+missing\s+(.+?)(?:\s+\()/)
     if (tsMatch) {
-      const table = tsMatch[1]
+      const tbl = tsMatch[1]
       const missingCols = tsMatch[2].split(/,\s*/)
-      const allFixed = missingCols.every(col => isTimestampAddedLater(table, col.trim()))
+      const allFixed = missingCols.every(col => isTimestampAddedLater(tbl, col.trim()))
       if (allFixed) {
         compliant++
         return false

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulbatical/tetra-dev-toolkit",
-  "version": "1.8.2",
+  "version": "1.8.4",
   "publishConfig": {
     "access": "restricted"
   },