@soulbatical/tetra-dev-toolkit 1.8.1 → 1.8.3

package/lib/checks/health/naming-conventions.js

@@ -42,6 +42,46 @@ function scanDatabaseNaming(projectPath, options = {}) {
 
   if (sqlFiles.length === 0) return { totalFields: 0, compliant: 0, violations: [], compliancePercent: 100 }
 
+  // Sort migration files chronologically so we can track renames
+  sqlFiles.sort()
+
+  // First pass: collect all renames and late-added columns from ALL migration files.
+  // These are used to suppress violations from earlier migrations.
+  const renamedTables = new Map()   // "old_table" → "new_table"
+  const renamedColumns = new Map()  // "table.old_col" → "new_col"
+  const renamedIndexes = new Map()  // "old_index" → "new_index"
+  const lateAddedColumns = new Map() // "table.col" → true (columns added via ALTER TABLE ADD COLUMN)
+
+  for (const filePath of sqlFiles) {
+    let content
+    try { content = readFileSync(filePath, 'utf-8') } catch { continue }
+
+    // Track RENAME TABLE: ALTER TABLE old RENAME TO new
+    const renameTableRegex = /ALTER\s+TABLE\s+(?:IF\s+EXISTS\s+)?(?:public\.)?["']?(\w+)["']?\s+RENAME\s+TO\s+["']?(\w+)["']?/gi
+    let m
+    while ((m = renameTableRegex.exec(content)) !== null) {
+      renamedTables.set(m[1], m[2])
+    }
+
+    // Track RENAME COLUMN: ALTER TABLE x RENAME COLUMN old TO new
+    const renameColRegex = /ALTER\s+TABLE\s+(?:IF\s+EXISTS\s+)?(?:public\.)?["']?(\w+)["']?\s+RENAME\s+COLUMN\s+["']?(\w+)["']?\s+TO\s+["']?(\w+)["']?/gi
+    while ((m = renameColRegex.exec(content)) !== null) {
+      renamedColumns.set(`${m[1]}.${m[2]}`, m[3])
+    }
+
+    // Track RENAME INDEX: ALTER INDEX old RENAME TO new
+    const renameIdxRegex = /ALTER\s+INDEX\s+(?:IF\s+EXISTS\s+)?["']?(\w+)["']?\s+RENAME\s+TO\s+["']?(\w+)["']?/gi
+    while ((m = renameIdxRegex.exec(content)) !== null) {
+      renamedIndexes.set(m[1], m[2])
+    }
+
+    // Track ADD COLUMN (timestamps added later fix "missing timestamps" violations)
+    const addColRegex = /ALTER\s+TABLE\s+(?:IF\s+EXISTS\s+)?(?:public\.)?["']?(\w+)["']?\s+ADD\s+(?:COLUMN\s+)?(?:IF\s+NOT\s+EXISTS\s+)?["']?(\w+)["']?\s+\w+/gi
+    while ((m = addColRegex.exec(content)) !== null) {
+      lateAddedColumns.set(`${m[1]}.${m[2]}`, true)
+    }
+  }
+
   const globalColumns = {}
 
   const checkColumn = (tableName, colName, colType, body, fileName) => {
@@ -140,6 +180,85 @@ function scanDatabaseNaming(projectPath, options = {}) {
     }
   }
 
+  // ── Filter violations resolved by later migrations ──
+
+  // Resolve a table name through renames: la_reflections → stella_reflections
+  const resolveTable = (table) => {
+    return renamedTables.get(table) || table
+  }
+
+  // Helper: check if a column was renamed (on original or renamed table)
+  const isColumnRenamed = (table, col) => {
+    if (renamedColumns.has(`${table}.${col}`)) return true
+    const resolved = resolveTable(table)
+    if (resolved !== table && renamedColumns.has(`${resolved}.${col}`)) return true
+    return false
+  }
+
+  // Helper: check if an index was renamed
+  const isIndexRenamed = (indexName) => {
+    return renamedIndexes.has(indexName)
+  }
+
+  // Helper: check if a missing timestamp was added (on original or renamed table)
+  const isTimestampAddedLater = (table, col) => {
+    if (lateAddedColumns.has(`${table}.${col}`)) return true
+    const resolved = resolveTable(table)
+    if (resolved !== table && lateAddedColumns.has(`${resolved}.${col}`)) return true
+    return false
+  }
+
+  // Helper: check if a table was renamed (violations on old name are resolved)
+  const isTableRenamed = (table) => {
+    return renamedTables.has(table)
+  }
+
+  // Filter out resolved violations
+  const unresolvedViolations = violations.filter(v => {
+    // Extract table name from any violation that mentions "table.col" or Table "name"
+    const tableColMatch = v.match(/"(\w+)\.(\w+)"/)
+    const tableOnlyMatch = v.match(/Table\s+"(\w+)"/)
+    const table = tableColMatch ? tableColMatch[1] : (tableOnlyMatch ? tableOnlyMatch[1] : null)
+
+    // If the table itself was renamed, ALL violations on the old name are resolved
+    // (the new table name will be checked separately if it appears in a CREATE TABLE)
+    if (table && isTableRenamed(table)) {
+      compliant++
+      return false
+    }
+
+    // Column violations: "Boolean/JSON/Column/PK/FK "table.col" ..."
+    if (tableColMatch && isColumnRenamed(tableColMatch[1], tableColMatch[2])) {
+      compliant++
+      return false
+    }
+
+    // Index violations: 'Index "name" should use idx_...'
+    const idxMatch = v.match(/Index\s+"(\w+)"\s+should/)
+    if (idxMatch && isIndexRenamed(idxMatch[1])) {
+      compliant++
+      return false
+    }
+
+    // Missing timestamp violations: 'Table "x" missing created_at, updated_at'
+    const tsMatch = v.match(/Table\s+"(\w+)"\s+missing\s+(.+?)(?:\s+\()/)
+    if (tsMatch) {
+      const tbl = tsMatch[1]
+      const missingCols = tsMatch[2].split(/,\s*/)
+      const allFixed = missingCols.every(col => isTimestampAddedLater(tbl, col.trim()))
+      if (allFixed) {
+        compliant++
+        return false
+      }
+    }
+
+    return true
+  })
+
+  // Replace violations array with filtered version
+  violations.length = 0
+  violations.push(...unresolvedViolations)
+
   // Consistency checks
   const consistencyGroups = [
     { concept: 'creation timestamp', preferred: 'created_at', alternatives: ['created_on', 'creation_date', 'inserted_at', 'date_created'] },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulbatical/tetra-dev-toolkit",
-  "version": "1.8.1",
+  "version": "1.8.3",
   "publishConfig": {
     "access": "restricted"
   },