@soulbatical/tetra-dev-toolkit 1.3.3 → 1.4.0

package/lib/checks/health/types.js

@@ -5,7 +5,7 @@
  */
 
 /**
- * @typedef {'plugins'|'mcps'|'git'|'tests'|'secrets'|'quality-toolkit'|'naming-conventions'|'rls-audit'|'rpc-param-mismatch'|'gitignore'|'repo-visibility'|'vincifox-widget'|'stella-integration'|'claude-md'|'doppler-compliance'|'infrastructure-yml'|'file-organization'} HealthCheckType
+ * @typedef {'plugins'|'mcps'|'git'|'tests'|'secrets'|'quality-toolkit'|'naming-conventions'|'rls-audit'|'rpc-param-mismatch'|'typescript-strict'|'prettier'|'coverage-thresholds'|'eslint-security'|'dependency-cruiser'|'conventional-commits'|'gitignore'|'repo-visibility'|'vincifox-widget'|'stella-integration'|'claude-md'|'doppler-compliance'|'infrastructure-yml'|'file-organization'} HealthCheckType
  *
  * @typedef {'ok'|'warning'|'error'} HealthStatus
  *

package/lib/checks/health/typescript-strict.js

@@ -0,0 +1,143 @@
+/**
+ * Health Check: TypeScript Strictness
+ *
+ * Checks TypeScript configuration for strict mode and type safety.
+ * Score: up to 3 points:
+ *   +1 for strict: true in tsconfig.json
+ *   +1 for tsc --noEmit script in package.json (typecheck command)
+ *   +1 for noImplicitAny + strictNullChecks (if not using strict: true)
+ *       OR bonus for strict: true + noUncheckedIndexedAccess
+ */
+
+import { existsSync, readFileSync } from 'fs'
+import { join } from 'path'
+import { createCheck } from './types.js'
+
+export async function check(projectPath) {
+  const result = createCheck('typescript-strict', 3, {
+    tsconfigFound: false,
+    strict: false,
+    noImplicitAny: false,
+    strictNullChecks: false,
+    noUncheckedIndexedAccess: false,
+    hasTypecheckScript: false,
+    typecheckScript: null,
+    tsconfigPaths: [],
+    message: ''
+  })
+
+  // Find tsconfig files in root + common sub-packages
+  const tsconfigLocations = [
+    'tsconfig.json',
+    'backend/tsconfig.json',
+    'frontend/tsconfig.json',
+    'frontend-user/tsconfig.json',
+    'src/tsconfig.json',
+    'mcp/tsconfig.json'
+  ]
+
+  let bestConfig = null
+
+  for (const loc of tsconfigLocations) {
+    const tsconfigPath = join(projectPath, loc)
+    if (!existsSync(tsconfigPath)) continue
+
+    result.details.tsconfigPaths.push(loc)
+    result.details.tsconfigFound = true
+
+    try {
+      // Strip JSON comments (// and /* */) before parsing
+      const raw = readFileSync(tsconfigPath, 'utf-8')
+      const stripped = raw
+        .replace(/\/\/.*$/gm, '')
+        .replace(/\/\*[\s\S]*?\*\//g, '')
+        .replace(/,\s*([}\]])/g, '$1')
+      const tsconfig = JSON.parse(stripped)
+      const opts = tsconfig.compilerOptions || {}
+
+      if (opts.strict && !bestConfig) {
+        bestConfig = { path: loc, strict: true, opts }
+      } else if (!bestConfig) {
+        bestConfig = { path: loc, strict: false, opts }
+      }
+    } catch { /* invalid tsconfig, skip */ }
+  }
+
+  if (!result.details.tsconfigFound) {
+    result.status = 'warning'
+    result.details.message = 'No tsconfig.json found'
+    return result
+  }
+
+  if (bestConfig) {
+    const opts = bestConfig.opts
+
+    if (opts.strict) {
+      result.score += 1
+      result.details.strict = true
+    }
+
+    if (opts.noImplicitAny) result.details.noImplicitAny = true
+    if (opts.strictNullChecks) result.details.strictNullChecks = true
+    if (opts.noUncheckedIndexedAccess) result.details.noUncheckedIndexedAccess = true
+
+    // Bonus point: strict + extra strictness OR individual flags
+    if (opts.strict && opts.noUncheckedIndexedAccess) {
+      result.score += 1
+    } else if (!opts.strict && opts.noImplicitAny && opts.strictNullChecks) {
+      result.score += 1
+    }
+  }
+
+  // Check for typecheck script in package.json files
+  const packageLocations = [
+    'package.json',
+    'backend/package.json',
+    'frontend/package.json',
+    'frontend-user/package.json'
+  ]
+
+  for (const loc of packageLocations) {
+    const pkgPath = join(projectPath, loc)
+    if (!existsSync(pkgPath)) continue
+
+    try {
+      const pkg = JSON.parse(readFileSync(pkgPath, 'utf-8'))
+      const scripts = pkg.scripts || {}
+
+      // Look for typecheck or tsc --noEmit scripts
+      for (const [name, cmd] of Object.entries(scripts)) {
+        if (typeof cmd !== 'string') continue
+        if (name === 'typecheck' || name === 'type-check' ||
+            cmd.includes('tsc --noEmit') || cmd.includes('tsc -noEmit') ||
+            (name === 'check' && cmd.includes('tsc'))) {
+          result.details.hasTypecheckScript = true
+          result.details.typecheckScript = `${loc} → ${name}: ${cmd}`
+          break
+        }
+      }
+      if (result.details.hasTypecheckScript) break
+    } catch { /* ignore */ }
+  }
+
+  if (result.details.hasTypecheckScript) {
+    result.score += 1
+  }
+
+  // Determine status
+  if (result.score === 0) {
+    result.status = 'error'
+    result.details.message = 'TypeScript not strict and no typecheck script found'
+  } else if (result.score < 2) {
+    result.status = 'warning'
+    result.details.message = result.details.strict
+      ? 'strict: true but no typecheck script'
+      : result.details.hasTypecheckScript
+        ? 'Typecheck script exists but strict mode disabled'
+        : 'Partial TypeScript strictness'
+  } else {
+    result.details.message = `TypeScript well-configured (${result.details.tsconfigPaths.length} tsconfig(s))`
+  }
+
+  return result
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulbatical/tetra-dev-toolkit",
-  "version": "1.3.3",
+  "version": "1.4.0",
   "publishConfig": {
     "access": "restricted"
   },
@@ -35,7 +35,8 @@
     "templates/"
   ],
   "scripts": {
-    "test": "node --test src/**/*.test.js",
+    "test": "vitest run",
+    "test:watch": "vitest",
     "lint": "eslint src/ lib/ bin/",
     "build": "echo 'No build step needed'"
   },
@@ -52,7 +53,8 @@
     "yaml": "^2.8.2"
   },
   "devDependencies": {
-    "eslint": "^9.0.0"
+    "eslint": "^9.0.0",
+    "vitest": "^4.0.18"
   },
   "peerDependencies": {
     "eslint": ">=8.0.0",