@soulbatical/tetra-dev-toolkit 1.20.26 → 1.21.0

package/lib/checks/codeQuality/api-response-format.js

@@ -33,46 +33,46 @@ export async function run(config, projectRoot) {
     }
   }
 
-  // Find all route and controller files
-  const patterns = [
-    '**/routes/**/*.ts',
-    '**/routes/**/*.js',
-    '**/controllers/**/*.ts',
-    '**/controllers/**/*.js',
-    '**/features/**/controllers/**/*.ts',
-    '**/features/**/*.controller.ts'
-  ]
-
-  let files = []
-  for (const pattern of patterns) {
-    const found = await glob(pattern, {
-      cwd: projectRoot,
-      ignore: [
-        ...(config.ignore || []),
-        'node_modules/**',
-        '**/node_modules/**',
-        'dist/**',
-        '**/dist/**',
-        'build/**',
-        '**/build/**',
-        '**/*.test.*',
-        '**/*.spec.*',
-        '**/*.d.ts',
-        '**/*.js.map'
-      ]
-    })
-    files.push(...found)
-  }
-
-  // Deduplicate
-  files = [...new Set(files)]
+  // Discover ALL backend source files (no path conventions assumed).
+  // Strategy: scan every .ts/.js file and detect Express route handlers by content.
+  // This catches feature folders, custom layouts, monorepo backends, etc.
+  const candidates = await glob('**/*.{ts,js,mts,cts,mjs,cjs}', {
+    cwd: projectRoot,
+    ignore: [
+      ...(config.ignore || []),
+      'node_modules/**',
+      '**/node_modules/**',
+      'dist/**',
+      '**/dist/**',
+      'build/**',
+      '**/build/**',
+      '.next/**',
+      '**/.next/**',
+      'coverage/**',
+      '**/coverage/**',
+      '**/*.test.*',
+      '**/*.spec.*',
+      '**/*.d.ts',
+      '**/*.js.map',
+      // Frontend folders – these are not Express backends
+      'frontend/**',
+      'web/**',
+      'app/**',
+      'pages/**',
+      'src/app/**',
+      'src/pages/**'
+    ]
+  })
+
+  const files = [...new Set(candidates)]
 
   if (files.length === 0) {
     results.skipped = true
-    results.skipReason = 'No route or controller files found'
+    results.skipReason = 'No source files found to scan'
     return results
   }
 
+  let backendFilesScanned = 0
   for (const file of files) {
     const filePath = `${projectRoot}/${file}`
     let content
@@ -82,10 +82,21 @@ export async function run(config, projectRoot) {
       continue
     }
 
+    if (!isExpressRouteFile(content)) continue
+
+    backendFilesScanned++
     const lines = content.split('\n')
     analyzeFile(file, lines, results)
   }
 
+  results.info.backendFilesScanned = backendFilesScanned
+
+  if (backendFilesScanned === 0) {
+    results.skipped = true
+    results.skipReason = 'No Express route handlers detected in scanned files'
+    return results
+  }
+
   results.passed = results.findings.filter(f => f.severity === 'critical' || f.severity === 'high').length === 0
   results.info.violations = results.findings.length
   results.info.compliant = results.info.totalEndpoints - results.info.violations
@@ -93,6 +104,30 @@ export async function run(config, projectRoot) {
   return results
 }
 
+/**
+ * Heuristic: does this file contain Express-style route handlers that
+ * eventually call res.json() or res.status().json()?
+ *
+ * We require BOTH:
+ *   1. An indicator that this is server code (express import / Request type / router/app verb)
+ *   2. At least one res.json() / res.status(...).json() call
+ *
+ * This avoids scanning frontend files that happen to use the variable name `res`.
+ */
+function isExpressRouteFile(content) {
+  const hasResJsonCall = /\bres\s*(?:\.\s*status\s*\([^)]*\)\s*)?\.\s*json\s*\(/.test(content)
+  if (!hasResJsonCall) return false
+
+  const looksLikeExpress =
+    /from\s+['"]express['"]/.test(content) ||
+    /require\s*\(\s*['"]express['"]\s*\)/.test(content) ||
+    /\b(?:Request|Response|NextFunction|Router)\b/.test(content) ||
+    /\b(?:router|app)\s*\.\s*(?:get|post|put|patch|delete|all|use)\s*\(/.test(content) ||
+    /\bexpress\s*\(\s*\)/.test(content)
+
+  return looksLikeExpress
+}
+
 function analyzeFile(file, lines, results) {
   for (let i = 0; i < lines.length; i++) {
     const line = lines[i]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@soulbatical/tetra-dev-toolkit",
-  "version": "1.20.26",
+  "version": "1.21.0",
   "publishConfig": {
     "access": "restricted"
   },