@sonisoft/now-sdk-ext-mcp 4.8.2 → 4.8.3

package/README.md

@@ -521,6 +521,12 @@ Since stdout is reserved for JSON-RPC, **never use `console.log()` in server cod
 - Every tool that talks to ServiceNow should accept an optional `instance` parameter
 - Test every tool through the MCP client (not by calling handler functions directly) so the full protocol stack is exercised
 
+## ServiceNow SDK upgrades
+
+New `@servicenow/sdk` releases are rolled through sn-credstore, core, the CLI and the MCP
+server by a scheduled routine. Its runbook and scripts (`scripts/sdk-watch/`) are described in
+[docs/SDK_UPGRADE_ROUTINE.md](docs/SDK_UPGRADE_ROUTINE.md).
+
 ## License
 
 MIT

package/dist/common/logging.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"logging.d.ts","sourceRoot":"","sources":["../../src/common/logging.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,MAAM,EAAiC,MAAM,4BAA4B,CAAC;AAKnF;;;;;;GAMG;AACH,wBAAgB,WAAW,IAAI,IAAI,CA2BlC;AAED;;;;;;;;;;;;;;;;;;;GAmBG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAE9C"}
+{"version":3,"file":"logging.d.ts","sourceRoot":"","sources":["../../src/common/logging.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAGH,OAAO,EAAE,MAAM,EAAiC,MAAM,4BAA4B,CAAC;AAgBnF;;;;;;GAMG;AACH,wBAAgB,WAAW,IAAI,IAAI,CA4DlC;AAWD;;;;;;;;;;;;;;;;;;;GAmBG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAE9C"}

package/dist/common/logging.js

@@ -15,8 +15,13 @@
  * stdout is the JSON-RPC transport. Everything here goes to stderr, and nothing in this
  * process may ever write to fd 1.
  */
+import { createRequire } from "node:module";
 import { Logger, configureLogging, redactValue } from "@sonisoft/now-sdk-ext-core";
 import { logger as sdkLogger } from "@servicenow/sdk-cli/dist/logger/index.js";
+/** The SDK logger module, wherever it was installed. */
+const SDK_LOGGER_PATH = /@servicenow[\\/]sdk-cli[\\/]dist[\\/]logger[\\/]index\.js$/;
+const isSdkLogger = (value) => typeof value?.setLevel === "function"
+    && ["info", "warn", "error", "debug"].every(level => typeof value[level] === "function");
 let configured = false;
 /**
  * Configures process-wide logging. Call once, before anything constructs a manager.
@@ -40,22 +45,64 @@ export function initLogging() {
         // resolves those; naming them here would override an operator's NEX_LOG_FILE=0.
     });
     const sdkLog = getLogger("ServiceNow SDK");
-    sdkLogger.setLevel("silent");
-    for (const level of ["info", "warn", "error", "debug"]) {
-        sdkLogger[level] = (...args) => {
-            const message = args.map(arg => {
-                if (typeof arg === "string")
-                    return arg;
-                try {
-                    return JSON.stringify(redactValue(arg)) ?? String(arg);
-                }
-                catch {
-                    return "[unserializable]";
-                }
-            }).join(" ");
-            sdkLog[level](message || "ServiceNow SDK");
-        };
+    // Every copy of the SDK's logger, not just the one this package resolves. When this
+    // package's @servicenow/sdk-cli and core's differ, core loads its own copy, and that
+    // is the copy that refreshes OAuth tokens. Unpatched, it printed "[now-sdk] Access
+    // Token has expired, refreshing token" through console.log, onto fd 1. Core has
+    // already been imported by now, so its copy is in the module cache.
+    //
+    // This finds CommonJS copies only (require.cache), which is what the SDK ships today.
+    // Should a release move its logger to ESM, the console backstop below still catches
+    // its console.log output, and scripts/sdk-watch/stdio-smoke.mjs checks fd 1 directly.
+    const cache = createRequire(import.meta.url).cache;
+    const copies = new Set(isSdkLogger(sdkLogger) ? [sdkLogger] : []);
+    for (const [path, mod] of Object.entries(cache)) {
+        const exported = mod?.exports?.logger;
+        if (SDK_LOGGER_PATH.test(path) && isSdkLogger(exported))
+            copies.add(exported);
     }
+    for (const copy of copies) {
+        copy.setLevel("silent");
+        for (const level of ["info", "warn", "error", "debug"]) {
+            copy[level] = (...args) => sdkLog[level](toMessage(args) || "ServiceNow SDK");
+        }
+    }
+    // And a backstop for anything else that reaches for console.log, info or debug: a
+    // copy loaded later, or another library. Those write to stdout; route them to stderr
+    // through the redacting logger instead. warn and error already go to stderr. Core's
+    // logger writes to a process.stderr stream, never console, so this cannot recurse;
+    // the guard keeps it that way if that ever changes.
+    const consoleLog = getLogger("console");
+    let routing = false;
+    const route = (level) => (...args) => {
+        if (routing) {
+            process.stderr.write(`${toMessage(args)}\n`);
+            return;
+        }
+        routing = true;
+        try {
+            consoleLog[level](toMessage(args));
+        }
+        finally {
+            routing = false;
+        }
+    };
+    console.log = route("info");
+    console.info = route("info");
+    console.debug = route("debug");
+}
+/** Joins log arguments, serialising anything that is not a string through redaction. */
+function toMessage(args) {
+    return args.map(arg => {
+        if (typeof arg === "string")
+            return arg;
+        try {
+            return JSON.stringify(redactValue(arg)) ?? String(arg);
+        }
+        catch {
+            return "[unserializable]";
+        }
+    }).join(" ");
 }
 /**
  * Returns a named logger.

package/dist/common/logging.js.map

@@ -1 +1 @@
-{"version":3,"file":"logging.js","sourceRoot":"","sources":["../../src/common/logging.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,MAAM,EAAE,gBAAgB,EAAE,WAAW,EAAE,MAAM,4BAA4B,CAAC;AACnF,OAAO,EAAE,MAAM,IAAI,SAAS,EAAE,MAAM,0CAA0C,CAAC;AAE/E,IAAI,UAAU,GAAG,KAAK,CAAC;AAEvB;;;;;;GAMG;AACH,MAAM,UAAU,WAAW;IACvB,IAAI,UAAU,EAAE,CAAC;QACb,OAAO;IACX,CAAC;IACD,UAAU,GAAG,IAAI,CAAC;IAElB,gBAAgB,CAAC;QACb,+EAA+E;QAC/E,+EAA+E;QAC/E,+EAA+E;QAC/E,kEAAkE;QAClE,YAAY,EAAE,OAAO,CAAC,GAAG,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,MAAM;QACzD,2EAA2E;QAC3E,gFAAgF;KACnF,CAAC,CAAC;IACH,MAAM,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC3C,SAAS,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAC7B,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,CAAU,EAAE,CAAC;QAC9D,SAAS,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,IAAe,EAAQ,EAAE;YAC5C,MAAM,OAAO,GAAG,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE;gBAC3B,IAAI,OAAO,GAAG,KAAK,QAAQ;oBAAE,OAAO,GAAG,CAAC;gBACxC,IAAI,CAAC;oBAAC,OAAO,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,IAAI,MAAM,CAAC,GAAG,CAAC,CAAC;gBAAC,CAAC;gBAC/D,MAAM,CAAC;oBAAC,OAAO,kBAAkB,CAAC;gBAAC,CAAC;YACxC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YACb,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,IAAI,gBAAgB,CAAC,CAAC;QAC/C,CAAC,CAAC;IACN,CAAC;AACL,CAAC;AAED;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,SAAS,CAAC,IAAY;IAClC,OAAO,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC;AAC5B,CAAC"}
+{"version":3,"file":"logging.js","sourceRoot":"","sources":["../../src/common/logging.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAC5C,OAAO,EAAE,MAAM,EAAE,gBAAgB,EAAE,WAAW,EAAE,MAAM,4BAA4B,CAAC;AACnF,OAAO,EAAE,MAAM,IAAI,SAAS,EAAE,MAAM,0CAA0C,CAAC;AAE/E,wDAAwD;AACxD,MAAM,eAAe,GAAG,4DAA4D,CAAC;AAMrF,MAAM,WAAW,GAAG,CAAC,KAAc,EAAsB,EAAE,CACvD,OAAQ,KAA+B,EAAE,QAAQ,KAAK,UAAU;OAC7D,CAAC,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC,OAAQ,KAAiC,CAAC,KAAK,CAAC,KAAK,UAAU,CAAC,CAAC;AAE1H,IAAI,UAAU,GAAG,KAAK,CAAC;AAEvB;;;;;;GAMG;AACH,MAAM,UAAU,WAAW;IACvB,IAAI,UAAU,EAAE,CAAC;QACb,OAAO;IACX,CAAC;IACD,UAAU,GAAG,IAAI,CAAC;IAElB,gBAAgB,CAAC;QACb,+EAA+E;QAC/E,+EAA+E;QAC/E,+EAA+E;QAC/E,kEAAkE;QAClE,YAAY,EAAE,OAAO,CAAC,GAAG,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,MAAM;QACzD,2EAA2E;QAC3E,gFAAgF;KACnF,CAAC,CAAC;IACH,MAAM,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC3C,oFAAoF;IACpF,qFAAqF;IACrF,mFAAmF;IACnF,gFAAgF;IAChF,oEAAoE;IACpE,EAAE;IACF,sFAAsF;IACtF,oFAAoF;IACpF,sFAAsF;IACtF,MAAM,KAAK,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC;IACnD,MAAM,MAAM,GAAG,IAAI,GAAG,CAAY,WAAW,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IAC7E,KAAK,MAAM,CAAC,IAAI,EAAE,GAAG,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QAC9C,MAAM,QAAQ,GAAI,GAAG,EAAE,OAA4C,EAAE,MAAM,CAAC;QAC5E,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,WAAW,CAAC,QAAQ,CAAC;YAAE,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;IAClF,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,MAAM,EAAE,CAAC;QACxB,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;QACxB,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,CAAU,EAAE,CAAC;YAC9D,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,IAAe,EAAQ,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,gBAAgB,CAAC,CAAC;QACnG,CAAC;IACL,CAAC;IAED,kFAAkF;IAClF,qFAAqF;IACrF,oFAAoF;IACpF,mFAAmF;IACnF,oDAAoD;IACpD,MAAM,UAAU,GAAG,SAAS,CAAC,SAAS,CAAC,CAAC;IACxC,IAAI,OAAO,GAAG,KAAK,CAAC;IACpB,MAAM,KAAK,GAAG,CAAC,KAAuB,EAAE,EAAE,CAAC,CAAC,GAAG,IAAe,EAAQ,EAAE;QACpE,IAAI,OAAO,EAAE,CAAC;YACV,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7C,OAAO;QACX,CAAC;QACD,OAAO,GAAG,IAAI,CAAC;QACf,IAAI,CAAC;YACD,UAAU,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC;QACvC,CAAC;gBAAS,CAAC;YACP,OAAO,GAAG,KAAK,CAAC;QACpB,CAAC;IACL,CAAC,CAAC;IACF,OAAO,CAAC,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC;IAC5B,OAAO,CAAC,IAAI,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC;IAC7B,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,OAAO,CAAC,CAAC;AACnC,CAAC;AAED,wFAAwF;AACxF,SAAS,SAAS,CAAC,IAAe;IAC9B,OAAO,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE;QAClB,IAAI,OAAO,GAAG,KAAK,QAAQ;YAAE,OAAO,GAAG,CAAC;QACxC,IAAI,CAAC;YAAC,OAAO,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,IAAI,MAAM,CAAC,GAAG,CAAC,CAAC;QAAC,CAAC;QAC/D,MAAM,CAAC;YAAC,OAAO,kBAAkB,CAAC;QAAC,CAAC;IACxC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AACjB,CAAC;AAED;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,SAAS,CAAC,IAAY;IAClC,OAAO,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC;AAC5B,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sonisoft/now-sdk-ext-mcp",
-  "version": "4.8.2",
+  "version": "4.8.3",
   "description": "MCP server for interacting with ServiceNow instances via @sonisoft/now-sdk-ext-core",
   "keywords": [
     "servicenow",