@sonisoft/now-sdk-ext-core 5.3.0 → 6.1.0

package/dist/util/LogConfig.js

@@ -0,0 +1,387 @@
+/**
+ * Where logging goes, and whether it happens at all.
+ *
+ * The bug this exists for (NEX-3): `Logger` built four Winston File transports at
+ * hard-coded RELATIVE paths, with no console transport and no injectable destination.
+ * Winston's File transport mkdirs in its own constructor, so merely constructing a
+ * Logger created `./logs/` — in whatever directory the process happened to start in.
+ * For a published library that is the consumer's project directory; for the MCP server
+ * it is whatever cwd its client chose. There was no way to turn it off.
+ *
+ * Configuration is process-global rather than constructor-injected because there are
+ * ~43 field initializers of the form `private _logger = new Logger("FlowManager")`,
+ * none of which receive arguments. Threading options through them would mean changing
+ * every manager constructor. The consuming application configures once at boot; the
+ * library reads its own environment so that a Logger used BEFORE that call still
+ * behaves — which makes boot order an optimization rather than a correctness
+ * requirement, and is what lets this work under Jest.
+ */
+import * as winston from "winston";
+import { homedir, tmpdir } from "os";
+import { join } from "path";
+import { redactValue, isSecretKey, redactMessage, REDACTED } from "./redact.js";
+const { combine, timestamp, json, metadata, printf } = winston.format;
+/** Directory name used under whichever per-user state root applies. */
+const APP_DIR = "now-sdk-ext";
+/** Winston's npm levels, which are the only levels the transports understand. */
+const VALID_LEVELS = Object.keys(winston.config.npm.levels);
+/**
+ * `trace` is not a winston level, but the CLI has always offered it. Left unmapped it
+ * does not merely fail validation: a transport with no explicit level compares against
+ * an undefined threshold and drops EVERY record, while level-pinned transports keep
+ * working. Partial and invisible, which is worse than rejecting it.
+ */
+const LEVEL_ALIASES = {
+    trace: "silly",
+    verbose: "verbose",
+    warning: "warn",
+    err: "error",
+};
+let explicit = {};
+let resolved;
+let root;
+let epochCounter = 0;
+const warnedOnce = new Set();
+/** Resolves when `event` fires, and never rejects. */
+function once(emitter, event) {
+    return new Promise((resolveOnce) => emitter.once(event, () => resolveOnce()));
+}
+function delay(ms) {
+    return new Promise((resolveDelay) => {
+        const timer = setTimeout(resolveDelay, ms);
+        // Must not hold the process open just because a flush is pending.
+        timer.unref?.();
+    });
+}
+/**
+ * Yields until the logger stream has no records left queued, bounded.
+ *
+ * A single `setImmediate` moves exactly one record through the Transform, so a burst
+ * logged in one tick needs one turn each.
+ */
+async function settle(turns) {
+    for (let i = 0; i < turns; i++) {
+        await new Promise((resolveTick) => setImmediate(resolveTick));
+    }
+}
+/** True while a File transport still has bytes it has not handed to the OS. */
+function fileTransportBusy(transport) {
+    const t = transport;
+    return Boolean(t._opening) || Boolean(t._drain) || (t._pendingSize ?? 0) > 0;
+}
+/** Complains to stderr at most once per distinct problem. */
+function warnOnce(key, message) {
+    if (warnedOnce.has(key)) {
+        return;
+    }
+    warnedOnce.add(key);
+    process.stderr.write(`[now-sdk-ext] ${message}\n`);
+}
+/** Matches sn-credstore's `envFlag` exactly, so the two packages agree on truthiness. */
+function envFlag(name) {
+    const value = process.env[name];
+    if (value === undefined) {
+        return undefined;
+    }
+    return value !== "" && value !== "0" && value.toLowerCase() !== "false";
+}
+function normalizeLevel(level, source) {
+    if (!level) {
+        return undefined;
+    }
+    const lowered = level.trim().toLowerCase();
+    const mapped = LEVEL_ALIASES[lowered] ?? lowered;
+    if (!VALID_LEVELS.includes(mapped)) {
+        warnOnce(`level:${mapped}`, `ignoring unknown log level "${level}" from ${source}`);
+        return undefined;
+    }
+    return mapped;
+}
+/**
+ * The user's home directory, or undefined if there isn't a usable one.
+ *
+ * Reads the environment before falling back to `os.homedir()`, which is what homedir()
+ * itself does on both POSIX and Windows — so this is the same answer, reachable from a
+ * test. A daemon with no HOME gets "/" back, and `join("/", ".local", …)` is an EACCES
+ * waiting to happen on the first write.
+ */
+function resolveHome() {
+    let raw;
+    try {
+        raw = (process.platform === "win32" ? process.env.USERPROFILE : process.env.HOME) ?? homedir();
+    }
+    catch {
+        return undefined;
+    }
+    const trimmed = raw?.trim();
+    if (!trimmed || trimmed === "/" || trimmed === ".") {
+        return undefined;
+    }
+    return trimmed;
+}
+/**
+ * Per-user state directory for logs.
+ *
+ * XDG_STATE_HOME is honoured on every platform, not just Linux. That is deliberate: it
+ * makes the whole thing testable with one environment variable and no mocking, and it
+ * matches how sn-credstore resolves its own state.
+ */
+export function defaultLogDir() {
+    const xdg = process.env.XDG_STATE_HOME?.trim();
+    if (xdg) {
+        return join(xdg, APP_DIR, "logs");
+    }
+    const home = resolveHome();
+    if (!home) {
+        return join(tmpdir(), APP_DIR, "logs");
+    }
+    if (process.platform === "win32") {
+        const localAppData = process.env.LOCALAPPDATA?.trim() || join(home, "AppData", "Local");
+        return join(localAppData, APP_DIR, "Logs");
+    }
+    if (process.platform === "darwin") {
+        return join(home, "Library", "Logs", APP_DIR);
+    }
+    return join(home, ".local", "state", APP_DIR, "logs");
+}
+function resolve() {
+    if (resolved) {
+        return resolved;
+    }
+    const envDir = process.env.NEX_LOG_DIR?.trim() || undefined;
+    const envFile = envFlag("NEX_LOG_FILE");
+    const envLevel = normalizeLevel(process.env.NEX_LOG_LEVEL, "NEX_LOG_LEVEL");
+    const dir = explicit.dir ?? envDir ?? defaultLogDir();
+    // A directory alone implies enable. Without that, `--log-dir ./logs` produces
+    // nothing and looks like a bug in the flag rather than a missing second flag.
+    const impliedByDir = explicit.dir !== undefined || envDir !== undefined;
+    const file = explicit.file ?? envFile ?? (impliedByDir ? true : false);
+    const level = normalizeLevel(explicit.level, "configureLogging") ?? envLevel ?? "info";
+    const consoleLevel = normalizeLevel(explicit.consoleLevel, "configureLogging") ?? "warn";
+    resolved = Object.freeze({
+        file,
+        dir,
+        level,
+        console: explicit.console ?? true,
+        consoleLevel,
+        maxSizeBytes: explicit.maxSizeBytes ?? 10 * 1024 * 1024,
+        maxFiles: explicit.maxFiles ?? 5,
+    });
+    return resolved;
+}
+/**
+ * Strips credential material from every record.
+ *
+ * Applied as a format rather than fixed at each call site on purpose. There are ~40
+ * logging calls across src/, several of which pass whole request configs and session
+ * objects, and the set grows. Auditing call sites catches today's leaks and none of
+ * tomorrow's; a format in the pipeline catches both.
+ *
+ * The specific leak that motivated it: RequestHandler built `{auth: this._session}` and
+ * logged it at debug on every single request, writing live cookies and tokens to disk.
+ */
+const redactSecrets = winston.format((info) => {
+    if (typeof info.message === "string") {
+        info.message = redactMessage(info.message);
+    }
+    for (const key of Object.keys(info)) {
+        if (key === "level" || key === "message" || key === "timestamp" || key === "label") {
+            continue;
+        }
+        if (isSecretKey(key)) {
+            info[key] = REDACTED;
+            continue;
+        }
+        info[key] = redactValue(info[key]);
+    }
+    return info;
+});
+/** Human-shaped single line for stderr. */
+const consoleLine = printf((info) => {
+    const meta = info.metadata;
+    const label = typeof info.label === "string" ? info.label : "-";
+    let tail = "";
+    if (meta && Object.keys(meta).length > 0) {
+        try {
+            tail = ` ${JSON.stringify(meta)}`;
+        }
+        catch {
+            tail = " [unserializable]";
+        }
+    }
+    // Both are `unknown` on the info object; stringify defensively rather than trusting
+    // a shape, because a caller can log anything.
+    const stamp = typeof info.timestamp === "string" ? info.timestamp : "";
+    const text = typeof info.message === "string" ? info.message : JSON.stringify(info.message);
+    return `${stamp} [${label}] ${info.level}: ${text}${tail}`;
+});
+function buildFileTransport(cfg) {
+    try {
+        return new winston.transports.File({
+            filename: join(cfg.dir, "nex.log"),
+            maxsize: cfg.maxSizeBytes,
+            maxFiles: cfg.maxFiles,
+            // Keep the newest data in nex.log, which is what `tail -f` users expect.
+            tailable: true,
+            format: combine(timestamp(), json()),
+        });
+    }
+    catch (e) {
+        // mkdirSync runs inside the File transport constructor and precedes its own
+        // `lazy` handling, so EACCES/EROFS/ENOSPC lands here. Degrade to console rather
+        // than throwing out of whatever business call happened to log first.
+        const reason = e instanceof Error ? e.message : String(e);
+        warnOnce("filetransport", `file logging disabled: ${reason}`);
+        return undefined;
+    }
+}
+/**
+ * The one winston logger for the process.
+ *
+ * Shared rather than per-`Logger` because rotation requires it: each File transport
+ * tracks its own size and rotates independently, so N transports on one path interleave
+ * renames and lose lines. It also fixes an fd leak — `ServiceNowRequest` is constructed
+ * per HTTP call, and each one used to open four more append streams that were never
+ * closed. That is where the 120 MB came from.
+ */
+export function getRootLogger() {
+    if (root) {
+        return root;
+    }
+    const cfg = resolve();
+    const transports = [];
+    if (cfg.file) {
+        const fileTransport = buildFileTransport(cfg);
+        if (fileTransport) {
+            transports.push(fileTransport);
+        }
+    }
+    // Stream, not Console. transports.Console routes by a stderrLevels MAP and falls
+    // through to stdout for any level absent from it, so it is a denylist by omission —
+    // one added level and MCP's JSON-RPC framing on fd 1 is corrupted. Stream writes
+    // where it is told.
+    transports.push(new winston.transports.Stream({
+        stream: process.stderr,
+        level: cfg.consoleLevel,
+        silent: !cfg.console,
+        format: consoleLine,
+    }));
+    root = winston.createLogger({
+        level: cfg.level,
+        format: combine(
+        // First in the chain: redact before anything reshapes, nests, or serializes
+        // the entry, so no later format can capture a raw value.
+        redactSecrets(), timestamp({ format: "YYYY-MM-DD HH:mm:ss" }), metadata({ fillExcept: ["message", "level", "timestamp", "label"] })),
+        // Never an empty transport array: winston console.error's the RAW info object
+        // when a logger has no transports, and it does so BEFORE the format chain runs,
+        // so redaction never happens. "Off" is a silent transport.
+        transports,
+        exitOnError: false,
+    });
+    return root;
+}
+/** Bumped whenever configuration changes, so live `Logger` facades pick up the new root. */
+export function logEpoch() {
+    return epochCounter;
+}
+/**
+ * Sets logging options for the process. Call once, early, from the application that
+ * owns the entry point — not from a library.
+ *
+ * Unset fields keep whatever the environment or the defaults provide, so a consumer can
+ * set only what it knows about.
+ */
+export function configureLogging(options = {}) {
+    explicit = { ...explicit, ...options };
+    resolved = undefined;
+    const previous = root;
+    root = undefined;
+    epochCounter++;
+    if (previous) {
+        // Close rather than drop, or every reconfigure leaks a file stream.
+        try {
+            previous.close();
+        }
+        catch {
+            // Closing is best-effort; a failure here must not break configuration.
+        }
+    }
+}
+export function getLogConfig() {
+    return resolve();
+}
+/**
+ * Waits for buffered records to reach disk.
+ *
+ * Winston's File transport buffers, and `process.exit()` drops whatever is pending. A
+ * library cannot register `process.on('exit')` for this because that handler cannot be
+ * async, so the application calls this before exiting.
+ */
+export async function flushLogs() {
+    if (!root) {
+        return;
+    }
+    const current = root;
+    // Let the pipeline settle first, and do not remove this. A winston Logger is a
+    // Transform stream, and records written in the current tick have not reached the
+    // transports yet — calling end() straight after a .info() truncates the pipeline and
+    // those records are lost. The documented `logger.on('finish'); logger.end()` idiom
+    // silently drops the very last lines without this, which are exactly the lines
+    // anyone flushing before exit most wants. One turn moves roughly one record, so give
+    // the pipeline several before looking at what the transports still owe.
+    await settle(8);
+    // A File transport opens its file asynchronously and buffers writes until it does.
+    // When the transport was built lazily by the very call being flushed — the common
+    // case for a short CLI command — ending here would discard that buffer, so wait for
+    // the file to actually be open first.
+    const fileTransports = current.transports.filter((t) => t instanceof winston.transports.File);
+    // Then wait for what the transports still owe. `_pendingSize` is winston's own count
+    // of bytes written but not yet acknowledged, `_opening` means writes are queued
+    // behind the file open, `_drain` means the OS buffer is full (file.js:86-90,
+    // 129-135, 213-220). Probing for `_stream` instead does not work — it is assigned
+    // synchronously inside open(), so it is already set while writes are still queued.
+    const deadline = Date.now() + 1500;
+    while (Date.now() < deadline && fileTransports.some(fileTransportBusy)) {
+        await delay(10);
+    }
+    await settle(2);
+    // The logger's own `finish` is not enough. It fires when the logger stream ends,
+    // which is before each File transport has drained to disk — so a flush that waits
+    // only on the logger returns with the file still empty.
+    const waiters = [
+        once(current, "finish"),
+        ...fileTransports.map((t) => once(t, "finish")),
+    ];
+    current.end();
+    // Bounded: a transport with nothing buffered may never emit, and a flush that can
+    // hang is worse than one that returns early.
+    await Promise.race([Promise.all(waiters), delay(2000)]);
+    if (root === current) {
+        root = undefined;
+        // Bump the epoch as well, exactly as configureLogging and resetLoggingForTests
+        // do. Dropping `root` alone is not enough: a Logger that already cached this
+        // instance sees an unchanged epoch, keeps the reference, and its next call is a
+        // write to an ended stream — which THROWS ("write after end"), losing the whole
+        // call rather than just the line. flushLogs is public API meant to be callable
+        // mid-process, not only on the way out.
+        epochCounter++;
+    }
+}
+/** Drops all configuration and the built logger. Test seam. */
+export function resetLoggingForTests() {
+    explicit = {};
+    resolved = undefined;
+    const previous = root;
+    root = undefined;
+    epochCounter++;
+    warnedOnce.clear();
+    if (previous) {
+        try {
+            previous.close();
+        }
+        catch {
+            // best effort
+        }
+    }
+}
+//# sourceMappingURL=LogConfig.js.map

package/dist/util/LogConfig.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"LogConfig.js","sourceRoot":"","sources":["../../src/util/LogConfig.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;GAiBG;AAEH,OAAO,KAAK,OAAO,MAAM,SAAS,CAAC;AACnC,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AACrC,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,WAAW,EAAE,WAAW,EAAE,aAAa,EAAE,QAAQ,EAAE,MAAM,UAAU,CAAC;AAE7E,MAAM,EAAE,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,MAAM,CAAC;AAEtE,uEAAuE;AACvE,MAAM,OAAO,GAAG,aAAa,CAAC;AAE9B,iFAAiF;AACjF,MAAM,YAAY,GAAG,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;AAE5D;;;;;GAKG;AACH,MAAM,aAAa,GAAqC;IACpD,KAAK,EAAE,OAAO;IACd,OAAO,EAAE,SAAS;IAClB,OAAO,EAAE,MAAM;IACf,GAAG,EAAE,OAAO;CACf,CAAC;AA6BF,IAAI,QAAQ,GAAe,EAAE,CAAC;AAC9B,IAAI,QAAuC,CAAC;AAC5C,IAAI,IAAgC,CAAC;AACrC,IAAI,YAAY,GAAG,CAAC,CAAC;AACrB,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;AAErC,sDAAsD;AACtD,SAAS,IAAI,CAAC,OAAyD,EAAE,KAAa;IAClF,OAAO,IAAI,OAAO,CAAO,CAAC,WAAW,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,EAAE,GAAG,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC;AACxF,CAAC;AAED,SAAS,KAAK,CAAC,EAAU;IACrB,OAAO,IAAI,OAAO,CAAO,CAAC,YAAY,EAAE,EAAE;QACtC,MAAM,KAAK,GAAG,UAAU,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;QAC3C,kEAAkE;QAClE,KAAK,CAAC,KAAK,EAAE,EAAE,CAAC;IACpB,CAAC,CAAC,CAAC;AACP,CAAC;AAED;;;;;GAKG;AACH,KAAK,UAAU,MAAM,CAAC,KAAa;IAC/B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,CAAC,EAAE,EAAE,CAAC;QAC7B,MAAM,IAAI,OAAO,CAAO,CAAC,WAAW,EAAE,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC;IACxE,CAAC;AACL,CAAC;AAED,+EAA+E;AAC/E,SAAS,iBAAiB,CAAC,SAAkB;IACzC,MAAM,CAAC,GAAG,SAA4E,CAAC;IACvF,OAAO,OAAO,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,YAAY,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;AACjF,CAAC;AAED,6DAA6D;AAC7D,SAAS,QAAQ,CAAC,GAAW,EAAE,OAAe;IAC1C,IAAI,UAAU,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;QACtB,OAAO;IACX,CAAC;IACD,UAAU,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;IACpB,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,iBAAiB,OAAO,IAAI,CAAC,CAAC;AACvD,CAAC;AAED,yFAAyF;AACzF,SAAS,OAAO,CAAC,IAAY;IACzB,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;IAChC,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;QACtB,OAAO,SAAS,CAAC;IACrB,CAAC;IACD,OAAO,KAAK,KAAK,EAAE,IAAI,KAAK,KAAK,GAAG,IAAI,KAAK,CAAC,WAAW,EAAE,KAAK,OAAO,CAAC;AAC5E,CAAC;AAED,SAAS,cAAc,CAAC,KAAyB,EAAE,MAAc;IAC7D,IAAI,CAAC,KAAK,EAAE,CAAC;QACT,OAAO,SAAS,CAAC;IACrB,CAAC;IACD,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;IAC3C,MAAM,MAAM,GAAG,aAAa,CAAC,OAAO,CAAC,IAAI,OAAO,CAAC;IACjD,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;QACjC,QAAQ,CAAC,SAAS,MAAM,EAAE,EAAE,+BAA+B,KAAK,UAAU,MAAM,EAAE,CAAC,CAAC;QACpF,OAAO,SAAS,CAAC;IACrB,CAAC;IACD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;;;;GAOG;AACH,SAAS,WAAW;IAChB,IAAI,GAAuB,CAAC;IAC5B,IAAI,CAAC;QACD,GAAG,GAAG,CAAC,OAAO,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,OAAO,EAAE,CAAC;IACnG,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,SAAS,CAAC;IACrB,CAAC;IACD,MAAM,OAAO,GAAG,GAAG,EAAE,IAAI,EAAE,CAAC;IAC5B,IAAI,CAAC,OAAO,IAAI,OAAO,KAAK,GAAG,IAAI,OAAO,KAAK,GAAG,EAAE,CAAC;QACjD,OAAO,SAAS,CAAC;IACrB,CAAC;IACD,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,aAAa;IACzB,MAAM,GAAG,GAAG,OAAO,CAAC,GAAG,CAAC,cAAc,EAAE,IAAI,EAAE,CAAC;IAC/C,IAAI,GAAG,EAAE,CAAC;QACN,OAAO,IAAI,CAAC,GAAG,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;IACtC,CAAC;IAED,MAAM,IAAI,GAAG,WAAW,EAAE,CAAC;IAC3B,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,OAAO,IAAI,CAAC,MAAM,EAAE,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;IAC3C,CAAC;IACD,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,EAAE,CAAC;QAC/B,MAAM,YAAY,GAAG,OAAO,CAAC,GAAG,CAAC,YAAY,EAAE,IAAI,EAAE,IAAI,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QACxF,OAAO,IAAI,CAAC,YAAY,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;IAC/C,CAAC;IACD,IAAI,OAAO,CAAC,QAAQ,KAAK,QAAQ,EAAE,CAAC;QAChC,OAAO,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,MAAM,EAAE,OAAO,CAAC,CAAC;IAClD,CAAC;IACD,OAAO,IAAI,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;AAC1D,CAAC;AAED,SAAS,OAAO;IACZ,IAAI,QAAQ,EAAE,CAAC;QACX,OAAO,QAAQ,CAAC;IACpB,CAAC;IAED,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,WAAW,EAAE,IAAI,EAAE,IAAI,SAAS,CAAC;IAC5D,MAAM,OAAO,GAAG,OAAO,CAAC,cAAc,CAAC,CAAC;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,OAAO,CAAC,GAAG,CAAC,aAAa,EAAE,eAAe,CAAC,CAAC;IAE5E,MAAM,GAAG,GAAG,QAAQ,CAAC,GAAG,IAAI,MAAM,IAAI,aAAa,EAAE,CAAC;IAEtD,8EAA8E;IAC9E,8EAA8E;IAC9E,MAAM,YAAY,GAAG,QAAQ,CAAC,GAAG,KAAK,SAAS,IAAI,MAAM,KAAK,SAAS,CAAC;IACxE,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,IAAI,OAAO,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC;IAEvE,MAAM,KAAK,GAAG,cAAc,CAAC,QAAQ,CAAC,KAAK,EAAE,kBAAkB,CAAC,IAAI,QAAQ,IAAI,MAAM,CAAC;IACvF,MAAM,YAAY,GACd,cAAc,CAAC,QAAQ,CAAC,YAAY,EAAE,kBAAkB,CAAC,IAAI,MAAM,CAAC;IAExE,QAAQ,GAAG,MAAM,CAAC,MAAM,CAAC;QACrB,IAAI;QACJ,GAAG;QACH,KAAK;QACL,OAAO,EAAE,QAAQ,CAAC,OAAO,IAAI,IAAI;QACjC,YAAY;QACZ,YAAY,EAAE,QAAQ,CAAC,YAAY,IAAI,EAAE,GAAG,IAAI,GAAG,IAAI;QACvD,QAAQ,EAAE,QAAQ,CAAC,QAAQ,IAAI,CAAC;KACnC,CAAC,CAAC;IACH,OAAO,QAAQ,CAAC;AACpB,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,aAAa,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE;IAC1C,IAAI,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;QACnC,IAAI,CAAC,OAAO,GAAG,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC/C,CAAC;IACD,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QAClC,IAAI,GAAG,KAAK,OAAO,IAAI,GAAG,KAAK,SAAS,IAAI,GAAG,KAAK,WAAW,IAAI,GAAG,KAAK,OAAO,EAAE,CAAC;YACjF,SAAS;QACb,CAAC;QACD,IAAI,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC;YAClB,IAAgC,CAAC,GAAG,CAAC,GAAG,QAAQ,CAAC;YAClD,SAAS;QACb,CAAC;QACA,IAAgC,CAAC,GAAG,CAAC,GAAG,WAAW,CAC/C,IAAgC,CAAC,GAAG,CAAC,CACzC,CAAC;IACN,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC,CAAC,CAAC;AAEH,2CAA2C;AAC3C,MAAM,WAAW,GAAG,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE;IAChC,MAAM,IAAI,GAAG,IAAI,CAAC,QAA+C,CAAC;IAClE,MAAM,KAAK,GAAG,OAAO,IAAI,CAAC,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC;IAChE,IAAI,IAAI,GAAG,EAAE,CAAC;IACd,IAAI,IAAI,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACvC,IAAI,CAAC;YACD,IAAI,GAAG,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,EAAE,CAAC;QACtC,CAAC;QAAC,MAAM,CAAC;YACL,IAAI,GAAG,mBAAmB,CAAC;QAC/B,CAAC;IACL,CAAC;IACD,oFAAoF;IACpF,8CAA8C;IAC9C,MAAM,KAAK,GAAG,OAAO,IAAI,CAAC,SAAS,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC;IACvE,MAAM,IAAI,GAAG,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC5F,OAAO,GAAG,KAAK,KAAK,KAAK,KAAK,IAAI,CAAC,KAAK,KAAK,IAAI,GAAG,IAAI,EAAE,CAAC;AAC/D,CAAC,CAAC,CAAC;AAEH,SAAS,kBAAkB,CAAC,GAAsB;IAC9C,IAAI,CAAC;QACD,OAAO,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;YAC/B,QAAQ,EAAE,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,SAAS,CAAC;YAClC,OAAO,EAAE,GAAG,CAAC,YAAY;YACzB,QAAQ,EAAE,GAAG,CAAC,QAAQ;YACtB,yEAAyE;YACzE,QAAQ,EAAE,IAAI;YACd,MAAM,EAAE,OAAO,CAAC,SAAS,EAAE,EAAE,IAAI,EAAE,CAAC;SACvC,CAAC,CAAC;IACP,CAAC;IAAC,OAAO,CAAC,EAAE,CAAC;QACT,4EAA4E;QAC5E,gFAAgF;QAChF,qEAAqE;QACrE,MAAM,MAAM,GAAG,CAAC,YAAY,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QAC1D,QAAQ,CAAC,eAAe,EAAE,0BAA0B,MAAM,EAAE,CAAC,CAAC;QAC9D,OAAO,SAAS,CAAC;IACrB,CAAC;AACL,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,aAAa;IACzB,IAAI,IAAI,EAAE,CAAC;QACP,OAAO,IAAI,CAAC;IAChB,CAAC;IACD,MAAM,GAAG,GAAG,OAAO,EAAE,CAAC;IACtB,MAAM,UAAU,GAAwB,EAAE,CAAC;IAE3C,IAAI,GAAG,CAAC,IAAI,EAAE,CAAC;QACX,MAAM,aAAa,GAAG,kBAAkB,CAAC,GAAG,CAAC,CAAC;QAC9C,IAAI,aAAa,EAAE,CAAC;YAChB,UAAU,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;QACnC,CAAC;IACL,CAAC;IAED,iFAAiF;IACjF,oFAAoF;IACpF,iFAAiF;IACjF,oBAAoB;IACpB,UAAU,CAAC,IAAI,CACX,IAAI,OAAO,CAAC,UAAU,CAAC,MAAM,CAAC;QAC1B,MAAM,EAAE,OAAO,CAAC,MAAM;QACtB,KAAK,EAAE,GAAG,CAAC,YAAY;QACvB,MAAM,EAAE,CAAC,GAAG,CAAC,OAAO;QACpB,MAAM,EAAE,WAAW;KACtB,CAAC,CACL,CAAC;IAEF,IAAI,GAAG,OAAO,CAAC,YAAY,CAAC;QACxB,KAAK,EAAE,GAAG,CAAC,KAAK;QAChB,MAAM,EAAE,OAAO;QACX,4EAA4E;QAC5E,yDAAyD;QACzD,aAAa,EAAE,EACf,SAAS,CAAC,EAAE,MAAM,EAAE,qBAAqB,EAAE,CAAC,EAC5C,QAAQ,CAAC,EAAE,UAAU,EAAE,CAAC,SAAS,EAAE,OAAO,EAAE,WAAW,EAAE,OAAO,CAAC,EAAE,CAAC,CACvE;QACD,8EAA8E;QAC9E,gFAAgF;QAChF,2DAA2D;QAC3D,UAAU;QACV,WAAW,EAAE,KAAK;KACrB,CAAC,CAAC;IACH,OAAO,IAAI,CAAC;AAChB,CAAC;AAED,4FAA4F;AAC5F,MAAM,UAAU,QAAQ;IACpB,OAAO,YAAY,CAAC;AACxB,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,gBAAgB,CAAC,UAAsB,EAAE;IACrD,QAAQ,GAAG,EAAE,GAAG,QAAQ,EAAE,GAAG,OAAO,EAAE,CAAC;IACvC,QAAQ,GAAG,SAAS,CAAC;IACrB,MAAM,QAAQ,GAAG,IAAI,CAAC;IACtB,IAAI,GAAG,SAAS,CAAC;IACjB,YAAY,EAAE,CAAC;IACf,IAAI,QAAQ,EAAE,CAAC;QACX,oEAAoE;QACpE,IAAI,CAAC;YACD,QAAQ,CAAC,KAAK,EAAE,CAAC;QACrB,CAAC;QAAC,MAAM,CAAC;YACL,uEAAuE;QAC3E,CAAC;IACL,CAAC;AACL,CAAC;AAED,MAAM,UAAU,YAAY;IACxB,OAAO,OAAO,EAAE,CAAC;AACrB,CAAC;AAED;;;;;;GAMG;AACH,MAAM,CAAC,KAAK,UAAU,SAAS;IAC3B,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,OAAO;IACX,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC;IAErB,+EAA+E;IAC/E,iFAAiF;IACjF,qFAAqF;IACrF,mFAAmF;IACnF,+EAA+E;IAC/E,qFAAqF;IACrF,wEAAwE;IACxE,MAAM,MAAM,CAAC,CAAC,CAAC,CAAC;IAEhB,mFAAmF;IACnF,kFAAkF;IAClF,oFAAoF;IACpF,sCAAsC;IACtC,MAAM,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,MAAM,CAC5C,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,YAAY,OAAO,CAAC,UAAU,CAAC,IAAI,CAC9C,CAAC;IACF,qFAAqF;IACrF,gFAAgF;IAChF,6EAA6E;IAC7E,kFAAkF;IAClF,mFAAmF;IACnF,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC;IACnC,OAAO,IAAI,CAAC,GAAG,EAAE,GAAG,QAAQ,IAAI,cAAc,CAAC,IAAI,CAAC,iBAAiB,CAAC,EAAE,CAAC;QACrE,MAAM,KAAK,CAAC,EAAE,CAAC,CAAC;IACpB,CAAC;IACD,MAAM,MAAM,CAAC,CAAC,CAAC,CAAC;IAEhB,iFAAiF;IACjF,kFAAkF;IAClF,wDAAwD;IACxD,MAAM,OAAO,GAAoB;QAC7B,IAAI,CAAC,OAAO,EAAE,QAAQ,CAAC;QACvB,GAAG,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;KAClD,CAAC;IAEF,OAAO,CAAC,GAAG,EAAE,CAAC;IACd,kFAAkF;IAClF,6CAA6C;IAC7C,MAAM,OAAO,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAExD,IAAI,IAAI,KAAK,OAAO,EAAE,CAAC;QACnB,IAAI,GAAG,SAAS,CAAC;QACjB,+EAA+E;QAC/E,6EAA6E;QAC7E,gFAAgF;QAChF,gFAAgF;QAChF,+EAA+E;QAC/E,wCAAwC;QACxC,YAAY,EAAE,CAAC;IACnB,CAAC;AACL,CAAC;AAED,+DAA+D;AAC/D,MAAM,UAAU,oBAAoB;IAChC,QAAQ,GAAG,EAAE,CAAC;IACd,QAAQ,GAAG,SAAS,CAAC;IACrB,MAAM,QAAQ,GAAG,IAAI,CAAC;IACtB,IAAI,GAAG,SAAS,CAAC;IACjB,YAAY,EAAE,CAAC;IACf,UAAU,CAAC,KAAK,EAAE,CAAC;IACnB,IAAI,QAAQ,EAAE,CAAC;QACX,IAAI,CAAC;YACD,QAAQ,CAAC,KAAK,EAAE,CAAC;QACrB,CAAC;QAAC,MAAM,CAAC;YACL,cAAc;QAClB,CAAC;IACL,CAAC;AACL,CAAC"}

package/dist/util/Logger.d.ts

@@ -1,33 +1,55 @@
 import * as winston from "winston";
+/**
+ * A named handle onto the process-wide logger.
+ *
+ * This used to build its own winston logger with four File transports per instance. It
+ * no longer builds anything: there are ~43 of these across the codebase, and
+ * `ServiceNowRequest` is constructed per HTTP call, so each request was opening four
+ * more never-closed append streams. That is where the 120 MB of logs came from, and it
+ * also made rotation impossible — File transports track size independently, so several
+ * on one path interleave renames and lose lines.
+ *
+ * Destination, level, and rotation now live in LogConfig and are set once by the
+ * application. See `configureLogging`.
+ */
 export declare class Logger {
+    _labelName: string;
+    /** Set only by `setLogger`. Overrides the shared root for this instance. */
+    private _override?;
+    private _cached?;
+    private _epochSeen;
     /**
-     * Strips credential material from every log entry.
-     *
-     * Applied as a format rather than fixed at each call site on purpose. There are
-     * ~40 logging calls across src/, several of which pass whole request configs and
-     * session objects, and the set grows. Auditing call sites catches today's leaks
-     * and none of tomorrow's; a format in the pipeline catches both.
-     *
-     * The specific leak that motivated it: RequestHandler built `{auth: this._session}`
-     * and logged it at debug on every single request, writing live cookies and tokens
-     * to logs/app-debug.log.
+     * @param labelName Appears as `label` on every record from this instance.
+     * @param level Ignored. Kept so existing call sites still compile.
+     * @deprecated Pass the level to `configureLogging` instead — it applies process-wide.
      */
-    static redactSecrets: winston.Logform.FormatWrap;
-    static errorFilter: winston.Logform.FormatWrap;
-    static infoFilter: winston.Logform.FormatWrap;
-    static debugFilter: winston.Logform.FormatWrap;
-    _labelName: string;
-    _localLogger: winston.Logger;
-    _logLevel: string;
     constructor(labelName: string, level?: string);
+    /** Replaces the underlying winston logger for this instance only. Test seam. */
     setLogger(logger: winston.Logger): void;
     getLabel(): string;
-    private initLogger;
+    /**
+     * @deprecated The `level` argument the constructor accepts is ignored; use
+     * `configureLogging({level})`.
+     */
     static createLogger(labelName: string): Logger;
+    /** Resolves the shared root, rebuilding the cached reference if config changed. */
+    private root;
+    /**
+     * Attaches this instance's label to the record.
+     *
+     * The label used to be a winston format bound to a per-instance logger. With one
+     * shared root it has to travel with the call. Callers pass all sorts of things as
+     * `metadata`, so a non-object is nested rather than spread — spreading a string
+     * would scatter it across numeric keys.
+     */
+    private meta;
     debug(message: string, metadata?: unknown): void;
     info(message: string, metadata?: unknown): void;
     error(message: string, metadata?: unknown): void;
     warn(message: string, metadata?: unknown): void;
+    verbose(message: string, metadata?: unknown): void;
+    http(message: string, metadata?: unknown): void;
+    silly(message: string, metadata?: unknown): void;
     addInfoMessage(message: string, metadata?: unknown): void;
     addErrorMessage(message: string, metadata?: unknown): void;
     addWarnMessage(message: string, metadata?: unknown): void;

package/dist/util/Logger.js

@@ -1,115 +1,109 @@
-import * as winston from "winston";
-import { redactValue, isSecretKey, REDACTED } from "./redact.js";
-const { combine, timestamp, json, metadata, label } = winston.format;
-const { format, transports } = winston;
+import { getRootLogger, logEpoch } from "./LogConfig.js";
+/**
+ * A named handle onto the process-wide logger.
+ *
+ * This used to build its own winston logger with four File transports per instance. It
+ * no longer builds anything: there are ~43 of these across the codebase, and
+ * `ServiceNowRequest` is constructed per HTTP call, so each request was opening four
+ * more never-closed append streams. That is where the 120 MB of logs came from, and it
+ * also made rotation impossible — File transports track size independently, so several
+ * on one path interleave renames and lose lines.
+ *
+ * Destination, level, and rotation now live in LogConfig and are set once by the
+ * application. See `configureLogging`.
+ */
 export class Logger {
+    _labelName;
+    /** Set only by `setLogger`. Overrides the shared root for this instance. */
+    _override;
+    _cached;
+    _epochSeen = -1;
     /**
-     * Strips credential material from every log entry.
-     *
-     * Applied as a format rather than fixed at each call site on purpose. There are
-     * ~40 logging calls across src/, several of which pass whole request configs and
-     * session objects, and the set grows. Auditing call sites catches today's leaks
-     * and none of tomorrow's; a format in the pipeline catches both.
-     *
-     * The specific leak that motivated it: RequestHandler built `{auth: this._session}`
-     * and logged it at debug on every single request, writing live cookies and tokens
-     * to logs/app-debug.log.
+     * @param labelName Appears as `label` on every record from this instance.
+     * @param level Ignored. Kept so existing call sites still compile.
+     * @deprecated Pass the level to `configureLogging` instead — it applies process-wide.
      */
-    static redactSecrets = winston.format((info) => {
-        for (const key of Object.keys(info)) {
-            if (key === "level" || key === "message" || key === "timestamp" || key === "label") {
-                continue;
-            }
-            if (isSecretKey(key)) {
-                info[key] = REDACTED;
-                continue;
-            }
-            info[key] = redactValue(info[key]);
-        }
-        return info;
-    });
-    static errorFilter = winston.format((info) => {
-        return info.level === "error" ? info : false;
-    });
-    static infoFilter = winston.format((info) => {
-        return info.level === "info" ? info : false;
-    });
-    static debugFilter = winston.format((info) => {
-        return info.level === "debug" ? info : false;
-    });
-    _labelName;
-    _localLogger;
-    _logLevel;
-    constructor(labelName, level = "info") {
+    constructor(labelName, level) {
         this._labelName = labelName;
-        this._logLevel = level;
-        this.initLogger();
+        void level;
     }
+    /** Replaces the underlying winston logger for this instance only. Test seam. */
     setLogger(logger) {
-        this._localLogger = logger;
+        this._override = logger;
     }
     getLabel() {
         return this._labelName;
     }
-    initLogger() {
-        this._localLogger = winston.createLogger({
-            level: this._logLevel,
-            format: combine(
-            // First in the chain: redact before anything reshapes, nests, or
-            // serializes the entry, so no later format can capture a raw value.
-            Logger.redactSecrets(), label({ label: this._labelName }), timestamp({ format: "YYYY-MM-DD HH:mm:ss" }), 
-            // Format the metadata object
-            metadata({ fillExcept: ["message", "level", "timestamp", "label"] })),
-            transports: [
-                new transports.File({
-                    filename: "logs/combined.log",
-                    format: format.combine(timestamp(), format.json())
-                }),
-                new transports.File({
-                    filename: "logs/app-error.log",
-                    level: "error",
-                    format: combine(Logger.errorFilter(), timestamp(), json()),
-                }),
-                new transports.File({
-                    filename: "logs/app-info.log",
-                    level: "info",
-                    format: combine(Logger.infoFilter(), timestamp(), json()),
-                }),
-                new transports.File({
-                    filename: "logs/app-debug.log",
-                    level: "debug",
-                    format: combine(Logger.debugFilter(), timestamp(), json()),
-                }),
-            ],
-            exitOnError: false
-        });
-    }
+    /**
+     * @deprecated The `level` argument the constructor accepts is ignored; use
+     * `configureLogging({level})`.
+     */
     static createLogger(labelName) {
         return new Logger(labelName);
     }
+    /** Resolves the shared root, rebuilding the cached reference if config changed. */
+    root() {
+        if (this._override) {
+            return this._override;
+        }
+        if (this._epochSeen !== logEpoch()) {
+            this._cached = getRootLogger();
+            this._epochSeen = logEpoch();
+        }
+        return this._cached;
+    }
+    /**
+     * Attaches this instance's label to the record.
+     *
+     * The label used to be a winston format bound to a per-instance logger. With one
+     * shared root it has to travel with the call. Callers pass all sorts of things as
+     * `metadata`, so a non-object is nested rather than spread — spreading a string
+     * would scatter it across numeric keys.
+     */
+    meta(metadata) {
+        if (metadata === undefined || metadata === null) {
+            return { label: this._labelName };
+        }
+        if (typeof metadata === "object" && !Array.isArray(metadata)) {
+            // Label last, deliberately. Metadata objects here are assembled ad hoc and
+            // grow over time; a caller key named `label` would otherwise misattribute
+            // the record to a component that never emitted it.
+            return { ...metadata, label: this._labelName };
+        }
+        return { label: this._labelName, meta: metadata };
+    }
     debug(message, metadata) {
-        this._localLogger.debug(message, metadata);
+        this.root().debug(message, this.meta(metadata));
     }
     info(message, metadata) {
-        this._localLogger.info(message, metadata);
+        this.root().info(message, this.meta(metadata));
     }
     error(message, metadata) {
-        this._localLogger.error(message, metadata);
+        this.root().error(message, this.meta(metadata));
     }
     warn(message, metadata) {
-        this._localLogger.warn(message, metadata);
+        this.root().warn(message, this.meta(metadata));
+    }
+    verbose(message, metadata) {
+        this.root().verbose(message, this.meta(metadata));
+    }
+    http(message, metadata) {
+        this.root().http(message, this.meta(metadata));
+    }
+    silly(message, metadata) {
+        this.root().silly(message, this.meta(metadata));
     }
     addInfoMessage(message, metadata) {
-        this._localLogger.info(message, metadata);
+        this.info(message, metadata);
     }
     addErrorMessage(message, metadata) {
-        this._localLogger.error(message, metadata);
+        this.error(message, metadata);
     }
     addWarnMessage(message, metadata) {
-        this._localLogger.warn(message, metadata);
+        this.warn(message, metadata);
     }
     successful(message, metadata) {
-        this._localLogger.info(message, metadata);
+        this.info(message, metadata);
     }
 }
 //# sourceMappingURL=Logger.js.map