@songsid/agend 2.3.5-alpha.5 → 2.3.5-beta.1

package/dist/settings-api.js

@@ -4,16 +4,13 @@ import { DEFAULT_REPLY_TRIGGERS } from "./reply-triggers.js";
 import { PUBLIC_TUNNEL_SECRET_ID, PUBLIC_TUNNEL_TOKEN_HINT } from "./public-tunnel-config.js";
 import { withSpawnHoldReply } from "./spawn-hold-reply.js";
 import { normalizeSettingsInstancePatch, removesInstanceOverride } from "./settings-instance-patch.js";
-import { credentialProfileLogin, instanceCredentialProfile } from "./backend/credential-profile.js";
-import { isSettingsReplay, settingsRequestExecution, settingsRequestLocalAdmin, settingsRequestLocalAdminCurrent, settingsWrite } from "./settings-request-capability.js";
+import { isSettingsReplay, settingsRequestExecution, settingsWrite } from "./settings-request-capability.js";
 import { noteSettingsWrite, settingsUndo, undoSettingsPaths } from "./settings-transaction.js";
 import { readBoundedWebBody } from "./web-body.js";
 import { gatewayRequestContext } from "./web-request-context.js";
 import { applyAppearanceChanges, applyGuestsPatch, applyVerifiedAuthorityPatch, parseAppearanceSettingsBody, parseWebSettingsBody } from "./web-settings-patch.js";
 import { APPEARANCE_BOUNDS, APPEARANCE_DEFAULTS, effectiveAppearanceLimits } from "./web-appearance-limits.js";
 import { permitWebContinuation } from "./web-continuation.js";
-import { parseRuntimesSettingsBody, runtimeSettingsView } from "./runtime-switches.js";
-import { hubMembershipSettings, parseHubMembership } from "./hub-membership-settings.js";
 import { evaluateWebRequest } from "./web-auth.js";
 import { redactInlineSecrets, restoreRedactedSecrets } from "./settings-redaction.js";
 /**
@@ -99,7 +96,7 @@ function normalizeChannelIdValue(value, path) {
     return { ok: false, error: `${path} must be a string (or a safe integer)` };
 }
 export function isSettingsPath(path) {
-    return isSettingsPage(path) || path.startsWith("/api/settings/") || path.startsWith("/api/hub/member/"); // S3c: the member's Hub card
+    return isSettingsPage(path) || path.startsWith("/api/settings/");
 }
 const classicPath = (ctx) => join(ctx.dataDir, "classicBot.yaml");
 class ClassicConfigParseError extends Error {
@@ -742,73 +739,8 @@ export function handleSettingsRequest(req, res, url, ctx) {
         json(res, 200, job, true);
         return true;
     }
-    // Remaining fleet Settings routes use in-memory configuration when they mutate.
+    // Everything below mutates — needs an in-memory fleet config.
     const cfg = ctx.fleetConfig;
-    // This pure Settings surface remains available while membership is off; it imports no Hub runtime.
-    if (path === "/api/settings/hub/membership") {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "hub_settings_not_over_public_link" });
-            return true;
-        }
-        if (method === "GET") {
-            if (!guestSettingsCaller(req, url, ctx)) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            try {
-                json(res, 200, { ok: true, ...hubMembershipSettings(ctx.getRawFleetConfig()) });
-            }
-            catch {
-                json(res, 409, { ok: false, error: "invalid_hub_membership" });
-            }
-            return true;
-        }
-        if (method !== "PUT") {
-            json(res, 405, { error: "method_not_allowed" });
-            return true;
-        }
-        const execution = settingsRequestExecution(req), configPath = ctx.configPath;
-        // Enabling is confirmed; disabling uses the same gate's immediate narrowing continuation.
-        let allowed = false;
-        try {
-            allowed = !!execution && settingsRequestLocalAdmin(req);
-        }
-        catch { /* stale */ }
-        if (!allowed || !execution) {
-            json(res, 403, { error: "admin_confirmation_required" });
-            return true;
-        }
-        if (!cfg || !configPath) {
-            json(res, 503, { ok: false, error: "unavailable" });
-            return true;
-        }
-        readBody(req, 1024).then(bytes => {
-            try {
-                execution.assert();
-                if (!settingsRequestLocalAdmin(req) || ctx.fleetConfig !== cfg || ctx.configPath !== configPath)
-                    throw Error("unavailable");
-                let input;
-                try {
-                    input = parseHubMembership(JSON.parse(bytes.toString("utf8")));
-                }
-                catch {
-                    json(res, 400, { ok: false, error: "invalid_hub_membership" });
-                    return;
-                }
-                settingsWrite(req, () => {
-                    if (!settingsRequestLocalAdmin(req) || ctx.fleetConfig !== cfg || ctx.configPath !== configPath)
-                        throw Error("unavailable");
-                    hubMembershipSettings(ctx.getRawFleetConfig());
-                    ctx.saveFleetConfig([{ path: ["hub_member", "enabled"], value: input.enabled }]);
-                });
-                json(res, 200, { ok: true, ...hubMembershipSettings(ctx.getRawFleetConfig()) });
-            }
-            catch {
-                json(res, 503, { ok: false, error: "unavailable" });
-            }
-        }).catch(() => json(res, 400, { ok: false, error: "invalid_hub_membership" }));
-        return true;
-    }
     // ── Manual pause / wake ──
     const actionMatch = path.match(/^\/api\/settings\/instances\/([^/]+)\/(pause|wake)$/);
     if (method === "POST" && actionMatch) {
@@ -978,378 +910,7 @@ export function handleSettingsRequest(req, res, url, ctx) {
         }).catch(() => json(res, 400, { error: "bad request" }));
         return true;
     }
-    // S3c (S-55): the member's exposures — local owner only, never over the public link. GET the list; POST publish or
-    // revise (only as a confirmed Settings replay: the confirmation layer intercepts the first request); POST
-    // .../<id>/withdraw at once (narrowing needs no confirmation), ok once the restrictive state is saved.
-    const hubExposures = path === "/api/hub/member/exposures" ? "list" : /^\/api\/hub\/member\/exposures\/[0-9a-f-]{36}\/withdraw$/.test(path) ? "withdraw" : null;
-    if (hubExposures) {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "hub_member_not_over_public_link" });
-            return true;
-        }
-        const api = ctx.hubMemberExposures?.() ?? null;
-        if (!api) {
-            json(res, 404, { error: "unavailable" });
-            return true;
-        }
-        const refused = (err) => { const code = err.code; json(res, 409, { ok: false, error: typeof code === "string" ? code : "unsaved" }); };
-        if (hubExposures === "list" && method === "GET") {
-            if (!guestSettingsCaller(req, url, ctx)) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            try {
-                json(res, 200, { ok: true, exposures: api.list() });
-            }
-            catch (err) {
-                refused(err);
-            }
-            return true;
-        }
-        if (hubExposures === "list" && method === "POST") {
-            const execution = settingsRequestExecution(req);
-            let allowed = false;
-            try {
-                allowed = !!execution && isSettingsReplay(req) && settingsRequestLocalAdmin(req);
-            }
-            catch { /* stale */ }
-            if (!allowed || !execution) {
-                json(res, 403, { error: "admin_confirmation_required" });
-                return true;
-            }
-            readBody(req, 8192).then((bytes) => {
-                execution.assert();
-                if ((ctx.hubMemberExposures?.() ?? null) !== api) {
-                    json(res, 409, { ok: false, error: "unavailable" });
-                    return;
-                }
-                try {
-                    json(res, 200, { ok: true, view: api.publish(JSON.parse(bytes.toString("utf8"))) });
-                }
-                catch (err) {
-                    refused(err);
-                }
-            }).catch(() => json(res, 400, { ok: false, error: "unsaved" }));
-            return true;
-        }
-        if (hubExposures === "withdraw" && method === "POST") {
-            const caller = guestSettingsCaller(req, url, ctx);
-            if (!caller) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            const id = path.split("/")[5];
-            readBody(req, 4096).then(async (bytes) => {
-                // #3115 r1 P3: the same live caller (a rotated token or revoked session is no one) and the same composed member
-                // at the effect, after the body's wait.
-                if (guestSettingsCaller(req, url, ctx) !== caller) {
-                    json(res, 401, { error: "no longer authorized" });
-                    return;
-                }
-                if ((ctx.hubMemberExposures?.() ?? null) !== api) {
-                    json(res, 409, { ok: false, error: "unavailable" });
-                    return;
-                }
-                const body = JSON.parse(bytes.toString("utf8") || "{}");
-                if (!Number.isSafeInteger(body.expectedRevision)) {
-                    json(res, 400, { ok: false, error: "conflict" });
-                    return;
-                }
-                try {
-                    json(res, 200, { ok: true, ...(await api.withdraw(id, body.expectedRevision)) });
-                }
-                catch (err) {
-                    refused(err);
-                }
-            }).catch(() => json(res, 400, { ok: false, error: "unsaved" }));
-            return true;
-        }
-        json(res, 405, { error: "method_not_allowed" });
-        return true;
-    }
-    // S3c PR B: the member's pairing — GET the projection; POST connect / confirm / disconnect only as a confirmed
-    // local-admin Settings replay (its continuation is the S1 call); POST cancel at once (local only). Never over the
-    // public link; no member composed: 404 "unavailable".
-    const pairingRoute = path.match(/^\/api\/hub\/member\/pairing(?:\/(connect|confirm|disconnect|cancel))?$/);
-    if (pairingRoute) {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "hub_member_not_over_public_link" });
-            return true;
-        }
-        const api = ctx.hubMemberPairing?.() ?? null;
-        if (!api) {
-            json(res, 404, { error: "unavailable" });
-            return true;
-        }
-        const step = pairingRoute[1];
-        if (!step && method === "GET") {
-            if (!guestSettingsCaller(req, url, ctx)) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            json(res, 200, { ok: true, pairing: api.view() });
-            return true;
-        }
-        if (step === "cancel" && method === "POST") {
-            if (!guestSettingsCaller(req, url, ctx)) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            json(res, 200, { ok: true, pairing: api.cancel() });
-            return true;
-        }
-        if (step && method === "POST") {
-            const execution = settingsRequestExecution(req);
-            let allowed = false;
-            try {
-                allowed = !!execution && isSettingsReplay(req) && settingsRequestLocalAdmin(req);
-            }
-            catch { /* stale */ }
-            if (!allowed || !execution) {
-                json(res, 403, { error: "admin_confirmation_required" });
-                return true;
-            }
-            const current = () => { try {
-                execution.assert();
-                return settingsRequestLocalAdminCurrent(req);
-            }
-            catch {
-                return false;
-            } };
-            readBody(req, 4096).then(async (bytes) => {
-                execution.assert();
-                if ((ctx.hubMemberPairing?.() ?? null) !== api) {
-                    json(res, 409, { ok: false, error: "unavailable" });
-                    return;
-                }
-                const body = JSON.parse(bytes.toString("utf8") || "{}");
-                const r = step === "connect" ? await api.connect({ address: body.address, code: body.code }, current)
-                    : step === "confirm" ? await api.confirmFingerprint(body.digest, current) : await api.disconnect({ hubId: body.hubId, binding: body.binding });
-                json(res, r.ok ? 200 : 409, r);
-            }).catch(() => json(res, 400, { ok: false, error: "unsaved" }));
-            return true;
-        }
-        json(res, 405, { error: "method_not_allowed" });
-        return true;
-    }
-    if (path === "/api/settings/general-location" && (method === "GET" || method === "POST")) {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "runtime_settings_not_over_public_link" });
-            return true;
-        }
-        if (!ctx.generalLocations || !ctx.switchGeneralLocation) {
-            json(res, 404, { error: "not available" });
-            return true;
-        }
-        if (method === "GET") {
-            try {
-                json(res, 200, ctx.generalLocations());
-            }
-            catch (err) {
-                json(res, 409, { error: err.message });
-            }
-            return true;
-        }
-        const execution = settingsRequestExecution(req);
-        let allowed = false;
-        try {
-            allowed = !!execution && isSettingsReplay(req) && settingsRequestLocalAdmin(req);
-        }
-        catch { /* stale */ }
-        if (!allowed || !execution) {
-            json(res, 403, { error: "admin_confirmation_required" });
-            return true;
-        }
-        readBody(req, 8192).then(async (bytes) => {
-            execution.assert();
-            const result = await ctx.switchGeneralLocation(JSON.parse(bytes.toString("utf8")), () => settingsRequestLocalAdminCurrent(req), execution);
-            // A committed settings execution no longer authorizes writes; the scoped operation already checked its start.
-            json(res, 200, { ok: true, ...result });
-        }).catch(err => { ctx.logger.warn({ err }, "settings: General location change held"); json(res, 409, { error: err.message }); });
-        return true;
-    }
-    if (["/api/settings/hub/browser-certificate", "/api/settings/hub/browser-certificate/prepare", "/api/settings/hub/browser-certificate/apply"].includes(path)) {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "hub_settings_not_over_public_link" });
-            return true;
-        }
-        const control = ctx.hubBrowserCertificate?.() ?? null;
-        if (!control) {
-            json(res, 404, { error: "unavailable" });
-            return true;
-        }
-        const refused = (err) => {
-            const code = err instanceof Error && ["invalid_browser_certificate", "conflict", "unavailable", "browser_certificate_busy"].includes(err.message) ? err.message : "unsaved";
-            json(res, code === "invalid_browser_certificate" ? 400 : code === "conflict" ? 409 : 503, { ok: false, error: code });
-        };
-        if (path.endsWith("/apply") && method === "POST") {
-            const execution = settingsRequestExecution(req);
-            let allowed = false;
-            try {
-                allowed = !!execution && isSettingsReplay(req) && settingsRequestLocalAdmin(req);
-            }
-            catch { /* stale */ }
-            if (!allowed || !execution) {
-                json(res, 403, { error: "admin_confirmation_required" });
-                return true;
-            }
-            readBody(req, 4096).then(bytes => {
-                try {
-                    execution.assert();
-                    if (ctx.hubBrowserCertificate?.() !== control)
-                        throw Error("unavailable");
-                    const certificate = settingsWrite(req, () => control.apply(JSON.parse(bytes.toString("utf8")), requestSessionBinding(req), () => settingsRequestLocalAdmin(req) && ctx.hubBrowserCertificate?.() === control));
-                    json(res, 200, { ok: true, certificate });
-                }
-                catch (err) {
-                    refused(err);
-                }
-            }).catch(refused);
-            return true;
-        }
-        const caller = guestSettingsCaller(req, url, ctx);
-        if (!caller) {
-            json(res, 403, { error: "admin_required" });
-            return true;
-        }
-        if (path.endsWith("/prepare") && method === "POST") {
-            const binding = requestSessionBinding(req);
-            const current = () => !req.aborted && !res.destroyed && ctx.hubBrowserCertificate?.() === control
-                && guestSettingsCaller(req, url, ctx) === caller && requestSessionBinding(req) === binding;
-            readBody(req, 16 * 1024).then(async (bytes) => {
-                if (!current())
-                    throw Error("unavailable");
-                const proposal = await control.prepare(JSON.parse(bytes.toString("utf8")), binding, current);
-                if (!current())
-                    throw Error("unavailable");
-                json(res, 200, { ok: true, proposal });
-            }).catch(refused);
-            return true;
-        }
-        if (path === "/api/settings/hub/browser-certificate" && method === "GET") {
-            try {
-                json(res, 200, { ok: true, certificate: control.read() });
-            }
-            catch (err) {
-                refused(err);
-            }
-            return true;
-        }
-        json(res, 405, { error: "method_not_allowed" });
-        return true;
-    }
-    if (path === "/api/settings/hub/retention") {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "hub_settings_not_over_public_link" });
-            return true;
-        }
-        const control = ctx.hubRetention?.() ?? null;
-        if (!control) {
-            json(res, 404, { error: "unavailable" });
-            return true;
-        }
-        const refused = (err) => {
-            const code = err instanceof Error && ["invalid_retention", "conflict", "unavailable", "retention_unavailable"].includes(err.message) ? err.message : "unsaved";
-            json(res, code === "invalid_retention" ? 400 : code === "conflict" ? 409 : 503, { ok: false, error: code });
-        };
-        if (method === "GET") {
-            if (!guestSettingsCaller(req, url, ctx)) {
-                json(res, 403, { error: "admin_required" });
-                return true;
-            }
-            try {
-                json(res, 200, { ok: true, policy: control.read() });
-            }
-            catch (err) {
-                refused(err);
-            }
-            return true;
-        }
-        if (method === "PUT") {
-            const execution = settingsRequestExecution(req);
-            let allowed = false;
-            try {
-                allowed = !!execution && isSettingsReplay(req) && settingsRequestLocalAdmin(req);
-            }
-            catch { /* stale */ }
-            if (!allowed || !execution) {
-                json(res, 403, { error: "admin_confirmation_required" });
-                return true;
-            }
-            readBody(req, 4096).then(bytes => {
-                try {
-                    execution.assert();
-                    if (ctx.hubRetention?.() !== control)
-                        throw Error("unavailable");
-                    const policy = settingsWrite(req, () => control.update(JSON.parse(bytes.toString("utf8")), () => settingsRequestLocalAdmin(req) && ctx.hubRetention?.() === control));
-                    json(res, 200, { ok: true, policy });
-                }
-                catch (err) {
-                    refused(err);
-                }
-            }).catch(refused);
-            return true;
-        }
-        json(res, 405, { error: "method_not_allowed" });
-        return true;
-    }
-    // ── M-2255: Settings → Runtime's switches — "Use this PC's Windows CLIs" (runtimes.windows_cli) and "Allow other
-    // Windows computers to pair" (runtimes.remote_runtime). Off by default; the environment overrides them (said here).
-    // Never over the public link. Switching one on is confirmed by a General admin (settings-change.ts); off applies at once.
-    if (method === "GET" && path === "/api/settings/runtimes") {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "runtime_settings_not_over_public_link" });
-            return true;
-        }
-        json(res, 200, runtimeSettingsView(cfg));
-        return true;
-    }
-    if (method === "PUT" && path === "/api/settings/fleet/runtimes") {
-        if (gatewayRequestContext(req)) {
-            json(res, 403, { error: "runtime_settings_not_over_public_link" });
-            return true;
-        }
-        if (!cfg) {
-            json(res, 503, { error: "fleet not loaded" });
-            return true;
-        }
-        readBody(req, 4096).then(buf => {
-            if (!permitWebContinuation(req, res, ctx))
-                return;
-            let body;
-            try {
-                body = JSON.parse(buf.toString("utf-8"));
-            }
-            catch {
-                return json(res, 400, { error: "invalid JSON" });
-            }
-            const parsed = parseRuntimesSettingsBody(body);
-            if ("error" in parsed)
-                return json(res, parsed.status, { error: parsed.error });
-            const changes = Object.entries(parsed.patch).map(([key, value]) => ({ path: ["runtimes", key], value }));
-            if (!changes.length)
-                return json(res, 200, { ok: true });
-            const runtimes = { ...cfg.runtimes, ...parsed.patch };
-            const before = validateFleet(cfg), after = validateFleet({ ...cfg, runtimes });
-            if (rejectIfWorse(res, before, after))
-                return;
-            const previous = { runtimes: cfg.runtimes, had: "runtimes" in cfg };
-            try {
-                settingsWrite(req, () => { cfg.runtimes = runtimes; ctx.saveFleetConfig(changes); });
-            }
-            catch (err) {
-                // The save refused (fleet.yaml unchanged): memory goes back to what the file still says.
-                if (previous.had)
-                    cfg.runtimes = previous.runtimes;
-                else
-                    delete cfg.runtimes;
-                ctx.logger.warn({ err }, "settings: runtime switches save refused");
-                return json(res, 500, { ok: false, error: err.message });
-            }
-            json(res, 200, { ok: true, ...runtimeSettingsView(cfg), warnings: saveWarnings(before, after) });
-        }).catch(() => json(res, 400, { error: "bad request" }));
-        return true;
-    }
+    // One hot web toggle; an unrelated Settings edit never materializes defaults.
     if (method === "PUT" && path === "/api/settings/fleet/web") {
         // #1620: never over the temporary public link — refused before the body is read (the confirmation gate refuses it
         // first; this is the second wall, for any path that reaches the handler without it).
@@ -1408,10 +969,6 @@ export function handleSettingsRequest(req, res, url, ctx) {
                 web.preview_cdn = parsed.previewCdn;
                 changes.push({ path: ["web", "preview_cdn"], value: parsed.previewCdn });
             }
-            if (parsed.loginQr !== undefined) {
-                web.login_qr = parsed.loginQr;
-                changes.push({ path: ["web", "login_qr"], value: parsed.loginQr });
-            }
             if (parsed.publicLink) {
                 if (Object.keys(parsed.publicLink).length)
                     web.public_link = { ...web.public_link, ...parsed.publicLink };
@@ -1642,26 +1199,6 @@ export function handleSettingsRequest(req, res, url, ctx) {
             if ("path" in restored)
                 return json(res, 400, { error: `redacted value has no stored credential: defaults.${restored.path}` });
             const merged = { ...cfg.defaults, ...officeInputPatch(restored.value) };
-            // #3212: backend_options is replaced whole, like every nested map in this write (the top-level keys merge): Settings
-            // → Accounts sends the whole map, and so does the Advanced editor, where leaving a key out removes it.
-            if (body.backend_options !== undefined && body.backend_options && typeof body.backend_options === "object" && !Array.isArray(body.backend_options)) {
-                const sent = body.backend_options;
-                // A fleet default moved onto a signed-out profile would leave every agent that follows it at a sign-in prompt.
-                for (const b of Object.keys(sent)) {
-                    const after = instanceCredentialProfile(undefined, merged, b), before = instanceCredentialProfile(undefined, cfg.defaults, b);
-                    if (!after || after === before)
-                        continue;
-                    let login = null;
-                    try {
-                        login = credentialProfileLogin(ctx.dataDir, b, after);
-                    }
-                    catch {
-                        login = null;
-                    }
-                    if (login?.state === "signed-out")
-                        return json(res, 409, { error: "credential_profile_signed_out", backend: b, profile: after, loginCommand: login.loginCommand });
-                }
-            }
             // #1310: locale:null means "clear the key" (user chose Auto). Mirrors
             // how the instance save handles model ("" → delete) and nullable overrides.
             if (body.locale === null || body.locale === "")
@@ -1876,6 +1413,7 @@ export function handleSettingsRequest(req, res, url, ctx) {
                 "tool_progress",
                 "reply_completion_guard",
                 "web_echo",
+                "quota_notice",
             ]);
             const unknown = Object.keys(body).filter(field => !allowed.has(field));
             if (unknown.length)
@@ -1933,6 +1471,8 @@ export function handleSettingsRequest(req, res, url, ctx) {
                 delete merged.reply_completion_guard;
             if (body.reply_triggers === null)
                 delete merged.reply_triggers;
+            if (body.quota_notice === null)
+                delete merged.quota_notice;
             channels[key] = merged;
             const before = validateClassicBotConfig(previous);
             const after = validateClassicBotConfig(classic);
@@ -2175,26 +1715,6 @@ export function handleSettingsRequest(req, res, url, ctx) {
         const after = validateFleet({ ...cfg, instances: { ...cfg.instances, [name]: mergedInst } });
         if (rejectIfWorse(res, before, after))
             return;
-        // #3212: moving an agent onto a named credential profile that is signed out is refused, as update_instance_config
-        // refuses it — the agent would wait at a sign-in prompt instead of working. Unknown (cannot tell) is let through.
-        if (!mergedInst.machine_id && mergedInst.runtime !== "windows") {
-            const backendAfter = String(mergedInst.backend ?? cfg.defaults?.backend ?? "claude-code");
-            const profileAfter = instanceCredentialProfile(mergedInst, cfg.defaults, backendAfter);
-            const profileBefore = exists ? instanceCredentialProfile(base, cfg.defaults, String(base.backend ?? cfg.defaults?.backend ?? "claude-code")) : null;
-            if (profileAfter && profileAfter !== profileBefore) {
-                let login = null;
-                try {
-                    login = credentialProfileLogin(ctx.dataDir, backendAfter, profileAfter);
-                }
-                catch {
-                    login = null;
-                }
-                if (login?.state === "signed-out") {
-                    json(res, 409, { error: "credential_profile_signed_out", backend: backendAfter, profile: profileAfter, loginCommand: login.loginCommand });
-                    return;
-                }
-            }
-        }
         // #3055 review r2: a topic whose agent is being deleted is going away on the platform now — binding it here would
         // lose it. Asked at commit, by physical destination; try again once the deletion is over.
         if (ctx.topicBindingInFlight?.(mergedInst)) {