@songsid/agend 2.3.3-beta.3 → 2.3.3-beta.5

package/dist/web-api.js

@@ -1,8 +1,7 @@
-import { canvasWorkerEnabled, CANVAS_WORKER_EXPERIMENTAL_MESSAGE } from "./web-experimental.js";
-import { isCanvasWorkerHttpPath } from "./web-experimental-http.js";
+import { CANVAS_WORKER_EXPERIMENTAL_MESSAGE } from "./web-experimental.js";
 import { webHumanOrigin } from "./human-delivery-receipts.js";
 import { classifyWebPeer, confirmAfterBody, noAuthority } from "./authority/web-authority.js";
-import { guestChatRefusal, guestCommandText, guestDeliveries, guestFrameData, guestHistory, guestMessages, guestPollBody, guestPrefs, guestRequestOf, guestSeesMessage, guestStatus } from "./web-guest-access.js";
+import { guestChatRefusal, guestCommandText, guestDeliveries, GUEST_PREF_MAX_BYTES, GUEST_SEARCHES, guestFrameData, guestHistory, guestMessages, guestOwnPrefs, guestPollBody, guestPrefs, guestRequestOf, guestSeesMessage, guestStatus } from "./web-guest-access.js";
 import { withSpawnHoldReply } from "./spawn-hold-reply.js";
 import { binaryProbe } from "./binary-probe.js";
 import { settingsRequestExecution, settingsWrite, isSettingsReplay } from "./settings-request-capability.js";
@@ -14,7 +13,6 @@ import { buildModBundle } from "./web-mod-export.js";
 import { AGENT_WIDGET_SLOTS, checkWidgetData, checkWidgetSpec } from "./web-widget.js";
 import { checkOwnerCss, ownerCssAssetRefs } from "./web-owner-css.js";
 import { canonicalText } from "./web-theme.js";
-import { EFFECT_WIRE_LIMIT } from "./web-effect-upload.js";
 import { SKIN_WIRE_BYTES } from "./web-office-skins.js";
 import { gatewayRequestContext } from "./web-request-context.js";
 import { crossInstanceVisibility } from "./cross-instance-notice.js";
@@ -51,7 +49,6 @@ import { parseMentionQuery } from "./web-mentions.js";
 import { authorizeExplicitInstanceRemoval } from "./instance-removal.js";
 import { measureSyncWork } from "./sync-work-attribution.js";
 import { resolveTz } from "./tz-utils.js";
-import { filesPlayInChat } from "./web-effect.js";
 import { QUERY_MAX_CHARS, RESULT_MAX, SEARCH_SOURCES } from "./search/search-store.js";
 import { xmsgShown } from "./search/search-docs.js";
 import { WebSendDedupe } from "./web-send-dedupe.js";
@@ -319,6 +316,8 @@ export const SSE_HEARTBEAT_MS = 10_000;
 async function parseBody(req) {
     return JSON.parse((await readBoundedWebBody(req, 512 * 1024)).toString("utf8"));
 }
+/** #2855: the guest accounts with a command in progress (one at a time each). */
+const guestCommandsRunning = new Set();
 /** Send JSON response. */
 function json(res, status, data) {
     jsonText(res, status, JSON.stringify(data));
@@ -943,159 +942,6 @@ function handleOwnerCss(req, res, url, ctx, path, method) {
     })().catch(fail);
     return true;
 }
-/** #1629: static current-placement posters, separate from the local human-only runtime API. */
-function handleEffectPosters(res, url, ctx, path, method) {
-    res.setHeader("Cache-Control", "private, no-store");
-    res.setHeader("X-Content-Type-Options", "nosniff");
-    const image = /^\/ui\/effect-posters\/([0-9a-f]{32})\.png$/.exec(path);
-    const names = [...url.searchParams.keys()], instance = url.searchParams.get("instance");
-    if (method !== "GET" || path !== "/ui/effect-posters" && !image || names.length !== 1 || names[0] !== "instance" || !instance || instance.length > 128) {
-        json(res, 404, { error: "not_found" });
-        return true;
-    }
-    const service = ctx.effectService;
-    if (!service) {
-        json(res, 404, { error: "effects_unavailable" });
-        return true;
-    }
-    if (image) {
-        const r = service.placedPoster(image[1], instance);
-        if (!r.ok)
-            json(res, 404, { error: "not_found" });
-        else {
-            res.writeHead(200, { "Content-Type": "image/png", "Content-Security-Policy": "default-src 'none'; sandbox" });
-            res.end(r.bytes);
-        }
-    }
-    else {
-        const result = service.posterPlacements(instance);
-        json(res, result.error === "themes_unreadable" ? 503 : result.error ? 404 : 200, result);
-    }
-    return true;
-}
-/** #1629 Try: separate local-admin routes. These never borrow ordinary read-tier/placement authority. */
-function handleEffectTrials(req, res, url, ctx, path, method) {
-    res.setHeader("Cache-Control", "private, no-store");
-    res.setHeader("X-Content-Type-Options", "nosniff");
-    const reading = method === "GET";
-    if (gatewayRequestContext(req)) {
-        json(res, reading ? 404 : 403, { error: "trials_not_over_public_link" });
-        return true;
-    }
-    const who = () => {
-        const sessions = ctx.webSessions;
-        const v = evaluateWebRequest(req, url, ctx.webToken ?? null, sessions, { touch: false });
-        if (v.kind !== "allow")
-            return { error: WEB_TOKEN_INVALID_MESSAGE, status: 401 };
-        if (v.via !== "session" || v.session.tier !== "admin" || v.session.surface !== "local")
-            return { error: "trials_need_a_local_admin", status: 403 };
-        const person = webPersonKey(v.session.owner);
-        let css = "unknown";
-        try {
-            const value = ctx.ownerCss?.effectState(person);
-            if (value === "off" || value === "on")
-                css = value;
-        }
-        catch { /* unavailable is never off */ }
-        // CSS is diagnostic for Try; its host-owned shadow shell isolates controls and local paint.
-        const actor = Object.freeze({ via: "session", surface: "local", tier: "admin", sessionHash: v.session.idHash, epoch: v.session.handle, person, ownerCss: css });
-        return { actor, record: v.session, sessions };
-    };
-    const first = who();
-    if ("error" in first) {
-        json(res, first.status, { error: first.error });
-        return true;
-    }
-    const service = ctx.effectService;
-    if (!service) {
-        json(res, 404, { error: "trials_unavailable" });
-        return true;
-    }
-    const start = path === "/ui/effect-trials/start";
-    const route = /^\/ui\/effect-trials\/([0-9a-f]{32})\/(resource|poster\.png|profile|stop)$/.exec(path);
-    const resource = reading && route && ["resource", "poster.png", "profile"].includes(route[2]);
-    const stop = method === "POST" && route?.[2] === "stop";
-    if (!(resource || stop || method === "POST" && start)) {
-        json(res, 404, { error: "not_found" });
-        return true;
-    }
-    const allowed = resource ? ["ownerEpoch", "instance"] : ["ownerEpoch"];
-    if ([...url.searchParams.keys()].some(k => !allowed.includes(k)) || allowed.some(k => url.searchParams.getAll(k).length !== 1)
-        || url.searchParams.get("ownerEpoch") !== first.actor.epoch) {
-        json(res, reading ? 404 : 409, { error: reading ? "not_found" : "trials_person_changed" });
-        return true;
-    }
-    const instance = url.searchParams.get("instance") ?? "";
-    const answer = (result) => json(res, result.error ? result.error === "not_found" ? 404
-        : ["profiles_unreadable", "profiles_busy", "profiles_write_failed"].includes(String(result.error)) ? 503 : 400 : 200, result);
-    if (resource) {
-        if (route[2] === "poster.png") {
-            const result = service.trialPoster(route[1], instance, first.actor);
-            if (!result.ok)
-                json(res, 404, { error: "not_found" });
-            else {
-                res.writeHead(200, { "Content-Type": "image/png", "Content-Security-Policy": "default-src 'none'; sandbox" });
-                res.end(result.bytes);
-            }
-        }
-        else
-            answer(route[2] === "profile" ? service.trialProfile(route[1], instance, first.actor) : service.trialResource(route[1], instance, first.actor));
-        return true;
-    }
-    (async () => {
-        let bytes;
-        try {
-            bytes = await readBoundedWebBody(req, 16 * 1024);
-        }
-        catch {
-            json(res, 413, { error: "trial_body_bound" });
-            return;
-        }
-        if (!permitWebContinuation(req, res, ctx))
-            return;
-        const now = who();
-        if ("error" in now) {
-            json(res, now.status, { error: now.error });
-            return;
-        }
-        if (!canvasWorkerEnabled(ctx.fleetConfig?.web)) {
-            json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
-            return;
-        }
-        if (now.record !== first.record || now.sessions !== first.sessions || now.actor.sessionHash !== first.actor.sessionHash
-            || now.actor.person !== first.actor.person || now.actor.epoch !== first.actor.epoch) {
-            json(res, 409, { error: "trials_person_changed" });
-            return;
-        }
-        let body;
-        try {
-            body = JSON.parse(new TextDecoder("utf-8", { fatal: true }).decode(bytes));
-        }
-        catch {
-            json(res, 400, { error: "trial_json" });
-            return;
-        }
-        if (start) {
-            const parsed = z.strictObject({ offer: z.string().regex(/^[0-9a-f]{32}$/), instance: z.string().min(1).max(128) }).safeParse(body);
-            if (!parsed.success) {
-                json(res, 400, { error: "trial_args" });
-                return;
-            }
-            answer(service.trialStart(parsed.data.offer, parsed.data.instance, now.actor));
-        }
-        else {
-            if (!z.strictObject({}).safeParse(body).success) {
-                json(res, 400, { error: "trial_args" });
-                return;
-            }
-            answer(service.trialStop(route[1], now.actor));
-        }
-    })().catch(() => { try {
-        json(res, 500, { error: "trial_request_failed" });
-    }
-    catch { /* response ended */ } });
-    return true;
-}
 /** #2599: the same closed browser controls as setup, for a current local human admin. */
 function handleBrowserBackendSignIns(req, res, url, ctx) {
     res.setHeader("Cache-Control", "private, no-store");
@@ -1291,148 +1137,6 @@ function handleBackendLogin(req, res, url, ctx, path, method) {
     catch { /* response ended */ } });
     return true;
 }
-/** #1629 B2: effect routes require a human session; route bodies never supply an actor or reference holder. */
-function handleEffects(req, res, url, ctx, path, method) {
-    res.setHeader("Cache-Control", "private, no-store");
-    res.setHeader("X-Content-Type-Options", "nosniff");
-    const reading = method === "GET";
-    // Reports are bounded untrusted diagnostics, not an appearance or admission write (r2 §6).
-    const profilePost = method === "POST" && /^\/ui\/effects\/profile\/[0-9a-f]{32}$/.test(path);
-    const gateway = gatewayRequestContext(req), guest = guestRequestOf(req);
-    const instanceQuery = url.searchParams.get("instance"), keys = [...url.searchParams.keys()];
-    const chatRead = reading && (path === "/ui/effects/placements" || /^\/ui\/effects\/resource\/[0-9a-f]{32}$/.test(path))
-        && keys.length === 2 && keys.includes("instance") && keys.includes("ownerEpoch") && !!instanceQuery && instanceQuery.length <= 128;
-    // Public viewing grants current Chat reads, never ordinary library/owner/Trial access or writes.
-    if (gateway && (!chatRead || !gateway.isCurrent())) {
-        json(res, reading ? 404 : 403, { error: "effects_not_over_public_link" });
-        return true;
-    }
-    const who = () => {
-        const verdict = evaluateWebRequest(req, url, ctx.webToken ?? null, ctx.webSessions, { touch: false });
-        if (verdict.kind !== "allow")
-            return { status: 401, error: WEB_TOKEN_INVALID_MESSAGE };
-        if (verdict.via !== "session" || !verdict.session)
-            return { status: 403, error: "effects_need_a_signed_in_person" };
-        if (!reading && !profilePost && verdict.session.tier !== "admin")
-            return { status: 403, error: "effects_read_only" };
-        if (verdict.session.tier === "guest" && (!chatRead || !guest || !guest.current() || !guest.scope().has(instanceQuery)))
-            return { status: 404, error: "not_found" };
-        return { person: webPersonKey(verdict.session.owner), canWrite: verdict.session.tier === "admin", epoch: verdict.session.handle, guest: verdict.session.tier === "guest" };
-    };
-    const first = who();
-    if ("status" in first) {
-        json(res, first.status, { error: first.error });
-        return true;
-    }
-    const service = ctx.effectService;
-    if (!service) {
-        json(res, 404, { error: "effects_unavailable" });
-        return true;
-    }
-    const unavailable = new Set(["themes_unreadable", "profiles_unreadable", "library_unreadable", "references_unreadable", "library_busy", "profiles_busy", "profiles_write_failed", "library_write_failed", "prefs_unreadable"]);
-    const answer = (result) => json(res, typeof result.error === "string" ? result.error === "not_found" ? 404 : result.error === "profile_rate_limited" ? 429 : unavailable.has(result.error) ? 503 : 400 : 200, result);
-    const idPath = /^\/ui\/effects\/(resource|profile)\/([0-9a-f]{32})$/.exec(path);
-    const instance = url.searchParams.get("instance") ?? undefined, slot = url.searchParams.get("slot");
-    if (slot !== null && instance !== undefined) {
-        json(res, 404, { error: "not_found" });
-        return true;
-    }
-    const runtimeRead = reading && (slot !== null || path === "/ui/effects/owner" || path === "/ui/effects/placements" || idPath?.[1] === "resource" || instance !== undefined && /^\/ui\/effects\/image\//.test(path));
-    if ((runtimeRead || profilePost) && (url.searchParams.getAll("ownerEpoch").length !== 1 || url.searchParams.get("ownerEpoch") !== first.epoch)) {
-        const privateResource = reading && (slot !== null || idPath?.[1] === "resource" || /^\/ui\/effects\/image\//.test(path));
-        json(res, privateResource ? 404 : 409, { error: privateResource ? "not_found" : "effects_person_changed" });
-        return true;
-    }
-    if (reading) {
-        const image = /^\/ui\/effects\/image\/([0-9a-f]{32})\/(poster|cursor)\.png$/.exec(path);
-        if (image) {
-            const r = slot === null ? service.image(first.person, image[1], image[2], instance) : service.ownerImage(first.person, image[1], image[2], slot);
-            if (!r.ok)
-                json(res, 404, { error: "not_found" });
-            else {
-                res.writeHead(200, { "Content-Type": "image/png", "Content-Security-Policy": "default-src 'none'; sandbox" });
-                res.end(r.bytes);
-            }
-            return true;
-        }
-        if (path === "/ui/effects")
-            answer({ ...service.list(first.person), canWrite: first.canWrite });
-        else if (path === "/ui/effects/owner" && instance === undefined && slot === null)
-            answer(service.ownerSelections(first.person));
-        else if (path === "/ui/effects/placements" && instance !== undefined)
-            answer(service.placements(first.person, instance, !!gateway || first.guest));
-        else if (idPath?.[1] === "resource")
-            answer(slot === null ? service.resource(first.person, idPath[2], instance, !!gateway || first.guest) : service.ownerResource(first.person, idPath[2], slot));
-        else if (idPath?.[1] === "profile" && instance === undefined)
-            answer(service.profile(first.person, idPath[2]));
-        else
-            json(res, 404, { error: "not_found" });
-        return true;
-    }
-    const deletion = /^\/ui\/effects\/([0-9a-f]{32})$/.exec(path);
-    if (method === "DELETE" && deletion) {
-        answer(service.delete(first.person, deletion[1]));
-        return true;
-    }
-    if (method !== "POST" || !["/ui/effects/upload", "/ui/effects/apply", "/ui/effects/remove", "/ui/effects/share"].includes(path) && idPath?.[1] !== "profile") {
-        json(res, 404, { error: "not_found" });
-        return true;
-    }
-    (async () => {
-        let bytes;
-        try {
-            bytes = await readBoundedWebBody(req, path === "/ui/effects/upload" ? EFFECT_WIRE_LIMIT : 16 * 1024);
-        }
-        catch {
-            json(res, 413, { error: "effect_body_bound" });
-            return;
-        }
-        if (!permitWebContinuation(req, res, ctx))
-            return;
-        const now = who();
-        if ("status" in now) {
-            json(res, now.status, { error: now.error });
-            return;
-        }
-        if (!canvasWorkerEnabled(ctx.fleetConfig?.web)) {
-            json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
-            return;
-        }
-        if (now.person !== first.person || now.epoch !== first.epoch) {
-            json(res, 409, { error: "effects_person_changed" });
-            return;
-        }
-        if (path === "/ui/effects/upload") {
-            answer(service.upload(now.person, bytes));
-            return;
-        }
-        let body;
-        try {
-            body = JSON.parse(new TextDecoder("utf-8", { fatal: true }).decode(bytes));
-        }
-        catch {
-            json(res, 400, { error: "effect_json" });
-            return;
-        }
-        if (path === "/ui/effects/apply")
-            answer(service.apply(now.person, body));
-        else if (path === "/ui/effects/remove")
-            answer(service.remove(now.person, body));
-        else if (path === "/ui/effects/share")
-            answer(service.share(now.person, body));
-        else {
-            if (body && typeof body === "object" && body.kind === "playback" && (url.searchParams.getAll("instance").length !== 1 || slot !== null)) {
-                json(res, 400, { error: "playback_report" });
-                return;
-            }
-            answer(service.report(now.person, idPath[2], body, instance, now.epoch));
-        }
-    })().catch(() => { try {
-        json(res, 500, { error: "effect_request_failed" });
-    }
-    catch { /* response ended */ } });
-    return true;
-}
 /**
  * #1629 r4 §4 (r4-5): mods — a person's import (stage, then commit), uninstall and export. Every route is a signed-in
  * session's, writes an admin's: never the CLI's header token (the way an agent could reach it) and never the public link
@@ -1515,18 +1219,13 @@ function handleMods(req, res, url, ctx, path, method) {
             json(res, 404, { error: "no_such_mod" });
             return true;
         }
-        // The file is the installed bundle, effects and all — also effects its import left out, which nobody installed.
-        // So the export ACL judges what the file carries, not what was installed: it downloads only when this person may
-        // read every effect in it (their own claim on that content, or a shared one). A file without effects is any admin's.
+        // The file is the installed bundle, effects and all. #2799: a file that carries Canvas Worker effects (or can't be
+        // read to tell) is not handed out; one without is any admin's.
         const fx = mods.bundleEffects(fileMatch[1]);
-        if (!canvasWorkerEnabled(ctx.fleetConfig?.web) && (fx === "unknown" || (fx?.length ?? 0) > 0)) {
+        if (fx === "unknown" || (fx?.length ?? 0) > 0) {
             json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
             return true;
         }
-        if (fx === "unknown" || (fx ?? []).some(id => !ctx.modPlacedEffect?.(first.person, id))) {
-            json(res, 403, { error: "mod_effects_not_yours", detail: "this mod's file carries effects that are not yours to share: export your own look instead" });
-            return true;
-        }
         res.writeHead(200, { "Content-Type": "application/json; charset=utf-8", "X-Content-Type-Options": "nosniff", "Cache-Control": "private, no-store",
             "Content-Disposition": `attachment; filename="${rec.name}-${rec.version}.agendmod.json"` });
         res.end(text);
@@ -1650,14 +1349,9 @@ export function exportMod(ctx, person, body) {
         const store = ctx.themeStore;
         const rec = store.get(name);
         if (inc.theme === true) {
-            // The effects the theme places travel with it, as the library keeps them (a person may export what is placed).
-            // Only effects this person may carry away travel (Sol's ACL); the rest are counted, never packaged.
-            // #2017: an older placement of an effect that doesn't play in chat stays out (a mod can't place it): counted.
-            const effects = (canvasWorkerEnabled(ctx.fleetConfig?.web) ? rec.placements.effects : []).flatMap(p => { const e = ctx.modPlacedEffect?.(person, p.id); if (!e || !filesPlayInChat(e.files)) {
-                omitted++;
-                return [];
-            } return [{ name: e.name, files: e.files, params: p.params ?? {} }]; });
-            parts.theme = { theme: rec.theme, picture: id => { const a = rec.assets.find(x => x.id === id); const b = store.asset(name, id); return a && b ? { bytes: b.bytes, kind: a.kind } : null; }, effects };
+            // #2799: Canvas Worker effects were removed; an older placement travels nowhere (it is counted as left out).
+            omitted += rec.placements.effects.length;
+            parts.theme = { theme: rec.theme, picture: id => { const a = rec.assets.find(x => x.id === id); const b = store.asset(name, id); return a && b ? { bytes: b.bytes, kind: a.kind } : null; }, effects: [] };
         }
         if (inc.identity === true)
             parts.identity = ctx.modCardText?.(name) ?? {};
@@ -1730,6 +1424,109 @@ export function webPeerOf(req) {
     const gateway = gatewayRequestContext(req);
     return gateway ? (gateway.named === true ? "named_link" : "quick_link") : classifyWebPeer(req);
 }
+/** #2855: the guest accounts with a search running, and how many guest searches run in all (GUEST_SEARCHES). */
+const guestSearchesRunning = new Set();
+let guestSearchesInFlight = 0;
+/**
+ * #2855: a trusted guest's search — chat messages of its in-scope agents that it can see now (guestSeesMessage, on the
+ * history's own row: one no longer kept is not shown, nothing else is), at most GUEST_SEARCHES.maxResults. Per account
+ * GUEST_SEARCHES a minute and one at a time; at most GUEST_SEARCHES.global guest searches running in all, so the
+ * index's queue always has room for the admins'. Its context: the same rows only.
+ */
+function guestSearch(req, res, url, ctx, guest, path) {
+    const refusal = () => {
+        if (!guest.current())
+            return [401, WEB_TOKEN_INVALID_MESSAGE];
+        if (!guest.trusted?.())
+            return [403, "guest_not_trusted"];
+        if (gatewayRequestContext(req) && ctx.fleetConfig?.web?.search?.public_link === false)
+            return [404, "search_not_over_public_link"];
+        if (ctx.fleetConfig?.web?.search?.enabled === false || !ctx.searchIndex || ctx.searchIndex.status() === "unavailable")
+            return [404, "search_unavailable"];
+        return null;
+    };
+    const first = refusal();
+    if (first) {
+        json(res, first[0], { error: first[1] });
+        return;
+    }
+    const account = `${guest.owner.adapterId}:${guest.owner.userId}`;
+    const limit = ctx.guestSearches?.check(account);
+    if (limit && !limit.ok) {
+        res.setHeader("Retry-After", String(limit.retry_after_s));
+        json(res, 429, { error: "guest_search_rate_limited", retry_after_s: limit.retry_after_s });
+        return;
+    }
+    if (guestSearchesRunning.has(account)) {
+        json(res, 429, { error: "guest_search_running" });
+        return;
+    }
+    if (guestSearchesInFlight >= GUEST_SEARCHES.global) {
+        res.setHeader("Retry-After", "2");
+        json(res, 503, { error: "search_busy" });
+        return;
+    }
+    const index = ctx.searchIndex, history = ctx.webChatHistory;
+    // What this guest may see of one indexed chat row: its history row, now, by the guest rule; else nothing.
+    const visible = (hit) => {
+        if (hit.source !== "chat" || !guest.scope().has(hit.instance) || !history)
+            return false;
+        const row = history.find(hit.instance, String(hit.ref.boot ?? ""), Number(hit.ref.id));
+        return !!row && guestSeesMessage(row, guest, guest.scope());
+    };
+    const finish = (status, body) => { const now = refusal(); if (now)
+        json(res, now[0], { error: now[1] });
+    else
+        json(res, status, body); };
+    const failed = (reason) => finish(reason === "timeout" || reason === "busy" ? 503 : 404, { error: `search_${reason}` });
+    let run;
+    if (path === "/ui/search/context") {
+        const key = url.searchParams.get("key") ?? "";
+        if (!key || key.length > 300) {
+            json(res, 400, { error: "key required" });
+            return;
+        }
+        run = index.context(key).then(r => {
+            if (!r.ok)
+                return failed(r.reason);
+            const value = r.value;
+            if (!value?.doc || !visible(value.doc))
+                return finish(404, { error: "not_found" });
+            finish(200, { doc: value.doc, before: value.before.filter(visible), after: value.after.filter(visible), building: r.building });
+        }, () => failed("unavailable"));
+    }
+    else {
+        // Never a team (whose members, and whether it exists, are the admin's) or "only mine" (an admin's own messages).
+        const own = new URL(url.href);
+        own.searchParams.delete("team");
+        own.searchParams.delete("mine");
+        const parsed = parseSearchQuery(own, ctx);
+        if ("error" in parsed) {
+            json(res, 400, { error: parsed.error });
+            return;
+        }
+        const scope = guest.scope();
+        const asked = parsed.filters.instances?.filter(n => scope.has(n)) ?? [...scope];
+        if (!asked.length) {
+            json(res, 200, { hits: [], limited: false });
+            return;
+        }
+        // Chat only, its scope only; more asked of the index than shown, since rows it can't see are left out after.
+        run = index.query({ q: parsed.filters.q, instances: asked, sources: ["chat"], limit: SEARCH_LIMIT_DEFAULT,
+            ...(parsed.filters.since !== undefined ? { since: parsed.filters.since } : {}), ...(parsed.filters.until !== undefined ? { until: parsed.filters.until } : {}) }).then(r => {
+            if (!r.ok)
+                return failed(r.reason);
+            const hits = r.value.hits.filter(visible);
+            finish(200, { hits: hits.slice(0, GUEST_SEARCHES.maxResults).map(h => ({ ...h, live: true })), limited: r.value.limited || hits.length > GUEST_SEARCHES.maxResults, building: r.building });
+        }, () => failed("unavailable"));
+    }
+    ctx.guestSearches?.record(account);
+    guestSearchesRunning.add(account);
+    guestSearchesInFlight++;
+    void run.catch(() => { if (!res.headersSent)
+        json(res, 500, { error: "search_failed" }); })
+        .finally(() => { guestSearchesRunning.delete(account); guestSearchesInFlight--; });
+}
 /**
  * #2122: what let this request in, asked now — its session (by handle, under the token it was signed in with) or the
  * header token; null when nothing does any more (the gate also refuses a public link that is no longer the current
@@ -1913,10 +1710,6 @@ function statusTick(ctx, t) {
 export function handleWebRequest(req, res, url, ctx) {
     const path = url.pathname;
     const method = req.method ?? "GET";
-    if (!canvasWorkerEnabled(ctx.fleetConfig?.web) && isCanvasWorkerHttpPath(path)) {
-        json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
-        return true;
-    }
     // Auth check for all /ui routes. Defence in depth behind the fleet-manager
     // gate: the same session cookie or header token, and an unset token closes
     // the panel instead of comparing null against a missing credential.
@@ -2192,7 +1985,10 @@ export function handleWebRequest(req, res, url, ctx) {
         const guest = guestRequestOf(req);
         const messages = !ctx.webChatHistory ? [] : guest ? guestHistory(ctx.webChatHistory, instance, limit, guest, guest.scope())
             : visibleMessages(ctx, !!gatewayRequestContext(req), ctx.webChatHistory.list(instance, limit));
-        json(res, 200, { messages, boot: ctx.webChatHistory?.boot ?? null, lastId: ctx.webChatHistory?.lastId ?? 0 });
+        // #2848: the chat has messages, none of them a guest's to see (all between agents, or kept before they were marked):
+        // said, so its empty chat is explained rather than blank. Only that there are some — never how many, or what.
+        const allHidden = !!guest && messages.length === 0 && (ctx.webChatHistory?.list(instance, 1).length ?? 0) > 0;
+        json(res, 200, { messages, boot: ctx.webChatHistory?.boot ?? null, lastId: ctx.webChatHistory?.lastId ?? 0, ...(allHidden ? { allHidden: true } : {}) });
         return true;
     }
     // ── #1218: the Log tab ─────────────────────────────────
@@ -2856,6 +2652,13 @@ export function handleWebRequest(req, res, url, ctx) {
             json(res, 404, { error: "Preferences are not kept on this fleet" });
             return true;
         }
+        // #2855: a guest saves its own preferences (GUEST_OWN_PREF_KEYS) into its own account's bucket — on any listener,
+        // the public link too, since nothing of the host's is written. At most GUEST_PREF_WRITES a minute per account.
+        const guest = guestRequestOf(req);
+        if (guest) {
+            saveGuestPrefs(req, res, ctx, prefs, guest);
+            return true;
+        }
         if (gatewayRequestContext(req)) {
             json(res, 403, { error: "prefs_not_over_public_link" });
             return true;
@@ -2896,30 +2699,16 @@ export function handleWebRequest(req, res, url, ctx) {
                 return;
             }
             const personal = [...parsed.patch.keys()].some(isOwnerEffectKey);
-            if (personal && !canvasWorkerEnabled(ctx.fleetConfig?.web)) {
+            // #2799: a person's own effect selections were Canvas Worker effects' (removed): refused, as before.
+            if (personal) {
                 json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
                 return;
             }
-            if (personal && now.person === null) {
-                json(res, 403, { error: "prefs_need_a_signed_in_person" });
-                return;
-            }
-            // A scope marker rejects a queued old page after a different login, including the same person's new session.
-            // It supplies neither identity nor authority; the current verified session still chooses the bucket.
-            if (personal && body.ownerEpoch !== now.epoch) {
-                json(res, 409, { error: "prefs_person_changed" });
-                return;
-            }
-            const before = prefs.readForViewer(now.person);
-            const written = prefs.writeForViewer(now.person, parsed.patch, { onlyIfUnset: body.onlyIfUnset === true,
-                validateEffect: (person, key, id) => ctx.effectService ? ctx.effectService.validateOwnerSelection(person, key, id) : "effects_unavailable" });
+            const written = prefs.writeForViewer(now.person, parsed.patch, { onlyIfUnset: body.onlyIfUnset === true, validateEffect: () => "effects_unavailable" });
             if (!written.ok) {
                 json(res, written.status, { error: written.error });
                 return;
             }
-            const dropped = written.changed.filter(isOwnerEffectKey).flatMap(key => typeof before.values[key] === "string" && before.values[key] !== written.view.values[key] ? [before.values[key]] : []);
-            if (dropped.length)
-                ctx.effectService?.collectOwnerReplaced(dropped);
             if (written.changed.length)
                 ctx.emitSseEvent("status", ctx.getUiStatus());
             json(res, 200, { ...written.view, ...prefsScope(now), changed: written.changed });
@@ -2945,19 +2734,11 @@ export function handleWebRequest(req, res, url, ctx) {
     // #1629 r4-5: mods — a person's import, uninstall and export (handleMods: sessions only, never the public link).
     if (path === "/ui/mods" || path.startsWith("/ui/mods/"))
         return handleMods(req, res, url, ctx, path, method);
-    // Posters remain behind the common session gate, with a closed GET-only public manifest.
-    if (path === "/ui/effect-posters" || path.startsWith("/ui/effect-posters/"))
-        return handleEffectPosters(res, url, ctx, path, method);
-    // Canvas effects are absent from the public gateway manifest and independently refused above.
-    if (path === "/ui/effect-trials" || path.startsWith("/ui/effect-trials/"))
-        return handleEffectTrials(req, res, url, ctx, path, method);
     // #2233: backend sign-in — absent from the public manifest and the guest table, and refused here too.
     if (path === "/ui/browser-backend-signins")
         return handleBrowserBackendSignIns(req, res, url, ctx);
     if (path === "/ui/backend-login" || path.startsWith("/ui/backend-login/"))
         return handleBackendLogin(req, res, url, ctx, path, method);
-    if (path === "/ui/effects" || path.startsWith("/ui/effects/"))
-        return handleEffects(req, res, url, ctx, path, method);
     // #1386: Acknowledge a "Needs you" delivery item — a session write (CSRF, checked by the gate) or the CLI's header
     // token. Who did it is recorded by principal: the session's public handle, never the session id or a credential.
     if (method === "POST" && path === "/ui/needs/ack") {
@@ -3052,6 +2833,21 @@ export function handleWebRequest(req, res, url, ctx) {
             return true;
         }
         const run = ctx.webCommand.bind(ctx);
+        // #2855: a guest — an in-scope agent, while guests may chat, the table's "anyone" commands only (runWebCommand), at
+        // most GUEST_COMMAND_RUNS a minute per account and one at a time.
+        const guest = guestRequestOf(req), account = guest ? `${guest.owner.adapterId}:${guest.owner.userId}` : "";
+        if (guest) {
+            const limit = ctx.guestCommandRuns?.check(account);
+            if (limit && !limit.ok) {
+                res.setHeader("Retry-After", String(limit.retry_after_s));
+                json(res, 429, { error: "guest_commands_rate_limited", retry_after_s: limit.retry_after_s });
+                return true;
+            }
+            if (guestCommandsRunning.has(account)) {
+                json(res, 429, { error: "guest_command_running" });
+                return true;
+            }
+        }
         const arrival = webAuthorityOf(req, url, ctx); // #1939 §3: on arrival, and again after the body
         (async () => {
             let body;
@@ -3081,9 +2877,39 @@ export function handleWebRequest(req, res, url, ctx) {
             const person = webPersonOr401(req, res, url, ctx); // #1827: asked again, now the body is in
             if (!person)
                 return;
-            const { authority } = confirmAfterBody(arrival, webAuthorityOf(req, url, ctx, instance));
-            const r = await run({ instance, command, args: str(body.args, MAX_COMMAND_ARGS), confirm: body.confirm }, { publicLink: !!gatewayRequestContext(req), person, authority });
-            json(res, r.status, r.body);
+            if (guest) {
+                if (!guest.current()) {
+                    json(res, 401, { error: WEB_TOKEN_INVALID_MESSAGE });
+                    return;
+                }
+                const refused = guestChatRefusal(guest, instance);
+                if (refused) {
+                    json(res, refused.status, { error: refused.error });
+                    return;
+                }
+                if (guestCommandsRunning.has(account)) {
+                    json(res, 429, { error: "guest_command_running" });
+                    return;
+                }
+                // The budget again, now (#2857 review): commands that ran while this body was on its way have counted.
+                const budget = ctx.guestCommandRuns?.check(account);
+                if (budget && !budget.ok) {
+                    res.setHeader("Retry-After", String(budget.retry_after_s));
+                    json(res, 429, { error: "guest_commands_rate_limited", retry_after_s: budget.retry_after_s });
+                    return;
+                }
+                guestCommandsRunning.add(account);
+                ctx.guestCommandRuns?.record(account);
+            }
+            try {
+                const { authority } = confirmAfterBody(arrival, webAuthorityOf(req, url, ctx, instance));
+                const r = await run({ instance, command, args: str(body.args, MAX_COMMAND_ARGS), confirm: body.confirm }, { publicLink: !!gatewayRequestContext(req), person, authority, ...(guest ? { guest: true } : {}) });
+                json(res, r.status, r.body);
+            }
+            finally {
+                if (guest)
+                    guestCommandsRunning.delete(account);
+            }
         })().catch(err => {
             ctx.logger.error({ err: err.message }, "Web command failed");
             try {
@@ -3708,11 +3534,15 @@ export function handleWebRequest(req, res, url, ctx) {
     // #2478 (the user's request): over the public link too, unless web.search.public_link is false. Asked on arrival and
     // again before the answer is sent.
     if (method === "GET" && (path === "/ui/search" || path === "/ui/search/context")) {
+        // #2855: a trusted guest searches only what it can see (guestSearch).
+        const searchGuest = guestRequestOf(req);
+        if (searchGuest) {
+            guestSearch(req, res, url, ctx, searchGuest, path);
+            return true;
+        }
         const refusal = () => {
             if (gatewayRequestContext(req) && ctx.fleetConfig?.web?.search?.public_link === false)
                 return [404, "search_not_over_public_link"];
-            if (guestRequestOf(req))
-                return [403, "guest_forbidden"];
             if (ctx.fleetConfig?.web?.search?.enabled === false || !ctx.searchIndex || ctx.searchIndex.status() === "unavailable")
                 return [404, "search_unavailable"];
             return null;
@@ -4123,7 +3953,7 @@ function handleSendMessage(req, res, ctx) {
             let quoted;
             if (replyTo) {
                 quoted = ctx.webChatHistory?.find(instance, replyTo.boot, replyTo.id);
-                if (!quoted || quoted.effectTrial || (guest && !guestSeesMessage(quoted, guest, guest.scope()))) {
+                if (!quoted || (guest && !guestSeesMessage(quoted, guest, guest.scope()))) {
                     json(res, 409, { error: t("web.reply_gone"), reason: "reply_gone" });
                     return;
                 }
@@ -4535,6 +4365,64 @@ function serveMediaRange(req, res, files, id, file) {
     res.writeHead(ranged ? 206 : 200);
     res.end(got.bytes);
 }
+/** #2855: a guest's own preferences — its own keys, its own bucket, favourites only in its scope. */
+function saveGuestPrefs(req, res, ctx, prefs, guest) {
+    const person = webPersonKey(guest.owner), account = `${guest.owner.adapterId}:${guest.owner.userId}`;
+    const limit = ctx.guestPrefWrites?.check(account);
+    if (limit && !limit.ok) {
+        res.setHeader("Retry-After", String(limit.retry_after_s));
+        json(res, 429, { error: "guest_prefs_rate_limited", retry_after_s: limit.retry_after_s });
+        return;
+    }
+    // Too large by its own declared length: answered before a byte is read (the body is drained, not cut off).
+    if (Number(req.headers["content-length"]) > GUEST_PREF_MAX_BYTES) {
+        req.resume();
+        json(res, 413, { error: "guest_prefs_too_large", detail: "at most 16 KB" });
+        return;
+    }
+    (async () => {
+        let body;
+        try {
+            body = JSON.parse((await readBoundedWebBody(req, GUEST_PREF_MAX_BYTES)).toString("utf8"));
+        }
+        catch {
+            json(res, 400, { error: "Invalid JSON, or over 16 KB" });
+            return;
+        }
+        if (!permitWebContinuation(req, res, ctx))
+            return;
+        if (!guest.current()) {
+            json(res, 401, { error: WEB_TOKEN_INVALID_MESSAGE });
+            return;
+        }
+        if (!body || typeof body !== "object" || Array.isArray(body) || !body.set || typeof body.set !== "object" || Array.isArray(body.set)) {
+            json(res, 400, { error: "set required" });
+            return;
+        }
+        const set = body.set, scope = guest.scope();
+        const favourites = set["nav.favorites"];
+        if (Array.isArray(favourites)) {
+            const outside = favourites.find((n) => typeof n !== "string" || !scope.has(n));
+            if (outside !== undefined) {
+                json(res, 400, { error: `not_in_scope: ${String(outside).slice(0, 64)}` });
+                return;
+            }
+        }
+        const written = prefs.writeForGuest(person, new Map(Object.entries(set)), { onlyIfUnset: body.onlyIfUnset === true });
+        if (!written.ok) {
+            json(res, written.status, { error: written.error });
+            return;
+        }
+        ctx.guestPrefWrites?.record(account);
+        json(res, 200, { ...guestOwnPrefs(prefs.readForViewer(person), prefs.readGuestOwn(person), scope), ownerScope: "person", ownerEpoch: null, changed: written.changed });
+    })().catch(err => {
+        ctx.logger.error({ err: err.message }, "Saving a guest's web preferences failed");
+        try {
+            json(res, 500, { error: "Saving preferences failed" });
+        }
+        catch { /* already answered */ }
+    });
+}
 function prefsViewer(req, url, ctx) {
     const v = evaluateWebRequest(req, url, ctx.webToken ?? null, ctx.webSessions, { touch: false });
     if (v.kind !== "allow")
@@ -4543,6 +4431,12 @@ function prefsViewer(req, url, ctx) {
     // it (#2094) read the host's preferences unfiltered: the sidebar's order and favourites, naming instances out of its
     // scope. Its account (phase 3) names it on its page.
     const guest = v.via === "session" && v.session?.tier === "guest" ? { guest: true, ...(v.session.owner ? { owner: v.session.owner } : {}) } : {};
+    // #2855: a guest reads its own preferences (its account's bucket) on every listener, the public link too.
+    if (v.via === "session" && v.session?.tier === "guest" && v.session.owner) {
+        const g = guestRequestOf(req);
+        return { person: webPersonKey(v.session.owner), epoch: v.session.handle, scope: "person", canWrite: false, via: "session", ...guest,
+            guestScope: () => g?.scope() ?? new Set() };
+    }
     if (!gatewayRequestContext(req) && v.via === "session" && v.session) {
         const person = webPersonKey(v.session.owner);
         return { person, epoch: v.session.handle, scope: person === OPERATOR ? "operator" : "person", canWrite: v.session.tier === "admin", via: "session", ...guest };
@@ -4553,7 +4447,10 @@ const prefsScope = (v) => ({ ownerScope: v?.scope ?? "none", ownerEpoch: v?.epoc
 // #1920: a guest reads the host's look and its own, never a preference that names an instance (guestPrefs).
 const prefsView = (prefs, v) => {
     const view = { ...prefs.readForViewer(v?.person ?? null), ...prefsScope(v) };
-    return v?.guest ? guestPrefs(view) : view;
+    if (!v?.guest)
+        return view;
+    // #2855: the host's look, then the guest's own preferences (only on a guest with an account: its bucket).
+    return v.person ? guestOwnPrefs(view, prefs.readGuestOwn(v.person), v.guestScope?.() ?? new Set()) : guestPrefs(view);
 };
 function shellHtmlTag(ctx, mode, viewer) {
     if (mode !== "full" || !ctx.webPrefs)
@@ -4572,20 +4469,12 @@ function shellOwnerCss(ctx, mode, viewer) {
 }
 function guestBodyAttrs(ctx, owner, attr) {
     const badge = ctx.guestBadge?.(owner);
-    return ` data-tier="guest"${badge ? ` data-guest-name="${attr(badge.name)}" data-guest-platform="${attr(badge.platform)}"` : ""}`;
-}
-/** A separate session fence for Chat playback: public/guest viewers acquire no owner-pref identity. */
-function shellEffect(req, ctx, mode) {
-    if (mode !== "full" || typeof ctx.effectBoot !== "string" || !/^[0-9a-f]{32}$/.test(ctx.effectBoot))
-        return null;
-    const v = evaluateWebRequest(req, new URL(req.url ?? "/", "http://localhost"), ctx.webToken ?? null, ctx.webSessions, { touch: false });
-    if (v.kind !== "allow" || v.via !== "session" || !v.session || !/^[a-f0-9]{16}$/.test(v.session.handle))
-        return null;
-    return { boot: ctx.effectBoot, epoch: v.session.handle, scope: gatewayRequestContext(req) || v.session.tier === "guest" ? "chat" : "owner" };
+    const trusted = ctx.guestTrusted?.(owner) ? ' data-guest-level="trusted"' : "";
+    return ` data-tier="guest"${trusted}${badge ? ` data-guest-name="${attr(badge.name)}" data-guest-platform="${attr(badge.platform)}"` : ""}`;
 }
 function shellBodyTag(req, ctx, mode, viewer) {
     const p = shellPreview(req, ctx, mode);
-    const ownerCss = shellOwnerCss(ctx, mode, viewer), effect = shellEffect(req, ctx, mode);
+    const ownerCss = shellOwnerCss(ctx, mode, viewer);
     let ownerCssState = mode === "full" && (gatewayRequestContext(req) || viewer?.guest) ? "off" : "unknown";
     if (mode === "full" && !viewer?.guest && viewer?.person != null && ctx.ownerCss) {
         ownerCssState = ctx.ownerCss.effectState(viewer.person);
@@ -4594,17 +4483,15 @@ function shellBodyTag(req, ctx, mode, viewer) {
     }
     const attr = (v) => String(v ?? "").replace(/[&<>"']/g, c => `&#${c.charCodeAt(0)};`);
     return `<body data-mode="${mode}"${mode === "full" && gatewayRequestContext(req) ? ' data-web-transport="poll"' : ""} data-dashboard-origin="${attr(p?.dashboardOrigin)}" data-preview-origin="${attr(p?.previewOrigin)}"`
-        + `${effect ? ` data-effect-boot="${effect.boot}" data-effect-epoch="${effect.epoch}" data-effect-scope="${effect.scope}"` : ""}`
         + ` data-preview-boot="${attr(p?.previewOrigin ? p.boot : "")}" data-preview-reason="${attr(p ? p.reason : "Previews are not available on this fleet.")}"`
         // #1554: no availability asked (the public link, or not the full app) still says why, in the page's language.
         + ` data-preview-reason-code="${attr(p ? p.code ?? "" : gatewayRequestContext(req) ? "publicLink" : "notOffered")}"`
         // #1723: why the public link's preview tunnel failed (a fixed reason the page words), when it did.
         + `${p?.detail ? ` data-preview-detail="${attr(p.detail)}"` : ""}`
         // #1523 N3: whether the fleet serves /api/ai-usage (web.usage_panel), for every page's ◔ — never to a guest (#1920).
-        + ` data-usage-panel="${ctx.fleetConfig?.web?.usage_panel === false || viewer?.guest ? "0" : "1"}"`
+        + ` data-usage-panel="${ctx.fleetConfig?.web?.usage_panel === false ? "0" : "1"}"` // #2855: guests' too
         // #1218: whether the Log tab is on (web.log_tab; off by default): the tab says so and offers to turn it on.
         + ` data-log-tab="${ctx.fleetConfig?.web?.log_tab === true ? "1" : "0"}"`
-        + ` data-canvas-worker="${canvasWorkerEnabled(ctx.fleetConfig?.web) ? "1" : "0"}"`
         // #1937: the upload limits in force for this page (the config's; the public link's own cap on it) — what the chat
         // checks before sending a file, and the numbers its words say. The server checks again on every upload.
         + ` data-upload-limits="${attr(JSON.stringify(uploadLimits(ctx.fleetConfig?.web, { publicLink: gatewayRequestContext(req) !== undefined })))}"`
@@ -4634,10 +4521,7 @@ export function serveAppShell(req, res, ctx, mode) {
         // A public-link page frames what its exposure's preview names (the quick-tunnel wildcard: its host is not known when
         // the page may load); every other page frames exactly the origin this load chose (#1723).
         const previewFrames = p && "frameSrc" in p ? p.frameSrc : p?.previewOrigin ? `${p.previewOrigin}/frame` : null;
-        // This fixed trusted document is independent of HTML preview. Its own response confines all Worker execution.
-        const effectOrigin = gatewayRequestContext(req)?.expectedOrigin ?? dashboardOriginFor(typeof req.headers.host === "string" ? req.headers.host : undefined, isSecureRequest(req));
-        const effectFrame = shellEffect(req, ctx, mode) && effectOrigin ? `${effectOrigin}/effect-bootstrap` : null;
-        const frameSrc = [previewFrames, effectFrame].filter(Boolean).join(" ");
+        const frameSrc = previewFrames ?? "";
         sendPanelHtml(res, withAppIconLinks(html).replace('<html lang="en">', shellHtmlTag(ctx, mode, viewer)).replace("<body>", shellBodyTag(req, ctx, mode, viewer)), 200, {}, { ...(frameSrc ? { frameSrc } : {}), mediaSrc });
     }
     catch {