@songsid/agend 2.3.0-beta.4 → 2.3.0-beta.5

package/dist/ui/shared/instance-nav.js

@@ -9,7 +9,7 @@
 // Public (/assets/): an anonymous View reader gets the same list, fed by View's roster read instead of status frames.
 import { html, useLayoutEffect, useRef, useState } from "./app-html.js";
 import { t } from "./app-i18n.js";
-import { appStore, createStore, useStore } from "./app-store.js";
+import { appStore, createStore, guestPage, useStore } from "./app-store.js";
 import { chatPath, detailsPath, logPath, viewPath } from "./app-route.js";
 import { Icon } from "./ui-icons.js";
 import { Skeleton } from "./ui-states.js";
@@ -391,10 +391,13 @@ export function InstanceNav({ route, items, loaded = true, exec = {}, awaiting =
   const favs = nav.favorites.filter((n) => known.has(n));
   const favSet = new Set(favs);
   const canStar = !viewOnly && prefsWritable();
+  // #1920: a guest's list is to pick from — no reordering and no filters (one this device kept would hide rows with no
+  // way to clear it).
+  const guest = guestPage();
   const shownGroups = favs.length ? [FAV_GROUP, ...groupNames] : groupNames;
   const shownInsts = new Map([...instByGroup].map(([g, names]) => [g, names.filter((n) => !favSet.has(n))]));
   if (favs.length) shownInsts.set(FAV_GROUP, favs);
-  const f = nav.filter;
+  const f = guest ? { q: "", status: [], cli: [] } : nav.filter;
   const shown = filterSidebar(shownGroups, shownInsts, byName, f.q, backendLabel, { status: f.status, cli: f.cli, statusOf: facetOf });
   // #1936: while a filter is on, the instance you have open stays on top, pinned and marked "Current", whether or not
   // it matches; a match is not repeated below. "N / M" still counts the filter's matches (the pinned row counts only
@@ -408,7 +411,7 @@ export function InstanceNav({ route, items, loaded = true, exec = {}, awaiting =
   const flip = (key, value) => { const cur = new Set(navStore.get().filter[key]); if (cur.has(value)) cur.delete(value); else cur.add(value); setNavFilter({ [key]: [...cur] }); };
   // Drag to reorder: only the full list (a filtered subset would be ambiguous), groups among groups, instances within
   // their group.
-  const dragProps = (item) => shown.active ? {} : {
+  const dragProps = (item) => shown.active || guest ? {} : {
     draggable: true,
     onDragStart: (e) => { drag.current = item; e.currentTarget.classList.add("dragging"); try { e.dataTransfer.effectAllowed = "move"; e.dataTransfer.setData("text/plain", item.name); } catch { /* Firefox needs data */ } },
     onDragEnd: (e) => { e.currentTarget.classList.remove("dragging"); drag.current = null; },
@@ -504,7 +507,7 @@ export function InstanceNav({ route, items, loaded = true, exec = {}, awaiting =
     })}
     ${loaded && shown.active && !shown.groups.length ? html`<p class="side-empty">${tn("filterNone")}</p>` : null}
     </div>
-    <div class="v-filter">
+    ${guest ? null : html`<div class="v-filter">
       <label class="v-filter-box"><${Icon} name="search" size=${14} /><span class="sr-only">${tn("filterPh")}</span>
         <input ref=${filterRef} id="filterInput" type="text" autocomplete="off" spellcheck=${false} placeholder=${tn("filterPh")} value=${f.q}
           onInput=${(e) => setNavFilter({ q: e.target.value })}
@@ -520,7 +523,7 @@ export function InstanceNav({ route, items, loaded = true, exec = {}, awaiting =
         </div>
         <p class="note nav-shown" aria-live="polite">${shown.shown} / ${shown.total}${shown.active ? ` ${tn("filterShown")}` : ""}</p>
       </div>
-    </div>
+    </div>`}
   </div>`;
 }
 

package/dist/web-api.d.ts

@@ -1,4 +1,5 @@
 import { type HumanOrigin } from "./human-delivery-receipts.js";
+import { type HumanAuthority, type WebAuthorityResult, type WebPeer } from "./authority/web-authority.js";
 import type { CachedImage } from "./web-images.js";
 import type { SettingsExecution } from "./settings-transaction.js";
 import type { PaneContextSource } from "./pane-context-cache.js";
@@ -13,7 +14,7 @@ import type { LifecycleCreateArgs } from "./instance-lifecycle.js";
 import { type PreviewAvailability } from "./web-preview.js";
 import { type WebChatHistory } from "./web-chat-history.js";
 import { type WebFileLedger } from "./web-upload.js";
-import type { WebSessionStore } from "./web-session.js";
+import type { WebSessionStore, SessionRecord } from "./web-session.js";
 import { type WebPrefsStore } from "./web-prefs.js";
 import { type WebAccount } from "./web-profile.js";
 import { type MentionNames, type MentionQuery } from "./web-mentions.js";
@@ -204,10 +205,18 @@ export interface WebApiContext {
     }, opts: {
         publicLink: boolean;
         person?: WebPerson;
+        authority?: HumanAuthority;
     }): Promise<{
         status: number;
         body: unknown;
     }>;
+    /** #1939 S1: the design's §3 for one request (`instance` once the body names it); absent: web carries no authority. */
+    webAuthority?(input: {
+        session: SessionRecord | null;
+        gateway: boolean;
+        peer: WebPeer;
+        instance?: string;
+    }): WebAuthorityResult;
     /**
      * #1827: a web person — for the account a session is bound to (none: the operator) — as agents and chats see them.
      * Absent: everyone is "web-user", as before.
@@ -238,6 +247,7 @@ export interface WebApiContext {
         userId: string;
         name: string;
         guest?: true;
+        authority?: HumanAuthority;
     }): Promise<{
         status: number;
         error?: string;
@@ -359,6 +369,11 @@ export interface AppShellContext {
     readonly ownerCss?: OwnerCssStore;
     readonly webToken?: string | null;
     readonly webSessions?: WebApiContext["webSessions"];
+    /** #1920 phase 3: a guest's page says who it is signed in as (its web name and platform), for its "Guest" chip. */
+    guestBadge?(owner: WebAccount): {
+        name: string;
+        platform: string;
+    };
 }
 export type AppShellMode = "full" | "view-only";
 /** The app shell page for one entry, under the panels' CSP; it may frame exactly <preview origin>/frame, and only

package/dist/web-api.js

@@ -1,4 +1,5 @@
 import { webHumanOrigin } from "./human-delivery-receipts.js";
+import { classifyWebPeer, confirmAfterBody, noAuthority } from "./authority/web-authority.js";
 import { guestChatRefusal, guestCommandText, guestDeliveries, guestFrameData, guestHistory, guestMessages, guestPollBody, guestPrefs, guestRequestOf, guestSeesMessage, guestStatus } from "./web-guest-access.js";
 import { withSpawnHoldReply } from "./spawn-hold-reply.js";
 import { binaryProbe } from "./binary-probe.js";
@@ -902,6 +903,17 @@ function webPersonOf(req, url, ctx) {
     const who = webAccountOf(req, url, ctx);
     return who ? ctx.webPerson(who.owner) : null;
 }
+/**
+ * #1939 S1: whether this request carries `web-session` authority, asked as it stands now — on arrival without an instance,
+ * after the body with the one it names (then confirmAfterBody joins the two). Never touches the session.
+ */
+function webAuthorityOf(req, url, ctx, instance) {
+    if (!ctx.webAuthority)
+        return { authority: noAuthority(0), refusal: "not_session" };
+    const v = evaluateWebRequest(req, url, ctx.webToken ?? null, ctx.webSessions, { touch: false });
+    return ctx.webAuthority({ session: v.kind === "allow" && v.via === "session" ? v.session : null, gateway: !!gatewayRequestContext(req),
+        peer: classifyWebPeer(req), ...(instance !== undefined ? { instance } : {}) });
+}
 /** #1827: the person, or the request is answered 401 here (it is no longer authorized) and null is returned. */
 function webPersonOr401(req, res, url, ctx) {
     const p = webPersonOf(req, url, ctx);
@@ -989,6 +1001,8 @@ export function handleWebRequest(req, res, url, ctx) {
         return true;
     }
     if (method === "GET" && path === "/ui/backends") {
+        // #2072 (#2098 review P3-3): the backend an agent created with "fleet default" runs, so its model list can be shown.
+        const defaultBackend = ctx.fleetConfig?.defaults?.backend ?? "claude-code";
         const BACKENDS = [
             { name: "claude-code", binary: "claude" },
             { name: "codex", binary: "codex" },
@@ -1005,7 +1019,7 @@ export function handleWebRequest(req, res, url, ctx) {
                 name: r.backend, binary: binaryOf.get(r.backend).binary, installed: r.state !== "not_installed" && r.path !== null, path: r.path ?? "",
                 deprecated: binaryOf.get(r.backend).deprecated ?? false, state: r.state, minVersion: r.minVersion, ...(r.state === "unknown" ? { unknown: true } : {}),
             }));
-            json(res, 200, { backends });
+            json(res, 200, { backends, defaultBackend });
             return true;
         }
         // #1490: seven sequential 2 s `execFileSync("which")` calls used to block the event loop here. The shared probe
@@ -1017,7 +1031,7 @@ export function handleWebRequest(req, res, url, ctx) {
             return { name: b.name, binary: b.binary, installed: path !== null, path: path ?? "", deprecated: b.deprecated ?? false,
                 ...(found.known ? {} : { unknown: true }) };
         })).then((backends) => { if (!res.headersSent)
-            json(res, 200, { backends }); }, () => { if (!res.headersSent)
+            json(res, 200, { backends, defaultBackend }); }, () => { if (!res.headersSent)
             json(res, 500, { error: "backend probe failed" }); });
         return true;
     }
@@ -1540,6 +1554,7 @@ export function handleWebRequest(req, res, url, ctx) {
             return true;
         }
         const click = ctx.clickWebReplyButton.bind(ctx);
+        const arrival = webAuthorityOf(req, url, ctx); // #1939 §3: on arrival, and again after the body
         (async () => {
             let body;
             try {
@@ -1577,7 +1592,8 @@ export function handleWebRequest(req, res, url, ctx) {
             if (!person)
                 return;
             // #1920 review: a guest's choice reaches the agent marked as a guest's, as its typed messages do.
-            const r = await click(instance, id, index, { key: person.voterKey, userId: person.userId, name: person.name, ...(guest ? { guest: true } : {}) });
+            const { authority } = confirmAfterBody(arrival, webAuthorityOf(req, url, ctx, instance));
+            const r = await click(instance, id, index, { key: person.voterKey, userId: person.userId, name: person.name, ...(guest ? { guest: true } : {}), authority });
             json(res, r.status, r.status === 200 ? { answered: true, ...(r.options ? { options: r.options } : {}) } : { error: r.error ?? "Refused", ...(r.status === 409 ? { gone: true } : {}) });
         })().catch(err => {
             ctx.logger.error({ err: err.message }, "Web reply-button click failed");
@@ -1761,6 +1777,7 @@ export function handleWebRequest(req, res, url, ctx) {
             return true;
         }
         const run = ctx.webCommand.bind(ctx);
+        const arrival = webAuthorityOf(req, url, ctx); // #1939 §3: on arrival, and again after the body
         (async () => {
             let body;
             try {
@@ -1789,7 +1806,8 @@ export function handleWebRequest(req, res, url, ctx) {
             const person = webPersonOr401(req, res, url, ctx); // #1827: asked again, now the body is in
             if (!person)
                 return;
-            const r = await run({ instance, command, args: str(body.args, MAX_COMMAND_ARGS), confirm: body.confirm }, { publicLink: !!gatewayRequestContext(req), person });
+            const { authority } = confirmAfterBody(arrival, webAuthorityOf(req, url, ctx, instance));
+            const r = await run({ instance, command, args: str(body.args, MAX_COMMAND_ARGS), confirm: body.confirm }, { publicLink: !!gatewayRequestContext(req), person, authority });
             json(res, r.status, r.body);
         })().catch(err => {
             ctx.logger.error({ err: err.message }, "Web command failed");
@@ -2445,6 +2463,7 @@ function webEchoPreview(message, names) {
 }
 /** Handle POST /ui/send — extracted for readability. */
 function handleSendMessage(req, res, ctx) {
+    const arrival = webAuthorityOf(req, new URL(req.url ?? "/", "http://localhost"), ctx); // #1939 §3: again after the body
     let body = "";
     let size = 0;
     req.on("data", (chunk) => {
@@ -2512,6 +2531,8 @@ function handleSendMessage(req, res, ctx) {
                 json(res, 401, { error: WEB_TOKEN_INVALID_MESSAGE });
                 return;
             }
+            // #1939 S1: what the receipt records about who authorized it (observe only: agents still read web as recognition).
+            const { authority } = confirmAfterBody(arrival, webAuthorityOf(req, new URL(req.url ?? "/", "http://localhost"), ctx, instance));
             const ts = new Date().toISOString();
             // The id the agent is given, and the one its delivery reports come back under: the page's ticks.
             const messageId = newWebMessageId();
@@ -2547,7 +2568,7 @@ function handleSendMessage(req, res, ctx) {
             let delivered;
             try {
                 const deliver = (name, payload) => ctx.deliverHumanToInstance
-                    ? ctx.deliverHumanToInstance(name, payload, webHumanOrigin(), typed)
+                    ? ctx.deliverHumanToInstance(name, payload, webHumanOrigin(false, authority), typed)
                     : ctx.deliverToInstance(name, payload);
                 delivered = await deliver(instance, {
                     type: "fleet_inbound",
@@ -2825,8 +2846,8 @@ function prefsViewer(req, url, ctx) {
         return null;
     // #1920: a guest is a guest on every listener. The public link's page and reads too — before, a guest signed in through
     // it (#2094) read the host's preferences unfiltered: the sidebar's order and favourites, naming instances out of its
-    // scope.
-    const guest = v.via === "session" && v.session?.tier === "guest" ? { guest: true } : {};
+    // scope. Its account (phase 3) names it on its page.
+    const guest = v.via === "session" && v.session?.tier === "guest" ? { guest: true, ...(v.session.owner ? { owner: v.session.owner } : {}) } : {};
     if (!gatewayRequestContext(req) && v.via === "session" && v.session) {
         const person = webPersonKey(v.session.owner);
         return { person, epoch: v.session.handle, scope: person === OPERATOR ? "operator" : "person", canWrite: v.session.tier === "admin", via: "session", ...guest };
@@ -2854,6 +2875,10 @@ function shellHtmlTag(ctx, mode, viewer) {
 function shellOwnerCss(ctx, mode, viewer) {
     return mode === "full" && viewer?.person !== null && viewer?.person !== undefined && ctx.ownerCss ? ctx.ownerCss.active(viewer.person) : null;
 }
+function guestBodyAttrs(ctx, owner, attr) {
+    const badge = ctx.guestBadge?.(owner);
+    return ` data-tier="guest"${badge ? ` data-guest-name="${attr(badge.name)}" data-guest-platform="${attr(badge.platform)}"` : ""}`;
+}
 function shellBodyTag(req, ctx, mode, viewer) {
     const p = shellPreview(req, ctx, mode);
     const ownerCss = shellOwnerCss(ctx, mode, viewer);
@@ -2870,8 +2895,8 @@ function shellBodyTag(req, ctx, mode, viewer) {
         + ` data-preview-reason-code="${attr(p ? p.code ?? "" : gatewayRequestContext(req) ? "publicLink" : "notOffered")}"`
         // #1723: why the public link's preview tunnel failed (a fixed reason the page words), when it did.
         + `${p?.detail ? ` data-preview-detail="${attr(p.detail)}"` : ""}`
-        // #1523 N3: whether the fleet serves /api/ai-usage (web.usage_panel), for every page's ◔.
-        + ` data-usage-panel="${ctx.fleetConfig?.web?.usage_panel === false ? "0" : "1"}"`
+        // #1523 N3: whether the fleet serves /api/ai-usage (web.usage_panel), for every page's ◔ — never to a guest (#1920).
+        + ` data-usage-panel="${ctx.fleetConfig?.web?.usage_panel === false || viewer?.guest ? "0" : "1"}"`
         // #1218: whether the Log tab is on (web.log_tab; off by default): the tab says so and offers to turn it on.
         + ` data-log-tab="${ctx.fleetConfig?.web?.log_tab === true ? "1" : "0"}"`
         // #1937: the upload limits in force for this page (the config's; the public link's own cap on it) — what the chat
@@ -2882,7 +2907,9 @@ function shellBodyTag(req, ctx, mode, viewer) {
         // #1629 r4 §3: the person's owner CSS in force (a sha), linked by the page unless this device or this load says not.
         + ` data-owner-css-state="${ownerCssState}"${ownerCss ? ` data-owner-css="${attr(ownerCss)}"` : ""}`
         // #1589: the public link shows attachments as downloads only (no inline text or media): its scope is unchanged.
-        + `${gatewayRequestContext(req) ? ' data-public-link="1"' : ""}>`;
+        + `${gatewayRequestContext(req) ? ' data-public-link="1"' : ""}`
+        // #1920 phase 3: a guest's page — the shell shows only what a guest may use, and who it is signed in as.
+        + `${mode === "full" && viewer?.guest && viewer.owner ? guestBodyAttrs(ctx, viewer.owner, attr) : ""}>`;
 }
 /** The app shell page for one entry, under the panels' CSP; it may frame exactly <preview origin>/frame, and only
  *  when this load chose one. */