@songsid/agend 2.2.0-beta.11 → 2.2.0-beta.13

package/dist/fleet-manager.d.ts

@@ -439,7 +439,6 @@ export declare class FleetManager implements FleetContext, LifecycleContext, Arc
     private updateProgressTimer;
     private updateProgressEditRunning;
     private lastUpdateProgressText;
-    private updateCompletionTipText;
     /**
      * #1660: an adopted update whose retire outcome is still owed. The
      * completion summary was (or will be) posted; this watch appends the

package/dist/fleet-manager.js

@@ -178,7 +178,7 @@ import { assertExplicitInstanceRemoval } from "./instance-removal.js";
 import { KNOWN_BACKENDS, validateFleetConfig } from "./config-validator.js";
 import { isRemovedBackend, removedBackendMessage } from "./backend/removed.js";
 import { presentationState, interactionSummary, sameInteractionOwner } from "./interaction-observation.js";
-import { readLastInboundAt } from "./daemon.js";
+import { DEFAULT_STUCK_TIMEOUT_MS, readLastInboundAt } from "./daemon.js";
 import { clearPausedMarker, readPausedAt, readPauseReason, writePausedMarker } from "./pause-marker.js";
 import { readBackgroundWorkEndedMarker } from "./background-work-ended.js";
 import { DEFAULT_WARM_OVERFLOW, WakeCoordinator } from "./wake-coordinator.js";
@@ -189,7 +189,7 @@ import { isSetupComplete, markSetupComplete } from "./setup-marker.js";
 import { manualCleanupMessage, reapStaleTunnel } from "./tunnel/lease.js";
 import { buildToolPermissionsNotice } from "./tool-permissions-notice.js";
 import { NeedsYouHub } from "./needs-you-hub.js";
-import { WEB_CHAT_NOTICE, WEB_REMOTE_DOCS_URL, claimNotice, hasWebChat, releaseNotice, upgradeNoticesPath } from "./upgrade-notices.js";
+import { WEB_CHAT_NOTICE, claimNotice, hasWebChat, releaseNotice, upgradeNoticesPath } from "./upgrade-notices.js";
 import { GENERAL_PAUSE_ERROR, isGeneralInstance } from "./general-instance.js";
 import { buildOrgChart } from "./web-org.js";
 import { CacheService, WINDOWS } from "./cache-service.js";
@@ -762,7 +762,6 @@ export class FleetManager {
     updateProgressTimer = null;
     updateProgressEditRunning = false;
     lastUpdateProgressText = null;
-    updateCompletionTipText = null;
     /**
      * #1660: an adopted update whose retire outcome is still owed. The
      * completion summary was (or will be) posted; this watch appends the
@@ -1662,6 +1661,7 @@ export class FleetManager {
                     content: payload.content,
                     delivery_id: claimed.deliveryId,
                     delivery_attempt: String(claimed.attemptNo),
+                    ...(isSilentScheduleDelivery(claimed) ? { silent_schedule: true } : {}),
                 }, { waitForIdle: false, noInlineWake: this.deliveryWorkerMode(target) !== "off" });
             }
             else {
@@ -2316,14 +2316,14 @@ export class FleetManager {
         // "not a beta" and sent a beta install to @latest. #1450 C5: the INSTALLED agend, verified, by absolute path.
         const installed = await resolveInstalledAgend();
         if (!installed.ok) {
-            this.failUpdateProgress(`/update cannot verify the installed AgEnD (${installed.reason}). Run \`agend update\` from a shell.`);
+            this.failUpdateProgress(`${t("update.failure.shell")} ${t("update.failure.installed", installed.reason)}`);
             return;
         }
         const origin = `slash /update by ${adapterId}:${data.userId}`;
         recordInternalRequest(this.dataDir, "update", origin);
         const launch = await resolveUpdateLaunch(installed.agend);
         if (!launch.ok) {
-            this.failUpdateProgress(`/update cannot prepare an independent updater (${launch.reason}). Run ` + "`agend update` from a host shell.");
+            this.failUpdateProgress(`${t("update.failure.shell")} ${t("update.failure.independent", launch.reason)}`);
             return;
         }
         if (this.fleetAdminGate(data.userId, adapterId) !== "ok" || this.shuttingDown) {
@@ -5398,13 +5398,12 @@ export class FleetManager {
         const adapter = owner.binding;
         const status = this.getPublicWebStatus();
         const publicAllowed = publicLinkSettings(this.fleetConfig?.web).allowed;
-        const tgHint = adapter.type === "telegram" && dmChatId === undefined ? this.tgStartWebUrl(owner.adapterId) : null;
-        const menuText = this.topicCommands.getDashboardText(false, !publicAllowed)
-            + (publicAllowed ? "\n\n" + t("dashboard.public_risk") : "")
-            + "\n" + t("dashboard.public_status", status.state, status.remainingSeconds ?? 0)
-            + (status.expiresAt ? t("dashboard.public_until", formatFleetTime(status.expiresAt)) : "")
-            + (tgHint ? "\n" + t("dashboard.menu_tg_hint", tgHint) : "");
-        const choices = [{ action: "local", label: t("dashboard.local") },
+        // Show the action before any link exists. TG's Start instructions belong to confirmed DM refusal below.
+        const menuText = this.topicCommands.getDashboardMenuText()
+            + (publicAllowed ? "\n" + t("dashboard.public_risk") : "")
+            + (status.state !== "closed" ? "\n" + t("dashboard.public_status", status.state, status.remainingSeconds ?? 0)
+                + (status.expiresAt ? t("dashboard.public_until", formatFleetTime(status.expiresAt)) : "") : "");
+        const choices = [{ action: "local", label: t("dashboard.local_signin") },
             ...(publicLinkSettings(this.fleetConfig?.web).allowed ? [{ action: "public", label: t("dashboard.public_open") }] : []),
             ...(status.state !== "closed" ? [{ action: "close", label: t("dashboard.public_close") }] : [])];
         const posted = await this.postNonceButtonPrompt({
@@ -5480,9 +5479,11 @@ export class FleetManager {
                 return false;
             this.initializeWebSessions();
             const issued = this.webLoginCodes.issue({ epoch: tokenEpoch(token), audience: exposureId, owner });
-            // #1586: the expiry in the fleet's zone with its offset, never a bare UTC ISO string.
-            const text = t("dashboard.private_link", url, issued.display, Math.round(LOGIN_CODE_TTL_MS / 60_000), expiresAt ? formatFleetTime(expiresAt) : t("dashboard.local"))
-                + "\n" + t("dashboard.code_next");
+            // Only a public link has a link expiry; the code's five-minute lifetime applies to either packet.
+            const minutes = Math.round(LOGIN_CODE_TTL_MS / 60_000);
+            const text = expiresAt !== undefined
+                ? t("dashboard.private_public", url, issued.display, minutes, formatFleetTime(expiresAt))
+                : t("dashboard.private_local", url, issued.display, minutes);
             const deadline = performance.now() + 10_000;
             const direct = owner.binding;
             // The route the sign-in message took: the code-only follow-up takes the same one (#1586).
@@ -5671,7 +5672,6 @@ export class FleetManager {
             messageId,
         });
         this.lastUpdateProgressText = null;
-        this.updateCompletionTipText = null;
         this.startUpdateProgressMonitor(adapter);
     }
     /** Persist the public response, wait for idle, then start the canonical service restart. */
@@ -5702,7 +5702,6 @@ export class FleetManager {
             return false;
         }
         this.lastUpdateProgressText = null;
-        this.updateCompletionTipText = null;
         this.startUpdateProgressMonitor(adapter);
         await this.waitForFullRestartIdleGrace();
         // An update can begin while the idle wait yields. Never launch a second
@@ -5942,17 +5941,8 @@ export class FleetManager {
             const adapter = this.adapters.get(target.adapterId) ?? (initialAdapter?.id === target.adapterId ? initialAdapter : undefined);
             if (!adapter)
                 return;
-            let text = formatUpdateProgress(marker);
-            // No-restart updates complete in the old fleet process, so they never
-            // reach RestartProgress.finish(). Append the same optional tip here.
-            if (marker.progress.stage === "complete" && this.tipsEnabled()) {
-                if (this.updateCompletionTipText === null) {
-                    const tip = this.pickAvailableTip();
-                    this.updateCompletionTipText = tip ? this.formatTip(tip) : "";
-                }
-                if (this.updateCompletionTipText)
-                    text += `\n\n${this.updateCompletionTipText}`;
-            }
+            // #1854: no tip on an update's completion (either path); tips come on their own schedule and from /tips.
+            const text = formatUpdateProgress(marker);
             if (text === this.lastUpdateProgressText)
                 return;
             this.updateProgressEditRunning = true;
@@ -6456,12 +6446,6 @@ export class FleetManager {
                 pausedNames,
                 failedNames,
                 backgroundWorkEndedNames,
-                tipText: pendingProgressOperation === "update" && this.tipsEnabled()
-                    ? (() => {
-                        const tip = this.pickAvailableTip();
-                        return tip ? this.formatTip(tip) : undefined;
-                    })()
-                    : undefined,
                 ...(cleanupOutcome && "render" in cleanupOutcome
                     ? { warningText: cleanupOutcome.render.warning, warningCommand: cleanupOutcome.render.cleanupCommand }
                     : {}),
@@ -8462,7 +8446,7 @@ export class FleetManager {
             if (!claimNotice(path, WEB_CHAT_NOTICE, adapterId))
                 continue;
             try {
-                await world.adapter.sendText(target.chatId, t("upgrade.web_chat", WEB_REMOTE_DOCS_URL), target.opts);
+                await world.adapter.sendText(target.chatId, t("upgrade.web_chat"), target.opts);
                 this.logger.info({ adapterId, notice: WEB_CHAT_NOTICE }, "Announced web chat in General");
             }
             catch (err) {
@@ -14579,7 +14563,7 @@ export class FleetManager {
         const instanceHangConfig = this.fleetConfig?.instances[instanceName]?.hang_detector;
         const configuredMinutes = instanceHangConfig?.timeout_minutes
             ?? this.fleetConfig?.defaults?.hang_detector?.timeout_minutes
-            ?? 15;
+            ?? DEFAULT_STUCK_TIMEOUT_MS / 60_000; // #1854: the detector's own default (10 min), not a stale 15
         const unchangedMinutes = unchangedForMs == null
             ? configuredMinutes
             : Math.max(1, Math.floor(unchangedForMs / 60_000));