@songsid/agend 2.2.0-beta.1 → 2.2.0-beta.2

package/dist/cli.js

@@ -1546,7 +1546,8 @@ program
             catch {
                 return false;
             } },
-            // `agend install` activates by default; the update owns stop/start, so only the file is refreshed here.
+            // `agend install` activates by default; the update owns stop/start, so only the file is refreshed here. Only
+            // an existing service is refreshed: a detached fleet's update never calls this (#1631).
             refresh: () => {
                 const result = capture(newAgend.command, [...newAgend.args, "install", "--no-activate"]);
                 if (result.status === 0)
@@ -1663,6 +1664,42 @@ program
         process.exitCode = 1;
         return;
     }
+    // ── Check if npm global needs sudo (read-only; decides the nvm path the preflight judges) ──
+    let needsSudo = false;
+    try {
+        const prefix = execSync("npm config get prefix", { encoding: "utf-8" }).trim();
+        const { accessSync, constants } = await import("node:fs");
+        try {
+            accessSync(prefix, constants.W_OK);
+        }
+        catch {
+            needsSudo = true;
+        }
+    }
+    catch { /* assume no sudo needed */ }
+    // ── #1441 B: can the target run here, on the Node it will actually run on? ──
+    // Read where the install runs (#1623 review): a direct install runs `npm` and the release's `node` from this
+    // environment, so it is decided now, before anything is touched. An nvm install runs nvm's npm and Node 22, which
+    // exist only once nvm has selected them: runUpdateInstall decides it there, before the lock and npm.
+    const preflight = targetVersion ? await import("./update-preflight.js") : null;
+    if (preflight && targetVersion && !needsSudo) {
+        const verdict = preflight.preflightUpdate({
+            run: (argv, timeoutMs) => {
+                const r = spawnSync(argv[0], argv.slice(1), { encoding: "utf-8", timeout: timeoutMs, stdio: ["ignore", "pipe", "ignore"] });
+                return { status: r.status, stdout: r.stdout ?? "" };
+            },
+            npm: "npm",
+        }, pkg, targetVersion, "the `node` on PATH");
+        if (verdict.kind === "refuse") {
+            console.error(`\n${verdict.message}\n`);
+            // A chat-started /update (Discord, Telegram, an agent) is waiting on this: the reason is its outcome.
+            setUpdateProgressStage(DATA_DIR, "failed", { error: `Not updated: ${verdict.summary}. Nothing was changed.` });
+            process.exitCode = 1;
+            return;
+        }
+        if (verdict.kind === "unknown")
+            console.log(verdict.note);
+    }
     if (targetVersion) {
         console.log(`\n  Updating AgEnD v${pkgVersion} → v${targetVersion}...\n`);
     }
@@ -1684,19 +1721,6 @@ program
         process.exit(1);
     };
     setUpdateProgressStage(DATA_DIR, "downloading");
-    // ── Check if npm global needs sudo ──
-    let needsSudo = false;
-    try {
-        const prefix = execSync("npm config get prefix", { encoding: "utf-8" }).trim();
-        const { accessSync, constants } = await import("node:fs");
-        try {
-            accessSync(prefix, constants.W_OK);
-        }
-        catch {
-            needsSudo = true;
-        }
-    }
-    catch { /* assume no sudo needed */ }
     if (needsSudo) {
         // ── nvm path: install without sudo ──
         if (!existsSync(nvmSh)) {
@@ -1728,6 +1752,9 @@ program
     process.once("exit", () => releaseLock());
     const installed = runUpdateInstall({
         pkg, targetVersion, viaNvm: needsSudo, nvmSh, rollback: true,
+        ...(preflight && targetVersion && needsSudo
+            ? { preflight: preflight.installPreflight(pkg, targetVersion, "the Node 22 nvm selected", { log: m => console.log(m), error: m => console.error(m) }) }
+            : {}),
         lock: prefix => {
             const lock = acquireInstallLock(prefix, { spec: pkg, agendHome: DATA_DIR }, {
                 pid: process.pid, processStart: admission.processStart, newToken: () => randomBytes(16).toString("hex"),
@@ -1786,7 +1813,19 @@ program
     .option("--activate", "Deprecated; service activation is now the default")
     .option("--no-activate", "Write the service file without activating it")
     .action(async (opts) => {
-    const { installService, activateService, detectPlatform, renderLaunchdPlist, launchdPlistPath } = await import("./service-installer.js");
+    const { installService, activateService, detectPlatform, renderLaunchdPlist, launchdPlistPath, getServicePath, getSystemServicePath } = await import("./service-installer.js");
+    // #1631 B: an older updater (2.2.0-beta.1 and before) refreshes a hand-started fleet's service too, through this
+    // command — which would CREATE a unit or plist, and every later update would then take a manager it may not reach
+    // as the authority. When no service exists and it is certain this is that updater's refresh, write nothing. A
+    // manual `agend install` (with or without --no-activate) creates the service as always.
+    if (opts.activate === false && getServicePath() === null && getSystemServicePath() === null) {
+        const { startedByUpdater, systemUpdaterCallerProbe } = await import("./updater-caller.js");
+        const caller = startedByUpdater(systemUpdaterCallerProbe(DATA_DIR, pkgVersion));
+        if (caller.updater) {
+            console.log("  No service to refresh: this update runs a hand-started fleet, so none was created (`agend install` creates one).");
+            return;
+        }
+    }
     const execPath = canonicalCliEntry();
     const serviceVars = {
         label: "com.agend.fleet",
@@ -2578,7 +2617,7 @@ program
     console.log("Web token rotated.");
     console.log("Every previously issued dashboard link and browser session is now rejected.");
     console.log("A running fleet picks this up immediately — no restart needed.");
-    console.log("Sign in again with `agend web` (prints a one-time code), or /dashboard in your chat channel.");
+    console.log("Sign in again with `agend web` (prints a one-time code), or /web in your chat channel.");
 });
 program
     .command("view")