@songsid/agend 2.1.4-beta.51 → 2.1.4-beta.53

package/dist/fleet-manager.js

@@ -1,7 +1,7 @@
 import { existsSync, readFileSync, mkdirSync, writeFileSync, unlinkSync, rmSync, readdirSync, renameSync, copyFileSync, chmodSync, statSync } from "node:fs";
 import { randomBytes } from "node:crypto";
 import { spawnSync } from "node:child_process";
-import { freemem } from "node:os";
+import { freemem, totalmem } from "node:os";
 import { createServer } from "node:http";
 import { join, dirname, basename } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -567,7 +567,8 @@ export class FleetManager {
     getSysInfo() {
         const mem = process.memoryUsage();
         const toMB = (b) => Math.round(b / 1024 / 1024 * 10) / 10;
-        const instances = Object.keys(this.fleetConfig?.instances ?? {}).map(name => ({
+        // Fleet instances (fleet.yaml)
+        const fleetInstances = Object.keys(this.fleetConfig?.instances ?? {}).map(name => ({
             name,
             status: this.getInstanceStatus(name),
             state: this.getInstanceExecutionState(name),
@@ -575,12 +576,46 @@ export class FleetManager {
             costCents: this.costGuard?.getDailyCostCents(name) ?? 0,
             rateLimits: this.statuslineWatcher.getRateLimits(name) ?? null,
         }));
+        // Classic instances (classicBot.yaml) — dedupe against fleet
+        const fleetNames = new Set(fleetInstances.map(i => i.name));
+        const classicInstances = (this.classicChannels?.getAll() ?? [])
+            .filter(ch => !fleetNames.has(ch.instanceName))
+            .map(ch => ({
+            name: ch.instanceName,
+            status: this.getInstanceStatus(ch.instanceName),
+            state: this.getInstanceExecutionState(ch.instanceName),
+            ipc: this.instanceIpcClients.has(ch.instanceName),
+            costCents: this.costGuard?.getDailyCostCents(ch.instanceName) ?? 0,
+            rateLimits: this.statuslineWatcher.getRateLimits(ch.instanceName) ?? null,
+        }));
+        // Combined roster (matches /api/fleet and agend ls)
+        const allInstances = [...fleetInstances, ...classicInstances];
+        // Fleet summary counts (fleet + Classic combined)
+        const running_count = allInstances.filter(i => i.status === "running").length;
+        const paused_count = allInstances.filter(i => i.status === "paused").length;
+        // System memory (GB, 1 decimal)
+        const totalGB = totalmem() / (1024 ** 3);
+        const usedGB = (totalmem() - freemem()) / (1024 ** 3);
+        const system_mem_gb = {
+            used: Math.round(usedGB * 10) / 10,
+            total: Math.round(totalGB * 10) / 10,
+        };
+        // Fleet memory: O(1) cgroup read (includes entire service tree: fleet + CLIs + MCP servers)
+        // This avoids blocking the event loop with per-instance tree scans.
+        const fleetMem = readFleetMemory();
+        const fleet_mem_mb = fleetMem.cgroupAnonBytes != null
+            ? Math.round(fleetMem.cgroupAnonBytes / (1024 * 1024) * 10) / 10
+            : null;
         return {
             uptime_seconds: Math.floor((Date.now() - this.startedAt) / 1000),
             memory_mb: { rss: toMB(mem.rss), heapUsed: toMB(mem.heapUsed), heapTotal: toMB(mem.heapTotal) },
-            instances,
+            instances: fleetInstances, // SysInfo.instances is fleet-only; /api/fleet enriches with Classic
             fleet_cost_cents: this.costGuard?.getFleetTotalCents() ?? 0,
             fleet_cost_limit_cents: this.costGuard?.getLimitCents() ?? 0,
+            running_count,
+            paused_count,
+            fleet_mem_mb,
+            system_mem_gb,
         };
     }
     /** Load fleet.yaml and build routing table */
@@ -1334,6 +1369,7 @@ export class FleetManager {
             throw new Error("Classic channel manager not initialized");
         const wasRunning = this.daemons.has(instanceName);
         this.classicChannels.reloadFromDisk();
+        this.reportClassicUnrecoverableIds();
         this.reregisterClassicChannels();
         const channel = this.classicChannels.getAll().find(item => item.instanceName === instanceName);
         if (!channel)
@@ -2000,6 +2036,11 @@ export class FleetManager {
         this.classicChannels = new ClassicChannelManager(this.dataDir, this.logger);
         const classicAdapters = fleet.channels?.length ? fleet.channels : (fleet.channel ? [fleet.channel] : []);
         this.classicChannels.configureAdapters(classicAdapters);
+        // The unrecoverable-id report is deliberately NOT sent here: no adapter
+        // exists yet at this point in startAll(), so notifyFleetError would find
+        // nothing to deliver through, drop the message silently, AND burn its
+        // 10-minute throttle key on the way out. It is sent once the shared adapter
+        // is up — see the adapterStartup continuation below.
         // Restore the persisted bot binding so replies/cancel go through the right
         // bot after a restart (before this, inbound would re-bind lazily).
         for (const ch of this.classicChannels.getAll()) {
@@ -2023,6 +2064,9 @@ export class FleetManager {
                 }
                 if (!this.classicChannels.checkReload())
                     return;
+                // A reload can introduce a bad id (hand edit) or clear one; the
+                // throttle keeps a repeated report from flooding the topic.
+                this.reportClassicUnrecoverableIds();
                 this.reregisterClassicChannels();
                 for (const ch of this.classicChannels.getAll()) {
                     const newBackend = this.classicChannels.getBackendByInstance(ch.instanceName, fleetBackend);
@@ -2257,6 +2301,10 @@ export class FleetManager {
                 catch (err) {
                     this.logger.error({ err }, "startSharedAdapter failed — fleet continues without some adapters");
                 }
+                // Now that there is somewhere to deliver: a classicBot.yaml that already
+                // holds an unmatchable id at boot is the COMMON case, and reporting it
+                // before the adapter existed meant the operator heard nothing at all.
+                this.reportClassicUnrecoverableIds();
             })();
             progressStart = adapterStartup.then(() => {
                 if (pendingUpdateProgress) {
@@ -2913,7 +2961,8 @@ export class FleetManager {
                 await data.respond(text);
             }
             else if (data.command === "sysinfo") {
-                await data.respond(this.topicCommands.getSysInfoText());
+                // Slash commands are Discord-only; use plain lines (no markdown table)
+                await data.respond(this.topicCommands.getSysInfoText({ platform: "discord" }));
             }
             else if (data.command === "dashboard") {
                 // Reply is ephemeral (adapter defers non-chat commands ephemerally), so
@@ -3259,7 +3308,8 @@ export class FleetManager {
                 await data.respond(text);
             }
             else if (data.command === "sysinfo") {
-                await data.respond(this.topicCommands.getSysInfoText());
+                // Slash commands are Discord-only; use plain lines (no markdown table)
+                await data.respond(this.topicCommands.getSysInfoText({ platform: "discord" }));
             }
             else if (data.command === "dashboard") {
                 // Reply is ephemeral (adapter defers non-chat commands ephemerally), so
@@ -5357,6 +5407,31 @@ export class FleetManager {
      * The log line is written by the caller regardless: if every adapter is down,
      * the only notification path is the one that is broken.
      */
+    /**
+     * Surface ids that can never match into the operator's General topic.
+     *
+     * The load-time log is still silence for anyone not reading daemon.log, and a
+     * chat that never gets in with nothing said anywhere is exactly the failure
+     * this line of work exists to remove. notifyFleetError throttles by message
+     * text for 10 minutes and resolves its target from config, so the 30s reload
+     * poll cannot flood the topic and a down General does not swallow it.
+     */
+    reportClassicUnrecoverableIds() {
+        const bad = this.classicChannels?.getUnrecoverableIds?.() ?? [];
+        if (bad.length === 0)
+            return;
+        // notifyFleetError claims its throttle key BEFORE attempting delivery, so
+        // calling it with no adapter would silence this message for ten minutes
+        // without anyone having seen it. Log and leave the key unspent; a later
+        // call, once an adapter exists, still gets through.
+        if (!this.adapter && this.adapters.size === 0) {
+            this.logger.error({ ids: bad }, "classicBot.yaml holds ids that can never match — deferring the operator notice until an adapter is up");
+            return;
+        }
+        const list = bad.map(e => `${e.field}: ${e.value}`).join(", ");
+        this.logger.error({ ids: bad }, "classicBot.yaml holds ids that can never match");
+        this.notifyFleetError(t("classic.unrecoverable_ids", list));
+    }
     notifyFleetError(text) {
         const now = Date.now();
         const key = text.slice(0, 200);
@@ -9764,72 +9839,81 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             }
             // Fleet API (enriched for agent board)
             if (req.method === "GET" && req.url === "/api/fleet") {
-                const sysInfo = this.getSysInfo();
-                const fleetInstances = sysInfo.instances.map(inst => ({ ...inst, classic: false }));
-                const fleetNames = new Set(fleetInstances.map(inst => inst.name));
-                const classicInstances = (this.classicChannels?.getAll() ?? [])
-                    .filter(channel => !fleetNames.has(channel.instanceName))
-                    .map(channel => ({
-                    name: channel.instanceName,
-                    status: this.getInstanceStatus(channel.instanceName),
-                    state: this.getInstanceExecutionState(channel.instanceName),
-                    ipc: this.instanceIpcClients.has(channel.instanceName),
-                    costCents: this.costGuard?.getDailyCostCents(channel.instanceName) ?? 0,
-                    rateLimits: this.statuslineWatcher.getRateLimits(channel.instanceName) ?? null,
-                    classic: true,
-                    classicName: channel.name,
-                    channelId: channel.channelId,
-                    adapterId: channel.adapterId ?? null,
-                }));
-                const enriched = [...fleetInstances, ...classicInstances].map(inst => {
-                    const config = this.fleetConfig?.instances[inst.name];
-                    const persistedInboundAt = readLastInboundAt(this.getInstanceDir(inst.name));
-                    const lastActivity = inst.classic
-                        ? Math.max(persistedInboundAt ?? 0, readClassicLastActivityAt(this.dataDir, inst.name) ?? 0) || null
-                        : (persistedInboundAt ?? this.lastActivityMs(inst.name)) || null;
-                    const backend = this.backendNameForInstance(inst.name);
-                    const resolvedModel = this.resolveInstanceModel(inst.name);
-                    const effortStrategy = this.effortStrategyFor(inst.name);
-                    const resolvedEffort = this.resolveInstanceEffort(inst.name);
-                    // Find claimed tasks for this instance
-                    let currentTask = null;
-                    try {
-                        const tasks = this.scheduler?.db.listTasks({ assignee: inst.name, status: "claimed" });
-                        if (tasks?.length)
-                            currentTask = tasks[0].title;
-                    }
-                    catch (err) {
-                        this.logger.debug({ err, name: inst.name }, "Scheduler listTasks failed (/api/fleet)");
+                try {
+                    const sysInfo = this.getSysInfo();
+                    const fleetInstances = sysInfo.instances.map(inst => ({ ...inst, classic: false }));
+                    const fleetNames = new Set(fleetInstances.map(inst => inst.name));
+                    const classicInstances = (this.classicChannels?.getAll() ?? [])
+                        .filter(channel => !fleetNames.has(channel.instanceName))
+                        .map(channel => ({
+                        name: channel.instanceName,
+                        status: this.getInstanceStatus(channel.instanceName),
+                        state: this.getInstanceExecutionState(channel.instanceName),
+                        ipc: this.instanceIpcClients.has(channel.instanceName),
+                        costCents: this.costGuard?.getDailyCostCents(channel.instanceName) ?? 0,
+                        rateLimits: this.statuslineWatcher.getRateLimits(channel.instanceName) ?? null,
+                        classic: true,
+                        classicName: channel.name,
+                        channelId: channel.channelId,
+                        adapterId: channel.adapterId ?? null,
+                    }));
+                    const enriched = [...fleetInstances, ...classicInstances].map(inst => {
+                        const config = this.fleetConfig?.instances[inst.name];
+                        const persistedInboundAt = readLastInboundAt(this.getInstanceDir(inst.name));
+                        const lastActivity = inst.classic
+                            ? Math.max(persistedInboundAt ?? 0, readClassicLastActivityAt(this.dataDir, inst.name) ?? 0) || null
+                            : (persistedInboundAt ?? this.lastActivityMs(inst.name)) || null;
+                        const backend = this.backendNameForInstance(inst.name);
+                        const resolvedModel = this.resolveInstanceModel(inst.name);
+                        const effortStrategy = this.effortStrategyFor(inst.name);
+                        const resolvedEffort = this.resolveInstanceEffort(inst.name);
+                        // Find claimed tasks for this instance
+                        let currentTask = null;
+                        try {
+                            const tasks = this.scheduler?.db.listTasks({ assignee: inst.name, status: "claimed" });
+                            if (tasks?.length)
+                                currentTask = tasks[0].title;
+                        }
+                        catch (err) {
+                            this.logger.debug({ err, name: inst.name }, "Scheduler listTasks failed (/api/fleet)");
+                        }
+                        return {
+                            ...inst,
+                            description: config?.description ?? ("classicName" in inst ? inst.classicName : null),
+                            backend,
+                            // Settings renders these runtime-effective values rather than the
+                            // sparse user-authored YAML. `auto` means the supported CLI is
+                            // using its own effort default; null is reserved for unsupported.
+                            model: resolvedModel.model,
+                            model_display: resolvedModel.display,
+                            model_source: resolvedModel.source,
+                            effort: effortStrategy === "unsupported" ? null : (resolvedEffort.effort ?? "auto"),
+                            effort_supported: effortStrategy !== "unsupported",
+                            tool_set: config?.tool_set ?? "full",
+                            general_topic: config?.general_topic ?? false,
+                            // User activity is persisted by the daemon, so both the board and
+                            // auto-pause retain an accurate age across fleet restarts.
+                            lastActivity,
+                            currentTask,
+                            idle: this.getInstanceIdle(inst.name),
+                            state: this.getInstanceExecutionState(inst.name),
+                        };
+                    });
+                    res.setHeader("Access-Control-Allow-Origin", "*");
+                    res.writeHead(200);
+                    res.end(JSON.stringify({
+                        ...sysInfo,
+                        version: this.currentVersion,
+                        instances: enriched,
+                    }));
+                }
+                catch (err) {
+                    this.logger.error({ err }, "/api/fleet failed");
+                    if (!res.headersSent) {
+                        res.writeHead(500);
+                        res.end("Internal Server Error");
                     }
-                    return {
-                        ...inst,
-                        description: config?.description ?? ("classicName" in inst ? inst.classicName : null),
-                        backend,
-                        // Settings renders these runtime-effective values rather than the
-                        // sparse user-authored YAML. `auto` means the supported CLI is
-                        // using its own effort default; null is reserved for unsupported.
-                        model: resolvedModel.model,
-                        model_display: resolvedModel.display,
-                        model_source: resolvedModel.source,
-                        effort: effortStrategy === "unsupported" ? null : (resolvedEffort.effort ?? "auto"),
-                        effort_supported: effortStrategy !== "unsupported",
-                        tool_set: config?.tool_set ?? "full",
-                        general_topic: config?.general_topic ?? false,
-                        // User activity is persisted by the daemon, so both the board and
-                        // auto-pause retain an accurate age across fleet restarts.
-                        lastActivity,
-                        currentTask,
-                        idle: this.getInstanceIdle(inst.name),
-                        state: this.getInstanceExecutionState(inst.name),
-                    };
-                });
-                res.setHeader("Access-Control-Allow-Origin", "*");
-                res.writeHead(200);
-                res.end(JSON.stringify({
-                    ...sysInfo,
-                    version: this.currentVersion,
-                    instances: enriched,
-                }));
+                }
                 return;
             }
             // Activity API