@songsid/agend 2.1.4-beta.11 → 2.1.4-beta.13

package/dist/fleet-manager.js

@@ -9,7 +9,7 @@ import { formatUpdateProgress } from "./update-progress.js";
 import { sdNotify, sdNotifyBlocking } from "./sd-notify.js";
 import { readFleetMemory } from "./process-memory.js";
 import { ReplyDeduper } from "./reply-dedup.js";
-import { isScalar, parseDocument } from "yaml";
+import { isMap, isScalar, parseDocument } from "yaml";
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 /** Fallback access policy for a channel with no `access:` block — open (no gate). */
@@ -54,6 +54,7 @@ import { releaseProcessFleetLock } from "./fleet-lock.js";
 import { GENERAL_PAUSE_ERROR, isGeneralInstance } from "./general-instance.js";
 import { loadOrCreateWebToken, WEB_TOKEN_INVALID_MESSAGE } from "./web-auth.js";
 import { RestartProgress } from "./restart-progress.js";
+import { collectRedundantInstanceDefaultPaths } from "./fleet-yaml-slim.js";
 import { getTmuxSession } from "./config.js";
 export function resolveReplyThreadId(argsThreadId, instanceConfig) {
     if (typeof argsThreadId === "string" && argsThreadId.length > 0) {
@@ -1453,6 +1454,7 @@ export class FleetManager {
         // Rotate fleet.log if oversized (before any logging)
         rotateLogIfNeeded(join(this.dataDir, "fleet.log"));
         const fleet = this.loadConfig(configPath);
+        this.slimFleetConfigAtStartup();
         setLocale(detectLocale(fleet)); // user-facing text language (fleet.yaml defaults.locale / timezone)
         const savedUpdateProgress = readUpdateProgress(this.dataDir);
         const pendingUpdateProgress = savedUpdateProgress
@@ -3902,7 +3904,29 @@ export class FleetManager {
     }
     /** Resolve display name for an instance, fallback to instance name. */
     resolveDisplayName(instanceName) {
-        return this.fleetConfig?.instances[instanceName]?.display_name ?? instanceName;
+        return this.fleetConfig?.instances[instanceName]?.display_name
+            ?? this.classicChannels?.getAll().find(ch => ch.instanceName === instanceName)?.displayName
+            ?? instanceName;
+    }
+    /** Persist identity to the instance's actual config store. Classic instances
+     * are registry rows in classicBot.yaml, not fleet.yaml instance entries. */
+    setInstanceDisplayName(instanceName, displayName) {
+        const fleetInstance = this.fleetConfig?.instances[instanceName];
+        if (fleetInstance) {
+            fleetInstance.display_name = displayName;
+            this.saveFleetConfig();
+            return true;
+        }
+        return this.classicChannels?.setDisplayNameByInstance(instanceName, displayName) ?? false;
+    }
+    setInstanceDescription(instanceName, description) {
+        const fleetInstance = this.fleetConfig?.instances[instanceName];
+        if (fleetInstance) {
+            fleetInstance.description = description;
+            this.saveFleetConfig();
+            return true;
+        }
+        return this.classicChannels?.setDescriptionByInstance(instanceName, description) ?? false;
     }
     handleSetDisplayName(instanceName, msg) {
         const fleetRequestId = msg.fleetRequestId;
@@ -3915,8 +3939,10 @@ export class FleetManager {
             ipc.send({ type: "fleet_display_name_response", fleetRequestId, error: "Name must be 1-30 characters" });
             return;
         }
-        this.fleetConfig.instances[instanceName].display_name = displayName;
-        this.saveFleetConfig();
+        if (!this.setInstanceDisplayName(instanceName, displayName)) {
+            ipc.send({ type: "fleet_display_name_response", fleetRequestId, error: `Instance '${instanceName}' not found` });
+            return;
+        }
         this.logger.info({ instanceName, displayName }, "Display name set");
         ipc.send({ type: "fleet_display_name_response", fleetRequestId, result: { display_name: displayName } });
     }
@@ -3931,8 +3957,10 @@ export class FleetManager {
             ipc.send({ type: "fleet_description_response", fleetRequestId, error: "Description cannot be empty" });
             return;
         }
-        this.fleetConfig.instances[instanceName].description = description;
-        this.saveFleetConfig();
+        if (!this.setInstanceDescription(instanceName, description)) {
+            ipc.send({ type: "fleet_description_response", fleetRequestId, error: `Instance '${instanceName}' not found` });
+            return;
+        }
         this.logger.info({ instanceName, description: description.slice(0, 80) }, "Description set");
         ipc.send({ type: "fleet_description_response", fleetRequestId, result: { description } });
     }
@@ -4061,8 +4089,8 @@ export class FleetManager {
             return { error: "Fleet config not available" };
         if (!name || name.length > 30)
             return { error: "Name must be 1-30 characters" };
-        this.fleetConfig.instances[instance].display_name = name;
-        this.saveFleetConfig();
+        if (!this.setInstanceDisplayName(instance, name))
+            return { error: `Instance '${instance}' not found` };
         return { display_name: name };
     }
     async handleSetDescriptionHttp(instance, description) {
@@ -4070,8 +4098,8 @@ export class FleetManager {
             return { error: "Fleet config not available" };
         if (!description)
             return { error: "Description cannot be empty" };
-        this.fleetConfig.instances[instance].description = description;
-        this.saveFleetConfig();
+        if (!this.setInstanceDescription(instance, description))
+            return { error: `Instance '${instance}' not found` };
         return { description };
     }
     summarizeToolCall(tool, args) {
@@ -4203,7 +4231,8 @@ export class FleetManager {
     }
     /**
      * Patch only values changed in the effective config into the original YAML
-     * document. Unknown keys, explicit overrides and comments remain untouched.
+     * document. Unknown keys and comments remain untouched; redundant
+     * non-identity instance leaves are canonicalized to inheritance afterward.
      */
     saveFleetConfig(explicitPatches = []) {
         if (!this.fleetConfig || !this.configPath)
@@ -4219,9 +4248,9 @@ export class FleetManager {
         }
         this.rawFleetConfig = loadRawFleetConfig(this.configPath);
         this.patchFleetDocument(this.rawFleetDocument, [], this.savedFleetConfigSnapshot, this.fleetConfig);
-        // Settings edits are expressed against the raw config. Persist them even
-        // when the chosen override equals the inherited effective value, a case
-        // the before/after runtime diff cannot observe.
+        // Settings edits are expressed against the raw config, so apply them before
+        // canonicalization. A non-identity value equal to its inherited default is
+        // intentionally stored as inheritance rather than an explicit duplicate.
         for (const patch of explicitPatches) {
             if (patch.remove) {
                 // YAML's deleteIn throws when an inherited nested key has no raw parent
@@ -4236,7 +4265,24 @@ export class FleetManager {
                 this.patchFleetDocument(this.rawFleetDocument, patch.path, before, patch.value);
             }
         }
+        const rawAfterPatches = this.rawFleetDocument.toJS();
+        const redundantPaths = collectRedundantInstanceDefaultPaths(rawAfterPatches);
+        for (const path of redundantPaths) {
+            if (this.rawFleetDocument.hasIn(path))
+                this.rawFleetDocument.deleteIn(path);
+            // Avoid leaving empty operational maps such as `terminal: {}` while
+            // preserving the instance mapping itself and all surrounding comments.
+            for (let depth = path.length - 1; depth > 2; depth--) {
+                const parentPath = path.slice(0, depth);
+                const parent = this.rawFleetDocument.getIn(parentPath, true);
+                if (!isMap(parent) || parent.items.length > 0)
+                    break;
+                this.rawFleetDocument.deleteIn(parentPath);
+            }
+        }
         const output = String(this.rawFleetDocument);
+        if (redundantPaths.length > 0)
+            this.writeFleetConfigBackup(source);
         const tempPath = `${this.configPath}.tmp-${process.pid}`;
         writeFileSync(tempPath, output, "utf-8");
         if (existsSync(this.configPath))
@@ -4244,7 +4290,36 @@ export class FleetManager {
         renameSync(tempPath, this.configPath);
         this.rawFleetConfig = loadRawFleetConfig(this.configPath);
         this.savedFleetConfigSnapshot = structuredClone(this.fleetConfig);
-        this.logger.info({ path: this.configPath }, "Saved fleet config (lossless patch)");
+        this.logger.info({ path: this.configPath, strippedDefaults: redundantPaths.length }, "Saved fleet config (lossless patch)");
+    }
+    /** One-time upgrade migration; invalid YAML is never rewritten. */
+    slimFleetConfigAtStartup() {
+        const redundantPaths = collectRedundantInstanceDefaultPaths(this.rawFleetConfig);
+        if (redundantPaths.length === 0)
+            return;
+        const validation = validateFleetConfig(this.rawFleetConfig);
+        if (!validation.valid) {
+            this.logger.warn({ errors: validation.errors, redundantDefaults: redundantPaths.length }, "Skipping fleet.yaml default slimming because the raw config is invalid");
+            return;
+        }
+        try {
+            this.saveFleetConfig();
+            this.logger.info({ strippedDefaults: redundantPaths.length, backup: `${this.configPath}.bak` }, "Slimmed redundant instance defaults in fleet.yaml");
+        }
+        catch (err) {
+            // A migration must not turn a previously bootable fleet into an outage.
+            this.logger.warn({ err }, "Could not slim fleet.yaml; continuing with the original config");
+        }
+    }
+    writeFleetConfigBackup(source) {
+        if (!this.configPath)
+            return;
+        const backupPath = `${this.configPath}.bak`;
+        const tempPath = `${backupPath}.tmp-${process.pid}`;
+        writeFileSync(tempPath, source, "utf-8");
+        if (existsSync(this.configPath))
+            chmodSync(tempPath, statSync(this.configPath).mode);
+        renameSync(tempPath, backupPath);
     }
     patchFleetDocument(document, path, before, after) {
         if (Object.is(before, after))
@@ -4296,7 +4371,12 @@ export class FleetManager {
                 currentNode.value = after;
             }
             else {
-                document.setIn(path, after);
+                // Use a YAML collection node for newly-added objects. Passing the raw
+                // object creates a scalar wrapper: it serializes, but nested hasIn /
+                // deleteIn cannot traverse it (notably when slimming create_instance).
+                document.setIn(path, after !== null && typeof after === "object"
+                    ? document.createNode(after)
+                    : after);
             }
         }
     }
@@ -7078,6 +7158,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             return;
         const workDir = join(getAgendHome(), "workspaces", instanceName);
         ensureWorkspaceGit(workDir);
+        const classicIdentity = this.classicChannels?.getAll().find(ch => ch.instanceName === instanceName);
         const config = {
             ...DEFAULT_INSTANCE_CONFIG,
             ...this.fleetConfig?.defaults,
@@ -7085,6 +7166,8 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             lightweight: true,
             ...(backend ? { backend } : {}),
             ...(model ? { model } : {}),
+            ...(classicIdentity?.displayName ? { display_name: classicIdentity.displayName } : {}),
+            ...(classicIdentity?.description ? { description: classicIdentity.description } : {}),
             ...(autoPauseAfter !== undefined ? { auto_pause_after: autoPauseAfter } : {}),
             ...(preTaskCommand ? { pre_task_command: preTaskCommand } : {}),
         };