@soltech/fluid-common 1.4.2 → 1.4.3

package/AGENTS.md

@@ -3,6 +3,7 @@
 Read this entire file before every task.
 
 ## Agent Rules & Safety
+- Never edit any files when the current git branch is `main` — always work on a feature branch. Run `git branch --show-current` to confirm before making any changes.
 - Never touch `.env*`, `certs/` or any file containing secrets/credentials.
 - Never introduce new dependencies without asking first.
 - Never rewrite large parts of the codebase unless explicitly requested.
@@ -17,7 +18,18 @@ Read this entire file before every task.
 ## Build, Dev & Validation
 - Build: `npm run build`
 - Lint: `npm run lint`
-- Publish: `npm run pub` (build + publish + push)
+- Publish: see Publishing Flow below
+
+### Publishing Flow
+The correct sequence before publishing a new version:
+1. Make all code changes to `src/index.ts`.
+2. Bump `version` in `package.json`.
+3. Run `npm i` (updates `package-lock.json`).
+4. Commit all changes (`src/index.ts`, `package.json`, `package-lock.json`).
+5. Push the commit: `git push`.
+6. Publish to npm: `npm publish` (this runs `npm run build` first via the `pub` script, or run `npm run build && npm publish` directly).
+
+Do **not** use `npm run pub` as a single command — it pushes *after* publishing, which means npm gets the package before git has a clean commit.
 
 Before final proposal on code changes:
 1. Run `npm run lint`.
@@ -41,3 +53,8 @@ When creating PRs, always include a Shortcut ticket reference in the PR body usi
 ```
 [sc-17649](https://app.shortcut.com/soltech/story/17649/ticket-title-slug)
 ```
+
+### PR description scope
+
+- The PR description must reflect **all changes in the branch**, not just the most recent commit. Run `git log main..HEAD` and review the full diff before writing or updating the description.
+- When a ticket spans multiple repos (e.g. a type/enum change here in `fluid-common` that also requires updates in `fluid-api`, `fluid-widget`, or `fluid-payments`), list the related repos and their PRs in the description so reviewers have the full picture. Name each repo, briefly describe what changed, and cross-link the corresponding PRs.

package/lib/index.d.ts

@@ -20,6 +20,11 @@ export declare enum PaymentType {
     CRYPTO = "Crypto",
     EWALLET = "EWallet"
 }
+export declare enum WindowRedirectType {
+    POPUP_WINDOW = "popupWindow",
+    BROWSER_TAB = "browserTab",
+    NONE = "none"
+}
 export interface WalletRequestBody {
     payload?: object | string;
     payloadOptions?: TransactionOptions;
@@ -115,7 +120,7 @@ export interface PaymentMethod {
     bonusCodes?: string[];
     instructions?: string;
     fees?: PaymentMethodFees;
-    popupWindowRedirect: boolean;
+    windowRedirectType?: WindowRedirectType;
     voucherAmounts?: number[];
     depositHandledByHostSite?: boolean;
     withdrawalHandledByHostSite?: boolean;

package/lib/index.js

@@ -24,6 +24,12 @@ export var PaymentType;
     PaymentType["CRYPTO"] = "Crypto";
     PaymentType["EWALLET"] = "EWallet";
 })(PaymentType || (PaymentType = {}));
+export var WindowRedirectType;
+(function (WindowRedirectType) {
+    WindowRedirectType["POPUP_WINDOW"] = "popupWindow";
+    WindowRedirectType["BROWSER_TAB"] = "browserTab";
+    WindowRedirectType["NONE"] = "none";
+})(WindowRedirectType || (WindowRedirectType = {}));
 export var EncryptionType;
 (function (EncryptionType) {
     EncryptionType["NO_ENCRYPTION"] = "NO_ENCRYPTION";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@soltech/fluid-common",
-	"version": "1.4.2",
+	"version": "1.4.3",
 	"type": "module",
 	"description": "Fluid frontend, API and AI common interfaces & enums",
 	"main": "lib/index.js",

package/src/index.ts

@@ -24,6 +24,12 @@ export enum PaymentType {
 	EWALLET = 'EWallet'
 }
 
+export enum WindowRedirectType {
+	POPUP_WINDOW = 'popupWindow',
+	BROWSER_TAB  = 'browserTab',
+	NONE         = 'none'
+}
+
 export interface WalletRequestBody {
 	payload?: object | string;
 	payloadOptions?: TransactionOptions;
@@ -129,7 +135,7 @@ export interface PaymentMethod {
 	bonusCodes?: string[];
 	instructions?: string;
 	fees?: PaymentMethodFees;
-	popupWindowRedirect: boolean;
+	windowRedirectType?: WindowRedirectType;
 	voucherAmounts?: number[];
 	depositHandledByHostSite?: boolean;
 	withdrawalHandledByHostSite?: boolean;