@solidstarters/solid-core 1.2.149 → 1.2.150

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidstarters/solid-core",
-  "version": "1.2.149",
+  "version": "1.2.150",
   "description": "This module is a NestJS module containing all the required core providers required by a Solid application",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/services/media.service.ts

@@ -84,7 +84,6 @@ export class MediaService extends CRUDService<Media> {
     const savedMedias = [];
     for (let i = 0; i < files.length; i++) {
 
-
       createDto['fieldMetadata'] = await this.fieldMetadataRepo.findOne({
         where: {
           id: createDto['fieldMetadataId']
@@ -113,9 +112,9 @@ export class MediaService extends CRUDService<Media> {
           const fileName = this.getFileName(file);
           let awsFileUrl;
           if (createDto.mediaStorageProviderMetadata.isPublic === true) {
-            awsFileUrl = await this.fileService.copyToS3(file.path, file.mimetype, fileName, createDto.mediaStorageProviderMetadata.bucketName,);
-          } else {
             awsFileUrl = await this.fileService.copyToS3WithPublic(file.path, file.mimetype, fileName, createDto.mediaStorageProviderMetadata.bucketName,);
+          } else {
+            awsFileUrl = await this.fileService.copyToS3(file.path, file.mimetype, fileName, createDto.mediaStorageProviderMetadata.bucketName,);
           }
           // createDto['relativeUri'] = this.getAwsS3FullFilePath(awsFileUrl, createDto.mediaStorageProviderMetadata.bucketName, createDto.mediaStorageProviderMetadata.region);
           createDto['relativeUri'] = awsFileUrl

package/src/services/mediaStorageProviders/file-s3-storage-provider.ts

@@ -60,7 +60,7 @@ export class FileS3StorageProvider<T> implements MediaStorageProvider<T> {
             throw new Error("Entity must be an instance of CommonEntity"); //FIXME This needs to be handled through generics. e.g T extends CommonEntity
         }
         const result: Media[] = [];
-        files.forEach(async (file) => {
+        for (const file of files) {
             const fileName = this.getFileName(file);
             // Store the file in the configured S3 Bucket
             let awsFileUrl;
@@ -84,7 +84,7 @@ export class FileS3StorageProvider<T> implements MediaStorageProvider<T> {
             }) as unknown as Media;
             result.push(mediaEntity);
             this.logger.debug(`Stored media with`, mediaEntity);
-        });
+        };
         return result;
     }
 

package/src/services/mediaStorageProviders/file-storage-provider.ts

@@ -38,7 +38,7 @@ export class FileStorageProvider<T> implements MediaStorageProvider<T> {
             throw new Error("Entity must be an instance of CommonEntity"); //FIXME This needs to be handled through generics. e.g T extends CommonEntity
         }
         const result: Media[] = [];
-        files.forEach(async (file) => {
+        for (const file of files) {
             // Store the file in the configured file storage directory
             const fileStoragePath = this.getFullFilePath(this.getFileName(file));
             await this.fileService.copyFile(file.path, fileStoragePath);
@@ -57,7 +57,7 @@ export class FileStorageProvider<T> implements MediaStorageProvider<T> {
             }) as unknown as Media;
             result.push(mediaEntity);
             this.logger.debug(`Stored media with`, mediaEntity);
-        });
+        };
         return result;
     }
 
@@ -66,7 +66,7 @@ export class FileStorageProvider<T> implements MediaStorageProvider<T> {
             throw new Error("Entity must be an instance of CommonEntity"); //FIXME This needs to be handled through generics. e.g T extends CommonEntity
         }
         const result: Media[] = [];
-        streamPairs.forEach(async (pair) => {
+        for (const pair of streamPairs) {
             const stream = pair[0];
             const fileName = pair[1];
             this.fileService.writeStreamToFile(stream, this.getFullFilePath(fileName));
@@ -78,7 +78,7 @@ export class FileStorageProvider<T> implements MediaStorageProvider<T> {
                 fieldMetadataId: mediaFieldMetadata.id
             }) as unknown as Media;
             this.logger.debug(`Stored media with`, mediaEntity);
-        });
+        };
         return result;
     }