@solidstarters/solid-core 1.2.142 → 1.2.144

package/src/services/module-metadata.service.ts

@@ -22,6 +22,7 @@ import { CrudHelperService } from './crud-helper.service';
 import { ModelMetadataService } from './model-metadata.service';
 import { ModuleMetadataHelperService } from 'src/helpers/module-metadata-helper.service';
 import { DisallowInProduction } from 'src/decorators/disallow-in-production.decorator';
+import { ERROR_MESSAGES } from 'src/constants/error-messages';
 
 @Injectable()
 export class ModuleMetadataService {
@@ -77,7 +78,7 @@ export class ModuleMetadataService {
 
   async findOneByUserKey(name: string, relations = {}) {
     if (!name) {
-      throw new BadRequestException('name is required for finding entity');
+      throw new BadRequestException(ERROR_MESSAGES.ENTITY_NAME_REQUIRED);
     }
     const entity = await this.moduleMetadataRepo.findOne({
       where: {
@@ -90,7 +91,7 @@ export class ModuleMetadataService {
 
   async findOne(id: number, relations = {}) {
     if (!id) {
-      throw new BadRequestException('ID is required for finding entity');
+      throw new BadRequestException(ERROR_MESSAGES.ENTITY_ID_REQUIRED);
     }
     const entity = await this.moduleMetadataRepo.findOne({
       where: {
@@ -99,7 +100,7 @@ export class ModuleMetadataService {
       relations: relations,
     });
     if (!entity) {
-      throw new NotFoundException(`entity #${id} not found`);
+      throw new NotFoundException(ERROR_MESSAGES.ENTITY_NOT_FOUND());
     }
     return entity;
   }
@@ -194,7 +195,7 @@ export class ModuleMetadataService {
     } catch (error) {
       // console.error('File creation failed:', error);
       this.logger.error('File creation failed:', error);
-      throw new Error('File creation failed, rolling back transaction'); // Trigger rollback
+      throw new Error(ERROR_MESSAGES.FILE_WRITE_FAILED); // Trigger rollback
     }
   }
 
@@ -221,7 +222,7 @@ export class ModuleMetadataService {
     });
 
     if (!module) {
-      throw new NotFoundException(`Module ${id} not found`);
+      throw new NotFoundException(ERROR_MESSAGES.MODULE_ID_NOT_FOUND(id));
     }
     if (files.length > 0) {
 
@@ -281,7 +282,7 @@ export class ModuleMetadataService {
     } catch (error) {
       // console.error('File creation failed:', error);
       this.logger.error('File creation failed:', error);
-      throw new Error('File creation failed, rolling back transaction'); // Trigger rollback
+      throw new Error(ERROR_MESSAGES.FILE_WRITE_FAILED); // Trigger rollback
     }
   }
 
@@ -320,7 +321,7 @@ export class ModuleMetadataService {
 
   async deleteMany(ids: number[]): Promise<any> {
     if (!ids || ids.length === 0) {
-      throw new Error('At least one ID is required for deletion');
+      throw new Error(ERROR_MESSAGES.DELETE_IDS_REQUIRED);
     }
     const removedEntities = [];
     for (let i = 0; i < ids.length; i++) {
@@ -348,13 +349,13 @@ export class ModuleMetadataService {
   @DisallowInProduction()
   async generateCode(options: CodeGenerationOptions): Promise<string> {
     if (!options.moduleId && !options.moduleUserKey) {
-      throw new BadRequestException('Module ID or Module Name is required for generating code');
+      throw new BadRequestException(ERROR_MESSAGES.MODEL_REQUIRED_FOR_CODE_GENERATION);
     }
     const module = options.moduleId ? await this.findOne(options.moduleId) : await this.findOneByUserKey(options.moduleUserKey);
 
     // Check if the module exists
     if (!module) {
-      throw new NotFoundException(`Module ${options.moduleId} not found`);
+      throw new NotFoundException(ERROR_MESSAGES.MODULE_ID_NOT_FOUND(options.moduleId));
     }
 
     // Check if the module name already exists and is loaded
@@ -371,7 +372,7 @@ export class ModuleMetadataService {
 
   private async generateAddModuleCode(options: CodeGenerationOptions = { dryRun: false }): Promise<string> {
     if (!options.moduleId && !options.moduleUserKey) {
-      throw new BadRequestException('Module ID or Module Name is required for generating code');
+      throw new BadRequestException(ERROR_MESSAGES.MODEL_REQUIRED_FOR_CODE_GENERATION);
     }
     const module = options.moduleId ? await this.findOne(options.moduleId) : await this.findOneByUserKey(options.moduleUserKey);
 

package/src/services/role-metadata.service.ts

@@ -12,6 +12,7 @@ import { CrudHelperService } from "src/services/crud-helper.service";
 import { RoleMetadata } from '../entities/role-metadata.entity';
 import { PermissionMetadata } from '../entities/permission-metadata.entity';
 import { CreateRoleMetadataDto } from '../dtos/create-role-metadata.dto';
+import { ERROR_MESSAGES } from 'src/constants/error-messages';
 
 @Injectable()
 export class RoleMetadataService extends CRUDService<RoleMetadata> {
@@ -180,7 +181,7 @@ export class RoleMetadataService extends CRUDService<RoleMetadata> {
     });
 
     if (!role) {
-      throw new Error(`Role ${roleName} not found.`);
+      throw new Error(ERROR_MESSAGES.ROLE_NOT_FOUND(roleName));
     }
 
     // modify the permissions array.
@@ -194,7 +195,7 @@ export class RoleMetadataService extends CRUDService<RoleMetadata> {
       where: { name },
     });
     if (!existingPermission) {
-      throw new NotFoundException(`Permission ${name} does not exist`)
+      throw new NotFoundException(ERROR_MESSAGES.PERMISSION_NOT_EXIST(name));
     }
     return existingPermission;
   }

package/src/services/sql-expression-resolver.service.ts

@@ -1,6 +1,7 @@
 import { Injectable } from "@nestjs/common";
 import { SqlExpression, SqlExpressionOperator } from "./question-data-providers/chartjs-sql-data-provider.service";
 import { RequestContextService } from "./request-context.service";
+import { ERROR_MESSAGES } from "src/constants/error-messages";
 
 export interface SqlReplacementResult {
   rawSql: string;
@@ -117,7 +118,7 @@ export class SqlExpressionResolverService {
           break;
 
         default:
-          throw new Error(`Unsupported SQL operator: ${expr.operator}`);
+          throw new Error(ERROR_MESSAGES.UNSUPPORTED_SQL_OPERATOR(expr.operator));
       }
       simplifiedSql = simplifiedSql.replace(placeholder, sqlFragment);
     }

package/src/services/user.service.ts

@@ -15,6 +15,7 @@ import { RoleMetadata } from '../entities/role-metadata.entity';
 import { User } from '../entities/user.entity';
 import { ActiveUserData } from '../interfaces/active-user-data.interface';
 import { iamConfig } from 'src/config/iam.config';
+import { ERROR_MESSAGES } from 'src/constants/error-messages';
 
 @Injectable()
 export class UserService extends CRUDService<User> {
@@ -42,7 +43,7 @@ export class UserService extends CRUDService<User> {
   override async delete(id: number, solidRequestContext: any = {}) {
     // Prevent user from deleting themselves
     if (solidRequestContext?.activeUser?.sub === id) {
-      throw new BadRequestException('Deleting logged-in user is not allowed');
+      throw new BadRequestException(ERROR_MESSAGES.DELETE_SELF_NOT_ALLOWED);
     }
 
     // ✅ Proceed with the default deletion logic
@@ -51,12 +52,12 @@ export class UserService extends CRUDService<User> {
 
   override async deleteMany(ids: number[], solidRequestContext: any = {}): Promise<any> {
     if (!ids || ids.length === 0) {
-      throw new Error('At least one ID is required for deletion');
+      throw new Error(ERROR_MESSAGES.DELETE_IDS_REQUIRED);
     }
 
     // ❌ If the active user is trying to delete themselves
     if (solidRequestContext?.activeUser?.sub && ids.includes(solidRequestContext.activeUser.id)) {
-      throw new BadRequestException('Deleting logged-in user is not allowed');
+      throw new BadRequestException(ERROR_MESSAGES.DELETE_SELF_NOT_ALLOWED);
     }
 
     return super.deleteMany(ids, solidRequestContext);
@@ -105,7 +106,7 @@ export class UserService extends CRUDService<User> {
       }
     });
     if (!user) {
-      throw new Error(`User not found.`);
+      throw new Error(ERROR_MESSAGES.USER_NOT_FOUND);
     }
     const roles = updateDto.roles ? updateDto.roles : [];
     await this.addRolesToUser(user.username, roles);
@@ -121,11 +122,11 @@ export class UserService extends CRUDService<User> {
       }
     });
     if (!user) {
-      throw new Error(`User with username '${username}' not found.`);
+      throw new Error(ERROR_MESSAGES.USER_NOT_FOUND_BY_USERNAME(username));
     }
     const role = await this.roleRepository.findOne({ where: { name: roleName } });
     if (!role) {
-      throw new Error(`Role '${roleName}' not found.`);
+      throw new Error(ERROR_MESSAGES.ROLE_NOT_FOUND(roleName));
     }
 
     if (user.roles && user.roles.length > 0) {
@@ -145,7 +146,7 @@ export class UserService extends CRUDService<User> {
     });
 
     if (!user) {
-      throw new Error(`User with username '${username}' not found.`);
+      throw new Error(ERROR_MESSAGES.USER_NOT_FOUND_BY_USERNAME(username));
     }
 
     const roles = await this.roleRepository.find({
@@ -155,7 +156,7 @@ export class UserService extends CRUDService<User> {
     if (roles.length !== roleNames.length) {
       const foundRoleNames = roles.map(role => role.name);
       const missingRoles = roleNames.filter(roleName => !foundRoleNames.includes(roleName));
-      throw new Error(`The following roles were not found: ${missingRoles.join(', ')}`);
+      throw new Error(ERROR_MESSAGES.ROLES_NOT_FOUND(missingRoles));
     }
 
     const currentRoles = user.roles.map(role => role.name);
@@ -189,7 +190,7 @@ export class UserService extends CRUDService<User> {
     });
 
     if (!user) {
-      throw new Error(`User with username '${username}' not found.`);
+      throw new Error(ERROR_MESSAGES.USER_NOT_FOUND_BY_USERNAME(username));
     }
 
     // modify the permissions array.
@@ -261,7 +262,7 @@ export class UserService extends CRUDService<User> {
 
   async initializeRolesForNewUser(roles: string[], user: User) {
     if (!user.id) {
-      throw new BadRequestException('User must exist before initializing roles');
+      throw new BadRequestException(ERROR_MESSAGES.USER_MISSING_ID);
     }
     let userRoles = [];
     // Default Internal user role assigned