@solidrt/cli 0.0.38 → 0.0.39

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidrt/cli",
-  "version": "0.0.38",
+  "version": "0.0.39",
   "license": "MIT",
   "author": "Antoine van Wel",
   "type": "module",
@@ -22,23 +22,23 @@
     "@jridgewell/remapping": "^2.3.0",
     "@jridgewell/trace-mapping": "^0.3.25",
     "@modelcontextprotocol/sdk": "^1.29.0",
-    "babel-preset-solid": "2.0.0-beta.20",
+    "babel-preset-solid": "2.0.0-beta.26",
     "bonjour-service": "^1.4.0",
     "qrcode-generator": "^2.0.4",
     "zod": "^4.4.3"
   },
   "optionalDependencies": {
-    "@solidrt/darwin-arm64": "0.0.38",
-    "@solidrt/linux-arm64-gnu": "0.0.38",
-    "@solidrt/linux-x64-gnu": "0.0.38",
-    "@solidrt/win32-x64-msvc": "0.0.38"
+    "@solidrt/darwin-arm64": "0.0.39",
+    "@solidrt/linux-arm64-gnu": "0.0.39",
+    "@solidrt/linux-x64-gnu": "0.0.39",
+    "@solidrt/win32-x64-msvc": "0.0.39"
   },
   "peerDependencies": {
-    "@solidrt/core": "0.0.38",
+    "@solidrt/core": "0.0.39",
     "typescript": "^7"
   },
   "devDependencies": {
-    "@solidrt/flux-types": "0.0.38",
+    "@solidrt/flux-types": "0.0.39",
     "@types/babel__core": "^7.20.5",
     "@types/bun": "latest"
   }

package/scaffold/icon.svg

@@ -0,0 +1,11 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 96 96">
+  <defs>
+    <linearGradient id="bg" x1="0" y1="0" x2="1" y2="1">
+      <stop offset="0" stop-color="#5b7cfa"/>
+      <stop offset="1" stop-color="#8a5cf6"/>
+    </linearGradient>
+  </defs>
+  <rect width="96" height="96" rx="22" fill="url(#bg)"/>
+  <circle cx="48" cy="48" r="21" fill="none" stroke="#ffffff" stroke-opacity="0.9" stroke-width="6"/>
+  <circle cx="48" cy="48" r="7" fill="#ffffff"/>
+</svg>

package/scaffold/package.json

@@ -9,12 +9,12 @@
     "android": "srt client --android"
   },
   "dependencies": {
-    "@solidrt/core": "0.0.38",
-    "@solidrt/components": "0.0.38"
+    "@solidrt/core": "0.0.39",
+    "@solidrt/components": "0.0.39"
   },
   "devDependencies": {
-    "@solidrt/cli": "0.0.38",
-    "@solidrt/flux-types": "0.0.38",
+    "@solidrt/cli": "0.0.39",
+    "@solidrt/flux-types": "0.0.39",
     "typescript": "^7"
   }
 }

package/src/commands/init.ts

@@ -141,9 +141,11 @@ export async function runInitCommand() {
 
   // The assets/ convention folder, created up front: everything in it ships
   // with the app, and the dev watcher only picks up an assets/ folder that
-  // exists when it starts.
+  // exists when it starts. It starts with a placeholder app icon (picked up
+  // through the assets/icon.svg convention) for the author to replace.
   await mkdir(join(dir, "assets"), { recursive: true })
-  console.log("   Write assets/")
+  await writeFile(join(dir, "assets", "icon.svg"), await readFile(join(SCAFFOLD_DIR, "icon.svg")))
+  console.log("   Write assets/icon.svg")
 
   // The scaffold package.json carries a placeholder name; set it from the
   // target folder. A core-level app gets no component framework dependency.

package/src/commands/mcp.ts

@@ -103,7 +103,7 @@ let TOOLS: {
     name: "get_stats",
     readOnly: true,
     description:
-      "Performance statistics from a running app client: fps, CPU%, memory, smoothed JS/layout/paint/hover frame times (ms), setProperty writes per frame, demand-gate reuse/skip counts per second, and live texture count. Layout-activity counters cover the last full rebuild, raw: nodes (live node count, mounted AND detached), mountedNodes/orphanNodes (live at query time: nodes reachable from the root vs not - orphans growing at a stable tree shape mean an unmount leak; absent when no engine is running), measureCalls (text measures; mostly cache hits, cheap), paraShapes (paragraphs actually shaped; the expensive signal - high layoutMs with near-zero paraShapes means the cost is not text shaping), dirtiedNodes (layout caches cleared by property writes since the previous rebuild; how much of the tree a write burst invalidated), cacheGets/cacheHits (layout-cache lookups during the rebuild; a hit on a container skips its whole subtree, so a healthy incremental rebuild shows a near-100% hit rate - a low rate at scale means the layout cache is being defeated).",
+      "Performance statistics from a running app client: fps, CPU%, memory, smoothed JS/layout/paint/hover frame times (ms), setProperty writes per frame, demand-gate reuse/skip counts per second, and live texture count. Layout-activity counters cover the last full rebuild, raw: nodes (live node count, mounted AND detached), mountedNodes/orphanNodes (live at query time: nodes reachable from the root vs not - orphans growing at a stable tree shape mean an unmount leak; absent when no engine is running), measureCalls (text measures; mostly cache hits, cheap), paraShapes (paragraphs actually shaped; the expensive signal - high layoutMs with near-zero paraShapes means the cost is not text shaping), dirtiedNodes (layout caches cleared by property writes since the previous rebuild; how much of the tree a write burst invalidated), cacheGets/cacheHits (layout-cache lookups during the rebuild; a hit on a container skips its whole subtree, so a healthy incremental rebuild shows a near-100% hit rate - a low rate at scale means the layout cache is being defeated). GPU-side health, read live at query time (absent when no engine is running): rasterQueue (raster commands sent but not yet executed; stuck nonzero means the raster thread is backlogged - the state where fps and frameMs go blind because no frames complete), idleTicks (cumulative idle frame signals emitted while the GPU had nothing queued; idleTicks racing while rasterQueue sits nonzero would mean the idle-tick gate is broken), fenceTimeouts (cumulative present-fence waits that expired instead of signaling - each one is a frame where the GPU was over budget for 100ms+ and one-frame-in-flight pacing was lost; zero on a healthy machine, climbing means the GPU is the bottleneck right now).",
     inputSchema: { client: CLIENT_ARG },
   },
   {
@@ -137,9 +137,12 @@ let TOOLS: {
     name: "get_snapshot",
     readOnly: true,
     description:
-      "Capture a PNG image of any node in a running app client's render tree, by node id (get ids from get_render_tree). Returns the rendered pixels of that node's subtree, so you can see what the app actually drew. The node must be currently mounted and have a non-zero layout box. Works on an idle client (the capture requests its own frame); a timeout means the client's JS thread is busy or wedged, not that the app is idle.",
+      "Capture a PNG image of any node in a running app client's render tree, by node id (get ids from get_render_tree). Returns the rendered pixels of that node's subtree, so you can see what the app actually drew. Capture the smallest node that contains what you are checking (e.g. the <texture> leaf itself) - that is exactly the content at its own pixel size; the window root is mostly empty layout around it and orders of magnitude more pixels. Reserve root captures for when layout/positioning itself is the question. The node must be currently mounted and have a non-zero layout box. Works on an idle client (the capture requests its own frame); a timeout means the client's JS thread is busy or wedged, not that the app is idle.",
     inputSchema: {
-      nodeId: z.number().int().describe("Id of the node to capture, from get_render_tree"),
+      nodeId: z
+        .number()
+        .int()
+        .describe("Id of the node to capture, from get_render_tree; prefer the smallest relevant node over the root"),
       save_to: SAVE_TO_ARG,
       client: CLIENT_ARG,
     },

package/src/pack-folder.ts

@@ -37,7 +37,7 @@ export type PackFolder = {
 export function buildPackFolder(entry: string, bytecode: Buffer): PackFolder {
   let identity = loadAppIdentity(entry)
   let projectDir = projectDirFor(resolve(entry))
-  let { assets } = collectAssets(entry)
+  let { assets, icon } = collectAssets(entry)
   let copies = assets.map((a) => ({ from: join(projectDir, a.path), to: a.path }))
 
   // The full resolved font set: custom fonts are already collected assets;
@@ -70,6 +70,7 @@ export function buildPackFolder(entry: string, bytecode: Buffer): PackFolder {
     appId: identity.appId,
     org: identity.org,
     displayName: identity.displayName,
+    ...(icon ? { icon } : {}),
     runtimeVersion: RUNTIME_VERSION,
     solidrtVersion: SOLIDRT_VERSION,
     bundle: { path: "bundle.bin", sha256: hashHex(bytecode), size: bytecode.length },

package/src/project.ts

@@ -8,7 +8,10 @@ import { basename, dirname, isAbsolute, join, relative, resolve, sep } from "nod
 //     "appId": "com.example.app",   // stable identity: storage dir, Android package id
 //     "org": "Example",             // optional display metadata (publisher)
 //     "displayName": "Example App", // optional display metadata (launcher/window)
-//     "fonts": { ... }              // see fonts.ts
+//     "fonts": { ... },             // see fonts.ts
+//     "icon": "./assets/icon.svg"   // optional app icon (SVG, under assets/);
+//                                   // an undeclared assets/icon.svg is picked
+//                                   // up by convention
 //   }
 //
 // Everything defaults from the package name (or the entry filename when there
@@ -71,11 +74,13 @@ export const SOLIDRT_VERSION: string = pkgVersion === "0.0.0" ? "unknown" : pkgV
 export function buildManifest(code: string, entry: string): string {
   let identity = loadAppIdentity(entry)
   let sha256 = new Bun.CryptoHasher("sha256").update(code).digest("hex")
-  let { assets, fonts } = collectAssets(entry)
+  let { assets, fonts, icon } = collectAssets(entry)
   return JSON.stringify({
     appId: identity.appId,
+    displayName: identity.displayName,
     runtimeVersion: RUNTIME_VERSION,
     solidrtVersion: SOLIDRT_VERSION,
+    ...(icon ? { icon } : {}),
     bundle: { path: "bundle.js", sha256, size: Buffer.byteLength(code, "utf8") },
     ...(assets.length ? { assets } : {}),
     ...(fonts.length ? { fonts } : {}),
@@ -116,11 +121,19 @@ function walkAssets(assetsDir: string, dir: string, out: ManifestAsset[]) {
 
 // The convention-first asset set: everything under the project's assets/
 // folder (next to package.json), collected wholesale in sorted order so the
-// manifest bytes are deterministic. Fonts are annotations pointing into that
-// set: `solidrt.fonts` path entries must live under assets/ so they reach dev
-// clients and the version store (`false` entries only drop pack defaults and
-// have no manifest presence).
-export function collectAssets(entry: string): { assets: ManifestAsset[]; fonts: ManifestFont[] } {
+// manifest bytes are deterministic. Fonts and the icon are annotations
+// pointing into that set: `solidrt.fonts` path entries and `solidrt.icon`
+// must live under assets/ so they reach dev clients and the version store
+// (`false` font entries only drop pack defaults and have no manifest
+// presence). The icon is SVG-only for now: the launcher renders SVG natively,
+// and the raster surfaces (window icon, OS embedding) come with later stages
+// (okf/backlog/app-icons.md). An undeclared assets/icon.svg is picked up by
+// convention.
+export function collectAssets(entry: string): {
+  assets: ManifestAsset[]
+  fonts: ManifestFont[]
+  icon: string | null
+} {
   let project = findProjectPackage(entry)
   let projectDir = projectDirFor(entry)
   let assetsDir = resolve(projectDir, "assets")
@@ -146,7 +159,27 @@ export function collectAssets(entry: string): { assets: ManifestAsset[]; fonts:
       fonts.push({ path, alias })
     }
   }
-  return { assets, fonts }
+
+  let icon: string | null = null
+  let declared = project?.pkg.solidrt?.icon
+  if (declared !== undefined) {
+    if (typeof declared !== "string") fail('"solidrt": "icon" must be a string path')
+    let path = assetPathFor(projectDir, resolve(projectDir, declared))
+    if (!path) {
+      fail(`"solidrt.icon": ${declared} must live under assets/ (the icon ships as a version asset)`)
+    }
+    if (!path.toLowerCase().endsWith(".svg")) {
+      fail(`"solidrt.icon": ${declared} must be an .svg file`)
+    }
+    if (!assets.some((a) => a.path === path)) {
+      fail(`"solidrt.icon": no such file: ${resolve(projectDir, declared)}`)
+    }
+    icon = path
+  } else if (assets.some((a) => a.path === "assets/icon.svg")) {
+    icon = "assets/icon.svg"
+  }
+
+  return { assets, fonts, icon }
 }
 
 // Resolve the app identity for a pack. All three fields are guaranteed