@solidjs/start 2.0.0-rc.8 → 2.0.0

package/CHANGELOG.md

@@ -1,5 +1,46 @@
 # @solidjs/start
 
+## 2.0.0
+
+### Highlights
+
+SolidStart v2 is now stable. This release replaces Vinxi with direct use of Vite’s Environment API, providing Solid v1 applications with a simpler Vite 8 and Rolldown-powered foundation, improved compatibility with the Vite ecosystem, and direct integration with deployment plugins.
+
+SolidStart v2 requires Node.js 24 or newer and Vite 8. Most SolidStart v1 applications can upgrade by moving their framework configuration from `app.config.ts` to `vite.config.ts` and following the migration guide.
+
+- [Read the full SolidStart v2 announcement](https://github.com/solidjs/solid-start/discussions/2281)
+- [Follow the migration guide](https://docs.solidjs.com/solid-start/v2/migrating-from-v1)
+- [View the complete changelog](https://github.com/solidjs/solid-start/blob/main/packages/start/CHANGELOG.md)
+
+## 2.0.0-rc.10
+
+### Minor Changes
+
+- 3f2b7a7: The file filter logic used for CSS crawling in development can now be configured with the vite plugin option `css.filter` analog to `serverFunctions.filter`:
+
+  ```ts
+  solidStart({
+    css: {
+      filter: {
+        // Exclude all node_modules except "my-dependency" with a flat node_modules layout
+        exclude: "node_modules/!(my-dependency)/**/*",
+      },
+    },
+  });
+  ```
+
+### Patch Changes
+
+- 6581877: Fixed shared chunk css not being server rendered in production (Vite 8 regression).
+- 37d4488: Migrate the built-in Vite configuration from the deprecated `rollupOptions` alias to `rolldownOptions`.
+- 3f2b7a7: Fixed css from files with url sensitive characters such as `+` not being server-rendered.
+
+## 2.0.0-rc.9
+
+### Patch Changes
+
+- 8eef552: Remove type-only import remnants from client server-function transforms so they do not retain server-only dependency chains.
+
 ## 2.0.0-rc.8
 
 ### Patch Changes
@@ -59,7 +100,6 @@
   Route files are imported through an id carrying the picked exports in the query (`routes/api.ts?pick=GET`), which left the id ending in the export name. Plugins whose filter is anchored on the file extension (`/\.[cm]?[jt]sx?$/`, the default for `unplugin-auto-import`, `unplugin-macros` and others) silently skipped every route file. The id now ends with a `lang.<ext>` marker, the same convention Vue SFCs use for `?vue&type=script&lang.ts`. Chunk filenames are unchanged.
 
 - d8f1ea8: Apply the configured `nonce` to the two script tags that were still missing it, so a strict `script-src` CSP no longer needs `unsafe-inline`:
-
   - The client-side redirect that streaming mode emits after the shell has already flushed (`<script>window.location=...</script>`) now carries the nonce.
   - The SPA entry script tag now carries the nonce, matching the SSR entry script.
 
@@ -239,7 +279,6 @@
 - 8256190: Rework `@solidjs/start/env`
 - 6cbba24: Fix multiple Set-Cookie headers being lost on redirect responses
 - d4cc548: ## Bump Seroval
-
   - version `1.4.1`
 
 - dd40610: Handle base url in api routes

package/dist/config/index.d.ts

@@ -1,4 +1,4 @@
-import type { PluginOption } from "vite";
+import type { PluginOption, FilterPattern } from "vite";
 import { type Options as SolidOptions } from "vite-plugin-solid";
 import { type ServerFunctionsOptions } from "../directives/index.ts";
 import { type EnvPluginOptions } from "./env.ts";
@@ -14,6 +14,18 @@ export interface SolidStartOptions {
      * @default "./src"
      */
     appRoot?: string;
+    /**
+     * Options related to the css crawling logic
+     */
+    css?: {
+        /**
+         * Filter files included during css crawling in development.
+         */
+        filter?: {
+            include?: FilterPattern;
+            exclude?: FilterPattern;
+        };
+    };
     /**
      * Options forwarded to `vite-plugin-solid`.
      *

package/dist/config/index.js

@@ -82,7 +82,7 @@ export function solidStart(options) {
                     appType: "custom",
                     build: {
                         assetsDir: "_build/assets",
-                        rollupOptions: {
+                        rolldownOptions: {
                             output: {
                                 // Keeps route chunks named after their file rather than after
                                 // the `?pick=...` id that addresses them. See toPickId.
@@ -107,7 +107,7 @@ export function solidStart(options) {
                                 write: true,
                                 manifest: true,
                                 outDir: "dist/client",
-                                rollupOptions: {
+                                rolldownOptions: {
                                     input: clientInput,
                                     treeshake: true,
                                     preserveEntrySignatures: "exports-only",
@@ -121,7 +121,7 @@ export function solidStart(options) {
                                 write: true,
                                 manifest: true,
                                 copyPublicDir: false,
-                                rollupOptions: {
+                                rolldownOptions: {
                                     input: handlers.server,
                                 },
                                 outDir: "dist/server",

package/dist/config/lazy.js

@@ -58,12 +58,17 @@ const lazy = () => {
             if (this.environment.name !== VITE_ENVIRONMENTS.client)
                 return;
             for (const chunk of Object.values(bundle)) {
-                if (chunk.type !== "chunk" || !chunk.isDynamicEntry || chunk.facadeModuleId)
+                if (chunk.type !== "chunk" || chunk.facadeModuleId)
+                    continue;
+                if (!chunk.viteMetadata?.importedCss.size)
+                    continue;
+                const moduleIds = chunk.moduleIds.filter(id => !id.endsWith("css"));
+                if (moduleIds.length <= 1)
                     continue;
                 // Has to follow Vites implementation:
                 // https://github.com/vitejs/vite/blob/4be37a8389c67873880f826b01fe40137e1c29a7/packages/vite/src/node/plugins/manifest.ts#L179
                 const chunkName = `_${basename(chunk.fileName)}`;
-                for (const id of chunk.moduleIds) {
+                for (const id of moduleIds) {
                     sharedChunkNames[id] = chunkName;
                 }
             }

package/dist/config/manifest.d.ts

@@ -1,3 +1,6 @@
 import { type PluginOption } from "vite";
 import { type SolidStartOptions } from "./index.ts";
+type StyleFilterOptions = NonNullable<SolidStartOptions["css"]>["filter"];
+export declare function createStyleFilter(options?: StyleFilterOptions): (id: unknown) => boolean;
 export declare function manifest(start: SolidStartOptions): PluginOption;
+export {};

package/dist/config/manifest.js

@@ -1,12 +1,17 @@
 import fs from "node:fs";
 import path from "node:path";
-import { version as viteVersion } from "vite";
+import { createFilter, version as viteVersion } from "vite";
 import { fileURLToPath } from "node:url";
 import { findStylesInModuleGraph } from "../server/collect-styles.js";
 import { VIRTUAL_MODULES } from "./constants.js";
 import { wrapId } from "./vite-utils.js";
+const DEFAULT_STYLE_EXCLUDE = /node_modules/;
+export function createStyleFilter(options) {
+    return createFilter(options?.include || [], options?.exclude || DEFAULT_STYLE_EXCLUDE);
+}
 export function manifest(start) {
     let devServer = undefined;
+    const styleFilter = createStyleFilter(start.css?.filter);
     return {
         name: "solid-start:manifest-plugin",
         enforce: "pre",
@@ -108,7 +113,7 @@ export function manifest(start) {
                     // Client env does not have css dependencies in mod.transformResult
                     // Aalways use ssr env instead, to prevent hydration mismatches
                     const env = devServer.environments["ssr"];
-                    const styles = await findStylesInModuleGraph(env, id);
+                    const styles = await findStylesInModuleGraph(env, id, styleFilter);
                     const cssAssets = Object.entries(styles).map(([key, value]) => `{
 						tag: "style",
 						attrs: {

package/dist/directives/remove-unused-variables.js

@@ -12,6 +12,18 @@ function isInvalidForRemoval(path) {
     }
     return isPathValid(target, t.isObjectPattern) || isPathValid(target, t.isArrayPattern);
 }
+function countValidImport(node) {
+    if (node.importKind === "type") {
+        return 0;
+    }
+    let count = 0;
+    for (const specifier of node.specifiers) {
+        if (specifier.type !== "ImportSpecifier" || specifier.importKind === "value") {
+            count += 1;
+        }
+    }
+    return count;
+}
 export function removeUnusedVariables(program) {
     // TODO(Alexis):
     // This implementation is simple but slow
@@ -34,7 +46,7 @@ export function removeUnusedVariables(program) {
                             if (binding.references === 0 && !binding.path.removed) {
                                 const parent = binding.path.parentPath;
                                 if (isPathValid(parent, t.isImportDeclaration)) {
-                                    if (parent.node.specifiers.length === 1) {
+                                    if (countValidImport(parent.node) <= 1) {
                                         parent.remove();
                                     }
                                     else {

package/dist/server/collect-styles.d.ts

@@ -1,3 +1,5 @@
 import type { DevEnvironment } from "vite";
+type StyleFilter = (id: string) => boolean;
 export declare const isCssModulesFile: (file: string) => boolean;
-export declare function findStylesInModuleGraph(vite: DevEnvironment, id: string): Promise<Record<string, any>>;
+export declare function findStylesInModuleGraph(vite: DevEnvironment, id: string, filter: StyleFilter): Promise<Record<string, any>>;
+export {};

package/dist/server/collect-styles.js

@@ -8,13 +8,16 @@ async function getViteModuleNode(vite, file, importer) {
     }
     catch (err) { }
 }
-async function findModuleDependencies(vite, file, deps, crawledFiles = new Set(), importer) {
+async function findModuleDependencies(vite, file, deps, filter, crawledFiles = new Set(), importer) {
     crawledFiles.add(file);
     const module = await getViteModuleNode(vite, file, importer);
     if (!module?.id || deps.has(module))
         return;
     deps.add(module);
-    if (module.url.endsWith(".css") || module.url.includes("node_modules"))
+    if (module.url.endsWith(".css"))
+        return;
+    // Apply user-config file filters only to real files (virtual modules should always be included)
+    if (module.file && !module.id.startsWith("\0") && !filter(module.file))
         return;
     if (!module.transformResult) {
         await vite.transformRequest(module.id).catch(() => { });
@@ -28,7 +31,7 @@ async function findModuleDependencies(vite, file, deps, crawledFiles = new Set()
         if (crawledFiles.has(dep)) {
             continue;
         }
-        await findModuleDependencies(vite, dep, deps, crawledFiles, module.id);
+        await findModuleDependencies(vite, dep, deps, filter, crawledFiles, module.id);
     }
 }
 // Vite doesn't expose these so we just copy the list for now
@@ -38,11 +41,11 @@ const cssFileRegExp = /\.(css|less|sass|scss|styl|stylus|pcss|postcss|sss)$/;
 const cssModulesRegExp = new RegExp(`\\.module${cssFileRegExp.source}`);
 const isCssFile = (file) => cssFileRegExp.test(file);
 export const isCssModulesFile = (file) => cssModulesRegExp.test(file);
-export async function findStylesInModuleGraph(vite, id) {
+export async function findStylesInModuleGraph(vite, id, filter) {
     const absolute = path.resolve(process.cwd(), id);
     const dependencies = new Set();
     try {
-        await findModuleDependencies(vite, absolute, dependencies);
+        await findModuleDependencies(vite, absolute, dependencies, filter);
     }
     catch (e) {
         console.error(e);

package/dist/server/manifest/dev-client-manifest.js

@@ -13,7 +13,7 @@ export function getClientDevManifest() {
             return import(__rewriteRelativeImportExtension(/* @vite-ignore */ join("/", id), true));
         },
         async getAssets(id) {
-            const assetsPath = `/@manifest/client/${Date.now()}/assets?id=${id}`;
+            const assetsPath = `/@manifest/client/${Date.now()}/assets?id=${encodeURIComponent(id)}`;
             const assets = (await import(__rewriteRelativeImportExtension(/* @vite-ignore */ assetsPath, true))).default;
             return await Promise.all(assets.map(async (v) => ({
                 ...v,

package/dist/server/manifest/dev-ssr-manifest.js

@@ -11,7 +11,7 @@ export function getSsrDevManifest(environment) {
     return {
         path: (id) => normalize(join(import.meta.env.BASE_URL, id)),
         async getAssets(id) {
-            const assetsPath = `/@manifest/${environment}/${Date.now()}/assets?id=${id}`;
+            const assetsPath = `/@manifest/${environment}/${Date.now()}/assets?id=${encodeURIComponent(id)}`;
             const assets = (await import(__rewriteRelativeImportExtension(/* @vite-ignore */ assetsPath, true))).default;
             return await Promise.all(assets.map(async (v) => ({
                 ...v,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidjs/start",
-  "version": "2.0.0-rc.8",
+  "version": "2.0.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/solidjs/solid-start.git",