@solidjs/signals 2.0.0-rc.7 → 2.0.0-rc.8

package/dist/prod/store/next/optimistic.js

@@ -18,11 +18,11 @@ import { $TARGET, markRawIngest, setNextOptimisticViewResolver, isWrappable, raw
 
 import { runProjectionComputedNext } from "./projection.js";
 
-import { wrapNext, runAuthoritative, storeSetterNext, hasActiveOverride, unwrapValue, targetsEqual, getNode, getHasNode, getKeySetNode, bumpDeep, stagedTruthPB, authoritativeRead } from "./store.js";
+import { wrapNext, runAuthoritative, storeSetterNext, hasActiveOverride, unwrapValue, targetsEqual, heldMaskView, getNode, getHasNode, getKeySetNode, bumpDeep, stagedTruthPB, authoritativeRead } from "./store.js";
 
 import { sameKey } from "./reconcile.js";
 
-import { setOptHooks } from "./target.js";
+import { setOptHooks, $OWNER, lookupTarget } from "./target.js";
 
 /**
  * Store rewrite — optimistic stores (§3/§7, RUL-3): no store-side layer, no
@@ -55,7 +55,7 @@ import { setOptHooks } from "./target.js";
  * staged values to converge (normal speculation). Resolves merges first:
  * merge unions optimistic nodes/stores into the target. */ function transitionHoldsOptimism(e) {
     const t = currentTransition(e);
-    return t.sn !== true && (t.Xe.length !== 0 || t.En.size !== 0);
+    return t.ft !== true && (t.it.length !== 0 || t.En.size !== 0);
 }
 
 let blockedInstalled = false;
@@ -76,8 +76,8 @@ function installNextBlockedHalf() {
     // Scheduler flush tails call _clearOptimisticStores whenever tracked
     // stores exist; next has no layer to clear — reverts are engine-native —
     // so the hook only empties the batch set.
-        if (!GlobalQueue.Wt) {
-        GlobalQueue.Wt = e => {
+        if (!GlobalQueue.ni) {
+        GlobalQueue.ni = e => {
             for (const t of e) {
                 const e = t?.[$TARGET];
                 const n = e?.fam?.overlaid;
@@ -96,24 +96,24 @@ function installNextBlockedHalf() {
             e.clear();
         };
     }
-    const e = GlobalQueue.dn;
-    GlobalQueue.dn = t => {
+    const e = GlobalQueue.cn;
+    GlobalQueue.cn = t => {
         for (const e of t.En) {
             const n = e?.[$TARGET];
             const i = n?.fam;
-            const r = i?.node;
+            const o = i?.node;
             // The hold exists to keep optimistic state alive until the store's own
             // truth lands (#2951). Once the family carries NO live overrides (a
             // landing consumed them, or they never existed), a pending firewall is
             // no reason to park the transaction — blocking then leaks it forever
             // when the in-flight question is never answered (undisposed fixtures).
-                        if (r == null || !(r.S & STATUS_PENDING)) continue;
+                        if (o == null || !(o.S & STATUS_PENDING)) continue;
             // Ownership is declared (#3146): only the flight's OWN transaction
             // parks on the flight (the #2951 anchor routed the bare write there).
             // A transaction that merely brushed the store never waits for truth
             // it does not carry.
-                        const o = i.ft != null ? liveTransition(i.ft) : null;
-            if (o !== null && o !== currentTransition(t)) continue;
+                        const r = i.ft != null ? liveTransition(i.ft) : null;
+            if (r !== null && r !== currentTransition(t)) continue;
             if (familyHasLiveOverrides(i)) return true;
         }
         return e(t);
@@ -128,10 +128,10 @@ function familyHasLiveOverrides(e) {
             if (t === null) continue;
             for (const e of Reflect.ownKeys(t)) {
                 const n = t[e];
-                if (n.o?.Pe !== undefined && n.o?.Pe !== NOT_PENDING) return true;
+                if (n.o?.be !== undefined && n.o?.be !== NOT_PENDING) return true;
             }
         }
-        if (e.k !== null && e.k.o?.Pe !== undefined && e.k.o?.Pe !== NOT_PENDING) return true;
+        if (e.k !== null && e.k.o?.be !== undefined && e.k.o?.be !== NOT_PENDING) return true;
     }
     t.clear();
  // nothing live — drop the bookkeeping
@@ -144,23 +144,23 @@ function createOptimisticStoreNext(e, t, n) {
     installOptimisticEngine();
     installNextBlockedHalf();
     const i = typeof e === "function";
-    const r = i ? n : t;
-    const o = i ? t : e;
+    const o = i ? n : t;
+    const r = i ? t : e;
     const s = {
         map: new WeakMap,
         node: null,
-        shallow: !!r?.shallow,
+        shallow: !!o?.shallow,
         opt: true
     };
-    const l = wrapNext(o, null, null, s);
+    const l = wrapNext(r, null, null, s);
     s.px = l;
     // Same key resolution the projection channels use ("id" default) — replay's
     // satisfaction rule reads it off the family.
-        const u = r?.key === undefined ? "id" : r.key;
+        const u = o?.key === undefined ? "id" : o.key;
     s.key = typeof u === "function" ? u : u === null ? null : e => isWrappable(e) ? e[u] : undefined;
     if (s.shallow) {
         l[$TARGET].s = true;
-        markRawIngest(o);
+        markRawIngest(r);
     }
     if (i) {
         const t = e;
@@ -178,7 +178,7 @@ function createOptimisticStoreNext(e, t, n) {
             if (e == null) return;
             let t = liveTransition(e);
             if (t === null) s.ft = t = createTransition();
-            s.node.Ae = t;
+            s.node.ge = t;
             globalQueue.initTransition(t);
         };
         // Landing router (#3164 fold ruling): while a transaction retains
@@ -223,8 +223,8 @@ function createOptimisticStoreNext(e, t, n) {
         // (#2933: the loading rail is transaction-invisible); a sync run clears
         // the declaration.
                 const declareFlight = e => {
-            if (e.o?.Ie == null) {
-                if (!e.Ne) s.ft = null;
+            if (e.o?.Pe == null) {
+                if (!e.Ae) s.ft = null;
                 return;
             }
             // First flight (#3146 carve-out): nothing has ever committed, so there
@@ -236,23 +236,23 @@ function createOptimisticStoreNext(e, t, n) {
             // fallback never showed and the whole page stayed blank. The loading
             // window (#2933) already declares nothing for the same reason; once
             // the first truth lands, every refetch flight declares as before.
-                        if (e.Ne || e.S & STATUS_UNINITIALIZED) return;
+                        if (e.Ae || e.S & STATUS_UNINITIALIZED) return;
             let t = activeTransition;
             if (t === null) globalQueue.initTransition(t = createTransition());
             s.ft = t;
-            e.Ae = t;
-            let n = t._e.get(e);
-            if (n === undefined) t._e.set(e, n = new Set);
+            e.ge = t;
+            let n = t.Re.get(e);
+            if (n === undefined) t.Re.set(e, n = new Set);
             n.add(e);
         };
         let n;
-        if (r?.seedLoadingValue) n = {
+        if (o?.seedLoadingValue) n = {
             loadingValue: undefined
         };
         const i = computed(() => {
             const e = getOwner();
             try {
-                runAuthoritative(() => runProjectionComputedNext(l, t, r?.key === undefined ? "id" : r.key, wrapCommit, aroundDraftWrite));
+                runAuthoritative(() => runProjectionComputedNext(l, t, o?.key === undefined ? "id" : o.key, wrapCommit, aroundDraftWrite));
             } finally {
                 declareFlight(e);
             }
@@ -274,8 +274,8 @@ function createOptimisticStoreNext(e, t, n) {
 
 /** Resolve a retained transition through its merge chain (`_done` holds the
  * merge target while merged, `true` once settled). Null = dead. */ function liveTransition(e) {
-    while (typeof e.sn === "object") e = e.sn;
-    return e.sn === true ? null : e;
+    while (typeof e.ft === "object") e = e.ft;
+    return e.ft === true ? null : e;
 }
 
 /** The transaction truth landings fold into: the first live member of the
@@ -320,10 +320,10 @@ function createOptimisticStoreNext(e, t, n) {
  * stay unarmed — the override is their display and its revert their
  * notification, A17). */ function runFolded(e, t) {
     runAsTransitionBatch(e, t);
-    const n = e.Mt;
+    const n = e.$t;
     for (let t = 0; t < n.length; t++) {
         const i = n[t];
-        i.Ae = e;
+        i.ge = e;
         if (i.T & CONFIG_OPTIMISTIC && !hasActiveOverride(i)) i.T |= CONFIG_HELD_TRUTH;
     }
 }
@@ -340,15 +340,15 @@ function createOptimisticStoreNext(e, t, n) {
         if (n !== null) {
             // Occurrence-aware key queues (parity with the adoption window):
             // duplicate keys match per occurrence, each current row consumed once.
-            let r = null;
-            const o = e.length;
-            for (let t = 0; t < o; t++) {
+            let o = null;
+            const r = e.length;
+            for (let t = 0; t < r; t++) {
                 const i = unwrapValue(e[t]);
                 if (!isWrappable(i)) continue;
-                const o = n(i);
-                if (o === undefined) continue;
-                const s = (r ??= new Map).get(o);
-                if (s === undefined) r.set(o, [ i ]); else s.push(i);
+                const r = n(i);
+                if (r === undefined) continue;
+                const s = (o ??= new Map).get(r);
+                if (s === undefined) o.set(r, [ i ]); else s.push(i);
             }
             // Echo adoption: an optimistic structural add whose key the landing
             // confirms must keep its raw (and so its proxy — list drivers keep the
@@ -363,42 +363,42 @@ function createOptimisticStoreNext(e, t, n) {
                 for (const e of Reflect.ownKeys(s)) {
                     const t = s[e];
                     if (!hasActiveOverride(t)) continue;
-                    const i = unwrapValue(unwrapOverride(t.o.Pe));
+                    const i = unwrapValue(unwrapOverride(t.o.be));
                     if (!isWrappable(i)) continue;
-                    const o = n(i);
-                    if (o === undefined) continue;
-                    const l = (r ??= new Map).get(o);
-                    if (l === undefined) r.set(o, [ i ]); else l.push(i);
+                    const r = n(i);
+                    if (r === undefined) continue;
+                    const l = (o ??= new Map).get(r);
+                    if (l === undefined) o.set(r, [ i ]); else l.push(i);
                 }
             }
-            for (let o = 0; o < i; o++) {
-                const i = t[o];
+            for (let r = 0; r < i; r++) {
+                const i = t[r];
                 let s;
-                if (isWrappable(i) && r !== null) {
+                if (isWrappable(i) && o !== null) {
                     const e = n(i);
                     if (e !== undefined) {
-                        for (const [t, n] of r) {
+                        for (const [t, n] of o) {
                             if (!sameKey(t, e)) continue;
                             s = n.shift();
-                            if (n.length === 0) r.delete(t);
+                            if (n.length === 0) o.delete(t);
                             break;
                         }
                     }
                 }
                 if (s !== undefined) {
-                    if (unwrapValue(e[o]) !== s) e[o] = s;
-                    stagedApply(e[o], i, n);
+                    if (unwrapValue(e[r]) !== s) e[r] = s;
+                    stagedApply(e[r], i, n);
                 } else {
-                    const t = unwrapValue(e[o]);
-                    if (!isEqual(t, i) && !targetsEqual(t, i)) e[o] = i;
+                    const t = unwrapValue(e[r]);
+                    if (!isEqual(t, i) && !targetsEqual(t, i)) e[r] = i;
                 }
             }
         } else {
-            for (let r = 0; r < i; r++) {
-                const i = t[r];
-                const o = unwrapValue(e[r]);
-                if (o === i) continue;
-                if (isWrappable(i) && isWrappable(o) && Array.isArray(i) === Array.isArray(o)) stagedApply(e[r], i, n); else if (!isEqual(o, i) && !targetsEqual(o, i)) e[r] = i;
+            for (let o = 0; o < i; o++) {
+                const i = t[o];
+                const r = unwrapValue(e[o]);
+                if (r === i) continue;
+                if (isWrappable(i) && isWrappable(r) && Array.isArray(i) === Array.isArray(r)) stagedApply(e[o], i, n); else if (!isEqual(r, i) && !targetsEqual(r, i)) e[o] = i;
             }
         }
         if (e.length !== i) e.length = i;
@@ -406,29 +406,29 @@ function createOptimisticStoreNext(e, t, n) {
     }
     // Object merge; also the degenerate root-kind-change shape (arrays accept
     // keyed writes/deletes, so a wholesale restatement still lands staged).
-        for (const r of Reflect.ownKeys(t)) {
-        if (i && r === "length") continue;
-        const o = t[r];
-        const s = unwrapValue(e[r]);
-        if (s === o) continue;
-        if (isWrappable(o) && isWrappable(s) && Array.isArray(o) === Array.isArray(s)) {
+        for (const o of Reflect.ownKeys(t)) {
+        if (i && o === "length" || o === $OWNER) continue;
+        const r = t[o];
+        const s = unwrapValue(e[o]);
+        if (s === r) continue;
+        if (isWrappable(r) && isWrappable(s) && Array.isArray(r) === Array.isArray(s)) {
             // Different-keyed entities never merge (tentative-channel parity):
             // the incoming object replaces the slot wholesale.
             if (n !== null) {
                 const t = n(s);
-                const i = n(o);
+                const i = n(r);
                 if (t !== undefined && i !== undefined && !sameKey(t, i)) {
-                    e[r] = o;
+                    e[o] = r;
                     continue;
                 }
             }
-            stagedApply(e[r], o, n);
-        } else if (!isEqual(s, o) && !targetsEqual(s, o)) {
-            e[r] = o;
+            stagedApply(e[o], r, n);
+        } else if (!isEqual(s, r) && !targetsEqual(s, r)) {
+            e[o] = r;
         }
     }
     for (const n of Reflect.ownKeys(e)) {
-        if (i && n === "length" || n in t) continue;
+        if (i && n === "length" || n === $OWNER || n in t) continue;
         delete e[n];
     }
 }
@@ -451,49 +451,63 @@ function createOptimisticStoreNext(e, t, n) {
         const e = liveTransition(n);
         if (e !== null) globalQueue.initTransition(e);
     }
-    const i = e.v;
-    const visible = (t, n) => {
+    // The write is judged against what ordinary readers SEE, not against the
+    // committed backing slot: under an adoption hold (#3074) `t.v` is already
+    // the truth a live transaction is holding, and an optimistic write equal
+    // to it compared as a no-op — no override, no lane, and the screen kept
+    // the pre-hold value until the transaction committed (#3330's store
+    // twin: `s.v = 1` after a `yield` while the derive had already staged
+    // `v: 1`). Signal parity: the override reveals on its lane now, with its
+    // derivations; the held truth reveals on the transaction's schedule.
+        const i = heldMaskView(e) ?? e.v;
+    // Compare RAWS on both sides (`nv` below is unwrapped already). A chained
+    // target's `old` is the inner store's proxy, whose reads hand back inner
+    // child PROXIES; the draft's clone holds the inner raws. Comparing the two
+    // as-is marked every untouched row changed, and the overlay then served
+    // each from an override as a fresh non-chained target — row identities
+    // churned for the life of the action and snapped back at settle (#3323).
+        const visible = (t, n) => {
         const i = e.n?.[t];
-        return i !== undefined && hasActiveOverride(i) ? unwrapOverride(i.o?.Pe) : n;
+        return unwrapValue(i !== undefined && hasActiveOverride(i) ? unwrapOverride(i.o?.be) : n);
     };
     const visiblePresent = t => {
         const n = e.h?.[t];
-        return n !== undefined && hasActiveOverride(n) ? !!unwrapOverride(n.o?.Pe) : t in i;
+        return n !== undefined && hasActiveOverride(n) ? !!unwrapOverride(n.o?.be) : t in i;
     };
-    let r = false;
-    const o = Array.isArray(t);
+    let o = false;
+    const r = Array.isArray(t);
     for (const n of Reflect.ownKeys(t)) {
-        if (o && n === "length") continue;
+        if (r && n === "length" || n === $OWNER) continue;
         const s = unwrapValue(t[n]);
         if (!visiblePresent(n)) {
             // Optimistic add: value node + presence node + membership bump.
             setSignal(getNode(e, n, i[n]), () => s);
             setSignal(getHasNode(e, n, n in i), true);
-            r = true;
+            o = true;
         } else {
             const t = visible(n, i[n]);
             if (!isEqual(t, s) && !targetsEqual(t, s)) {
                 setSignal(getNode(e, n, t), () => s);
-                if (o) r = true;
+                if (r) o = true;
             }
         }
     }
     for (const n of Reflect.ownKeys(i)) {
-        if (o && n === "length") continue;
+        if (r && n === "length" || n === $OWNER) continue;
         if (n in t || !visiblePresent(n)) continue;
         // Optimistic delete: node reads undefined, presence flips, membership bumps.
                 setSignal(getNode(e, n, i[n]), () => undefined);
         setSignal(getHasNode(e, n, true), false);
-        r = true;
+        o = true;
     }
-    if (o) {
+    if (r) {
         const n = visible("length", i.length);
         if (n !== t.length) {
             setSignal(getNode(e, "length", n), () => t.length);
-            r = true;
+            o = true;
         }
     }
-    if (r) setSignal(getKeySetNode(e), e => e + 1);
+    if (o) setSignal(getKeySetNode(e), e => e + 1);
     // Deep-witness: optimistic value writes notify deep() subscribers too
     // (structural ones already ride the key-set bump above).
         bumpDeep(e);
@@ -504,7 +518,7 @@ function createOptimisticStoreNext(e, t, n) {
         e.pb = stagedTruthPB.get(e) ?? null;
     if (e.pb !== null) stagedTruthPB.delete(e);
     (e.fam.overlaid ??= new Set).add(e);
-    GlobalQueue._n?.(e.fam.px ?? e.px);
+    GlobalQueue.Nn?.(e.fam.px ?? e.px);
 }
 
 /** Optimistic-view composition for snapshot/deep (O1: snapshot is the CURRENT
@@ -523,19 +537,19 @@ function createOptimisticStoreNext(e, t, n) {
         for (const e of Reflect.ownKeys(i)) {
             const n = i[e];
             if (!hasActiveOverride(n)) continue;
-            const r = unwrapOverride(n.o?.Pe);
+            const o = unwrapOverride(n.o?.be);
             if (e === "length" && Array.isArray(t)) {
-                if (t.length !== r) ensure().length = r;
-            } else if (!isEqual(t[e], r)) ensure()[e] = r;
+                if (t.length !== o) ensure().length = o;
+            } else if (!isEqual(t[e], o)) ensure()[e] = o;
         }
     }
-    const r = e.h;
-    if (r !== null) {
-        for (const e of Reflect.ownKeys(r)) {
-            const i = r[e];
+    const o = e.h;
+    if (o !== null) {
+        for (const e of Reflect.ownKeys(o)) {
+            const i = o[e];
             if (!hasActiveOverride(i)) continue;
-            const o = !!unwrapOverride(i.o?.Pe);
-            if (!o && e in (n ?? t)) delete ensure()[e];
+            const r = !!unwrapOverride(i.o?.be);
+            if (!r && e in (n ?? t)) delete ensure()[e];
         }
     }
     return n ?? t;
@@ -543,16 +557,16 @@ function createOptimisticStoreNext(e, t, n) {
 
 function applyTentative(e, t, n) {
     const i = e.pb ?? e.v;
-    const r = optimisticView(e, i);
-    const o = e.fam.map;
+    const o = optimisticView(e, i);
+    const r = e.fam;
     const s = Array.isArray(t);
-    if (Array.isArray(r) !== s) return;
+    if (Array.isArray(o) !== s) return;
  // kind change at root: flat overrides below
         const l = [];
     let u;
     if (s) u = [ ...t ]; else {
         u = {};
-        for (const e of Reflect.ownKeys(t)) u[e] = t[e];
+        for (const e of Reflect.ownKeys(t)) if (e !== $OWNER) u[e] = t[e];
     }
     const match = (e, t) => {
         if (!isWrappable(e) || !isWrappable(t)) return null;
@@ -560,22 +574,22 @@ function applyTentative(e, t, n) {
         if (Array.isArray(e) !== Array.isArray(t)) return null;
         if (n) {
             const i = n(e);
-            const r = n(t);
+            const o = n(t);
             // SameValueZero (re-audit 3, P1-3): parity with the plain reconcile
             // channel — NaN keys are self-equal.
-                        if (i !== undefined && r !== undefined && !sameKey(i, r)) return null;
+                        if (i !== undefined && o !== undefined && !sameKey(i, o)) return null;
         }
-        return o.get(unwrapValue(e)) ?? null;
+        return lookupTarget(unwrapValue(e), r) ?? null;
     };
     if (s) {
-        const e = r;
+        const e = o;
         let i = null;
-        for (let r = 0; r < t.length; r++) {
-            const o = t[r];
-            if (!isWrappable(o)) continue;
+        for (let o = 0; o < t.length; o++) {
+            const r = t[o];
+            if (!isWrappable(r)) continue;
             let s;
             if (n) {
-                const t = n(o);
+                const t = n(r);
                 if (t !== undefined) {
                     if (i === null) {
                         // Occurrence-aware index queues (re-audit 3, P1-3): parity with
@@ -583,40 +597,41 @@ function applyTentative(e, t, n) {
                         // occurrence, each view row consumed once.
                         i = new Map;
                         for (let t = 0; t < e.length; t++) {
-                            const r = unwrapValue(e[t]);
-                            if (isWrappable(r)) {
-                                const e = n(r);
+                            const o = unwrapValue(e[t]);
+                            if (isWrappable(o)) {
+                                const e = n(o);
                                 if (e === undefined) continue;
-                                const o = i.get(e);
-                                if (o === undefined) i.set(e, t); else if (Array.isArray(o)) o.push(t); else i.set(e, [ o, t ]);
+                                const r = i.get(e);
+                                if (r === undefined) i.set(e, t); else if (Array.isArray(r)) r.push(t); else i.set(e, [ r, t ]);
                             }
                         }
                     }
-                    const r = i.get(t);
-                    if (r === undefined) s = undefined; else if (Array.isArray(r)) {
-                        s = unwrapValue(e[r.shift()]);
-                        if (r.length === 1) i.set(t, r[0]);
+                    const o = i.get(t);
+                    if (o === undefined) s = undefined; else if (Array.isArray(o)) {
+                        s = unwrapValue(e[o.shift()]);
+                        if (o.length === 1) i.set(t, o[0]);
                     } else {
-                        s = unwrapValue(e[r]);
+                        s = unwrapValue(e[o]);
                         i.delete(t);
                     }
-                } else s = unwrapValue(e[r]);
-            } else s = unwrapValue(e[r]);
-            const a = match(s, o);
+                } else s = unwrapValue(e[o]);
+            } else s = unwrapValue(e[o]);
+            const a = match(s, r);
             if (a !== null) {
                 // Keep the existing row in the slot (identity preserved); recurse.
-                u[r] = unwrapValue(s);
-                l.push([ a, o ]);
+                u[o] = unwrapValue(s);
+                l.push([ a, r ]);
             }
         }
     } else {
         for (const e of Reflect.ownKeys(t)) {
-            const n = unwrapValue(r[e]);
+            if (e === $OWNER) continue;
+            const n = unwrapValue(o[e]);
             const i = t[e];
-            const o = match(n, i);
-            if (o !== null) {
+            const r = match(n, i);
+            if (r !== null) {
                 u[e] = n;
-                l.push([ o, i ]);
+                l.push([ r, i ]);
             }
         }
     }

package/dist/prod/store/next/projection.js

@@ -215,8 +215,8 @@ function runProjectionComputedNext(e, t, r, i, o) {
     // for the whole first flight — the derive works a detached shadow of the
     // seed so draft writes cannot tear through to readers (#2988). Every commit
     // point reconciles the shadow through the normal commit path.
-        const u = n.Ne ? JSON.parse(JSON.stringify(e[$TARGET][STORE_VALUE])) : null;
-    const l = wrapDraft(e, () => !c || n.o?.Ie === s, o);
+        const u = n.Ae ? JSON.parse(JSON.stringify(e[$TARGET][STORE_VALUE])) : null;
+    const l = wrapDraft(e, () => !c || n.o?.Pe === s, o);
     storeSetterNext(l, o => {
         s = t(u ?? o);
         c = true;
@@ -230,7 +230,7 @@ function runProjectionComputedNext(e, t, r, i, o) {
             i ? i(write, t) : write();
         };
         const l = handleAsync(n, s, commit);
-        if (!n.Ne) commit(l);
+        if (!n.Ae) commit(l);
     }, false);
     return n;
 }