@solidjs/signals 2.0.0-rc.6 → 2.0.0-rc.8

package/dist/prod/core/dev.js

@@ -1,3 +1,5 @@
+import "./core.js";
+
 const DEV = undefined;
 
 export { DEV };

package/dist/prod/core/effect.js

@@ -1,29 +1,31 @@
-import { REACTIVE_DISPOSED, STATUS_ERROR, EFFECT_USER, CONFIG_AUTO_DISPOSE, CONFIG_CHILDREN_FORBIDDEN, EFFECT_TRACKED, EFFECT_RENDER, STATUS_PENDING } from "./constants.js";
+import { REACTIVE_DISPOSED, LANE_RUN, STATUS_ERROR, EFFECT_USER, CONFIG_AUTO_DISPOSE, CONFIG_CHILDREN_FORBIDDEN, EFFECT_TRACKED, EFFECT_RENDER, STATUS_PENDING } from "./constants.js";
 
 import { setEffectStatusNotify, ext, createEffectNode, recompute, computed, staleValues } from "./core.js";
 
 import { unwrapStatusError, StatusError } from "./error.js";
 
-import { GlobalQueue, haltReactivity } from "./scheduler.js";
+import { enqueueSub } from "./heap.js";
+
+import { GlobalQueue, currentTransition, activeTransition, haltReactivity, schedule } from "./scheduler.js";
 
 /**
  * Effects are the leaf nodes of our reactive graph. When their sources change, they are
  * automatically added to the queue of effects to re-execute, which will cause them to fetch their
  * sources and recompute
- */ function effect(t, e, E, f) {
-    const r = !!f?.user;
-    const R = createEffectNode(t, e, E, r ? EFFECT_USER : EFFECT_RENDER, f);
-    recompute(R, true);
-    !f?.defer && (R.ge === EFFECT_USER || f?.schedule ? R.C.enqueue(R.ge, runEffect.bind(null, R)) : runEffect(R));
+ */ function effect(t, e, E, r) {
+    const n = !!r?.user;
+    const f = createEffectNode(t, e, E, n ? EFFECT_USER : EFFECT_RENDER, r);
+    recompute(f, true);
+    !r?.defer && (f.Ce === EFFECT_USER || r?.schedule ? f.C.enqueue(f.Ce, runEffect.bind(null, f)) : runEffect(f, LANE_RUN));
 }
 
 function notifyEffectStatus(t, e) {
     // Use passed values if provided, otherwise read from node
     const E = t !== undefined ? t : this.S;
-    const f = e !== undefined ? e : this.o?._;
+    const r = e !== undefined ? e : this.o?._;
     if (E & STATUS_ERROR) {
         this.C.notify(this, STATUS_PENDING, 0);
-        if (this.ge === EFFECT_USER) {
+        if (this.Ce === EFFECT_USER) {
             // The error handler is the error arm of the effect phase (#2840 ruling):
             // queue it like the effect function. It runs in the same imperative,
             // writable scope, throws escalate the same way, and a held transition
@@ -34,22 +36,42 @@ function notifyEffectStatus(t, e) {
             // `status` arg without node-state writes) don't queue: the status
             // re-propagates unblocked at commit.
             if (this.S & STATUS_ERROR) {
-                this.tt = true;
-                this.C.enqueue(this.ge, this.nt ??= runEffect.bind(null, this));
+                this.He = true;
+                this.C.enqueue(this.Ce, this.rt ??= runEffect.bind(null, this));
             }
             return;
         }
         if (!this.C.notify(this, STATUS_ERROR, STATUS_ERROR)) {
-            haltReactivity(unwrapStatusError(f));
-            throw f;
+            haltReactivity(unwrapStatusError(r));
+            throw r;
         }
-    } else if (this.ge === EFFECT_RENDER) {
-        this.C.notify(this, STATUS_PENDING | STATUS_ERROR, E, f);
+    } else if (this.Ce === EFFECT_RENDER) {
+        this.C.notify(this, STATUS_PENDING | STATUS_ERROR, E, r);
     }
 }
 
-function runEffect(t) {
-    if (!t.tt || t.ie & REACTIVE_DISPOSED) return;
+function runEffect(t, e) {
+    if (!t.He || t.ie & REACTIVE_DISPOSED) return;
+    // Ownership (#3319): a value computed under a transaction is applied by that
+    // transaction's commit. The ordinary effect phase runs with a transaction
+    // active only when the flush's finalize ENTERED one (every other path parks
+    // or settles first): leave a run owned by a still-held transaction queued —
+    // `_modified` stays set — and the next gate stashes it with the owner.
+    // Mainline-owned runs (null) apply now. Lanes are exempt by design (they
+    // apply their own effects ahead of their transaction — the optimistic view)
+    // and mark their runs with LANE_RUN.
+    
+    // Lane exemption has one exception (#3331): a lane runner for an effect that
+    // no longer rides a lane — its optimistic source was superseded, so the lane
+    // has no optimistic view left to apply, and the value this effect now
+    // carries (or will, once its plain recompute lands) belongs to the still-held
+    // transaction. Hand the run to the regular queue, where the transaction's
+    // gate stashes it with the owner. Lane-less runners with no live owner
+    // (reverts, wake-only lanes) apply now.
+        if (t._t !== null && !currentTransition(t._t).ft && (e & LANE_RUN ? !t.o?.Oe : activeTransition !== null)) {
+        t.C.enqueue(t.Ce, t.rt);
+        return;
+    }
     // Error arm (#2840), user effects only: a compute-phase error that is still
     // the node's settled state at effect time runs the bundle's error handler in
     // this same imperative, writable scope. Unwrap the StatusError used for
@@ -60,14 +82,14 @@ function runEffect(t) {
     // Render effects bypass: their errors route to boundaries synchronously in
     // notifyEffectStatus, and a runner queued by an earlier valueChanged in the
     // same flush must not be hijacked by a later-arriving error status.
-        if (t.S & STATUS_ERROR && t.ge === EFFECT_USER) {
+        if (t.S & STATUS_ERROR && t.Ce === EFFECT_USER) {
         const e = unwrapStatusError(t.o?._);
-        t.At = t.be;
-        t.tt = false;
+        t.Ft = t.me;
+        t.He = false;
         try {
-            t.Ct ? t.Ct(e, () => {
-                const e = t.Rt;
-                t.Rt = undefined;
+            t.vt ? t.vt(e, () => {
+                const e = t.Ht;
+                t.Ht = undefined;
                 e?.();
             }) : console.error(e);
         } catch (e) {
@@ -78,14 +100,14 @@ function runEffect(t) {
         }
         return;
     }
-    const e = t.Rt;
-    t.Rt = undefined;
+    const E = t.Ht;
+    t.Ht = undefined;
     try {
-        e?.();
-        const E = t.Ot(t.be, t.At);
-        if (false && E !== undefined && typeof E !== "function") ;
+        E?.();
+        const e = t.ht(t.me, t.Ft);
+        if (false && e !== undefined && typeof e !== "function") ;
         // The final cleanup is invoked by disposeChildren at true disposal.
-                t.Rt = E;
+                t.Ht = e;
     } catch (e) {
         ext(t)._ = new StatusError(t, e);
         t.S |= STATUS_ERROR;
@@ -94,12 +116,12 @@ function runEffect(t) {
             throw e;
         }
     } finally {
-        t.At = t.be;
-        t.tt = false;
+        t.Ft = t.me;
+        t.He = false;
     }
 }
 
-GlobalQueue.it = runEffect;
+GlobalQueue.ct = runEffect;
 
 /**
  * Internal tracked effect - bypasses heap, goes directly to effect queue.
@@ -107,31 +129,38 @@ GlobalQueue.it = runEffect;
  * Uses stale reads.
  */ function trackedEffect(t, e) {
     const run = () => {
-        if (!E.tt || E.ie & REACTIVE_DISPOSED) return;
+        // `_modified` is NOT redundant with the heap: the heap dedups within a
+        // pass, but a held transition's passes each enqueue `_run` into the same
+        // user queue, and this gate is what collapses them into one run at commit.
+        if (!E.He || E.ie & REACTIVE_DISPOSED) return;
         try {
-            E.tt = false;
+            E.He = false;
             recompute(E);
         } finally {}
     };
     const E = computed(() => {
-        const e = E.Rt;
-        E.Rt = undefined;
+        const e = E.Ht;
+        E.Ht = undefined;
         e?.();
-        const f = staleValues(t);
-        E.Rt = f;
+        const r = staleValues(t);
+        E.Ht = r;
     }, {
         ...e,
         lazy: true
     });
-    E.Rt = undefined;
+    E.Ht = undefined;
     E.T = E.T & ~CONFIG_AUTO_DISPOSE | CONFIG_CHILDREN_FORBIDDEN;
-    E.tt = true;
-    E.ge = EFFECT_TRACKED;
+    E.He = true;
+    E.Ce = EFFECT_TRACKED;
     // Status dispatch rides the SHARED notifier (statusNotifierOf keys off
     // _type): its error arm is behavior-identical to the closure that used to
     // live here, without the per-node NodeExtension allocation.
-        E.yt = run;
-    E.C.enqueue(EFFECT_USER, run);
+        E.Ve = run;
+    // The first run rides the heap like every wake (GlobalQueue._update), so a
+    // tracked effect created inside a render-effect callback runs after that
+    // pass's staged writes commit, not before.
+        enqueueSub(E);
+    schedule();
 }
 
 // Install the shared effect status notifier (statusNotifierOf serves it to

package/dist/prod/core/external.js

@@ -64,8 +64,8 @@ function externalUntrack(e) {
 // removed on reset) so core's null checks stay equivalent to the old
 // `externalSourceConfig` truthiness checks.
 function syncExternalHooks() {
-    GlobalQueue.Pt = externalSourceConfig ? wireExternalSource : null;
-    GlobalQueue.ht = externalSourceConfig ? externalUntrack : null;
+    GlobalQueue.kt = externalSourceConfig ? wireExternalSource : null;
+    GlobalQueue.Lt = externalSourceConfig ? externalUntrack : null;
 }
 
 function enableExternalSource(e) {

package/dist/prod/core/graph.js

@@ -1,4 +1,6 @@
-import { CONFIG_AUTO_DISPOSE, STATUS_PENDING, REACTIVE_DISPOSED, REACTIVE_ZOMBIE, REACTIVE_RECOMPUTING_DEPS } from "./constants.js";
+import { CONFIG_AUTO_DISPOSE, STATUS_PENDING, REACTIVE_DISPOSED, REACTIVE_ZOMBIE, CONFIG_SLOT_NODE, REACTIVE_RECOMPUTING_DEPS } from "./constants.js";
+
+import { slotUnobservedHook } from "./core.js";
 
 import { deleteFromHeap, queueFor } from "./heap.js";
 
@@ -8,15 +10,17 @@ import { bumpNotifyEpoch } from "./scheduler.js";
 
 // https://github.com/stackblitz/alien-signals/blob/v2.0.3/src/system.ts#L100
 function unlinkSubs(e) {
-    const n = e.ot;
-    const l = e.lt;
-    const o = e.ae;
-    const u = e.en;
-    if (o !== null) o.en = u; else n._t = u;
-    if (u !== null) u.ae = o; else {
+    const n = e.Se;
+    const l = e.ae;
+    const o = e.Te;
+    const s = e.en;
+    if (o !== null) o.en = s; else n.dt = s;
+    if (s !== null) s.Te = o; else {
         n.u = o;
         if (o === null) {
-            n.o?.Et?.();
+            // Slot nodes (store leaves) dispatch to the ONE shared hook — no
+            // per-node unobserved closure, no NodeExtension to hold it.
+            if (n.T & CONFIG_SLOT_NODE) slotUnobservedHook(n); else n.o?.Ct?.();
             // No more subscribers; only tear down if CONFIG_AUTO_DISPOSE is set.
             // A pending node is exempt: its in-flight async work (or the
             // transition holding it) is an observer — tearing down would orphan
@@ -31,13 +35,13 @@ function unlinkSubs(e) {
 }
 
 function trimStaleDeps(e) {
-    const n = e.je;
-    let l = n !== null ? n.lt : e.ut;
+    const n = e.et;
+    let l = n !== null ? n.ae : e.fe;
     if (l !== null) {
         do {
             l = unlinkSubs(l);
         } while (l !== null);
-        if (n !== null) n.lt = null; else e.ut = null;
+        if (n !== null) n.ae = null; else e.fe = null;
     }
 }
 
@@ -46,13 +50,13 @@ function trimStaleDeps(e) {
 // and skipping early also avoids adding one (hidden-class churn) via the
 // null-out below.
 function clearDeps(e) {
-    let n = e.ut;
+    let n = e.fe;
     if (!n) return;
     do {
         n = unlinkSubs(n);
     } while (n !== null);
-    e.ut = null;
-    e.je = null;
+    e.fe = null;
+    e.et = null;
 }
 
 function unobserved(e) {
@@ -104,20 +108,20 @@ function link(e, n, l = false) {
     // not relabel the value dependency as probe-only — the value read is what
     // real-error propagation and affects() coverage key off, regardless of
     // read order within the computation.
-    const o = n.je;
-    if (o !== null && o.ot === e) {
-        o.ve &&= l;
+    const o = n.et;
+    if (o !== null && o.Se === e) {
+        o.je &&= l;
         return;
     }
-    let u = null;
+    let s = null;
     const t = n.ie & REACTIVE_RECOMPUTING_DEPS;
     if (t) {
-        u = o !== null ? o.lt : n.ut;
-        if (u !== null && u.ot === e) {
-            u.Ft = n.Ke;
-            n.je = u;
+        s = o !== null ? o.ae : n.fe;
+        if (s !== null && s.Se === e) {
+            s.yt = n.tt;
+            n.et = s;
             // First touch of this pass: the previous pass's label is stale.
-                        u.ve = l;
+                        s.je = l;
             return;
         }
     }
@@ -126,24 +130,24 @@ function link(e, n, l = false) {
     // [deps.._depsTail] prefix — the O(1) equivalent of scanning the dep list
     // (the old alien-signals `isValidLink` walk, O(n²) when a computation
     // re-reads earlier deps non-consecutively, e.g. store leaf reads).
-        const s = e._t;
-    if (s !== null && s.ce === n && (!t || s.Ft === n.Ke)) {
+        const r = e.dt;
+    if (r !== null && r.Ie === n && (!t || r.yt === n.tt)) {
         // Gen-matched during a recompute = repeat touch this pass (AND); outside
         // a recompute there is no pass boundary, so the latest read labels it.
-        if (t) s.ve &&= l; else s.ve = l;
+        if (t) r.je &&= l; else r.je = l;
         return;
     }
-    const r = n.je = e._t = {
-        ot: e,
-        ce: n,
-        lt: u,
-        en: s,
-        ae: null,
-        Ft: n.Ke,
-        ve: l
+    const u = n.et = e.dt = {
+        Se: e,
+        Ie: n,
+        ae: s,
+        en: r,
+        Te: null,
+        yt: n.tt,
+        je: l
     };
-    if (o !== null) o.lt = r; else n.ut = r;
-    if (s !== null) s.ae = r; else e.u = r;
+    if (o !== null) o.ae = u; else n.fe = u;
+    if (r !== null) r.Te = u; else e.u = u;
     // New subscriber edge: staged-rewrite skips (§12d) must not miss it.
         bumpNotifyEpoch();
 }

package/dist/prod/core/heap.js

@@ -1,6 +1,6 @@
 import "./core.js";
 
-import { REACTIVE_IN_HEAP, REACTIVE_IN_HEAP_HEIGHT, EFFECT_TRACKED, EFFECT_USER, REACTIVE_ZOMBIE, REACTIVE_RECOMPUTING_DEPS, REACTIVE_MANUAL_WRITE, REACTIVE_CHECK, REACTIVE_DIRTY, CONFIG_FW_CHILDREN } from "./constants.js";
+import { REACTIVE_IN_HEAP, REACTIVE_IN_HEAP_HEIGHT, REACTIVE_ZOMBIE, REACTIVE_RECOMPUTING_DEPS, REACTIVE_MANUAL_WRITE, REACTIVE_CHECK, REACTIVE_DIRTY, CONFIG_FW_CHILDREN } from "./constants.js";
 
 import { zombieQueue, dirtyQueue } from "./scheduler.js";
 
@@ -9,33 +9,27 @@ import { zombieQueue, dirtyQueue } from "./scheduler.js";
 }
 
 /**
- * Schedule one subscriber to re-run on the next flush: tracked effects bypass
- * the heap and go directly to their effect queue; everything else is inserted
- * into its own (zombie-flag-routed) heap with the `_min` cursor pulled down.
+ * Schedule one subscriber to re-run on the next flush: inserted into its own
+ * (zombie-flag-routed) heap with the `_min` cursor pulled down. Tracked
+ * effects ride the heap too — the heap visit is their (empty) compute phase,
+ * which hands the callback to the user queue once the pass has committed
+ * (see GlobalQueue._update, #3291).
  */ function enqueueSub(e) {
-    if (e.ge === EFFECT_TRACKED) {
-        const E = e;
-        if (!E.tt) {
-            E.tt = true;
-            E.C.enqueue(EFFECT_USER, E.yt);
-        }
-        return;
-    }
     const E = queueFor(e);
-    if (E.Qe > e.Me) E.Qe = e.Me;
+    if (E.Ke > e.Be) E.Ke = e.Be;
     insertIntoHeap(e, E);
 }
 
 function actualInsertIntoHeap(e, E) {
-    const t = (e.ke?.Gt ? e.ke.Dt?.Me : e.ke?.Me) ?? -1;
-    if (t >= e.Me) e.Me = t + 1;
-    const n = e.Me;
+    const t = (e.qe?.gt ? e.qe.bt?.Be : e.qe?.Be) ?? -1;
+    if (t >= e.Be) e.Be = t + 1;
+    const n = e.Be;
     const I = E.eE[n];
     if (I === undefined) E.eE[n] = e; else {
-        const E = I.ct;
-        E.rt = e;
-        e.ct = E;
-        I.ct = e;
+        const E = I.Tt;
+        E.Nt = e;
+        e.Tt = E;
+        I.Tt = e;
     }
     if (n > E.EE) E.EE = n;
 }
@@ -50,12 +44,17 @@ function insertIntoHeap(e, E) {
         e.ie = t & -4 | REACTIVE_DIRTY | REACTIVE_IN_HEAP;
     } else {
         e.ie = t | REACTIVE_IN_HEAP;
-        // An unmarked node entering a marked heap invalidates the markHeap memo:
-        // `_marked` is only reset by runHeap, so a write between two mid-tick
-        // pulls (read-time markHeap + updateIfNecessary) would otherwise leave
-        // this node unmarked and every downstream pull stale until the next
-        // flush (#2922: the second `latest()` returned the first write's value).
-                if (E.tE && !(t & REACTIVE_DIRTY)) E.tE = false;
+        // An unmarked node entering an already-marked heap is marked on the
+        // spot, keeping the markHeap memo valid. `_marked` is only reset by
+        // runHeap, so a write between two mid-tick pulls (read-time markHeap +
+        // updateIfNecessary) would otherwise leave this node unmarked and every
+        // downstream pull stale until the next flush (#2922: the second
+        // `latest()` returned the first write's value). Invalidating the memo
+        // instead re-walked the WHOLE heap on the next pull — with N effects
+        // parked in the heap for a synchronous mount (each row writing a ref
+        // signal its effect subscribes to), mounting N rows was O(N²) (#3350).
+        // markNode's own guard skips an already-DIRTY node.
+                if (E.tE) markNode(e);
     }
     if (!(t & REACTIVE_IN_HEAP_HEIGHT)) actualInsertIntoHeap(e, E);
 }
@@ -71,23 +70,23 @@ function deleteFromHeap(e, E) {
     const t = e.ie;
     if (!(t & (REACTIVE_IN_HEAP | REACTIVE_IN_HEAP_HEIGHT))) return;
     e.ie = t & -25;
-    const n = e.Me;
-    if (e.ct === e) E.eE[n] = undefined; else {
-        const t = e.rt;
+    const n = e.Be;
+    if (e.Tt === e) E.eE[n] = undefined; else {
+        const t = e.Nt;
         const I = E.eE[n];
         const o = t ?? I;
-        if (e === I) E.eE[n] = t; else e.ct.rt = t;
-        o.ct = e.ct;
+        if (e === I) E.eE[n] = t; else e.Tt.Nt = t;
+        o.Tt = e.Tt;
     }
-    e.ct = e;
-    e.rt = undefined;
+    e.Tt = e;
+    e.Nt = undefined;
 }
 
 function markHeap(e) {
     if (e.tE) return;
     e.tE = true;
     for (let E = 0; E <= e.EE; E++) {
-        for (let t = e.eE[E]; t !== undefined; t = t.rt) {
+        for (let t = e.eE[E]; t !== undefined; t = t.Nt) {
             if (t.ie & REACTIVE_IN_HEAP) markNode(t);
         }
     }
@@ -97,16 +96,16 @@ function markNode(e, E = REACTIVE_DIRTY) {
     const t = e.ie;
     if ((t & (REACTIVE_CHECK | REACTIVE_DIRTY)) >= E) return;
     e.ie = t & -4 | E;
-    for (let E = e.u; E !== null; E = E.ae) {
-        markNode(E.ce, REACTIVE_CHECK);
+    for (let E = e.u; E !== null; E = E.Te) {
+        markNode(E.Ie, REACTIVE_CHECK);
     }
     // Firewall children (projection machinery only): gate the cold-extension
     // deref on the config bit — markNode runs per sub edge per write, and an
     // unconditional _x chase here taxed every propagation (diamond -22%).
         if (e.T & CONFIG_FW_CHILDREN) {
-        for (let E = e.o.i; E !== null; E = E.Se) {
-            for (let e = E.u; e !== null; e = e.ae) {
-                markNode(e.ce, REACTIVE_CHECK);
+        for (let E = e.o.i; E !== null; E = E.Ee) {
+            for (let e = E.u; e !== null; e = e.Te) {
+                markNode(e.Ie, REACTIVE_CHECK);
             }
         }
     }
@@ -114,11 +113,11 @@ function markNode(e, E = REACTIVE_DIRTY) {
 
 function runHeap(e, E) {
     e.tE = false;
-    for (e.Qe = 0; e.Qe <= e.EE; e.Qe++) {
-        let t = e.eE[e.Qe];
+    for (e.Ke = 0; e.Ke <= e.EE; e.Ke++) {
+        let t = e.eE[e.Ke];
         while (t !== undefined) {
             if (t.ie & REACTIVE_IN_HEAP) E(t); else adjustHeight(t, e);
-            t = e.eE[e.Qe];
+            t = e.eE[e.Ke];
         }
     }
     e.EE = 0;
@@ -126,21 +125,21 @@ function runHeap(e, E) {
 
 function adjustHeight(e, E) {
     deleteFromHeap(e, E);
-    let t = e.Me;
-    for (let E = e.ut; E; E = E.lt) {
-        const e = E.ot;
-        const n = e.st || e;
-        if (n.oe && n.Me >= t) t = n.Me + 1;
+    let t = e.Be;
+    for (let E = e.fe; E; E = E.ae) {
+        const e = E.Se;
+        const n = e.ce || e;
+        if (n.oe && n.Be >= t) t = n.Be + 1;
     }
-    if (e.Me !== t) {
-        e.Me = t;
-        for (let E = e.u; E !== null; E = E.ae) {
+    if (e.Be !== t) {
+        e.Be = t;
+        for (let E = e.u; E !== null; E = E.Te) {
             // Route each subscriber by its own zombie flag, mirroring the
             // post-recompute height-adjust path. Inserting into the running `heap`
             // unconditionally can park a zombie in `dirtyQueue` (or a live node in
             // `zombieQueue`), breaking the flag/queue invariant `deleteFromHeap`
             // relies on — the same corruption class as #2759.
-            insertIntoHeapHeight(E.ce, queueFor(E.ce));
+            insertIntoHeapHeight(E.Ie, queueFor(E.Ie));
         }
     }
 }