@solidjs/signals 2.0.0-rc.14 → 2.0.0-rc.16

package/dist/observe/store/store.js

@@ -2,20 +2,24 @@ import { attrHooks } from "../core/attribution-hooks.js";
 
 import { CONFIG_MANUAL_WRITE, CONFIG_OVERRIDE, CONFIG_HELD, $REFRESH, NOT_PENDING, STATUS_PENDING, STATUS_ERROR, EFFECT_RENDER, REACTIVE_RECOMPUTING_DEPS, REACTIVE_STAGED_READ, CONFIG_VERDICT, CONFIG_CHILDREN_FORBIDDEN, CONFIG_PROMOTED, REACTIVE_DIRTY, REACTIVE_CHECK } from "../core/constants.js";
 
-import { setSignal, isEqual, read, verdict, context, notePromotedWrite, untrack, slotSignal, stagedScreen, stagedRead } from "../core/core.js";
+import { writeHook, setSignal, isEqual, read, verdict, snapshotCaptureActive, captureWriteSnapshot, context, notePromotedWrite, untrack, slotSignal, stagedScreen, stagedRead } from "../core/core.js";
 
 import { registerGraph } from "../core/dev.js";
 
+import { signalHook } from "../core/identities.js";
+
 import { setSlotUnobserved } from "../core/graph.js";
 
 import { getOwner, getObserver } from "../core/owner.js";
 
 import { insertIntoHeap } from "../core/heap.js";
 
-import { txOf, flushTransaction, holdNode, joinFuture, insertSubs, schedule, passLane, globalQueue, queuePendingNode, GlobalQueue, joinPassTx, dirtyQueue } from "../core/scheduler.js";
+import { txOf, flushTransaction, holdNode, joinFuture, insertSubs, schedule, passLane, globalQueue, queuePendingNode, GlobalQueue, installStoreHooks, joinPassTx, dirtyQueue } from "../core/scheduler.js";
 
 import { lookupTarget, storeOwners, setLookup, $OWNER, isOwned, markDescendants, devAssertNeverUserMutation } from "./target.js";
 
+import { optHooks, affectsHooks } from "./hooks.js";
+
 import { $TARGET, rawValuesUsed, isRawValue, isWrappable, markRawIngest, writeOverride, markRawOne, $RECORD, $PROXY, $TRACK } from "./types.js";
 
 export { markRaw } from "./types.js";
@@ -49,18 +53,7 @@ export { markRaw } from "./types.js";
  * Perf contracts (plan sec. 31.4): lazy nodes; one literal per node; O(written) per
  * setter (`wk`); overlay drafts for large plain records; no new named
  * fields on array targets; zero allocation for adopted-but-unread objects.
- */ let optHooks = null;
-
-function installOptHooks(e) {
-    optHooks = e;
-}
-
-let affectsHooks = null;
-
-function installAffectsHooks(e) {
-    affectsHooks = e;
-}
-
+ */
 /** Key of the deep-witness slot node (never a user key). */ const $DEEP = Symbol(0);
 
 // ---------------------------------------------------------------------------
@@ -179,7 +172,7 @@ function wrap(e, n = null, t = null, r = n?.fam ?? null) {
 // adoption swap raw identity without changing the logical value — only
 // changed leaves notify, R9).
 const slotNodeEquals = function(e, n) {
-    return isEqual(e, n) || sameLogicalSlot(this.yt, e, n);
+    return isEqual(e, n) || sameLogicalSlot(this.O, e, n);
 };
 
 /** The deep witness: the store decides when it notifies. */ const never = false;
@@ -217,7 +210,7 @@ function sameKey(e, n) {
 /** The container node's comparator: a staging is a backing (identity — a
  * pending backing is never "equal" to the committed one); a lane value is
  * an arrangement (`LaneView`), judged by the optimistic machinery. */ const containerEquals = function(e, n) {
-    return e === n || optHooks !== null && optHooks.arrangement(this.yt, e, n);
+    return e === n || optHooks !== null && optHooks.arrangement(this.O, e, n);
 };
 
 function sameLogicalSlot(e, n, t) {
@@ -230,8 +223,8 @@ function sameLogicalSlot(e, n, t) {
  * released at the commit that resolves it (`drainFolds`). */ const deferredReleases = new Set;
 
 function releaseSlot(e) {
-    const n = e.yt;
-    const t = e.bt;
+    const n = e.O;
+    const t = e.Vt;
     if (t === $TRACK) {
         if (n.k === e) n.k = null;
     } else if (t === $DEEP) {
@@ -247,17 +240,21 @@ function releaseSlot(e) {
 /** A node was born on `target`: a family target enters the live index. */ function noteNode(e, n, t) {
     if (e.fam !== null) e.fam.live.add(e);
     markDescendants(e);
-    if (affectsHooks !== null) affectsHooks.born(e, n, t);
+    if (affectsHooks !== null) affectsHooks.fo(e, n, t);
 }
 
 // Shared slot-node release handler: registered once; the core sweep
 // dispatches CONFIG_SLOT_NODE nodes here (graph.ts) instead of holding a
 // per-node closure in a per-node NodeExtension. A dropped node is
 // unreachable through the store — a fresh read makes a fresh node.
+// A staged write — or a lane's value (a guess, S4) — is state only the node
+// holds: its release waits for the commit that resolves it. So does a leaf of
+// a held container (#4146): a mainline write it carried is in the held
+// staging too, where it would read as the hold's until the landing.
+const slotKept = e => e.ue !== NOT_PENDING || e.l & CONFIG_OVERRIDE || e.O.k?.l & CONFIG_HELD;
+
 setSlotUnobserved(e => {
-    // A staged write — or a lane's value (a guess, S4) — is state only the
-    // node holds: defer the release to the commit that resolves it.
-    if (e.Ae !== NOT_PENDING || e.u & CONFIG_OVERRIDE) deferredReleases.add(e); else releaseSlot(e);
+    if (slotKept(e)) deferredReleases.add(e); else releaseSlot(e);
 });
 
 /** A node born while its container has a staging is born from the two
@@ -265,19 +262,19 @@ setSlotUnobserved(e => {
  * pending one — and held by the container's transaction when the container
  * is held (#3706: the unit of the hold is the key — a key the batch left
  * unchanged stages nothing and holds no one). */ function bornStaged(e, n, t, r) {
-    if (n.tn && n.tn(n.pe, t)) return;
+    if (n.Ye && n.Ye(n.Ie, t)) return;
     queuePendingNode(n);
-    n.Ae = t;
+    n.ue = t;
     const o = e.k;
     if (o === null) return;
  // a node-less staging holds nothing (`stageOn`)
     // Held by the container's transaction only for a key the HELD staging
     // changed — a mainline layer's change above it stages mainline. (A
     // container carrying a guess is a lane's: the flush's park decides.)
-        if ((o.u & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD && heldKeyChanged(e, r)) holdNode(n, txOf(o));
+        if ((o.l & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD && heldKeyChanged(e, r)) holdNode(n, txOf(o));
     // A28 (4): a batch written inside a creation-time pass is promoted — its
     // late-materialized leaf with it.
-        if (o.u & CONFIG_PROMOTED) notePromotedWrite(n);
+        if (o.l & CONFIG_PROMOTED) notePromotedWrite(n);
 }
 
 function getNode(e, n, 
@@ -302,7 +299,9 @@ t = -1) {
         // the hottest store path, and the disabled cost must stay one null
         // check (nodes created before enable() stay generically named).
                 if (attrHooks !== null) {
-            l._name = storeLabel(e) + "." + String(n);
+            const t = storeRoot(e);
+            l._name = (storeNames.get(t) ?? "store") + "." + String(n);
+            l._loc = storeLocs.get(t);
             stampNodeOwner(l, e);
         }
         r[n] = o;
@@ -339,8 +338,8 @@ function getHasNode(e, n) {
         // pending backing staged — so whoever asked for it reads the frame it
         // would have read had the node been there from the write.
                 if (e.pb !== null && !directCommit) {
-            n.pe = preBatch(e);
-            n.Ae = e.pb;
+            n.Ie = preBatch(e);
+            n.ue = e.pb;
             queuePendingNode(n);
         }
     }
@@ -356,11 +355,11 @@ function getHasNode(e, n) {
  * staging: nothing allocates, nothing is swept at the commit (dbmon's tick
  * re-created, queued, swept and dropped ~7000 container nodes). If the
  * flush parks, the seam materializes and holds the node then
- * (`_storePark`) — the one case the staging home exists for. */ function stageOn(e, n) {
-    if (e.k === null && passLane === null && (context === null || globalQueue.ee) && !deriveHolds(e)) return;
+ * (`storeParkHook`) — the one case the staging home exists for. */ function stageOn(e, n) {
+    if (e.k === null && passLane === null && (context === null || globalQueue.q) && !deriveHolds(e)) return;
     const t = getContainerNode(e);
-    if (t.Ae === NOT_PENDING) queuePendingNode(t);
-    t.Ae = n;
+    if (t.ue === NOT_PENDING) queuePendingNode(t);
+    t.ue = n;
     // A28 (4): a write issued inside a pass outside a flush (a creation-time
     // derive) is promoted at the pass's end — the batch with it.
         if (context !== null) notePromotedWrite(t);
@@ -370,10 +369,10 @@ function getHasNode(e, n) {
 /** The projection's derive is held by a transaction and this is its own
  * write (not a user setter's): the staging is the derive's (`holdWithDerive`). */ function deriveHolds(e) {
     const n = e.fam?.node;
-    return n != null && !userWrite && (n.u & CONFIG_HELD) !== 0;
+    return n != null && !userWrite && (n.l & CONFIG_HELD) !== 0;
 }
 
-GlobalQueue.hn = e => {
+const storePark = e => {
     for (let n = 0; n < foldList.length; n++) {
         const t = foldList[n];
         if (t.k === null && t.pb !== null) holdNode(getContainerNode(t), e);
@@ -402,8 +401,9 @@ function bumpDeep(e) {
     // on the guess (`laneWrite` → `supersede`, judged by `containerEquals`);
     // otherwise the structural readers are walked (the staging is already on
     // the node; the comparator is the store's, done).
-    if (e.u & CONFIG_OVERRIDE) setSignal(e, n); else {
-        if (e.u & CONFIG_HELD) joinFuture(txOf(e));
+    if (e.l & CONFIG_OVERRIDE) setSignal(e, n); else {
+        if (e.l & CONFIG_HELD) joinFuture(txOf(e));
+        if (snapshotCaptureActive) captureWriteSnapshot(e, e.Ie);
         insertSubs(e);
         schedule();
     }
@@ -426,12 +426,17 @@ function stampNodeOwner(e, n) {
 
 const storeNames = new WeakMap;
 
-function nameStore(e, n) {
-    if (attrHooks !== null && n) storeNames.set(e[$TARGET], n);
-}
+// The store's `loc` option, carried onto every property node beside its
+// label (the same gate: nodes created before the engine is installed carry
+// neither).
+const storeLocs = new WeakMap;
 
-function storeLabel(e) {
-    return storeNames.get(storeRoot(e)) ?? "store";
+function nameStore(e, n, t) {
+    if (attrHooks !== null) {
+        const r = e[$TARGET];
+        if (n) storeNames.set(r, n);
+        if (t) storeLocs.set(r, t);
+    }
 }
 
 // ---------------------------------------------------------------------------
@@ -520,7 +525,7 @@ const plainProto = e => {
     if (e.kc > OVERLAY_REBUILD_MAX_KEYS) return false;
     if (e.del !== null && e.del.size !== 0) return true;
     const t = e.wk;
-    if (t !== null && t !== WK_ALL && t.size <= OVERLAY_REBUILD_MIN_ADDS) return false;
+    if (t !== null && t !== WK_ALL && t.u === undefined && t.size <= OVERLAY_REBUILD_MIN_ADDS) return false;
     const r = e.v;
     let o = 0;
     for (const e of Reflect.ownKeys(n)) if (!hasOwn.call(r, e) && ++o > OVERLAY_REBUILD_MIN_ADDS) return true;
@@ -540,7 +545,7 @@ const plainProto = e => {
     e.pb = t;
     e.ovl = false;
     // The staging IS the pending backing: re-point the container node.
-        if (e.k !== null && e.k.Ae === n) e.k.Ae = t;
+        if (e.k !== null && e.k.ue === n) e.k.ue = t;
     return t;
 }
 
@@ -561,7 +566,7 @@ const plainProto = e => {
         // mainline setter mid-hold publishes mainline; the held keys stay held).
         n = e.pb = cloneRaw(n, e);
         const t = e.k;
-        if (t !== null && !(t.u & CONFIG_HELD)) t.Ae = n;
+        if (t !== null && !(t.l & CONFIG_HELD)) t.ue = n;
     } else if (n === null) {
         const t = e.v;
         if (!directCommit) queueFold(e);
@@ -640,7 +645,7 @@ const plainProto = e => {
     } else r = e.v;
     if (directCommit) {
         e.pb = null;
-        if (e.k !== null) e.k.pe = n;
+        if (e.k !== null) e.k.Ie = n;
     } else {
         // Eager (INTERNALS §3): the backing swaps now — handlers read the
         // adopted object before the flush — while the container node, when
@@ -736,7 +741,7 @@ let foldIndex = null;
             if (r.pb === null) continue;
  // folded already (a direct commit)
                         const o = r.k;
-            if (o !== null && o.Ae !== NOT_PENDING) {
+            if (o !== null && o.ue !== NOT_PENDING) {
                 // held: commits with its hold
                 foldList.push(r);
                 foldOlds.push(n[t]);
@@ -747,7 +752,7 @@ let foldIndex = null;
     }
     if (deferredReleases.size !== 0) {
         for (const e of deferredReleases) {
-            if (e.Ae === NOT_PENDING && !(e.u & CONFIG_OVERRIDE) && e.t === null) {
+            if (e.o === null && !slotKept(e)) {
                 deferredReleases.delete(e);
                 releaseSlot(e);
             }
@@ -758,28 +763,33 @@ let foldIndex = null;
 /** Core asks: is a slot node's truth in flight? Its family's derive is —
  * lanes (A17, #2864: a guess mid-refetch stands in for the flight) and
  * marks (an ambient `affects()` over a declared reload lives to the
- * landing) read it. */ GlobalQueue.F = e => {
-    const n = e.yt?.fam;
-    return n != null && n.node !== null && (n.node.G & STATUS_PENDING) !== 0;
+ * landing) read it. */ GlobalQueue.k = e => {
+    const n = e.O?.fam;
+    return n != null && n.node !== null && (n.node.m & STATUS_PENDING) !== 0;
 };
 
 /** Core asks (lanes.ts `covered`): the value a slot node's guess covered.
  * A chained link's committed value is the inner store's at the last
  * read-through — refreshed here, since a guess served the reads since
- * (#3672: the revert compares against the base's live value). */ GlobalQueue.Nn = e => {
-    const n = e.yt;
+ * (#3672: the revert compares against the base's live value). */ GlobalQueue.fn = e => {
+    const n = e.O;
     if (n.ch) {
-        const t = e.bt;
+        const t = e.Vt;
         const r = n.v;
-        if (n.h !== null && n.h[t] === e) e.pe = untrack(() => t in r); else if (n.n !== null && n.n[t] === e) e.pe = untrack(() => unwrapValue(r[t]));
+        if (n.h !== null && n.h[t] === e) e.Ie = untrack(() => t in r); else if (n.n !== null && n.n[t] === e) e.Ie = untrack(() => unwrapValue(r[t]));
     }
-    return e.pe;
+    return e.Ie;
 };
 
-GlobalQueue.Sn = () => {
+installStoreHooks(storePark, () => {
     drainFolds();
     optHooks?.sweep();
-};
+});
+
+/** The store half of `affects()` (store/affects.ts) makes its marks' nodes
+ * and walks records through these: it never imports the engine. */ GlobalQueue.no = getNode;
+
+GlobalQueue.so = isWrappable;
 
 /** A projection's creation run commits directly (a memo's first value is
  * its `_value`, not a staging): the draft still writes a clone of the seed,
@@ -807,7 +817,7 @@ function runDirect(e) {
                     // the adopted object (shared ownership — never cloned).
                     e.pb = null;
                     e.wk = null;
-                } else if (e.ovl && (e.v !== n || !overlayRebuilds(e, r))) {
+                } else if (e.ovl && (e.v !== n || !overlayRebuilds(e, r) && t?.T?.lt !== n)) {
                     // Overlay flatten (#3044): the backing keeps its identity, so the
                     // `t.v === old` gate below skips path copying (the parent slot
                     // already points here) and the adopted-notify (setter
@@ -821,8 +831,8 @@ function runDirect(e) {
                     const t = e.v;
                     const o = e.wk;
                     if (o !== null && o !== WK_ALL) {
-                        for (const e of o) {
-                            if (hasOwn.call(r, e)) copyOwn(t, r, e); else delete t[e];
+                        for (let e = o; e !== undefined; e = e.u) for (const n of e) {
+                            if (hasOwn.call(r, n)) copyOwn(t, r, n); else delete t[n];
                         }
                     } else {
                         for (const e of Reflect.ownKeys(r)) {
@@ -849,7 +859,7 @@ function runDirect(e) {
                 // subscribes to was a transient staging home (INTERNALS §5: an
                 // observer-less write holds a transient record until the fold,
                 // discarded with it) — gone with the batch.
-                if (t.t === null) e.k = null; else if (t.pe instanceof LaneView) t.pe.base = e.v; else t.pe = e.v;
+                if (t.o === null) e.k = null; else if (t.Ie instanceof LaneView) t.Ie.base = e.v; else t.Ie = e.v;
             }
             if (e.v !== n && e.u) {
                 const t = parentSlotKey(e, n);
@@ -922,9 +932,9 @@ function reportReplacedContainers(e, n, t, r) {
 
 function heldDerivation(e, n, t) {
     if (e.fam === null || !userWrite) return false;
-    if (n !== undefined) return (n.u & (CONFIG_HELD | CONFIG_MANUAL_WRITE)) === CONFIG_HELD && txOf(n) !== flushTransaction;
+    if (n !== undefined) return (n.l & (CONFIG_HELD | CONFIG_MANUAL_WRITE)) === CONFIG_HELD && txOf(n) !== flushTransaction;
     const r = e.k;
-    return r !== null && (r.u & CONFIG_HELD) !== 0 && txOf(r) !== flushTransaction && heldKeyChanged(e, t);
+    return r !== null && (r.l & CONFIG_HELD) !== 0 && txOf(r) !== flushTransaction && heldKeyChanged(e, t);
 }
 
 /** Setter exit: one node write per changed observed key (the leaves stage
@@ -954,7 +964,10 @@ function heldDerivation(e, n, t) {
     // value can change when ANY key is written), or a non-plain prototype
     // (class instances: prototype getters derive from arbitrary fields).
     // Overlay pbs chain to the COMMITTED object (#3044) — plainness is the
-    // committed container's prototype, not the overlay's.
+    // committed container's prototype, not the overlay's. THIS setter's keys
+    // only (D-8, #3743): a key an earlier setter of the batch wrote and this
+    // one did not is no second proposal — its node was told then, and telling
+    // a held node its unchanged value again would join this tick to the hold.
         const o = e.wk;
     const i = o === WK_ALL || e.a === true || !plainProto(e.ovl ? e.v : n) ? null : o;
     if (attrHooks !== null) reportReplacedContainers(e, t, n, i);
@@ -970,15 +983,18 @@ function heldDerivation(e, n, t) {
             if (o.acc === true || hasOwn.call(n, i) && lookupGetter.call(n, i) !== undefined) {
                 // Accessor keys: the node is linked for shape-change notification,
                 // its value is never served (the getter runs with the proxy
-                // receiver on read) — FORCE wakes the readers.
+                // receiver on read) — FORCE wakes the readers. A data descriptor
+                // falls through so the cleared-acc hot read serves it (#3949);
+                // an own getter's descriptor has no `value`, so the compare below
+                // would otherwise keep the getter's result (or FORCE) for `undefined`.
                 o.acc = isOwnAccessor(n, i);
                 const e = Object.getOwnPropertyDescriptor(t, i);
                 const r = Object.getOwnPropertyDescriptor(n, i);
-                if (e && (e.get || e.set) || r && (r.get || r.set)) {
+                if (!r || r.get || r.set) {
                     if (e?.get !== r?.get || e?.set !== r?.set || e?.value !== r?.value) setSignal(o, () => FORCE);
                     continue;
                 }
-                if (!isEqual(e?.value, r?.value)) setSignal(o, () => r?.value);
+                if (e?.get || e?.set || !isEqual(e?.value, r.value)) setSignal(o, () => r.value);
                 continue;
             }
             const l = e.del !== null && e.del.has(i) ? undefined : n[i];
@@ -987,9 +1003,9 @@ function heldDerivation(e, n, t) {
                 // The derive's write is a derivation; a user setter's is a proposal
                 // (A34 (3)'s discriminator).
                 if (!userWrite) {
-                    o.u &= ~CONFIG_MANUAL_WRITE;
+                    o.l &= ~CONFIG_MANUAL_WRITE;
                     holdWithDerive(e, o);
-                } else o.u |= CONFIG_MANUAL_WRITE;
+                } else o.l |= CONFIG_MANUAL_WRITE;
             }
         }
     }
@@ -1020,7 +1036,7 @@ function heldDerivation(e, n, t) {
     // container carrying an arrangement guess is told whether or not anyone
     // subscribes: the write is a landing on the guess (`notifyContainer`).
         const u = e.k;
-    if (u !== null && (u.t !== null || u.u & CONFIG_OVERRIDE)) {
+    if (u !== null && (u.o !== null || u.l & CONFIG_OVERRIDE)) {
         let r;
         if (e.ovl) {
             r = e.del !== null && e.del.size !== 0;
@@ -1069,13 +1085,14 @@ function membershipChanged(e, n) {
         e.acc = isOwnAccessor(r, n);
         const o = Object.getOwnPropertyDescriptor(t, n);
         const i = Object.getOwnPropertyDescriptor(r, n);
-        if (o && (o.get || o.set) || i && (i.get || i.set)) {
+        // Data descriptors fall through, as in notifyWrites (#3949).
+                if (!i || i.get || i.set) {
             if (o?.get !== i?.get || o?.set !== i?.set || o?.value !== i?.value) setSignal(e, () => FORCE);
             return;
         }
         const l = o?.value;
         const u = i?.value;
-        if (!isEqual(l, u) && !targetsEqual(l, u)) setSignal(e, typeof u === "function" ? () => u : u);
+        if (o?.get || o?.set || !isEqual(l, u) && !targetsEqual(l, u)) setSignal(e, typeof u === "function" ? () => u : u);
     } else {
         const o = t[n];
         const i = r[n];
@@ -1121,7 +1138,7 @@ function hasAccessorFlag(e) {
         for (const o of Reflect.ownKeys(r)) if (e || o in n !== o in t) setSignal(r[o], o in t);
     }
     const o = e.k;
-    if (o !== null && (o.t !== null || o.u & CONFIG_OVERRIDE)) {
+    if (o !== null && (o.o !== null || o.l & CONFIG_OVERRIDE)) {
         const e = Array.isArray(t) && Array.isArray(n) ? arrayStructureChanged(n, t) : membershipChanged(n, t);
         if (e) notifyContainer(o, t);
     }
@@ -1178,7 +1195,7 @@ function inDraft(e) {
  * "adoption is eager by contract" — and the node keeps the frame committed
  * readers under a hold still see), `t.v` otherwise. */ function committed(e) {
     const n = e.k;
-    if (n !== null) return n.Ae !== NOT_PENDING ? asBacking(n.pe) : e.v;
+    if (n !== null) return n.ue !== NOT_PENDING ? asBacking(n.Ie) : e.v;
     // A node-less staging (`stageOn`): the fold queue remembers the frame.
         return e.pb !== null ? preBatch(e) : e.v;
 }
@@ -1190,8 +1207,8 @@ function inDraft(e) {
  * committed frame. */ function stagingReader() {
     let e = context;
     if (e === null) return null;
-    if (e.Ht) e = e.gt ?? null;
-    return e === null || e.u & CONFIG_CHILDREN_FORBIDDEN ? null : e;
+    if (e.Pt) e = e.Ht ?? null;
+    return e === null || e.l & CONFIG_CHILDREN_FORBIDDEN ? null : e;
 }
 
 /** The backing a read serves (RUL-1, signal parity): the draft and the write
@@ -1229,10 +1246,10 @@ function inDraft(e) {
         if (writeOverride && !userWrite) {
             const t = n !== undefined ? e.n?.[n] : undefined;
             if (t !== undefined) {
-                if ((t.u & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD) joinPassTx(txOf(t));
+                if ((t.l & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD) joinPassTx(txOf(t));
             } else {
                 const t = e.k;
-                if (t !== null && (t.u & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD && (n === undefined || heldKeyChanged(e, n))) joinPassTx(txOf(t));
+                if (t !== null && (t.l & (CONFIG_HELD | CONFIG_OVERRIDE)) === CONFIG_HELD && (n === undefined || heldKeyChanged(e, n))) joinPassTx(txOf(t));
             }
         }
         return r;
@@ -1244,9 +1261,9 @@ function inDraft(e) {
     // it).
         if (n !== undefined) {
         const t = e.n?.[n];
-        if (t !== undefined && t.u & CONFIG_OVERRIDE) return committed(e);
+        if (t !== undefined && t.l & CONFIG_OVERRIDE) return committed(e);
     }
-    const i = o !== null && (o.u & CONFIG_HELD) !== 0;
+    const i = o !== null && (o.l & CONFIG_HELD) !== 0;
     // A held container: the hold's unit is the key (#3706). A key the HELD
     // staging left unchanged reads the ambient view — a mainline layer's
     // write above the hold publishes mainline (#3688, #3612); a key it
@@ -1264,7 +1281,7 @@ function inDraft(e) {
         // probe) judges the container like any node — for a key the batch
         // changed; an unchanged key is committed and final (A22: pending is per
         // key). A held container's committed frame is the node's.
-                if (verdict === null || !i && n !== undefined && !keyChanged(e, n, t)) return i ? asBacking(o.pe) : e.v;
+                if (verdict === null || !i && n !== undefined && !keyChanged(e, n, t)) return i ? asBacking(o.Ie) : e.v;
         return o === null ? committed(e) : asBacking(read(o));
     }
     // A pass reading a key the batch left unchanged: the same value in both
@@ -1281,13 +1298,13 @@ function inDraft(e) {
         // frames, a changed one is what the mark already stands for. The
         // per-key question is asked once per pass, not once per key (a
         // `mapArray` over 1k shifted rows asked it 1k times).
-        if (l.R & REACTIVE_STAGED_READ && !(l.u & (CONFIG_VERDICT | CONFIG_CHILDREN_FORBIDDEN))) return r;
+        if (l.R & REACTIVE_STAGED_READ && !(l.l & (CONFIG_VERDICT | CONFIG_CHILDREN_FORBIDDEN))) return r;
         if (n !== undefined && !keyChanged(e, n, t)) return committed(e);
         // A node-less staging (`stageOn`): what `read()` of its node would do
         // for this pass — a verdict reader sees the screen, any other derives
         // from the staging and is marked as having read it.
                 if (o === null) {
-            if (l.u & CONFIG_VERDICT && stagedScreen(l)) return committed(e);
+            if (l.l & CONFIG_VERDICT && stagedScreen(l)) return committed(e);
             stagedRead(l);
             return r;
         }
@@ -1297,11 +1314,52 @@ function inDraft(e) {
 
 /** Did the HELD staging (the container node's, not a mainline layer above
  * it) change `key`? */ function heldKeyChanged(e, n, t = true) {
-    return changedBetween(e, e.k.pe, e.k.Ae, n, t);
+    return changedBetween(e, e.k.Ie, e.k.ue, n, t) && !adoptChild(e, n);
+}
+
+/** The values of a held frame, built once per frame: neither the committed
+ * frame nor the held staging changes while the hold stands (a draft writes a
+ * clone), so the set stays true for every first read of the hold. */ const frameRaws = new WeakMap;
+
+function rawsOf(e) {
+    let n = frameRaws.get(e);
+    if (n === undefined) frameRaws.set(e, n = new Set(Object.values(e)));
+    return n;
+}
+
+/** The same row at a slot, as the adoption pairs rows (reconcile.ts): two
+ * objects whose keys agree — positionally for an unkeyed family. */ function sameRow(e, n, t) {
+    return e !== null && typeof e === "object" && n !== null && typeof n === "object" && (t === null || sameKey(t(e), t(n)));
+}
+
+/** A key of a held adoption whose old and new values are the same row that
+ * nothing had proxied when the adoption ran, so `descend` never paired
+ * them: paired now, as it would have been (#3712) — one target, the old
+ * raw its committed frame, the new raw its staging, held by the same
+ * transaction. Both raws resolve to it, so the slot reads as unchanged and
+ * the row's own leaves decide: `id` the same in both frames holds no one,
+ * `version` holds. A record's keys pair by name; an array's by the family's
+ * key — without a family the pairing is not known here and the hold stands. */ function adoptChild(e, n) {
+    const t = e.k;
+    const r = asBacking(t.Ie);
+    const o = r[n];
+    const i = t.ue[n];
+    const l = Array.isArray(r) ? e.fam?.key : null;
+    if (e.s || l === undefined || !sameRow(o, i, l) || !isWrappable(o) || !isWrappable(i) || Array.isArray(o) !== Array.isArray(i) || lookupTarget(o, e.fam) !== undefined || lookupTarget(i, e.fam) !== undefined || 
+    // A raw in both frames (the same objects swapped or reordered) is its
+    // own row: pairing it with another would alias the two after the commit.
+    rawsOf(r).has(i) || rawsOf(t.ue).has(o)) return false;
+    // A raw-marked value wraps to itself, a proxy to its own target: neither
+    // is a fresh target around `ov`.
+        const u = wrap(o, e, n)[$TARGET];
+    if (u === undefined || u.v !== o) return false;
+    adoptPB(u, i, false);
+    holdNode(getContainerNode(u), txOf(t));
+    return true;
 }
 
 /** A family target's unheld staging, read with no pass (a handler). */ function familyAhead(e) {
-    return e.fam !== null && context === null && !(e.k !== null && e.k.u & CONFIG_HELD);
+    return e.fam !== null && context === null && !(e.k !== null && e.k.l & CONFIG_HELD);
 }
 
 /** Did this batch change `key` — value (slot equality), presence, and (for
@@ -1335,7 +1393,7 @@ function changedBetween(e, n, t, r, o) {
  * tracked or not, applies the hold and A28 rules a signal's read does. A
  * projection's unheld staging is ahead for a handler (`familyAhead`). */ function nodeValue(e, n, t) {
     let r = read(e);
-    if (e.Ae !== NOT_PENDING && !(e.u & CONFIG_HELD) && context === null && t.fam !== null) r = e.Ae;
+    if (e.ue !== NOT_PENDING && !(e.l & CONFIG_HELD) && context === null && t.fam !== null) r = e.ue;
     return r === FORCE ? n : r;
 }
 
@@ -1355,8 +1413,8 @@ function changedBetween(e, n, t, r, o) {
             if (l) {
                 // The link's committed value follows the inner store's (what a lane
                 // over it covers — its reveal and revert compare against it, S4).
-                o.pe = t;
-                if (o.u & CONFIG_OVERRIDE) u = n;
+                o.Ie = t;
+                if (o.l & CONFIG_OVERRIDE) u = n;
             } else u = n;
         }
     }
@@ -1377,7 +1435,7 @@ function changedBetween(e, n, t, r, o) {
 }
 
 /** Is `n` among `c`'s dependencies (any pass's — a kept tail included)? */ function linkedTo(e, n) {
-    for (let t = e._; t !== null; t = t.p) if (t.I === n) return true;
+    for (let t = e.C; t !== null; t = t.G) if (t.S === n) return true;
     return false;
 }
 
@@ -1396,7 +1454,7 @@ function changedBetween(e, n, t, r, o) {
     // reader of a memo would — linked, so it re-runs at the landing (the
     // next settled pass pulls without linking and the stale link trims), a
     // verdict reader registered, a tracked pass suspended.
-        if (n.G & (STATUS_PENDING | STATUS_ERROR)) {
+        if (n.m & (STATUS_PENDING | STATUS_ERROR)) {
         // A render effect outside the flight's own flush is the frame, not a
         // derivation: it keeps what it shows and learns of the landing from the
         // leaves the landing changes (unchanged leaves say nothing — it is not a
@@ -1404,9 +1462,10 @@ function changedBetween(e, n, t, r, o) {
         // One that already observes the flight (linked by the pass that saw it
         // go up — the frame's hold, `blocked`) keeps observing it: a re-run for
         // another reason (a guess it read, the seam) that dropped the link would
-        // release the hold with the flight still up.
+        // release the hold with the flight still up. An errored derive has no
+        // landing to learn of: the error is what the frame shows.
         const t = context;
-        if (t !== null && t.i === EFFECT_RENDER && n.u & CONFIG_HELD && flushTransaction !== txOf(n) && !linkedTo(t, n)) return;
+        if (t !== null && t.i === EFFECT_RENDER && !(n.m & STATUS_ERROR) && n.l & CONFIG_HELD && flushTransaction !== txOf(n) && !linkedTo(t, n)) return;
         // An optimistic family carrying guesses that stand in for the flight
         // (A17): the guesses are the display — a reader is served the leaves
         // (committed plus the guesses) and does not suspend on the derive; a
@@ -1414,7 +1473,7 @@ function changedBetween(e, n, t, r, o) {
         // up). The family's, not the target's: the edit stands in for the one
         // flight the family has.
                 const r = e.fam.overlaid;
-        if (verdict === null && n.G & STATUS_PENDING && r !== undefined && r.size !== 0) return;
+        if (verdict === null && n.m & STATUS_PENDING && r !== undefined && r.size !== 0) return;
         read(n);
     } else untrack(() => read(n));
 }
@@ -1427,12 +1486,12 @@ function changedBetween(e, n, t, r, o) {
  * classification, as core reads it — `heldNotFinal`). */ function holdWithDerive(e, n) {
     const t = e.fam?.node;
     if (t !== undefined && t !== null && !userWrite && // the derive's own write (its draft or landing), not a user setter's
-    t.u & CONFIG_HELD && n.Ae !== NOT_PENDING && 
+    t.l & CONFIG_HELD && n.ue !== NOT_PENDING && 
     // A node carrying a guess is the lane's: its staging is the truth beneath
     // the guess (`setSignal` → `laneWrite`), never re-homed by the store.
-    !(n.u & (CONFIG_HELD | CONFIG_OVERRIDE))) {
+    !(n.l & (CONFIG_HELD | CONFIG_OVERRIDE))) {
         holdNode(n, txOf(t));
-        n.m.It = t.m.It;
+        n.T.ut = t.T.ut;
     }
 }
 
@@ -1475,6 +1534,22 @@ function changedBetween(e, n, t, r, o) {
 
 // ---------------------------------------------------------------------------
 // traps
+/** A trap write: the target is told at the setter's exit, the key recorded
+ * in this setter's `wk`. A setter's first write to a target still staged by
+ * an earlier setter of the batch opens a set of its own (the notify visits
+ * it, D-8) and chains the earlier one behind for the fold's union. */ function touch(e, n) {
+    let t = e.wk;
+    if (!pendingNotify.has(e)) {
+        pendingNotify.add(e);
+        if (t !== null && t !== WK_ALL) {
+            t = new Set;
+            t.u = e.wk;
+            e.wk = t;
+        }
+    }
+    if (t !== WK_ALL) (e.wk ??= new Set).add(n);
+}
+
 const traps = {
     get(e, n, t) {
         // One typeof gates every brand-symbol compare off the hot string path.
@@ -1503,7 +1578,7 @@ const traps = {
                 }
         // (The witness before the pull: a mark on an uninitialized derived
         // store is witnessed, then the pull throws — loading, declared pending.)
-                if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.witness(e, n);
+                if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.ro(e, n);
         if (e.fam !== null) pullFamily(e);
         // Hot inline case: existing PLAIN node (non-accessor) read outside any
         // draft — the dbmon/uibench effect re-read shape. Core's `read()` serves
@@ -1518,7 +1593,7 @@ const traps = {
                 const r = e.n?.[n];
         if (writeScopes === null && !writeOverride) {
             const t = r;
-            if (t !== undefined && t.acc !== true && (!e.ch || t.u & CONFIG_OVERRIDE)) {
+            if (t !== undefined && t.acc !== true && (!e.ch || t.l & CONFIG_OVERRIDE)) {
                 const r = nodeValue(t, undefined, e);
                 if (r === null || typeof r !== "object") return r;
                 if (e.s) return serveShallow(e, n, r);
@@ -1600,7 +1675,7 @@ const traps = {
         if (n === $OWNER || n === $RECORD) return false;
         // (The witness before the pull: a mark on an uninitialized derived
         // store is witnessed, then the pull throws — loading, declared pending.)
-                if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.witness(e, n);
+                if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.ro(e, n);
         if (e.fam !== null) pullFamily(e);
         const t = readSource(e, n);
         // A tracked reader's presence node answers (born from the two frames;
@@ -1613,9 +1688,9 @@ const traps = {
                 const o = read(r);
                 if (!e.ch || t !== e.v) return !!o;
                 const i = n in t;
-                r.pe = i;
+                r.Ie = i;
  // the link follows the inner store (S4)
-                                if (r.u & CONFIG_OVERRIDE) return !!o;
+                                if (r.l & CONFIG_OVERRIDE) return !!o;
                 return i;
             } else if (optRead(e)) {
                 const t = optHooks.has(e, n);
@@ -1625,14 +1700,14 @@ const traps = {
         return n in t && !(e.del !== null && t === e.pb && e.del.has(n));
     },
     ownKeys(e) {
-        if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.witness(e, undefined);
+        if (verdict !== null && affectsHooks !== null && getObserver() === null) affectsHooks.ro(e, undefined);
         if (e.fam !== null) pullFamily(e);
         return visibleKeys(e, enumerationSource(e));
     },
     getOwnPropertyDescriptor(e, n) {
         if (n === $OWNER || n === $RECORD) return undefined;
         const t = getObserver();
-        if (verdict !== null && affectsHooks !== null && t === null) affectsHooks.witness(e, n);
+        if (verdict !== null && affectsHooks !== null && t === null) affectsHooks.ro(e, n);
         if (e.fam !== null) pullFamily(e);
         // An enumerator (spread, Object.entries) already holds the container
         // node and reads its frame; a descriptor read on its own tracks
@@ -1650,7 +1725,7 @@ const traps = {
             const t = getHasNode(e, n);
             const r = read(t);
             i = readSource(e, n, true);
-            if (!r && (!e.ch || t.u & CONFIG_OVERRIDE || !(n in i))) return undefined;
+            if (!r && (!e.ch || t.l & CONFIG_OVERRIDE || !(n in i))) return undefined;
         } else i = readSource(e, n, true);
         let l;
         if (!o && optRead(e)) {
@@ -1671,15 +1746,22 @@ const traps = {
  // pollution guard (core R30)
                 const i = e.s ? t : unwrapValue(t);
         const l = ensurePB(e);
-        pendingNotify.add(e);
+        // #4146 (R1: node existence is unobservable; #3706: the hold's unit is
+        // the key): a user setter writing a key a HELD container's staging left
+        // unchanged would write it into the held staging — read as the hold's
+        // until its landing, while the same key with a leaf (a live reader)
+        // publishes at the flush. The key gets its leaf first, born from the two
+        // frames (`bornStaged`: a key the hold left unchanged — or added — is
+        // unstaged and held by no one; a key the hold changed is born held, A34
+        // (1)), and the write stages on it (A28; a write by the holder joins it,
+        // A34) — as it would with a reader's leaf. Kept while the container is
+        // held (`deferredReleases`).
+                if (userWrite && e.k?.l & CONFIG_HELD) deferredReleases.add(getNode(e, n));
         if (Array.isArray(l)) {
-            if (n === "length") e.wk = WK_ALL; else if (e.wk !== WK_ALL) {
-                const t = e.wk ??= new Set;
-                t.add(n);
-                t.add("length");
-            }
+            touch(e, n);
+            if (n === "length") e.wk = WK_ALL; else touch(e, "length");
         } else {
-            if (e.wk !== WK_ALL) (e.wk ??= new Set).add(n);
+            touch(e, n);
             if (!(n in l)) e.kc++;
         }
         if (UNSAFE_KEYS.has(n)) {
@@ -1717,8 +1799,7 @@ const traps = {
         };
         const i = ensurePB(e);
         if (e.a || !(t.enumerable && t.writable && t.configurable)) e.sc = 1;
-        pendingNotify.add(e);
-        if (e.wk !== WK_ALL) (e.wk ??= new Set).add(n);
+        touch(e, n);
         Object.defineProperty(i, n, t);
         if (e.del !== null) e.del.delete(n);
         if (o) notifyWrites(e);
@@ -1729,10 +1810,22 @@ const traps = {
         const r = !t && writeOverride;
         if (!t && !r) return true;
         const o = ensurePB(e);
-        pendingNotify.add(e);
-        if (e.wk !== WK_ALL) (e.wk ??= new Set).add(n);
-        delete o[n];
-        if (e.ovl && hasOwn.call(e.v, n)) (e.del ??= new Set).add(n);
+        touch(e, n);
+        // The key count (`kc`, the overlay gate and the rebuild cap) follows a
+        // delete the way it follows an add: an own key of the draft leaving — a
+        // clone's key, or an overlay's own add — is one fewer now. An overlay's
+        // override of a committed key is the exception: the committed key's
+        // deletion is recorded in `del` and counted at the rebuild, as before.
+        // Without the decrement the natural "delete the old key, set the new
+        // one" shape drifted the count up by one per write until a three-key
+        // object crossed the overlay threshold and paid a rebuild on every
+        // commit after.
+                const i = e.ovl && hasOwn.call(e.v, n);
+        if (hasOwn.call(o, n)) {
+            delete o[n];
+            i || e.kc--;
+        }
+        if (i) (e.del ??= new Set).add(n);
         if (r) notifyWrites(e);
         return true;
     }
@@ -1743,11 +1836,12 @@ const traps = {
  * to the key's presence node or a later add never re-runs it. */ function observerHoldsContainer(e, n) {
     const t = e.k;
     if (t === null) return false;
-    const r = t.Dt;
-    return r !== null && r.o === n && (!(n.R & REACTIVE_RECOMPUTING_DEPS) || r.Ue === n.he);
+    const r = t.dt;
+    return r !== null && r.u === n && (!(n.R & REACTIVE_RECOMPUTING_DEPS) || r.Te === n.Ne);
 }
 
 function storeSetter(e, n, t = true) {
+    if (writeHook !== null) writeHook(e);
     const r = e[$TARGET];
     const o = writeScopes;
     writeScopes = new Set;
@@ -1801,6 +1895,8 @@ function storeSetter(e, n, t = true) {
 function createStore(e, n) {
     const t = n?.shallow === true;
     const r = wrap(e);
+    // Dependency edges (store/edges.ts): the root is named like a plain signal.
+        if (signalHook !== null) signalHook(r[$TARGET]);
     if (t) {
         r[$TARGET].s = true;
         markRawIngest(e);
@@ -1815,7 +1911,7 @@ function createStore(e, n) {
         // disabled, buys nothing.
                 if (attrHooks !== null) {
             storeOwners.set(r[$TARGET], e);
-            nameStore(r, n?.name);
+            nameStore(r, n?.name, n?.loc);
         }
     }
     const setter = e => storeSetter(r, e);
@@ -1944,7 +2040,7 @@ function snapshotWalk(e, n, t) {
         // R27: a snapshot sees the batch's pending backing — a held one (another
         // transaction's future) only from its own draft.
                 let i = o.v;
-        if (o.pb !== null && (inDraft(o) || writeOverride || o.k === null || !(o.k.u & CONFIG_HELD))) {
+        if (o.pb !== null && (inDraft(o) || writeOverride || o.k === null || !(o.k.l & CONFIG_HELD))) {
             if (o.ovl) materializePB(o);
             i = o.pb;
         }
@@ -1996,4 +2092,4 @@ function snapshotWalk(e, n, t) {
     return i ?? r;
 }
 
-export { $PROXY, $TARGET, $TRACK, LaneView, adoptPB, affectsHooks, arrayStructureChanged, asBacking, bumpDeep, cloneRaw, committed, containerEquals, createStore, deep, getContainerNode, getHasNode, getNode, hasAccessorFlag, installAffectsHooks, installOptHooks, materializePB, membershipChanged, nameStore, notifyFold, notifyFoldTail, notifyKeyDiff, notifyKeyValue, optHooks, resolveChainedRaw, runDirect, sameKey, snapshot, storeHasFamily, storeHasOptimisticFamily, storeIsShallow, storeSetter, targetsEqual, unwrapValue, userWriting, wrap };
+export { $PROXY, $TARGET, $TRACK, LaneView, adoptPB, arrayStructureChanged, asBacking, bumpDeep, cloneRaw, committed, containerEquals, createStore, deep, getContainerNode, getHasNode, getNode, hasAccessorFlag, materializePB, membershipChanged, nameStore, notifyFold, notifyFoldTail, notifyKeyDiff, notifyKeyValue, resolveChainedRaw, runDirect, sameKey, sameRow, snapshot, storeHasFamily, storeHasOptimisticFamily, storeIsShallow, storeSetter, targetsEqual, unwrapValue, userWriting, wrap };