@solidjs/signals 0.9.7 → 0.9.8

package/dist/dev.js

@@ -350,7 +350,6 @@ function insertSubs(node, optimistic = false) {
 function finalizePureQueue(completingTransition = null, incomplete = false) {
   let resolvePending = !incomplete;
   if (dirtyQueue._max >= dirtyQueue._min) {
-    resolvePending = true;
     runHeap(dirtyQueue, GlobalQueue._update);
   }
   if (resolvePending) {
@@ -562,6 +561,7 @@ function recompute(el, create = false) {
   setOptimisticReadActive(prevOptimisticRead);
   (!create || el._statusFlags & STATUS_PENDING) &&
     !el._transition &&
+    !(activeTransition && el._optimistic) &&
     globalQueue._pendingNodes.push(el);
   el._transition &&
     isEffect &&
@@ -1042,12 +1042,14 @@ function setSignal(el, v) {
   const valueChanged = !el._equals || !el._equals(currentValue, v);
   if (!valueChanged) return v;
   if (isOptimistic) {
-    const isFirstWrite = el._pendingValue === NOT_PENDING;
-    if (el._transition && !isFirstWrite) {
+    const alreadyTracked = globalQueue._optimisticNodes.includes(el);
+    if (el._transition && alreadyTracked) {
       globalQueue.initTransition(el._transition);
     }
-    if (isFirstWrite) {
+    if (el._pendingValue === NOT_PENDING) {
       el._pendingValue = el._value;
+    }
+    if (!alreadyTracked) {
       globalQueue._optimisticNodes.push(el);
     }
     el._value = v;

package/dist/node.cjs

@@ -343,7 +343,6 @@ function insertSubs(e, t = false) {
 function finalizePureQueue(e = null, t = false) {
   let n = !t;
   if (_.S >= _.W) {
-    n = true;
     runHeap(_, GlobalQueue.K);
   }
   if (n) {
@@ -539,7 +538,7 @@ function recompute(t, n = false) {
     }
   }
   setOptimisticReadActive(y);
-  (!n || t.re & c) && !t.X && A.D.push(t);
+  (!n || t.re & c) && !t.X && !(v && t.le) && A.D.push(t);
   t.X && i && v !== t.X && runInTransition(t.X, () => recompute(t));
 }
 function handleAsync(e, t, n) {
@@ -989,12 +988,14 @@ function setSignal(e, t) {
   const i = !e.ae || !e.ae(r, t);
   if (!i) return t;
   if (n) {
-    const n = e.te === g;
-    if (e.X && !n) {
+    const n = A.B.includes(e);
+    if (e.X && n) {
       A.initTransition(e.X);
     }
-    if (n) {
+    if (e.te === g) {
       e.te = e.ne;
+    }
+    if (!n) {
       A.B.push(e);
     }
     e.ne = t;

package/dist/prod.js

@@ -342,7 +342,6 @@ function insertSubs(e, t = false) {
 function finalizePureQueue(e = null, t = false) {
   let n = !t;
   if (dirtyQueue.O >= dirtyQueue.N) {
-    n = true;
     runHeap(dirtyQueue, GlobalQueue.j);
   }
   if (n) {
@@ -539,7 +538,7 @@ function recompute(e, t = false) {
     }
   }
   setOptimisticReadActive(c);
-  (!t || e.ie & STATUS_PENDING) && !e.X && globalQueue.L.push(e);
+  (!t || e.ie & STATUS_PENDING) && !e.X && !(activeTransition && e.le) && globalQueue.L.push(e);
   e.X && n && activeTransition !== e.X && runInTransition(e.X, () => recompute(e));
 }
 function handleAsync(e, t, n) {
@@ -1000,12 +999,14 @@ function setSignal(e, t) {
   const r = !e.fe || !e.fe(i, t);
   if (!r) return t;
   if (n) {
-    const n = e.te === NOT_PENDING;
-    if (e.X && !n) {
+    const n = globalQueue.H.includes(e);
+    if (e.X && n) {
       globalQueue.initTransition(e.X);
     }
-    if (n) {
+    if (e.te === NOT_PENDING) {
       e.te = e.ne;
+    }
+    if (!n) {
       globalQueue.H.push(e);
     }
     e.ne = t;
@@ -2120,8 +2121,8 @@ function mapArray(e, t, n) {
       Ue: [],
       ke: i,
       We: i || n?.keyed === false ? [] : undefined,
-      xe: t.length > 1 ? [] : undefined,
-      Qe: n?.fallback
+      Qe: t.length > 1 ? [] : undefined,
+      xe: n?.fallback
     })
   );
 }
@@ -2136,17 +2137,17 @@ function updateKeyedMap() {
       r = this.We
         ? () => {
             this.We[i] = signal(e[i], pureOptions);
-            this.xe && (this.xe[i] = signal(i, pureOptions));
+            this.Qe && (this.Qe[i] = signal(i, pureOptions));
             return this.Ve(
               read.bind(null, this.We[i]),
-              this.xe ? read.bind(null, this.xe[i]) : undefined
+              this.Qe ? read.bind(null, this.Qe[i]) : undefined
             );
           }
-        : this.xe
+        : this.Qe
           ? () => {
               const t = e[i];
-              this.xe[i] = signal(i, pureOptions);
-              return this.Ve(() => t, read.bind(null, this.xe[i]));
+              this.Qe[i] = signal(i, pureOptions);
+              return this.Ve(() => t, read.bind(null, this.Qe[i]));
             }
           : () => {
               const t = e[i];
@@ -2160,10 +2161,10 @@ function updateKeyedMap() {
         this.me = [];
         this.we = 0;
         this.We && (this.We = []);
-        this.xe && (this.xe = []);
+        this.Qe && (this.Qe = []);
       }
-      if (this.Qe && !this.me[0]) {
-        this.me[0] = runWithOwner((this.Ue[0] = createOwner()), this.Qe);
+      if (this.xe && !this.me[0]) {
+        this.me[0] = runWithOwner((this.Ue[0] = createOwner()), this.xe);
       }
     } else if (this.we === 0) {
       if (this.Ue[0]) this.Ue[0].dispose();
@@ -2184,7 +2185,7 @@ function updateKeyedMap() {
         E = new Array(t),
         T = new Array(t),
         R = this.We ? new Array(t) : undefined,
-        d = this.xe ? new Array(t) : undefined;
+        d = this.Qe ? new Array(t) : undefined;
       for (
         o = 0, s = Math.min(this.we, t);
         o < s && (this.ve[o] === e[o] || (this.We && compare(this.ke, this.ve[o], e[o])));
@@ -2202,7 +2203,7 @@ function updateKeyedMap() {
         E[u] = this.me[s];
         T[u] = this.Ue[s];
         R && (R[u] = this.We[s]);
-        d && (d[u] = this.xe[s]);
+        d && (d[u] = this.Qe[s]);
       }
       a = new Map();
       f = new Array(u + 1);
@@ -2221,7 +2222,7 @@ function updateKeyedMap() {
           E[i] = this.me[n];
           T[i] = this.Ue[n];
           R && (R[i] = this.We[n]);
-          d && (d[i] = this.xe[n]);
+          d && (d[i] = this.Qe[n]);
           i = f[i];
           a.set(c, i);
         } else this.Ue[n].dispose();
@@ -2235,8 +2236,8 @@ function updateKeyedMap() {
             setSignal(this.We[i], e[i]);
           }
           if (d) {
-            this.xe[i] = d[i];
-            setSignal(this.xe[i], i);
+            this.Qe[i] = d[i];
+            setSignal(this.Qe[i], i);
           }
         } else {
           this.me[i] = runWithOwner((this.Ue[i] = createOwner()), r);
@@ -2258,7 +2259,7 @@ function repeat(e, t, n) {
     Ue: [],
     me: [],
     $e: n?.from,
-    Qe: n?.fallback
+    xe: n?.fallback
   });
 }
 function updateRepeat() {
@@ -2272,8 +2273,8 @@ function updateRepeat() {
         this.me = [];
         this.we = 0;
       }
-      if (this.Qe && !this.me[0]) {
-        this.me[0] = runWithOwner((this.Ue[0] = createOwner()), this.Qe);
+      if (this.xe && !this.me[0]) {
+        this.me[0] = runWithOwner((this.Ue[0] = createOwner()), this.xe);
       }
       return;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidjs/signals",
-  "version": "0.9.7",
+  "version": "0.9.8",
   "description": "",
   "author": "Ryan Carniato",
   "license": "MIT",