@solidjs/signals 0.9.6 → 0.9.8

package/dist/dev.js

@@ -350,7 +350,6 @@ function insertSubs(node, optimistic = false) {
 function finalizePureQueue(completingTransition = null, incomplete = false) {
   let resolvePending = !incomplete;
   if (dirtyQueue._max >= dirtyQueue._min) {
-    resolvePending = true;
     runHeap(dirtyQueue, GlobalQueue._update);
   }
   if (resolvePending) {
@@ -562,6 +561,7 @@ function recompute(el, create = false) {
   setOptimisticReadActive(prevOptimisticRead);
   (!create || el._statusFlags & STATUS_PENDING) &&
     !el._transition &&
+    !(activeTransition && el._optimistic) &&
     globalQueue._pendingNodes.push(el);
   el._transition &&
     isEffect &&
@@ -677,7 +677,7 @@ function clearStatus(el) {
   }
 }
 function notifyStatus(el, status, error) {
-  el._statusFlags = status | (el._statusFlags & STATUS_UNINITIALIZED);
+  el._statusFlags = status | (status !== STATUS_ERROR ? el._statusFlags & STATUS_UNINITIALIZED : 0);
   el._error = error;
   updatePendingSignal(el);
   if (el._notifyStatus) return el._notifyStatus();
@@ -942,7 +942,10 @@ function getPendingValueComputed(el) {
   if (!el._pendingValueComputed) {
     const prevPending = pendingReadActive;
     pendingReadActive = false;
+    const prevContext = context;
+    context = null;
     el._pendingValueComputed = optimisticComputed(() => read(el));
+    context = prevContext;
     pendingReadActive = prevPending;
   }
   return el._pendingValueComputed;
@@ -1039,12 +1042,14 @@ function setSignal(el, v) {
   const valueChanged = !el._equals || !el._equals(currentValue, v);
   if (!valueChanged) return v;
   if (isOptimistic) {
-    const isFirstWrite = el._pendingValue === NOT_PENDING;
-    if (el._transition && !isFirstWrite) {
+    const alreadyTracked = globalQueue._optimisticNodes.includes(el);
+    if (el._transition && alreadyTracked) {
       globalQueue.initTransition(el._transition);
     }
-    if (isFirstWrite) {
+    if (el._pendingValue === NOT_PENDING) {
       el._pendingValue = el._value;
+    }
+    if (!alreadyTracked) {
       globalQueue._optimisticNodes.push(el);
     }
     el._value = v;

package/dist/node.cjs

@@ -343,7 +343,6 @@ function insertSubs(e, t = false) {
 function finalizePureQueue(e = null, t = false) {
   let n = !t;
   if (_.S >= _.W) {
-    n = true;
     runHeap(_, GlobalQueue.K);
   }
   if (n) {
@@ -539,7 +538,7 @@ function recompute(t, n = false) {
     }
   }
   setOptimisticReadActive(y);
-  (!n || t.re & c) && !t.X && A.D.push(t);
+  (!n || t.re & c) && !t.X && !(v && t.le) && A.D.push(t);
   t.X && i && v !== t.X && runInTransition(t.X, () => recompute(t));
 }
 function handleAsync(e, t, n) {
@@ -651,7 +650,7 @@ function clearStatus(e) {
   }
 }
 function notifyStatus(e, t, n) {
-  e.re = t | (e.re & d);
+  e.re = t | (t !== a ? e.re & d : 0);
   e.J = n;
   updatePendingSignal(e);
   if (e.pe) return e.pe();
@@ -907,7 +906,10 @@ function getPendingValueComputed(e) {
   if (!e.xe) {
     const t = I;
     I = false;
+    const n = Q;
+    Q = null;
     e.xe = optimisticComputed(() => read(e));
+    Q = n;
     I = t;
   }
   return e.xe;
@@ -986,12 +988,14 @@ function setSignal(e, t) {
   const i = !e.ae || !e.ae(r, t);
   if (!i) return t;
   if (n) {
-    const n = e.te === g;
-    if (e.X && !n) {
+    const n = A.B.includes(e);
+    if (e.X && n) {
       A.initTransition(e.X);
     }
-    if (n) {
+    if (e.te === g) {
       e.te = e.ne;
+    }
+    if (!n) {
       A.B.push(e);
     }
     e.ne = t;

package/dist/prod.js

@@ -342,7 +342,6 @@ function insertSubs(e, t = false) {
 function finalizePureQueue(e = null, t = false) {
   let n = !t;
   if (dirtyQueue.O >= dirtyQueue.N) {
-    n = true;
     runHeap(dirtyQueue, GlobalQueue.j);
   }
   if (n) {
@@ -539,7 +538,7 @@ function recompute(e, t = false) {
     }
   }
   setOptimisticReadActive(c);
-  (!t || e.ie & STATUS_PENDING) && !e.X && globalQueue.L.push(e);
+  (!t || e.ie & STATUS_PENDING) && !e.X && !(activeTransition && e.le) && globalQueue.L.push(e);
   e.X && n && activeTransition !== e.X && runInTransition(e.X, () => recompute(e));
 }
 function handleAsync(e, t, n) {
@@ -651,7 +650,7 @@ function clearStatus(e) {
   }
 }
 function notifyStatus(e, t, n) {
-  e.ie = t | (e.ie & STATUS_UNINITIALIZED);
+  e.ie = t | (t !== STATUS_ERROR ? e.ie & STATUS_UNINITIALIZED : 0);
   e.B = n;
   updatePendingSignal(e);
   if (e.Te) return e.Te();
@@ -907,7 +906,10 @@ function getPendingValueComputed(e) {
   if (!e.ge) {
     const t = pendingReadActive;
     pendingReadActive = false;
+    const n = context;
+    context = null;
     e.ge = optimisticComputed(() => read(e));
+    context = n;
     pendingReadActive = t;
   }
   return e.ge;
@@ -997,12 +999,14 @@ function setSignal(e, t) {
   const r = !e.fe || !e.fe(i, t);
   if (!r) return t;
   if (n) {
-    const n = e.te === NOT_PENDING;
-    if (e.X && !n) {
+    const n = globalQueue.H.includes(e);
+    if (e.X && n) {
       globalQueue.initTransition(e.X);
     }
-    if (n) {
+    if (e.te === NOT_PENDING) {
       e.te = e.ne;
+    }
+    if (!n) {
       globalQueue.H.push(e);
     }
     e.ne = t;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solidjs/signals",
-  "version": "0.9.6",
+  "version": "0.9.8",
   "description": "",
   "author": "Ryan Carniato",
   "license": "MIT",