@solidjs/signals 0.13.6 → 0.13.8

package/dist/dev.js

@@ -655,6 +655,209 @@ function assignOrMergeLane(el, sourceLane) {
   }
   el._optimisticLane = sourceLane;
 }
+function unlinkSubs(link) {
+  const dep = link._dep;
+  const nextDep = link._nextDep;
+  const nextSub = link._nextSub;
+  const prevSub = link._prevSub;
+  if (nextSub !== null) nextSub._prevSub = prevSub;
+  else dep._subsTail = prevSub;
+  if (prevSub !== null) prevSub._nextSub = nextSub;
+  else {
+    dep._subs = nextSub;
+    if (nextSub === null) {
+      dep._unobserved?.();
+      dep._fn && !dep._preventAutoDisposal && !(dep._flags & REACTIVE_ZOMBIE) && unobserved(dep);
+    }
+  }
+  return nextDep;
+}
+function unobserved(el) {
+  deleteFromHeap(el, el._flags & REACTIVE_ZOMBIE ? zombieQueue : dirtyQueue);
+  let dep = el._deps;
+  while (dep !== null) {
+    dep = unlinkSubs(dep);
+  }
+  el._deps = null;
+  disposeChildren(el, true);
+}
+function link(dep, sub) {
+  const prevDep = sub._depsTail;
+  if (prevDep !== null && prevDep._dep === dep) return;
+  let nextDep = null;
+  const isRecomputing = sub._flags & REACTIVE_RECOMPUTING_DEPS;
+  if (isRecomputing) {
+    nextDep = prevDep !== null ? prevDep._nextDep : sub._deps;
+    if (nextDep !== null && nextDep._dep === dep) {
+      sub._depsTail = nextDep;
+      return;
+    }
+  }
+  const prevSub = dep._subsTail;
+  if (prevSub !== null && prevSub._sub === sub && (!isRecomputing || isValidLink(prevSub, sub)))
+    return;
+  const newLink =
+    (sub._depsTail =
+    dep._subsTail =
+      { _dep: dep, _sub: sub, _nextDep: nextDep, _prevSub: prevSub, _nextSub: null });
+  if (prevDep !== null) prevDep._nextDep = newLink;
+  else sub._deps = newLink;
+  if (prevSub !== null) prevSub._nextSub = newLink;
+  else dep._subs = newLink;
+}
+function isValidLink(checkLink, sub) {
+  const depsTail = sub._depsTail;
+  if (depsTail !== null) {
+    let link = sub._deps;
+    do {
+      if (link === checkLink) return true;
+      if (link === depsTail) break;
+      link = link._nextDep;
+    } while (link !== null);
+  }
+  return false;
+}
+const PENDING_OWNER = {};
+function markDisposal(el) {
+  let child = el._firstChild;
+  while (child) {
+    child._flags |= REACTIVE_ZOMBIE;
+    if (child._flags & REACTIVE_IN_HEAP) {
+      deleteFromHeap(child, dirtyQueue);
+      insertIntoHeap(child, zombieQueue);
+    }
+    markDisposal(child);
+    child = child._nextSibling;
+  }
+}
+function dispose(node) {
+  let toRemove = node._deps || null;
+  do {
+    toRemove = unlinkSubs(toRemove);
+  } while (toRemove !== null);
+  node._deps = null;
+  node._depsTail = null;
+  disposeChildren(node, true);
+}
+function disposeChildren(node, self = false, zombie) {
+  if (node._flags & REACTIVE_DISPOSED) return;
+  if (self) node._flags = REACTIVE_DISPOSED;
+  if (self && node._fn) node._inFlight = null;
+  let child = zombie ? node._pendingFirstChild : node._firstChild;
+  while (child) {
+    const nextChild = child._nextSibling;
+    if (child._deps) {
+      const n = child;
+      deleteFromHeap(n, n._flags & REACTIVE_ZOMBIE ? zombieQueue : dirtyQueue);
+      let toRemove = n._deps;
+      do {
+        toRemove = unlinkSubs(toRemove);
+      } while (toRemove !== null);
+      n._deps = null;
+      n._depsTail = null;
+    }
+    disposeChildren(child, true);
+    child = nextChild;
+  }
+  if (zombie) {
+    node._pendingFirstChild = null;
+  } else {
+    node._firstChild = null;
+    node._childCount = 0;
+  }
+  runDisposal(node, zombie);
+}
+function runDisposal(node, zombie) {
+  let disposal = zombie ? node._pendingDisposal : node._disposal;
+  if (!disposal) return;
+  if (Array.isArray(disposal)) {
+    for (let i = 0; i < disposal.length; i++) {
+      const callable = disposal[i];
+      callable.call(callable);
+    }
+  } else {
+    disposal.call(disposal);
+  }
+  zombie ? (node._pendingDisposal = null) : (node._disposal = null);
+}
+function childId(owner, consume) {
+  let counter = owner;
+  while (counter._transparent && counter._parent) counter = counter._parent;
+  if (counter.id != null)
+    return formatId(counter.id, consume ? counter._childCount++ : counter._childCount);
+  throw new Error("Cannot get child id from owner without an id");
+}
+function getNextChildId(owner) {
+  return childId(owner, true);
+}
+function peekNextChildId(owner) {
+  return childId(owner, false);
+}
+function formatId(prefix, id) {
+  const num = id.toString(36),
+    len = num.length - 1;
+  return prefix + (len ? String.fromCharCode(64 + len) : "") + num;
+}
+function getObserver() {
+  if (pendingCheckActive || latestReadActive) return PENDING_OWNER;
+  return tracking ? context : null;
+}
+function getOwner() {
+  return context;
+}
+function cleanup(fn) {
+  if (!context) return fn;
+  if (!context._disposal) context._disposal = fn;
+  else if (Array.isArray(context._disposal)) context._disposal.push(fn);
+  else context._disposal = [context._disposal, fn];
+  return fn;
+}
+function isDisposed(node) {
+  return !!(node._flags & (REACTIVE_DISPOSED | REACTIVE_ZOMBIE));
+}
+function createOwner(options) {
+  const parent = context;
+  const transparent = options?.transparent ?? false;
+  const owner = {
+    id:
+      options?.id ??
+      (transparent ? parent?.id : parent?.id != null ? getNextChildId(parent) : undefined),
+    _transparent: transparent || undefined,
+    _root: true,
+    _parentComputed: parent?._root ? parent._parentComputed : parent,
+    _firstChild: null,
+    _nextSibling: null,
+    _disposal: null,
+    _queue: parent?._queue ?? globalQueue,
+    _context: parent?._context || defaultContext,
+    _childCount: 0,
+    _pendingDisposal: null,
+    _pendingFirstChild: null,
+    _parent: parent,
+    dispose(self = true) {
+      disposeChildren(owner, self);
+    }
+  };
+  if (parent?._childrenForbidden) {
+    throw new Error(
+      "Cannot create reactive primitives inside createTrackedEffect or owner-backed onSettled"
+    );
+  }
+  if (parent) {
+    const lastChild = parent._firstChild;
+    if (lastChild === null) {
+      parent._firstChild = owner;
+    } else {
+      owner._nextSibling = lastChild;
+      parent._firstChild = owner;
+    }
+  }
+  return owner;
+}
+function createRoot(init, options) {
+  const owner = createOwner(options);
+  return runWithOwner(owner, () => init(owner.dispose));
+}
 function addPendingSource(el, source) {
   if (el._pendingSource === source || el._pendingSources?.has(source)) return false;
   if (!el._pendingSource) {
@@ -819,6 +1022,17 @@ function handleAsync(el, result, setter) {
   if (iterator) {
     const it = result[Symbol.asyncIterator]();
     let hadSyncValue = false;
+    let completed = false;
+    cleanup(() => {
+      if (completed) return;
+      completed = true;
+      try {
+        const returned = it.return?.();
+        if (returned && typeof returned.then === "function") {
+          returned.then(undefined, () => {});
+        }
+      } catch {}
+    });
     const iterate = () => {
       let syncResult,
         resolved = false,
@@ -828,14 +1042,21 @@ function handleAsync(el, result, setter) {
           if (isSync) {
             syncResult = r;
             resolved = true;
+            if (r.done) completed = true;
+          } else if (el._inFlight !== result) {
+            return;
           } else if (!r.done) asyncWrite(r.value, iterate);
           else {
+            completed = true;
             schedule();
             flush();
           }
         },
         e => {
-          if (!isSync) handleError(e);
+          if (!isSync && el._inFlight === result) {
+            completed = true;
+            handleError(e);
+          }
         }
       );
       isSync = false;
@@ -942,208 +1163,6 @@ function enableExternalSource(config) {
     externalSourceConfig = { factory: factory, untrack: untrackFn };
   }
 }
-const PENDING_OWNER = {};
-function markDisposal(el) {
-  let child = el._firstChild;
-  while (child) {
-    child._flags |= REACTIVE_ZOMBIE;
-    if (child._flags & REACTIVE_IN_HEAP) {
-      deleteFromHeap(child, dirtyQueue);
-      insertIntoHeap(child, zombieQueue);
-    }
-    markDisposal(child);
-    child = child._nextSibling;
-  }
-}
-function dispose(node) {
-  let toRemove = node._deps || null;
-  do {
-    toRemove = unlinkSubs(toRemove);
-  } while (toRemove !== null);
-  node._deps = null;
-  node._depsTail = null;
-  disposeChildren(node, true);
-}
-function disposeChildren(node, self = false, zombie) {
-  if (node._flags & REACTIVE_DISPOSED) return;
-  if (self) node._flags = REACTIVE_DISPOSED;
-  let child = zombie ? node._pendingFirstChild : node._firstChild;
-  while (child) {
-    const nextChild = child._nextSibling;
-    if (child._deps) {
-      const n = child;
-      deleteFromHeap(n, n._flags & REACTIVE_ZOMBIE ? zombieQueue : dirtyQueue);
-      let toRemove = n._deps;
-      do {
-        toRemove = unlinkSubs(toRemove);
-      } while (toRemove !== null);
-      n._deps = null;
-      n._depsTail = null;
-    }
-    disposeChildren(child, true);
-    child = nextChild;
-  }
-  if (zombie) {
-    node._pendingFirstChild = null;
-  } else {
-    node._firstChild = null;
-    node._childCount = 0;
-  }
-  runDisposal(node, zombie);
-}
-function runDisposal(node, zombie) {
-  let disposal = zombie ? node._pendingDisposal : node._disposal;
-  if (!disposal) return;
-  if (Array.isArray(disposal)) {
-    for (let i = 0; i < disposal.length; i++) {
-      const callable = disposal[i];
-      callable.call(callable);
-    }
-  } else {
-    disposal.call(disposal);
-  }
-  zombie ? (node._pendingDisposal = null) : (node._disposal = null);
-}
-function childId(owner, consume) {
-  let counter = owner;
-  while (counter._transparent && counter._parent) counter = counter._parent;
-  if (counter.id != null)
-    return formatId(counter.id, consume ? counter._childCount++ : counter._childCount);
-  throw new Error("Cannot get child id from owner without an id");
-}
-function getNextChildId(owner) {
-  return childId(owner, true);
-}
-function peekNextChildId(owner) {
-  return childId(owner, false);
-}
-function formatId(prefix, id) {
-  const num = id.toString(36),
-    len = num.length - 1;
-  return prefix + (len ? String.fromCharCode(64 + len) : "") + num;
-}
-function getObserver() {
-  if (pendingCheckActive || latestReadActive) return PENDING_OWNER;
-  return tracking ? context : null;
-}
-function getOwner() {
-  return context;
-}
-function cleanup(fn) {
-  if (!context) return fn;
-  if (!context._disposal) context._disposal = fn;
-  else if (Array.isArray(context._disposal)) context._disposal.push(fn);
-  else context._disposal = [context._disposal, fn];
-  return fn;
-}
-function isDisposed(node) {
-  return !!(node._flags & (REACTIVE_DISPOSED | REACTIVE_ZOMBIE));
-}
-function createOwner(options) {
-  const parent = context;
-  const transparent = options?.transparent ?? false;
-  const owner = {
-    id:
-      options?.id ??
-      (transparent ? parent?.id : parent?.id != null ? getNextChildId(parent) : undefined),
-    _transparent: transparent || undefined,
-    _root: true,
-    _parentComputed: parent?._root ? parent._parentComputed : parent,
-    _firstChild: null,
-    _nextSibling: null,
-    _disposal: null,
-    _queue: parent?._queue ?? globalQueue,
-    _context: parent?._context || defaultContext,
-    _childCount: 0,
-    _pendingDisposal: null,
-    _pendingFirstChild: null,
-    _parent: parent,
-    dispose(self = true) {
-      disposeChildren(owner, self);
-    }
-  };
-  if (parent?._childrenForbidden) {
-    throw new Error(
-      "Cannot create reactive primitives inside createTrackedEffect or owner-backed onSettled"
-    );
-  }
-  if (parent) {
-    const lastChild = parent._firstChild;
-    if (lastChild === null) {
-      parent._firstChild = owner;
-    } else {
-      owner._nextSibling = lastChild;
-      parent._firstChild = owner;
-    }
-  }
-  return owner;
-}
-function createRoot(init, options) {
-  const owner = createOwner(options);
-  return runWithOwner(owner, () => init(owner.dispose));
-}
-function unlinkSubs(link) {
-  const dep = link._dep;
-  const nextDep = link._nextDep;
-  const nextSub = link._nextSub;
-  const prevSub = link._prevSub;
-  if (nextSub !== null) nextSub._prevSub = prevSub;
-  else dep._subsTail = prevSub;
-  if (prevSub !== null) prevSub._nextSub = nextSub;
-  else {
-    dep._subs = nextSub;
-    if (nextSub === null) {
-      dep._unobserved?.();
-      dep._fn && !dep._preventAutoDisposal && !(dep._flags & REACTIVE_ZOMBIE) && unobserved(dep);
-    }
-  }
-  return nextDep;
-}
-function unobserved(el) {
-  deleteFromHeap(el, el._flags & REACTIVE_ZOMBIE ? zombieQueue : dirtyQueue);
-  let dep = el._deps;
-  while (dep !== null) {
-    dep = unlinkSubs(dep);
-  }
-  el._deps = null;
-  disposeChildren(el, true);
-}
-function link(dep, sub) {
-  const prevDep = sub._depsTail;
-  if (prevDep !== null && prevDep._dep === dep) return;
-  let nextDep = null;
-  const isRecomputing = sub._flags & REACTIVE_RECOMPUTING_DEPS;
-  if (isRecomputing) {
-    nextDep = prevDep !== null ? prevDep._nextDep : sub._deps;
-    if (nextDep !== null && nextDep._dep === dep) {
-      sub._depsTail = nextDep;
-      return;
-    }
-  }
-  const prevSub = dep._subsTail;
-  if (prevSub !== null && prevSub._sub === sub && (!isRecomputing || isValidLink(prevSub, sub)))
-    return;
-  const newLink =
-    (sub._depsTail =
-    dep._subsTail =
-      { _dep: dep, _sub: sub, _nextDep: nextDep, _prevSub: prevSub, _nextSub: null });
-  if (prevDep !== null) prevDep._nextDep = newLink;
-  else sub._deps = newLink;
-  if (prevSub !== null) prevSub._nextSub = newLink;
-  else dep._subs = newLink;
-}
-function isValidLink(checkLink, sub) {
-  const depsTail = sub._depsTail;
-  if (depsTail !== null) {
-    let link = sub._deps;
-    do {
-      if (link === checkLink) return true;
-      if (link === depsTail) break;
-      link = link._nextDep;
-    } while (link !== null);
-  }
-  return false;
-}
 GlobalQueue._update = recompute;
 GlobalQueue._dispose = disposeChildren;
 let tracking = false;
@@ -1212,6 +1231,7 @@ function recompute(el, create = false) {
     if (el._transition && (!isEffect || activeTransition) && activeTransition !== el._transition)
       globalQueue.initTransition(el._transition);
     deleteFromHeap(el, el._flags & REACTIVE_ZOMBIE ? zombieQueue : dirtyQueue);
+    el._inFlight = null;
     if (el._transition || isEffect === EFFECT_TRACKED) disposeChildren(el);
     else {
       markDisposal(el);
@@ -1516,6 +1536,11 @@ function read(el) {
       ) {
         foundPending = true;
       }
+      let c = context;
+      if (c?._root) c = c._parentComputed;
+      if (c && tracking) link(el, c);
+      read(getPendingSignal(el));
+      read(getPendingSignal(firewall));
     } else {
       if (read(getPendingSignal(el))) foundPending = true;
       if (firewall && read(getPendingSignal(firewall))) foundPending = true;
@@ -1890,7 +1915,13 @@ function runEffect() {
   this._cleanup?.();
   this._cleanup = undefined;
   try {
-    this._cleanup = this._effectFn(this._value, this._prevValue);
+    const cleanup = this._effectFn(this._value, this._prevValue);
+    if (true && cleanup !== undefined && typeof cleanup !== "function") {
+      throw new Error(
+        `${this._name || "effect"} callback returned an invalid cleanup value. Return a cleanup function or undefined.`
+      );
+    }
+    this._cleanup = cleanup;
   } catch (error) {
     this._error = new StatusError(this, error);
     this._statusFlags |= STATUS_ERROR;
@@ -1916,7 +1947,13 @@ function trackedEffect(fn, options) {
     () => {
       node._cleanup?.();
       node._cleanup = undefined;
-      node._cleanup = staleValues(fn) || undefined;
+      const cleanup = staleValues(fn);
+      if (cleanup !== undefined && typeof cleanup !== "function") {
+        throw new Error(
+          `${node._name || "trackedEffect"} callback returned an invalid cleanup value. Return a cleanup function or undefined.`
+        );
+      }
+      node._cleanup = cleanup;
     },
     undefined,
     { ...options, lazy: true }
@@ -2036,7 +2073,13 @@ function createReaction(effectFn, options) {
         () => (tracking(), getOwner()),
         node => {
           cl?.();
-          cl = (effectFn.effect || effectFn)?.();
+          const cleanup = (effectFn.effect || effectFn)?.();
+          if (true && cleanup !== undefined && typeof cleanup !== "function") {
+            throw new Error(
+              "Reaction callback returned an invalid cleanup value. Return a cleanup function or undefined."
+            );
+          }
+          cl = cleanup;
           dispose(node);
         },
         effectFn.error,
@@ -2076,9 +2119,14 @@ function createOptimistic(first, second, third) {
 function onSettled(callback) {
   const owner = getOwner();
   owner && !owner._childrenForbidden
-    ? createTrackedEffect(() => untrack(callback))
+    ? createTrackedEffect(() => untrack(callback), { name: "onSettled" })
     : globalQueue.enqueue(EFFECT_USER, () => {
         const cleanup = callback();
+        if (cleanup !== undefined && typeof cleanup !== "function") {
+          throw new Error(
+            "onSettled callback returned an invalid cleanup value. Return a cleanup function or undefined."
+          );
+        }
         cleanup?.();
       });
 }
@@ -2287,6 +2335,18 @@ function createWriteTraps(isActive) {
       }
       return typeof value === "object" && value !== null ? new Proxy(value, traps) : value;
     },
+    has(_, prop) {
+      let value;
+      setWriteOverride(true);
+      setProjectionWriteActive(true);
+      try {
+        value = prop in _;
+      } finally {
+        setWriteOverride(false);
+        setProjectionWriteActive(false);
+      }
+      return value;
+    },
     set(_, prop, value) {
       if (isActive && !isActive()) return true;
       setWriteOverride(true);
@@ -2344,7 +2404,12 @@ function wrap(value, target) {
   return p;
 }
 function isWrappable(obj) {
-  return obj != null && typeof obj === "object" && !Object.isFrozen(obj);
+  return (
+    obj != null &&
+    typeof obj === "object" &&
+    !Object.isFrozen(obj) &&
+    !(typeof Node !== "undefined" && obj instanceof Node)
+  );
 }
 let writeOverride = false;
 function setWriteOverride(value) {
@@ -2496,17 +2561,19 @@ const storeTraps = {
         : target[STORE_OVERRIDE] && property in target[STORE_OVERRIDE]
           ? target[STORE_OVERRIDE][property] !== $DELETED
           : property in target[STORE_VALUE];
-    getObserver() &&
-      read(
-        getNode(
-          getNodes(target, STORE_HAS),
-          property,
-          has,
-          target[STORE_FIREWALL],
-          isEqual,
-          target[STORE_OPTIMISTIC]
-        )
-      );
+    if (!writeOnly(target[$PROXY])) {
+      getObserver() &&
+        read(
+          getNode(
+            getNodes(target, STORE_HAS),
+            property,
+            has,
+            target[STORE_FIREWALL],
+            isEqual,
+            target[STORE_OPTIMISTIC]
+          )
+        );
+    }
     return has;
   },
   set(target, property, rawValue) {
@@ -2544,25 +2611,32 @@ const storeTraps = {
               ? target[STORE_OVERRIDE][property]
               : base;
         const value = rawValue?.[$TARGET]?.[STORE_VALUE] ?? rawValue;
-        if (prev === value) return true;
+        const isArrayIndexWrite = Array.isArray(state) && property !== "length";
+        const nextIndex = isArrayIndexWrite ? parseInt(property) + 1 : 0;
         const len =
-          target[STORE_OPTIMISTIC_OVERRIDE]?.length ||
-          target[STORE_OVERRIDE]?.length ||
-          state.length;
-        if (value !== undefined && value === base) delete target[overrideKey][property];
-        else (target[overrideKey] || (target[overrideKey] = Object.create(null)))[property] = value;
+          isArrayIndexWrite &&
+          (target[STORE_OPTIMISTIC_OVERRIDE] && "length" in target[STORE_OPTIMISTIC_OVERRIDE]
+            ? target[STORE_OPTIMISTIC_OVERRIDE].length
+            : target[STORE_OVERRIDE] && "length" in target[STORE_OVERRIDE]
+              ? target[STORE_OVERRIDE].length
+              : state.length);
+        const nextLength = isArrayIndexWrite && nextIndex > len ? nextIndex : undefined;
+        if (prev === value && nextLength === undefined) return true;
+        if (value !== undefined && value === base && nextLength === undefined)
+          delete target[overrideKey]?.[property];
+        else {
+          const override = target[overrideKey] || (target[overrideKey] = Object.create(null));
+          override[property] = value;
+          if (nextLength !== undefined) override.length = nextLength;
+        }
         const wrappable = isWrappable(value);
         target[STORE_HAS]?.[property] && setSignal(target[STORE_HAS][property], true);
         const nodes = getNodes(target, STORE_NODE);
         nodes[property] &&
           setSignal(nodes[property], () => (wrappable ? wrap(value, target) : value));
         if (Array.isArray(state)) {
-          if (property === "length") {
-            nodes.length && setSignal(nodes.length, value);
-          } else {
-            const index = parseInt(property) + 1;
-            if (index > len) nodes.length && setSignal(nodes.length, index);
-          }
+          const lengthValue = property === "length" ? value : nextLength;
+          lengthValue !== undefined && nodes.length && setSignal(nodes.length, lengthValue);
         }
         nodes[$TRACK] && setSignal(nodes[$TRACK], undefined);
       });
@@ -3316,8 +3390,9 @@ class CollectionQueue extends Queue {
   checkSources() {
     for (const source of this._sources) {
       if (
-        !(source._statusFlags & this._collectionType) &&
-        !(this._collectionType & STATUS_ERROR && source._statusFlags & STATUS_PENDING)
+        source._flags & REACTIVE_DISPOSED ||
+        (!(source._statusFlags & this._collectionType) &&
+          !(this._collectionType & STATUS_ERROR && source._statusFlags & STATUS_PENDING))
       )
         this._sources.delete(source);
     }