@solidjs/signals 0.10.0 → 0.10.2

package/dist/dev.js

@@ -1,15 +1,15 @@
 class NotReadyError extends Error {
-  _source;
-  constructor(_source) {
+  source;
+  constructor(source) {
     super();
-    this._source = _source;
+    this.source = source;
   }
 }
 class StatusError extends Error {
-  _source;
-  constructor(_source, original) {
+  source;
+  constructor(source, original) {
     super(original instanceof Error ? original.message : String(original), { cause: original });
-    this._source = _source;
+    this.source = source;
   }
 }
 class NoOwnerError extends Error {
@@ -288,9 +288,9 @@ class GlobalQueue extends Queue {
         if (
           activeTransition &&
           actualError &&
-          !activeTransition._asyncNodes.includes(actualError._source)
+          !activeTransition._asyncNodes.includes(actualError.source)
         ) {
-          activeTransition._asyncNodes.push(actualError._source);
+          activeTransition._asyncNodes.push(actualError.source);
           schedule();
         }
       }
@@ -463,7 +463,7 @@ function transitionComplete(transition) {
   let done = true;
   for (let i = 0; i < transition._asyncNodes.length; i++) {
     const node = transition._asyncNodes[i];
-    if (node._statusFlags & STATUS_PENDING && node._error?._source === node) {
+    if (node._statusFlags & STATUS_PENDING && node._error?.source === node) {
       done = false;
       break;
     }
@@ -672,7 +672,7 @@ function notifyStatus(el, status, error, blockStatus, lane) {
     !(error instanceof NotReadyError)
   )
     error = new StatusError(el, error);
-  const isSource = error instanceof NotReadyError && error._source === el;
+  const isSource = error instanceof NotReadyError && error.source === el;
   const isOptimisticBoundary = status === STATUS_PENDING && el._optimistic && !isSource;
   const startsBlocking = isOptimisticBoundary && hasActiveOverride(el);
   if (!blockStatus) {
@@ -685,7 +685,7 @@ function notifyStatus(el, status, error, blockStatus, lane) {
     assignOrMergeLane(el, lane);
   }
   if (startsBlocking && activeTransition && error instanceof NotReadyError) {
-    const source = error._source;
+    const source = error.source;
     if (!activeTransition._asyncNodes.includes(source)) {
       activeTransition._asyncNodes.push(source);
     }
@@ -858,6 +858,7 @@ function disposeChildren(node, self = false, zombie) {
   } else {
     node._firstChild = null;
     node._nextSibling = null;
+    node._childCount = 0;
   }
   runDisposal(node, zombie);
 }
@@ -1019,6 +1020,7 @@ function recompute(el, create = false) {
       el._pendingFirstChild = el._firstChild;
       el._disposal = null;
       el._firstChild = null;
+      el._childCount = 0;
     }
   }
   const isOptimisticDirty = !!(el._flags & REACTIVE_OPTIMISTIC_DIRTY);
@@ -1623,7 +1625,8 @@ function onSettled(callback) {
 function unwrap(value) {
   return value?.[$TARGET]?.[STORE_NODE] ?? value;
 }
-function getOverrideValue(value, override, nodes, key) {
+function getOverrideValue(value, override, nodes, key, optOverride) {
+  if (optOverride && key in optOverride) return optOverride[key];
   return override && key in override ? override[key] : value[key];
 }
 function getAllKeys(value, override, next) {
@@ -1636,20 +1639,21 @@ function applyState(next, state, keyFn, all) {
   if (!target) return;
   const previous = target[STORE_VALUE];
   const override = target[STORE_OVERRIDE];
+  const optOverride = target[STORE_OPTIMISTIC_OVERRIDE];
   let nodes = target[STORE_NODE];
-  if (next === previous && !override) return;
+  if (next === previous && !override && !optOverride) return;
   (target[STORE_LOOKUP] || storeLookup).set(next, target[$PROXY]);
   target[STORE_VALUE] = next;
   target[STORE_OVERRIDE] = undefined;
   if (Array.isArray(previous)) {
     let changed = false;
-    const prevLength = getOverrideValue(previous, override, nodes, "length");
+    const prevLength = getOverrideValue(previous, override, nodes, "length", optOverride);
     if (next.length && prevLength && next[0] && keyFn(next[0]) != null) {
       let i, j, start, end, newEnd, item, newIndicesNext, keyVal;
       for (
         start = 0, end = Math.min(prevLength, next.length);
         start < end &&
-        ((item = getOverrideValue(previous, override, nodes, start)) === next[start] ||
+        ((item = getOverrideValue(previous, override, nodes, start, optOverride)) === next[start] ||
           (item && next[start] && keyFn(item) === keyFn(next[start])));
         start++
       ) {
@@ -1661,7 +1665,7 @@ function applyState(next, state, keyFn, all) {
         end = prevLength - 1, newEnd = next.length - 1;
         end >= start &&
         newEnd >= start &&
-        ((item = getOverrideValue(previous, override, nodes, end)) === next[newEnd] ||
+        ((item = getOverrideValue(previous, override, nodes, end, optOverride)) === next[newEnd] ||
           (item && next[newEnd] && keyFn(item) === keyFn(next[newEnd])));
         end--, newEnd--
       ) {
@@ -1693,7 +1697,7 @@ function applyState(next, state, keyFn, all) {
         newIndices.set(keyVal, j);
       }
       for (i = start; i <= end; i++) {
-        item = getOverrideValue(previous, override, nodes, i);
+        item = getOverrideValue(previous, override, nodes, i, optOverride);
         keyVal = item ? keyFn(item) : item;
         j = newIndices.get(keyVal);
         if (j !== undefined && j !== -1) {
@@ -1712,7 +1716,7 @@ function applyState(next, state, keyFn, all) {
       if (start < next.length) changed = true;
     } else if (next.length) {
       for (let i = 0, len = next.length; i < len; i++) {
-        const item = getOverrideValue(previous, override, nodes, i);
+        const item = getOverrideValue(previous, override, nodes, i, optOverride);
         isWrappable(item)
           ? applyState(next[i], wrap(item, target), keyFn, all)
           : target[STORE_NODE][i] && setSignal(target[STORE_NODE][i], next[i]);
@@ -1731,7 +1735,7 @@ function applyState(next, state, keyFn, all) {
     for (let i = 0, len = keys.length; i < len; i++) {
       const key = keys[i];
       const node = nodes[key];
-      const previousValue = unwrap(getOverrideValue(previous, override, nodes, key));
+      const previousValue = unwrap(getOverrideValue(previous, override, nodes, key, optOverride));
       let nextValue = unwrap(next[key]);
       if (previousValue === nextValue) continue;
       if (
@@ -2746,7 +2750,7 @@ class CollectionQueue extends Queue {
     )
       return super.notify(node, type, flags, error);
     if (flags & this._collectionType) {
-      const source = error?._source || node._error?._source;
+      const source = error?.source || node._error?.source;
       if (source) {
         const wasEmpty = this._sources.size === 0;
         this._sources.add(source);