@soleri/forge 9.2.0 → 9.3.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/scaffold-filetree.js +1 -1
- package/dist/skills/brain-debrief/SKILL.md +12 -12
- package/dist/skills/brainstorming/SKILL.md +7 -7
- package/dist/skills/code-patrol/SKILL.md +15 -15
- package/dist/skills/context-resume/SKILL.md +8 -8
- package/dist/skills/deep-review/SKILL.md +22 -11
- package/dist/skills/executing-plans/SKILL.md +10 -9
- package/dist/skills/fix-and-learn/SKILL.md +8 -8
- package/dist/skills/health-check/SKILL.md +11 -11
- package/dist/skills/knowledge-harvest/SKILL.md +17 -17
- package/dist/skills/onboard-me/SKILL.md +10 -10
- package/dist/skills/parallel-execute/SKILL.md +46 -32
- package/dist/skills/retrospective/SKILL.md +9 -9
- package/dist/skills/second-opinion/SKILL.md +11 -8
- package/dist/skills/systematic-debugging/SKILL.md +8 -8
- package/dist/skills/test-driven-development/SKILL.md +11 -11
- package/dist/skills/vault-capture/SKILL.md +15 -15
- package/dist/skills/vault-navigator/SKILL.md +10 -10
- package/dist/skills/vault-smells/SKILL.md +24 -16
- package/dist/skills/verification-before-completion/SKILL.md +18 -18
- package/dist/skills/writing-plans/SKILL.md +9 -9
- package/package.json +1 -1
- package/src/scaffold-filetree.ts +1 -1
- package/src/skills/brain-debrief/SKILL.md +12 -12
- package/src/skills/brainstorming/SKILL.md +7 -7
- package/src/skills/code-patrol/SKILL.md +15 -15
- package/src/skills/context-resume/SKILL.md +8 -8
- package/src/skills/deep-review/SKILL.md +22 -11
- package/src/skills/executing-plans/SKILL.md +10 -9
- package/src/skills/fix-and-learn/SKILL.md +8 -8
- package/src/skills/health-check/SKILL.md +11 -11
- package/src/skills/knowledge-harvest/SKILL.md +17 -17
- package/src/skills/onboard-me/SKILL.md +10 -10
- package/src/skills/parallel-execute/SKILL.md +46 -32
- package/src/skills/retrospective/SKILL.md +9 -9
- package/src/skills/second-opinion/SKILL.md +11 -8
- package/src/skills/systematic-debugging/SKILL.md +8 -8
- package/src/skills/test-driven-development/SKILL.md +11 -11
- package/src/skills/vault-capture/SKILL.md +15 -15
- package/src/skills/vault-navigator/SKILL.md +10 -10
- package/src/skills/vault-smells/SKILL.md +24 -16
- package/src/skills/verification-before-completion/SKILL.md +18 -18
- package/src/skills/writing-plans/SKILL.md +9 -9
|
@@ -91,13 +91,13 @@ YOUR_AGENT_core op:session_capture
|
|
|
91
91
|
|
|
92
92
|
## Quick Reference
|
|
93
93
|
|
|
94
|
-
| Phase
|
|
95
|
-
|
|
96
|
-
| 0. Search
|
|
97
|
-
| 1. Root Cause
|
|
98
|
-
| 2. Pattern
|
|
99
|
-
| 3. Hypothesis
|
|
100
|
-
| 4. Implementation | Test, fix, verify
|
|
101
|
-
| 5. Capture
|
|
94
|
+
| Phase | Key Activities | Tools |
|
|
95
|
+
| ----------------- | ------------------------------ | -------------------------------------------------------- |
|
|
96
|
+
| 0. Search | Vault, web, memory | `search_intelligent`, `brain_strengths`, `memory_search` |
|
|
97
|
+
| 1. Root Cause | Read errors, reproduce, trace | `loop_iterate` |
|
|
98
|
+
| 2. Pattern | Find working examples, compare | `search_intelligent` |
|
|
99
|
+
| 3. Hypothesis | Form theory, test minimally | `loop_iterate` |
|
|
100
|
+
| 4. Implementation | Test, fix, verify | `loop_iterate` |
|
|
101
|
+
| 5. Capture | Persist root cause | `capture_knowledge`, `loop_complete` |
|
|
102
102
|
|
|
103
103
|
**Related skills:** test-driven-development, verification-before-completion, fix-and-learn
|
|
@@ -75,17 +75,17 @@ YOUR_AGENT_core op:capture_quick
|
|
|
75
75
|
- Test passes immediately (testing existing behavior, not new)
|
|
76
76
|
- Multiple behaviors in one test ("and" in name means split it)
|
|
77
77
|
|
|
78
|
-
| Problem
|
|
79
|
-
|
|
80
|
-
| Don't know how to test | Write wished-for API first
|
|
81
|
-
| Must mock everything
|
|
82
|
-
| Test setup huge
|
|
78
|
+
| Problem | Solution |
|
|
79
|
+
| ---------------------- | ---------------------------------- |
|
|
80
|
+
| Don't know how to test | Write wished-for API first |
|
|
81
|
+
| Must mock everything | Code too coupled — use DI |
|
|
82
|
+
| Test setup huge | Extract helpers or simplify design |
|
|
83
83
|
|
|
84
84
|
## Quick Reference
|
|
85
85
|
|
|
86
|
-
| Op
|
|
87
|
-
|
|
88
|
-
| `search_intelligent`
|
|
89
|
-
| `brain_strengths`
|
|
90
|
-
| `loop_start` / `loop_iterate` / `loop_complete` | TDD cycle tracking
|
|
91
|
-
| `capture_quick`
|
|
86
|
+
| Op | When to Use |
|
|
87
|
+
| ----------------------------------------------- | ---------------------------- |
|
|
88
|
+
| `search_intelligent` | Find testing patterns |
|
|
89
|
+
| `brain_strengths` | Proven testing approaches |
|
|
90
|
+
| `loop_start` / `loop_iterate` / `loop_complete` | TDD cycle tracking |
|
|
91
|
+
| `capture_quick` | Capture new testing patterns |
|
|
@@ -25,13 +25,13 @@ If similar entry exists, update it instead of creating a duplicate.
|
|
|
25
25
|
|
|
26
26
|
### 2. Classify the Knowledge
|
|
27
27
|
|
|
28
|
-
| Type
|
|
29
|
-
|
|
30
|
-
| **pattern**
|
|
31
|
-
| **anti-pattern** | Fails and should be avoided
|
|
32
|
-
| **workflow**
|
|
33
|
-
| **principle**
|
|
34
|
-
| **decision**
|
|
28
|
+
| Type | Description |
|
|
29
|
+
| ---------------- | ----------------------------------- |
|
|
30
|
+
| **pattern** | Works and should be repeated |
|
|
31
|
+
| **anti-pattern** | Fails and should be avoided |
|
|
32
|
+
| **workflow** | Steps for a specific task |
|
|
33
|
+
| **principle** | Guiding rule or heuristic |
|
|
34
|
+
| **decision** | Architectural choice with rationale |
|
|
35
35
|
|
|
36
36
|
### 3. Capture
|
|
37
37
|
|
|
@@ -76,11 +76,11 @@ For cross-project knowledge: `op:memory_promote_to_global params: { entryId: "<i
|
|
|
76
76
|
|
|
77
77
|
## Quick Reference
|
|
78
78
|
|
|
79
|
-
| Op
|
|
80
|
-
|
|
81
|
-
| `search_intelligent`
|
|
82
|
-
| `capture_knowledge` / `capture_quick` | Persist to vault
|
|
83
|
-
| `curator_groom` / `curator_enrich`
|
|
84
|
-
| `curator_contradictions`
|
|
85
|
-
| `memory_promote_to_global`
|
|
86
|
-
| `admin_health`
|
|
79
|
+
| Op | When to Use |
|
|
80
|
+
| ------------------------------------- | -------------------- |
|
|
81
|
+
| `search_intelligent` | Check for duplicates |
|
|
82
|
+
| `capture_knowledge` / `capture_quick` | Persist to vault |
|
|
83
|
+
| `curator_groom` / `curator_enrich` | Post-capture quality |
|
|
84
|
+
| `curator_contradictions` | Find conflicts |
|
|
85
|
+
| `memory_promote_to_global` | Share cross-project |
|
|
86
|
+
| `admin_health` | Verify health |
|
|
@@ -72,13 +72,13 @@ If all vault strategies return nothing, search the web. If web finds something u
|
|
|
72
72
|
|
|
73
73
|
## Quick Reference
|
|
74
74
|
|
|
75
|
-
| Op
|
|
76
|
-
|
|
77
|
-
| `search_intelligent`
|
|
78
|
-
| `search`
|
|
79
|
-
| `vault_tags` / `vault_domains`
|
|
80
|
-
| `vault_recent`
|
|
81
|
-
| `vault_age_report`
|
|
82
|
-
| `memory_cross_project_search`
|
|
83
|
-
| `brain_strengths` / `brain_global_patterns` | Proven patterns
|
|
84
|
-
| `capture_quick`
|
|
75
|
+
| Op | When to Use |
|
|
76
|
+
| ------------------------------------------- | ------------------------------ |
|
|
77
|
+
| `search_intelligent` | Default semantic search |
|
|
78
|
+
| `search` | Structured search with filters |
|
|
79
|
+
| `vault_tags` / `vault_domains` | Browse knowledge landscape |
|
|
80
|
+
| `vault_recent` | Recently modified entries |
|
|
81
|
+
| `vault_age_report` | Stale entries |
|
|
82
|
+
| `memory_cross_project_search` | Cross-project search |
|
|
83
|
+
| `brain_strengths` / `brain_global_patterns` | Proven patterns |
|
|
84
|
+
| `capture_quick` | Capture web findings |
|
|
@@ -23,6 +23,7 @@ YOUR_AGENT_core op:curator_contradictions
|
|
|
23
23
|
```
|
|
24
24
|
|
|
25
25
|
**What to look for:**
|
|
26
|
+
|
|
26
27
|
- Two patterns that recommend opposite approaches for the same situation
|
|
27
28
|
- An anti-pattern that contradicts an active pattern
|
|
28
29
|
- Entries from different time periods with conflicting advice (the older one may be stale)
|
|
@@ -38,6 +39,7 @@ YOUR_AGENT_core op:vault_age_report
|
|
|
38
39
|
```
|
|
39
40
|
|
|
40
41
|
**Indicators:**
|
|
42
|
+
|
|
41
43
|
- Entries >60 days without access or update
|
|
42
44
|
- Patterns referencing APIs, libraries, or versions that have changed
|
|
43
45
|
- Entries tagged with technologies the project no longer uses
|
|
@@ -55,6 +57,7 @@ YOUR_AGENT_core op:curator_detect_duplicates
|
|
|
55
57
|
```
|
|
56
58
|
|
|
57
59
|
**Indicators:**
|
|
60
|
+
|
|
58
61
|
- Entries with zero inbound or outbound links
|
|
59
62
|
- Entries never returned in search results (check search insights)
|
|
60
63
|
- Entries with no tags or only generic tags
|
|
@@ -73,6 +76,7 @@ YOUR_AGENT_core op:curator_detect_duplicates
|
|
|
73
76
|
```
|
|
74
77
|
|
|
75
78
|
**Indicators:**
|
|
79
|
+
|
|
76
80
|
- High similarity scores between entries
|
|
77
81
|
- Same tags and category but different titles
|
|
78
82
|
- Entries captured in different sessions about the same topic
|
|
@@ -89,6 +93,7 @@ YOUR_AGENT_core op:curator_health_audit
|
|
|
89
93
|
```
|
|
90
94
|
|
|
91
95
|
**Indicators:**
|
|
96
|
+
|
|
92
97
|
- Description under 50 characters
|
|
93
98
|
- No examples or context
|
|
94
99
|
- Missing "why" — only states "what" without rationale
|
|
@@ -107,6 +112,7 @@ YOUR_AGENT_core op:vault_tags
|
|
|
107
112
|
```
|
|
108
113
|
|
|
109
114
|
**Indicators:**
|
|
115
|
+
|
|
110
116
|
- Near-duplicate categories (e.g., "error-handling" and "errors" and "exception-handling")
|
|
111
117
|
- Categories with only 1-2 entries (too granular)
|
|
112
118
|
- Tags used inconsistently (same concept, different tag names)
|
|
@@ -123,6 +129,7 @@ YOUR_AGENT_core op:brain_strengths
|
|
|
123
129
|
```
|
|
124
130
|
|
|
125
131
|
**Indicators:**
|
|
132
|
+
|
|
126
133
|
- Patterns with high initial strength that have decayed below 0.3
|
|
127
134
|
- Patterns that were strong but haven't received positive feedback in >30 days
|
|
128
135
|
- Patterns with mixed feedback (both positive and negative) — unresolved
|
|
@@ -131,13 +138,14 @@ YOUR_AGENT_core op:brain_strengths
|
|
|
131
138
|
|
|
132
139
|
### 8. Knowledge Gap Smells
|
|
133
140
|
|
|
134
|
-
Areas where the vault
|
|
141
|
+
Areas where the vault _should_ have knowledge but doesn't.
|
|
135
142
|
|
|
136
143
|
```
|
|
137
144
|
YOUR_AGENT_core op:admin_search_insights
|
|
138
145
|
```
|
|
139
146
|
|
|
140
147
|
**Indicators:**
|
|
148
|
+
|
|
141
149
|
- Repeated search queries that return no results
|
|
142
150
|
- Domains the project uses but vault has no entries for
|
|
143
151
|
- Anti-patterns captured without corresponding patterns (what to do instead?)
|
|
@@ -166,11 +174,11 @@ YOUR_AGENT_core op:admin_search_insights
|
|
|
166
174
|
|
|
167
175
|
For each smell category, assess severity:
|
|
168
176
|
|
|
169
|
-
| Severity
|
|
170
|
-
|
|
171
|
-
| 🟢 Clean
|
|
172
|
-
| 🟡 Minor
|
|
173
|
-
| 🟠 Moderate | Multiple instances, degrading quality
|
|
177
|
+
| Severity | Meaning |
|
|
178
|
+
| ----------- | ------------------------------------------ |
|
|
179
|
+
| 🟢 Clean | No issues in this category |
|
|
180
|
+
| 🟡 Minor | 1-3 instances, low impact |
|
|
181
|
+
| 🟠 Moderate | Multiple instances, degrading quality |
|
|
174
182
|
| 🔴 Critical | Widespread, actively causing bad decisions |
|
|
175
183
|
|
|
176
184
|
### Step 3: Present the Report
|
|
@@ -237,15 +245,15 @@ After fixes: `op:brain_build_intelligence` to rebuild with clean data.
|
|
|
237
245
|
|
|
238
246
|
## Quick Reference
|
|
239
247
|
|
|
240
|
-
| Smell
|
|
241
|
-
|
|
242
|
-
| Contradictions
|
|
243
|
-
| Staleness
|
|
244
|
-
| Orphans
|
|
245
|
-
| Duplicates
|
|
246
|
-
| Shallow entries
|
|
247
|
-
| Category drift
|
|
248
|
-
| Confidence decay | `brain_strengths`
|
|
249
|
-
| Knowledge gaps
|
|
248
|
+
| Smell | Detection Op | Fix Op |
|
|
249
|
+
| ---------------- | ------------------------------ | ------------------------------- |
|
|
250
|
+
| Contradictions | `curator_contradictions` | `curator_resolve_contradiction` |
|
|
251
|
+
| Staleness | `vault_age_report` | Review + archive/update |
|
|
252
|
+
| Orphans | `admin_vault_analytics` | Link or archive |
|
|
253
|
+
| Duplicates | `curator_detect_duplicates` | `curator_groom` (merge) |
|
|
254
|
+
| Shallow entries | `curator_health_audit` | Enrich or archive |
|
|
255
|
+
| Category drift | `vault_domains` + `vault_tags` | `curator_groom_all` |
|
|
256
|
+
| Confidence decay | `brain_strengths` | Reinforce or retire |
|
|
257
|
+
| Knowledge gaps | `admin_search_insights` | `capture_knowledge` |
|
|
250
258
|
|
|
251
259
|
**Related skills:** health-check (operational status), vault-curate (active cleanup), knowledge-harvest (fill gaps)
|
|
@@ -43,12 +43,12 @@ If any check reports problems, address before claiming completion.
|
|
|
43
43
|
|
|
44
44
|
## Common Failures
|
|
45
45
|
|
|
46
|
-
| Claim
|
|
47
|
-
|
|
48
|
-
| Tests pass
|
|
49
|
-
| Build succeeds
|
|
50
|
-
| Bug fixed
|
|
51
|
-
| Requirements met | Line-by-line checklist
|
|
46
|
+
| Claim | Requires | Not Sufficient |
|
|
47
|
+
| ---------------- | ----------------------- | ----------------------------- |
|
|
48
|
+
| Tests pass | Test output: 0 failures | Previous run, "should pass" |
|
|
49
|
+
| Build succeeds | Build command: exit 0 | Linter passing |
|
|
50
|
+
| Bug fixed | Original symptom passes | "Code changed, assumed fixed" |
|
|
51
|
+
| Requirements met | Line-by-line checklist | Tests passing alone |
|
|
52
52
|
|
|
53
53
|
## Red Flags — STOP
|
|
54
54
|
|
|
@@ -57,12 +57,12 @@ If any check reports problems, address before claiming completion.
|
|
|
57
57
|
- About to commit/push/PR without verification
|
|
58
58
|
- Relying on partial verification
|
|
59
59
|
|
|
60
|
-
| Excuse
|
|
61
|
-
|
|
62
|
-
| "Should work now"
|
|
63
|
-
| "I'm confident"
|
|
64
|
-
| "Just this once"
|
|
65
|
-
| "Partial check is enough" | Partial proves nothing
|
|
60
|
+
| Excuse | Reality |
|
|
61
|
+
| ------------------------- | -------------------------- |
|
|
62
|
+
| "Should work now" | RUN the verification |
|
|
63
|
+
| "I'm confident" | Confidence is not evidence |
|
|
64
|
+
| "Just this once" | No exceptions |
|
|
65
|
+
| "Partial check is enough" | Partial proves nothing |
|
|
66
66
|
|
|
67
67
|
## After Verification
|
|
68
68
|
|
|
@@ -77,9 +77,9 @@ Capture session summary: `YOUR_AGENT_core op:session_capture params: { summary:
|
|
|
77
77
|
|
|
78
78
|
## Quick Reference
|
|
79
79
|
|
|
80
|
-
| Op
|
|
81
|
-
|
|
82
|
-
| `admin_health`
|
|
83
|
-
| `admin_diagnostic`
|
|
84
|
-
| `admin_vault_analytics` | Knowledge quality metrics
|
|
85
|
-
| `session_capture`
|
|
80
|
+
| Op | When to Use |
|
|
81
|
+
| ----------------------- | ----------------------------------- |
|
|
82
|
+
| `admin_health` | Quick system health check |
|
|
83
|
+
| `admin_diagnostic` | Comprehensive diagnostic |
|
|
84
|
+
| `admin_vault_analytics` | Knowledge quality metrics |
|
|
85
|
+
| `session_capture` | Persist verified completion context |
|
|
@@ -97,12 +97,12 @@ Offer execution choice: subagent-driven (this session) or parallel session with
|
|
|
97
97
|
|
|
98
98
|
## Quick Reference
|
|
99
99
|
|
|
100
|
-
| Op
|
|
101
|
-
|
|
102
|
-
| `search_intelligent`
|
|
103
|
-
| `brain_strengths`
|
|
104
|
-
| `create_plan`
|
|
105
|
-
| `plan_grade` / `plan_auto_improve` | Grade and improve
|
|
106
|
-
| `plan_iterate`
|
|
107
|
-
| `plan_split`
|
|
108
|
-
| `approve_plan`
|
|
100
|
+
| Op | When to Use |
|
|
101
|
+
| ---------------------------------- | ----------------------------- |
|
|
102
|
+
| `search_intelligent` | Find patterns before planning |
|
|
103
|
+
| `brain_strengths` | Proven approaches |
|
|
104
|
+
| `create_plan` | Create tracked plan |
|
|
105
|
+
| `plan_grade` / `plan_auto_improve` | Grade and improve |
|
|
106
|
+
| `plan_iterate` | Iterate with feedback |
|
|
107
|
+
| `plan_split` | Split into tasks |
|
|
108
|
+
| `approve_plan` | Lock in approved plan |
|
package/package.json
CHANGED
package/src/scaffold-filetree.ts
CHANGED
|
@@ -95,7 +95,7 @@ When building a new feature, adding functionality, or creating components.
|
|
|
95
95
|
tools: `tools:
|
|
96
96
|
- soleri_vault op:search_intelligent
|
|
97
97
|
- soleri_vault op:capture_knowledge
|
|
98
|
-
-
|
|
98
|
+
- soleri_links op:link_entries
|
|
99
99
|
- soleri_plan op:create_plan
|
|
100
100
|
- soleri_plan op:approve_plan
|
|
101
101
|
- soleri_brain op:recommend
|
|
@@ -56,15 +56,15 @@ Format as a report with: Strengths, Risks (recurring anti-patterns), Gaps, Stale
|
|
|
56
56
|
|
|
57
57
|
## Quick Reference
|
|
58
58
|
|
|
59
|
-
| Op
|
|
60
|
-
|
|
61
|
-
| `brain_stats`
|
|
62
|
-
| `brain_strengths`
|
|
63
|
-
| `brain_global_patterns`
|
|
64
|
-
| `brain_recommend`
|
|
65
|
-
| `brain_build_intelligence`
|
|
66
|
-
| `memory_topics` / `memory_stats` | Knowledge clusters and health
|
|
67
|
-
| `vault_age_report`
|
|
68
|
-
| `curator_health_audit`
|
|
69
|
-
| `admin_vault_analytics`
|
|
70
|
-
| `admin_search_insights`
|
|
59
|
+
| Op | When to Use |
|
|
60
|
+
| -------------------------------- | ---------------------------------- |
|
|
61
|
+
| `brain_stats` | Aggregate metrics |
|
|
62
|
+
| `brain_strengths` | Proven patterns ranked |
|
|
63
|
+
| `brain_global_patterns` | Cross-project patterns |
|
|
64
|
+
| `brain_recommend` | Project-similarity recommendations |
|
|
65
|
+
| `brain_build_intelligence` | Rebuild intelligence pipeline |
|
|
66
|
+
| `memory_topics` / `memory_stats` | Knowledge clusters and health |
|
|
67
|
+
| `vault_age_report` | Stale entries |
|
|
68
|
+
| `curator_health_audit` | Vault quality score |
|
|
69
|
+
| `admin_vault_analytics` | Knowledge quality metrics |
|
|
70
|
+
| `admin_search_insights` | Search miss analysis |
|
|
@@ -79,11 +79,11 @@ Write validated design to `docs/plans/YYYY-MM-DD-<topic>-design.md` and commit.
|
|
|
79
79
|
|
|
80
80
|
## Quick Reference
|
|
81
81
|
|
|
82
|
-
| Op
|
|
83
|
-
|
|
84
|
-
| `route_intent`
|
|
85
|
-
| `search_intelligent`
|
|
82
|
+
| Op | When to Use |
|
|
83
|
+
| ------------------------------ | -------------------------- |
|
|
84
|
+
| `route_intent` | Classify work type |
|
|
85
|
+
| `search_intelligent` | Search vault for prior art |
|
|
86
86
|
| `vault_tags` / `vault_domains` | Browse knowledge landscape |
|
|
87
|
-
| `brain_strengths`
|
|
88
|
-
| `memory_cross_project_search`
|
|
89
|
-
| `capture_knowledge`
|
|
87
|
+
| `brain_strengths` | Check proven patterns |
|
|
88
|
+
| `memory_cross_project_search` | Check other projects |
|
|
89
|
+
| `capture_knowledge` | Persist design decision |
|
|
@@ -32,13 +32,13 @@ YOUR_AGENT_core op:brain_strengths
|
|
|
32
32
|
|
|
33
33
|
### 3. Review the Code
|
|
34
34
|
|
|
35
|
-
| Check
|
|
36
|
-
|
|
37
|
-
| Violates critical rule
|
|
38
|
-
| Matches known anti-pattern
|
|
39
|
-
| Doesn't follow proven pattern | `brain_strengths`
|
|
40
|
-
| Breaks project conventions
|
|
41
|
-
| Misses pattern opportunity
|
|
35
|
+
| Check | Source | Severity |
|
|
36
|
+
| ----------------------------- | ----------------------------- | ------------- |
|
|
37
|
+
| Violates critical rule | `search (severity: critical)` | Must fix |
|
|
38
|
+
| Matches known anti-pattern | `search (type: anti-pattern)` | Must fix |
|
|
39
|
+
| Doesn't follow proven pattern | `brain_strengths` | Should fix |
|
|
40
|
+
| Breaks project conventions | `project_list_rules` | Should fix |
|
|
41
|
+
| Misses pattern opportunity | `search_intelligent` | Could improve |
|
|
42
42
|
|
|
43
43
|
### 4. Present the Review
|
|
44
44
|
|
|
@@ -76,11 +76,11 @@ Re-run patrol after user applies fixes. Check `admin_health`.
|
|
|
76
76
|
|
|
77
77
|
## Quick Reference
|
|
78
78
|
|
|
79
|
-
| Op
|
|
80
|
-
|
|
81
|
-
| `route_intent`
|
|
82
|
-
| `search_intelligent`
|
|
83
|
-
| `search`
|
|
84
|
-
| `project_list_rules` / `get_behavior_rules` | Project conventions
|
|
85
|
-
| `brain_strengths`
|
|
86
|
-
| `capture_quick` / `capture_knowledge`
|
|
79
|
+
| Op | When to Use |
|
|
80
|
+
| ------------------------------------------- | ------------------------------------- |
|
|
81
|
+
| `route_intent` | Classify code domain |
|
|
82
|
+
| `search_intelligent` | Find relevant patterns |
|
|
83
|
+
| `search` | Find anti-patterns and critical rules |
|
|
84
|
+
| `project_list_rules` / `get_behavior_rules` | Project conventions |
|
|
85
|
+
| `brain_strengths` | Proven patterns |
|
|
86
|
+
| `capture_quick` / `capture_knowledge` | Capture new discoveries |
|
|
@@ -85,11 +85,11 @@ YOUR_AGENT_core op:admin_health
|
|
|
85
85
|
|
|
86
86
|
## Quick Reference
|
|
87
87
|
|
|
88
|
-
| Op
|
|
89
|
-
|
|
90
|
-
| `plan_stats` / `get_plan` / `plan_list_tasks` | Active plans
|
|
91
|
-
| `memory_search` / `memory_list`
|
|
92
|
-
| `vault_recent`
|
|
93
|
-
| `loop_is_active` / `loop_status`
|
|
94
|
-
| `brain_strengths`
|
|
95
|
-
| `admin_health`
|
|
88
|
+
| Op | When to Use |
|
|
89
|
+
| --------------------------------------------- | --------------------------- |
|
|
90
|
+
| `plan_stats` / `get_plan` / `plan_list_tasks` | Active plans |
|
|
91
|
+
| `memory_search` / `memory_list` | Session summaries |
|
|
92
|
+
| `vault_recent` | Recently captured knowledge |
|
|
93
|
+
| `loop_is_active` / `loop_status` | In-flight loops |
|
|
94
|
+
| `brain_strengths` | Relevant proven patterns |
|
|
95
|
+
| `admin_health` | System health check |
|
|
@@ -20,12 +20,14 @@ The user provides a **target**: file, module, directory, PR diff, or function. I
|
|
|
20
20
|
### Pass 1: Structural Analysis & Code Smells
|
|
21
21
|
|
|
22
22
|
**Metrics** (gather by reading the code):
|
|
23
|
+
|
|
23
24
|
- File length and function count
|
|
24
25
|
- Cyclomatic complexity (nesting depth, branch count)
|
|
25
26
|
- Dependency count — imports from how many modules?
|
|
26
27
|
- Export surface area — how much is public vs. should be internal?
|
|
27
28
|
|
|
28
29
|
**Structural Smells:**
|
|
30
|
+
|
|
29
31
|
- **God file/class** — too many responsibilities, >300 lines with mixed concerns
|
|
30
32
|
- **Long parameter lists** — function takes 5+ params (should be an object/config)
|
|
31
33
|
- **Deep nesting** — 4+ levels of if/for/try/catch
|
|
@@ -34,11 +36,13 @@ The user provides a **target**: file, module, directory, PR diff, or function. I
|
|
|
34
36
|
- **Boolean blindness** — functions with multiple boolean params (`fn(true, false, true)`)
|
|
35
37
|
|
|
36
38
|
**Duplication Smells:**
|
|
39
|
+
|
|
37
40
|
- Copy-paste with slight variations
|
|
38
41
|
- Repeated conditional logic — same if-chain in 3+ places
|
|
39
42
|
- Parallel structures that always change together
|
|
40
43
|
|
|
41
44
|
**Temporal Smells** (check git history):
|
|
45
|
+
|
|
42
46
|
- Files that always change together but live in different modules → missing abstraction
|
|
43
47
|
- Functions that get patched repeatedly → wrong abstraction
|
|
44
48
|
- High churn files → instability signal
|
|
@@ -52,16 +56,19 @@ Present findings before moving to Pass 2.
|
|
|
52
56
|
### Pass 2: Architectural Fitness
|
|
53
57
|
|
|
54
58
|
**Dependency Direction:**
|
|
59
|
+
|
|
55
60
|
- Do dependencies flow in the right direction? (Outer layers depend on inner, not reverse)
|
|
56
61
|
- Are there circular dependencies?
|
|
57
62
|
- Does the code reach across module boundaries it shouldn't?
|
|
58
63
|
|
|
59
64
|
**Abstraction Level:**
|
|
65
|
+
|
|
60
66
|
- Is this the right level of abstraction for the problem?
|
|
61
67
|
- Over-engineered? (abstraction for one use case, premature generalization)
|
|
62
68
|
- Under-engineered? (inline logic that should be extracted)
|
|
63
69
|
|
|
64
70
|
**Cohesion & Coupling:**
|
|
71
|
+
|
|
65
72
|
- Does everything in this module belong together? (high cohesion)
|
|
66
73
|
- Is the module tangled with others? (low coupling desired)
|
|
67
74
|
- Feature envy — does a function touch another module's internals more than its own?
|
|
@@ -78,23 +85,27 @@ If vault has relevant patterns, check alignment. If not, skip — this pass work
|
|
|
78
85
|
### Pass 3: Solution Quality Assessment
|
|
79
86
|
|
|
80
87
|
**Simplification:**
|
|
88
|
+
|
|
81
89
|
- Is there a simpler way to achieve the same result?
|
|
82
90
|
- Could any abstraction be removed without loss?
|
|
83
91
|
- Are there standard library/framework features that replace custom code?
|
|
84
92
|
|
|
85
93
|
**Edge Cases:**
|
|
94
|
+
|
|
86
95
|
- What inputs would break this?
|
|
87
96
|
- Are error paths handled or just the happy path?
|
|
88
97
|
- What happens with empty/null/undefined inputs?
|
|
89
98
|
- Concurrency: race conditions, shared mutable state?
|
|
90
99
|
|
|
91
100
|
**Performance:**
|
|
101
|
+
|
|
92
102
|
- Any O(n²) or worse hidden in loops?
|
|
93
103
|
- Unnecessary allocations, copies, or serialization?
|
|
94
104
|
- N+1 query patterns?
|
|
95
105
|
- Unbounded growth (arrays/maps that grow without limit)?
|
|
96
106
|
|
|
97
107
|
**Evolutionary Fitness:**
|
|
108
|
+
|
|
98
109
|
- How does this code age? Easy to modify in 6 months?
|
|
99
110
|
- Does it create "gravity" — attracting more complexity over time?
|
|
100
111
|
- Are extension points in the right places?
|
|
@@ -145,12 +156,12 @@ If vault has relevant patterns, check alignment. If not, skip — this pass work
|
|
|
145
156
|
|
|
146
157
|
## Severity Scale
|
|
147
158
|
|
|
148
|
-
| Level | Meaning
|
|
149
|
-
|
|
150
|
-
| ✅
|
|
151
|
-
| 💡
|
|
152
|
-
| ⚠️
|
|
153
|
-
| 🔴
|
|
159
|
+
| Level | Meaning |
|
|
160
|
+
| ----- | ------------------------------------------------------------- |
|
|
161
|
+
| ✅ | Clean — no action needed |
|
|
162
|
+
| 💡 | Info — worth knowing, low priority |
|
|
163
|
+
| ⚠️ | Warning — should fix, causes friction |
|
|
164
|
+
| 🔴 | Critical — fix before shipping, causes bugs or blocks scaling |
|
|
154
165
|
|
|
155
166
|
## Capturing Learnings (Optional)
|
|
156
167
|
|
|
@@ -179,8 +190,8 @@ Only capture if genuinely reusable — not every review finding is vault-worthy.
|
|
|
179
190
|
|
|
180
191
|
## Quick Reference
|
|
181
192
|
|
|
182
|
-
| Pass
|
|
183
|
-
|
|
184
|
-
| 1. Structural
|
|
185
|
-
| 2. Architecture | Fitness
|
|
186
|
-
| 3. Solution
|
|
193
|
+
| Pass | Focus | Key Activities |
|
|
194
|
+
| --------------- | ---------------- | ----------------------------------------------------------- |
|
|
195
|
+
| 1. Structural | Metrics + Smells | Read code, check complexity, find smells, check git history |
|
|
196
|
+
| 2. Architecture | Fitness | Dependency direction, abstraction level, cohesion/coupling |
|
|
197
|
+
| 3. Solution | Quality | Simplification, edge cases, performance, evolution |
|
|
@@ -36,6 +36,7 @@ YOUR_AGENT_core op:loop_start
|
|
|
36
36
|
### Step 3: Execute Batch (default: first 3 tasks)
|
|
37
37
|
|
|
38
38
|
For each task:
|
|
39
|
+
|
|
39
40
|
1. `op:update_task` — mark `in_progress`
|
|
40
41
|
2. Follow each step exactly
|
|
41
42
|
3. Run verifications as specified
|
|
@@ -78,14 +79,14 @@ Capture mid-execution learnings with `op:capture_quick` as they happen — don't
|
|
|
78
79
|
|
|
79
80
|
## Quick Reference
|
|
80
81
|
|
|
81
|
-
| Op
|
|
82
|
-
|
|
83
|
-
| `get_plan` / `plan_list_tasks` / `plan_stats`
|
|
84
|
-
| `update_task`
|
|
85
|
-
| `loop_start` / `loop_iterate` / `loop_complete` | Validation loop
|
|
86
|
-
| `plan_reconcile`
|
|
87
|
-
| `plan_complete_lifecycle`
|
|
88
|
-
| `session_capture`
|
|
89
|
-
| `capture_quick`
|
|
82
|
+
| Op | When to Use |
|
|
83
|
+
| ----------------------------------------------- | --------------------------- |
|
|
84
|
+
| `get_plan` / `plan_list_tasks` / `plan_stats` | Load plan |
|
|
85
|
+
| `update_task` | Mark task status |
|
|
86
|
+
| `loop_start` / `loop_iterate` / `loop_complete` | Validation loop |
|
|
87
|
+
| `plan_reconcile` | Post-execution drift report |
|
|
88
|
+
| `plan_complete_lifecycle` | Extract knowledge, archive |
|
|
89
|
+
| `session_capture` | Save session context |
|
|
90
|
+
| `capture_quick` | Mid-execution learnings |
|
|
90
91
|
|
|
91
92
|
**Related skills:** writing-plans, verification-before-completion, test-driven-development
|
|
@@ -92,11 +92,11 @@ Bug resolved, tests pass, root cause captured in vault. A fix without a capture
|
|
|
92
92
|
|
|
93
93
|
## Quick Reference
|
|
94
94
|
|
|
95
|
-
| Op
|
|
96
|
-
|
|
97
|
-
| `route_intent`
|
|
98
|
-
| `search_intelligent`
|
|
99
|
-
| `memory_search`
|
|
100
|
-
| `loop_start` / `loop_iterate` / `loop_complete` | Iterative fix cycle
|
|
101
|
-
| `capture_knowledge` / `capture_quick`
|
|
102
|
-
| `curator_detect_duplicates`
|
|
95
|
+
| Op | When to Use |
|
|
96
|
+
| ----------------------------------------------- | -------------------------- |
|
|
97
|
+
| `route_intent` | Classify as FIX intent |
|
|
98
|
+
| `search_intelligent` | Check vault for known bugs |
|
|
99
|
+
| `memory_search` | Search session memories |
|
|
100
|
+
| `loop_start` / `loop_iterate` / `loop_complete` | Iterative fix cycle |
|
|
101
|
+
| `capture_knowledge` / `capture_quick` | Persist anti-pattern |
|
|
102
|
+
| `curator_detect_duplicates` | Prevent redundant entries |
|
|
@@ -122,14 +122,14 @@ YOUR_AGENT_core op:governance_expire
|
|
|
122
122
|
|
|
123
123
|
## Quick Reference
|
|
124
124
|
|
|
125
|
-
| Op
|
|
126
|
-
|
|
127
|
-
| `admin_health` / `admin_diagnostic`
|
|
128
|
-
| `admin_vault_analytics` / `admin_vault_size` | Vault metrics
|
|
129
|
-
| `curator_health_audit`
|
|
130
|
-
| `curator_detect_duplicates`
|
|
131
|
-
| `curator_contradictions`
|
|
132
|
-
| `vault_age_report`
|
|
133
|
-
| `admin_search_insights`
|
|
134
|
-
| `curator_consolidate`
|
|
135
|
-
| `brain_build_intelligence`
|
|
125
|
+
| Op | When to Use |
|
|
126
|
+
| -------------------------------------------- | --------------------- |
|
|
127
|
+
| `admin_health` / `admin_diagnostic` | System health |
|
|
128
|
+
| `admin_vault_analytics` / `admin_vault_size` | Vault metrics |
|
|
129
|
+
| `curator_health_audit` | Quality score |
|
|
130
|
+
| `curator_detect_duplicates` | Find duplicates |
|
|
131
|
+
| `curator_contradictions` | Find conflicts |
|
|
132
|
+
| `vault_age_report` | Stale entries |
|
|
133
|
+
| `admin_search_insights` | Search miss analysis |
|
|
134
|
+
| `curator_consolidate` | Full cleanup pipeline |
|
|
135
|
+
| `brain_build_intelligence` | Rebuild after cleanup |
|