@soleri/forge 8.1.0 → 9.0.1

package/src/skills/writing-plans/SKILL.md

@@ -0,0 +1,105 @@
+---
+name: writing-plans
+description: Use when there is a spec or requirements for a multi-step task and an implementation plan needs to be written before touching code.
+---
+
+# Writing Plans
+
+Write implementation plans assuming the engineer has zero codebase context. Document everything: which files to touch, code, testing, expected output. Bite-sized tasks. DRY. YAGNI. TDD. Frequent commits.
+
+**Announce at start:** "I'm using the writing-plans skill to create the implementation plan."
+
+**Save plans to:** `docs/plans/YYYY-MM-DD-<feature-name>.md`
+
+## Before Writing — Search First
+
+### 1. Vault First
+
+```
+ernesto_core op:search_intelligent
+  params: { query: "<feature being planned>" }
+ernesto_core op:brain_strengths
+ernesto_core op:vault_domains
+ernesto_core op:vault_tags
+```
+
+### 2. Web Search Second
+
+If vault lacks guidance: libraries, reference implementations, API docs, known pitfalls.
+
+### 3. Then Write the Plan
+
+Incorporate vault insights and web findings. Reference specific entries.
+
+## Create a Tracked Plan
+
+```
+ernesto_core op:create_plan
+  params: {
+    objective: "<one-sentence goal>",
+    scope: { included: [...], excluded: [...] },
+    steps: [{ title: "Step 1", description: "details" }, ...]
+  }
+```
+
+## Grade and Improve
+
+```
+ernesto_core op:plan_grade params: { planId: "<id>" }
+ernesto_core op:plan_auto_improve params: { planId: "<id>" }
+ernesto_core op:plan_meets_grade params: { planId: "<id>", targetGrade: "A" }
+```
+
+Iterate with: `op:plan_iterate params: { planId: "<id>", feedback: "<improvement>" }`
+
+## Split into Tasks
+
+After approval: `ernesto_core op:plan_split params: { planId: "<id>" }`
+
+## Task Granularity
+
+Each step is one action (2-5 minutes): write failing test, run it, implement, run tests, commit.
+
+## Plan Document Header
+
+```markdown
+# [Feature] Implementation Plan
+
+> **For Claude:** REQUIRED SUB-SKILL: Use executing-plans to implement this plan task-by-task.
+
+**Goal:** [One sentence]
+**Architecture:** [2-3 sentences]
+**Tech Stack:** [Key technologies]
+```
+
+## Task Structure
+
+- Files: Create / Modify / Test paths
+- Steps: Write failing test (code) -> verify fail (expected output) -> implement (code) -> verify pass (expected output) -> commit (exact commands)
+
+## After Approval
+
+```
+ernesto_core op:approve_plan params: { planId: "<id>" }
+```
+
+Offer execution choice: subagent-driven (this session) or parallel session with executing-plans.
+
+## Common Mistakes
+
+- Writing plans from scratch without searching vault first
+- Vague steps like "add validation" instead of exact code
+- Missing test steps in the plan
+- Not grading the plan before presenting to user
+
+## Quick Reference
+
+| Op | When to Use |
+|----|-------------|
+| `search_intelligent` | Find patterns before planning |
+| `brain_strengths` | Proven approaches |
+| `create_plan` | Create tracked plan |
+| `plan_grade` / `plan_auto_improve` | Grade and improve |
+| `plan_iterate` | Iterate with feedback |
+| `plan_split` | Split into tasks |
+| `approve_plan` | Lock in approved plan |

package/src/templates/agents-md.ts

@@ -80,7 +80,6 @@ ${domainRows}
 | ${bt}${tp}_memory${bt} | ${bt}memory_search${bt}, ${bt}memory_capture${bt}, ${bt}session_capture${bt} |
 | ${bt}${tp}_control${bt} | ${bt}route_intent${bt}, ${bt}morph${bt}, ${bt}get_behavior_rules${bt}, ${bt}governance_dashboard${bt}, ${bt}governance_policy${bt} |
 | ${bt}${tp}_loop${bt} | ${bt}loop_start${bt}, ${bt}loop_iterate${bt}, ${bt}loop_status${bt}, ${bt}loop_cancel${bt} |
-| ${bt}${tp}_cognee${bt} | ${bt}cognee_search${bt}, ${bt}cognee_graph_stats${bt}, ${bt}cognee_export_status${bt} |
 | ${bt}${tp}_context${bt} | ${bt}context_extract_entities${bt}, ${bt}context_retrieve_knowledge${bt}, ${bt}context_analyze${bt} |
 | ${bt}${tp}_agency${bt} | ${bt}agency_enable${bt}, ${bt}agency_status${bt}, ${bt}agency_surface_patterns${bt}, ${bt}agency_warnings${bt}, ${bt}agency_clarify${bt} |
 | ${bt}${tp}_admin${bt} | ${bt}admin_health${bt}, ${bt}admin_tool_list${bt}, ${bt}admin_diagnostic${bt} |

package/src/templates/claude-md-template.ts

@@ -115,8 +115,7 @@ export function generateClaudeMdTemplate(config: AgentConfig): string {
     `| ${bt}${toolPrefix}_memory${bt} | ${bt}memory_search${bt}, ${bt}memory_capture${bt}, ${bt}session_capture${bt} |`,
     `| ${bt}${toolPrefix}_control${bt} | ${bt}route_intent${bt}, ${bt}morph${bt}, ${bt}get_behavior_rules${bt}, ${bt}governance_dashboard${bt}, ${bt}governance_policy${bt} |`,
     `| ${bt}${toolPrefix}_loop${bt} | ${bt}loop_start${bt}, ${bt}loop_iterate${bt}, ${bt}loop_status${bt}, ${bt}loop_cancel${bt} |`,
-    // Intelligence — cognee, context, agency
-    `| ${bt}${toolPrefix}_cognee${bt} | ${bt}cognee_search${bt}, ${bt}cognee_graph_stats${bt}, ${bt}cognee_export_status${bt} |`,
+    // Intelligence — context, agency
     `| ${bt}${toolPrefix}_context${bt} | ${bt}context_extract_entities${bt}, ${bt}context_retrieve_knowledge${bt}, ${bt}context_analyze${bt} |`,
     `| ${bt}${toolPrefix}_agency${bt} | ${bt}agency_enable${bt}, ${bt}agency_status${bt}, ${bt}agency_surface_patterns${bt}, ${bt}agency_warnings${bt}, ${bt}agency_clarify${bt} |`,
     // Admin

package/src/templates/entry-point.ts

@@ -56,7 +56,7 @@ async function main(): Promise<void> {
   // ─── Runtime — vault, brain, planner, curator, LLM, key pools ───
   const runtime = createAgentRuntime({
     agentId: '${config.id}',
-    dataDir: join(__dirname, 'intelligence', 'data'),${config.sharedVaultPath ? `\n    sharedVaultPath: '${config.sharedVaultPath}',` : ''}${config.cognee ? `\n    cognee: true,` : ''}
+    dataDir: join(__dirname, 'intelligence', 'data'),${config.sharedVaultPath ? `\n    sharedVaultPath: '${config.sharedVaultPath}',` : ''}
   });
 
   const tag = PERSONA.name.toLowerCase();

package/src/templates/shared-rules.ts

@@ -69,6 +69,26 @@ const ENGINE_RULES_LINES: string[] = [
   '- After every response, rate your confidence from 1 to 10. Anything below 7, flag it.',
   '',
 
+  // ─── MCP Tool Schema Validation ─────────────────────────
+  '## MCP Tool Schema Validation',
+  '<!-- soleri:tool-schema-validation -->',
+  '',
+  '**MANDATORY**: Before calling any MCP tool for the first time in a session, fetch its full JSON schema first.',
+  '',
+  '- Use `ToolSearch` (or platform equivalent) to retrieve the tool definition before invoking it.',
+  '- Read required fields, types, enum constraints, and nesting structure.',
+  '- Do NOT guess parameter shapes from memory or training data — schemas evolve between versions.',
+  '- Once fetched, the schema is valid for the remainder of the session.',
+  '',
+  '**Why:** MCP tools have strict parameter validation. Guessing formats causes repeated failures (wrong nesting, invalid enums, missing required fields), wasting tokens and eroding user trust. The schema is always available — use it.',
+  '',
+  '| Wrong | Right |',
+  '|-------|-------|',
+  '| Call tool, fail, retry with different shape | ToolSearch first, call once correctly |',
+  '| Assume `severity: "suggestion"` is valid | Read schema: `"critical" \\| "warning" \\| "info"` |',
+  '| Pass flat params when tool expects `entries[]` | Read schema: `entries` is required array |',
+  '',
+
   // ─── Memory Quality Gate ───────────────────────────────
   '## Memory Quality Gate',
   '<!-- soleri:memory-quality -->',

package/src/templates/test-facades.ts

@@ -86,7 +86,6 @@ ${domainPackDescribes ? `\n${domainPackDescribes}\n` : ''}
       expect(names).toContain('${config.id}_loop');
       expect(names).toContain('${config.id}_orchestrate');
       expect(names).toContain('${config.id}_control');
-      expect(names).toContain('${config.id}_cognee');
     });
 
     it('total ops across all facades should meet minimum threshold', () => {
@@ -273,16 +272,6 @@ ${domainPackDescribes ? `\n${domainPackDescribes}\n` : ''}
     });
   });
 
-  describe('${config.id}_cognee', () => {
-    it('should contain cognee ops', () => {
-      const facade = createSemanticFacades(runtime, '${config.id}').find(f => f.name === '${config.id}_cognee')!;
-      const opNames = facade.ops.map(o => o.name);
-      expect(opNames).toContain('cognee_status');
-      expect(opNames).toContain('cognee_search');
-      expect(opNames).toContain('cognee_sync_status');
-    });
-  });
-
   describe('${config.id}_core (agent-specific)', () => {
     function buildAgentFacade(): FacadeConfig {
       const agentOps: OpDefinition[] = [

package/src/types.ts

@@ -31,10 +31,10 @@ export const AgentConfigSchema = z.object({
   role: z.string().min(1).max(100),
   /** Longer description of what this agent does */
   description: z.string().min(10).max(500),
-  /** Knowledge domains this agent covers */
-  domains: z.array(z.string().min(1)).min(1).max(20),
-  /** Core principles the agent follows (3-7 recommended) */
-  principles: z.array(z.string()).min(1).max(10),
+  /** Knowledge domains this agent covers (discovered from usage if empty) */
+  domains: z.array(z.string().min(1)).max(20).optional().default([]),
+  /** Core principles the agent follows (discovered from usage if empty) */
+  principles: z.array(z.string()).max(10).optional().default([]),
   /** Communication tone: precise, mentor, or pragmatic */
   tone: z.enum(TONES).optional().default('pragmatic'),
   /** Greeting message when agent introduces itself (auto-generated if omitted) */
@@ -51,8 +51,6 @@ export const AgentConfigSchema = z.object({
   setupTarget: z.enum(SETUP_TARGETS).optional().default('claude'),
   /** Enable Telegram transport scaffolding. Default: false. */
   telegram: z.boolean().optional().default(false),
-  /** Enable Cognee vector search integration. Default: false. */
-  cognee: z.boolean().optional().default(false),
   /** Domain packs — npm packages with custom ops, knowledge, rules, and skills. */
   domainPacks: z
     .array(
@@ -78,6 +76,8 @@ export const AgentConfigSchema = z.object({
     .optional(),
   /** @deprecated Use vaults[] instead. Shorthand for a single shared vault at priority 0.6. */
   sharedVaultPath: z.string().optional(),
+  /** Composable persona configuration. If omitted, Italian Craftsperson default is used. */
+  persona: z.record(z.unknown()).optional(),
 });
 
 export type AgentConfig = z.infer<typeof AgentConfigSchema>;

package/dist/skills/agent-dev.md

@@ -1,122 +0,0 @@
----
-name: agent-dev
-description: >
-  Use when extending the agent itself — adding facades, tools, vault operations,
-  brain features, new skills, or modifying agent internals. Triggers on "add a facade",
-  "new tool", "extend vault", "add brain feature", "new skill", "add operation",
-  "extend agent", or when the work target is the agent's own codebase rather than
-  a project the agent assists with. Enforces vault-first knowledge gathering before
-  any code reading or planning.
----
-
-# Agent Dev — Vault-First Internal Development
-
-Develop the agent's own internals with the vault as the primary source of truth. The vault knows more about the agent than any code scan or model training data. Always search the vault first, extract maximum context, and only then touch code.
-
-## When to Use
-
-Any time the work target is the agent's own codebase: adding tools, extending facades, modifying vault operations, brain features, skills, or transport. Not for projects that merely *use* the agent.
-
-## Core Principle
-
-**Vault first. Before code. Before training data. Always.**
-
-The vault is the authoritative source for how the agent works. Do not rely on general knowledge from training data — it is outdated and lacks project-specific decisions. Do not scan the codebase to understand architecture — the vault already has it.
-
-## Orchestration Sequence
-
-### Step 1: Search the Vault (MANDATORY — before anything else)
-
-Before reading any source file, before making any plan, before offering any advice:
-
-```
-YOUR_AGENT_core op:search_vault_intelligent
-  params: { query: "<description of planned work>", options: { intent: "pattern" } }
-```
-
-Search again with architecture-specific terms: the facade name, tool name, or subsystem being modified.
-
-```
-YOUR_AGENT_core op:query_vault_knowledge
-  params: { type: "workflow", category: "<relevant category>" }
-```
-
-If initial results are sparse, search again with broader terms — synonyms, related subsystem names, parent concepts. Exhaust the vault before moving on.
-
-Review all results. Extract file paths, module names, function references, conventions, and constraints. These become the foundation for every step that follows.
-
-### Step 2: Check Brain for Proven Patterns
-
-```
-YOUR_AGENT_core op:strengths
-  params: { days: 30, minStrength: 60 }
-```
-
-```
-YOUR_AGENT_core op:recommend
-  params: { projectPath: "." }
-```
-
-Check if the brain has learned anything relevant from recent sessions.
-
-### Step 3: Targeted Code Reading (Only What Vault Pointed To)
-
-By now the vault has provided architecture context, file paths, and module references. Only read code when the vault describes the subsystem but lacks implementation detail (e.g., method signatures, exact line numbers).
-
-**Read only what the vault pointed to.** Open the specific files referenced in vault results — not the surrounding codebase, not the parent directory, not "let me explore the project structure."
-
-**Fallback: Codebase scan.** Only when vault search returned zero relevant results for the subsystem — meaning the vault genuinely has no knowledge about it — fall back to `Grep` with targeted terms. This is the last resort, not the default.
-
-### Step 4: Plan with Vault Context
-
-Create the implementation plan referencing vault findings explicitly:
-
-- Which patterns apply (cite vault entry titles)
-- Which anti-patterns to avoid (cite the specific anti-pattern)
-- Which conventions to follow (naming, facade structure, tool registration)
-
-Every plan must trace its decisions back to vault knowledge. If a decision has no vault backing, flag it as a new architectural choice that should be captured after implementation (Step 7).
-
-### Step 5: Implement
-
-Follow the plan. Key conventions for agent internals:
-
-- **Facades**: Thin routing layer — delegate to domain modules. No business logic in facades.
-- **Tools**: Follow `op:operation_name` naming, return structured responses.
-- **Vault writes**: All writes go through the vault intelligence layer.
-- **Tests**: Colocated test files. Run with vitest.
-- **Build**: Must compile without errors before considering done.
-
-### Step 6: Validate and Self-Correct
-
-Run the relevant test suite. Rebuild — must complete without errors.
-
-**Self-correction loop:** If tests fail or build breaks, do NOT ask the user what to do. Read the error, trace the cause in the code just written, fix it, and re-run. Repeat until green. The agent owns the code it wrote — if something fails, the agent fixes its own implementation. Only escalate to the user when the failure is outside the agent's control (missing infrastructure, permissions, unclear requirements).
-
-### Step 7: Capture What Was Learned
-
-If this work revealed new architectural knowledge, a useful pattern, or a surprising anti-pattern:
-
-```
-YOUR_AGENT_core op:capture_knowledge
-  params: {
-    title: "<what was learned>",
-    description: "<the pattern or anti-pattern>",
-    type: "pattern",
-    tags: ["<relevant-tags>"]
-  }
-```
-
-This ensures future sessions benefit from today's discovery — making the vault smarter for the next developer.
-
-## Anti-Patterns to Avoid
-
-- **Code-first exploration**: Reading source files before searching the vault. The vault already has the architecture — scanning code is slower and gives less context.
-- **Training-data advice**: Offering general guidance from model training data instead of searching the vault for project-specific knowledge.
-- **Skipping vault search**: The vault contains all architecture knowledge. Not searching it means reinventing knowledge that already exists.
-- **Planning without vault context**: Plans created without vault knowledge miss conventions, duplicate existing patterns, or violate architectural boundaries.
-- **Broad codebase scanning**: Exploring directories and reading files "to understand the project" instead of using vault results as a targeted map.
-
-## Exit Criteria
-
-Development is complete when: vault was searched exhaustively first (Step 1), implementation follows discovered patterns, tests pass, build succeeds, and any new learning is captured back to vault (Step 7).

package/dist/skills/agent-guide.md

@@ -1,110 +0,0 @@
----
-name: agent-guide
-description: >
-  Use when the user asks "what can you do", "help me", "how do I use this",
-  "what features do you have", "what tools are available", "how does this work",
-  "show me your capabilities", "what are you", "who are you", or any question
-  about the agent's identity, capabilities, available tools, or how to use them.
-  Not needed for proactive tool suggestions — those are handled by engine rules.
----
-
-# Agent Guide — Capability Discovery
-
-Help users understand what this agent can do, how to use it effectively, and what makes it different from a raw LLM. This skill handles the deep discovery flow — proactive tool suggestions during normal work are handled by the engine rules (Tool Advocacy section).
-
-## When to Use
-
-- "What can you do?" / "What are your capabilities?"
-- "How do I search for X?" / "How do I capture knowledge?"
-- "What tools do you have?" / "Show me your features"
-- "Who are you?" / "What is this agent?"
-- "Help" / "I'm stuck" / "How does this work?"
-- First-time users, onboarding, or anyone unfamiliar with the agent
-
-## Capability Discovery Sequence
-
-### Step 1: Identity
-
-```
-YOUR_AGENT_core op:activate
-  params: { projectPath: "." }
-```
-
-This returns the agent's persona: name, role, description, tone, principles, and domains. Present the identity first — who the agent is and what it specializes in.
-
-### Step 2: Health & Status
-
-```
-YOUR_AGENT_core op:admin_health
-```
-
-Shows what subsystems are active: vault (how many entries), brain (vocabulary size), LLM availability, cognee status. This tells the user what the agent currently has to work with.
-
-### Step 3: Available Tools
-
-```
-YOUR_AGENT_core op:admin_tool_list
-```
-
-Lists all facades and operations. Present them grouped by category with plain-language descriptions.
-
-### Step 4: Present by What Users Can DO
-
-Organize capabilities by user goals, not technical names:
-
-**Knowledge & Memory**
-- Search the vault for patterns, anti-patterns, and architectural decisions
-- Capture new knowledge from the current session
-- Search across sessions and projects for relevant context
-- Curate: deduplicate, groom, resolve contradictions
-
-**Planning & Execution**
-- Create structured plans with vault context and brain recommendations
-- Split plans into tasks with complexity estimates
-- Track execution with drift detection
-- Complete with knowledge capture and session recording
-
-**Intelligence & Learning**
-- Brain learns from every session — patterns get stronger with use
-- Recommendations based on similar past work
-- Strength tracking: which patterns are proven vs experimental
-- Feedback loop: brain improves based on what works
-
-**Quality & Validation**
-- Health checks across all subsystems
-- Iterative validation loops with configurable targets
-- Governance: policies, proposals, quotas
-
-**Identity & Control**
-- Persona activation and deactivation
-- Intent routing: the agent classifies what you want and routes to the right workflow
-- Project registration and cross-project linking
-
-**Domain Knowledge** (varies by agent)
-- Each domain has: `get_patterns`, `search`, `get_entry`, `capture`, `remove`
-- Call `op:activate` to discover which domains are configured
-
-## Common Questions
-
-### "What makes you different from regular Claude?"
-
-You have persistent knowledge (vault), learned patterns (brain), structured planning with grading, iterative validation loops, and domain-specific intelligence. Regular Claude starts fresh every conversation — this agent accumulates knowledge and gets smarter over time.
-
-### "How do I get the most out of you?"
-
-1. **Use the vault** — search before deciding, capture after learning
-2. **Use planning** — structured plans beat ad-hoc work for anything non-trivial
-3. **Trust the brain** — pattern recommendations come from real usage data
-4. **Capture everything** — every bug fix, every pattern, every anti-pattern. The vault grows smarter with use.
-5. **Use loops for quality** — iterative validation catches issues that single-pass work misses
-
-### "How do I add new capabilities?"
-
-Extensions in `src/extensions/` can add new ops, facades, middleware, and hooks. Domain packs add domain-specific knowledge and validation.
-
-## Anti-Patterns
-
-- **Listing raw op names without context** — always explain what the op does in plain language
-- **Claiming capabilities that do not exist** — only reference ops the agent actually has. When unsure, call `op:admin_tool_list` first
-- **Dumping the entire tool catalog** — answer the specific question, show relevant tools, not all tools
-- **Repeating what the user already knows** — if they ask about a specific feature, answer that, don't give the full tour

package/dist/skills/agent-persona.md

@@ -1,66 +0,0 @@
----
-name: agent-persona
-description: >
-  Use when the user activates the agent's persona via its greeting phrase, or says
-  "activate persona", "be yourself", "stay in character", or any activation phrase
-  defined in the agent's persona configuration. Reinforces character persistence
-  through the session and survives context compaction.
----
-
-# Agent Persona — Stay in Character
-
-This skill reinforces persona persistence. The MCP activation loads the runtime payload — this skill ensures the character sticks across the full session, including after context compaction.
-
-## How It Works
-
-Every agent has a persona defined in `src/identity/persona.ts` (or `src/activation/persona.ts` in older agents). This file contains:
-
-- **name** — the agent's display name
-- **role** — what the agent does
-- **tone** — `precise`, `mentor`, or `pragmatic`
-- **greeting** — the activation response
-- **principles** — core values that guide behavior
-
-## Activation
-
-When the user triggers activation (greeting phrase or explicit request):
-
-```
-YOUR_AGENT_core op:activate
-  params: { projectPath: "." }
-```
-
-The activation response contains the full persona payload. Adopt it immediately.
-
-## Rules
-
-1. **Stay in character for EVERY response** until the user explicitly deactivates
-2. **Technical accuracy is the priority** — persona is the wrapper, not a replacement for correctness
-3. **Tone consistency** — match the configured tone (`precise` = concise and exact, `mentor` = educational and encouraging, `pragmatic` = direct and practical)
-4. If character drifts after context compaction, the persona information in the compacted summary should restore it — follow it
-
-## Context Compaction Survival
-
-Long sessions trigger context compaction. To survive:
-
-- The persona activation state is included in compaction summaries
-- After compaction, check if persona was active and re-adopt the character
-- Never break character just because the conversation was compacted
-
-## Deactivation
-
-When the user says "deactivate", "stop persona", "be normal", or uses the agent's deactivation phrase:
-
-```
-YOUR_AGENT_core op:activate
-  params: { deactivate: true }
-```
-
-Return to neutral assistant mode.
-
-## Anti-Patterns
-
-- **Dropping character mid-session** — if activated, stay activated
-- **Over-persona, under-substance** — character adds flavor, not replaces technical depth
-- **Forcing persona on unwilling users** — only activate when explicitly triggered
-- **Ignoring tone setting** — a `precise` agent should not use flowery language; a `mentor` agent should not be terse