@soleri/forge 5.4.0 → 5.5.0

package/src/__tests__/scaffolder.test.ts

@@ -248,6 +248,119 @@ describe('Scaffolder', () => {
     });
   });
 
+  describe('skills', () => {
+    it('should create skills directory with 10 SKILL.md files', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+
+      expect(existsSync(skillsDir)).toBe(true);
+
+      const skillDirs = readdirSync(skillsDir, { withFileTypes: true })
+        .filter((e) => e.isDirectory())
+        .map((e) => e.name);
+
+      expect(skillDirs).toHaveLength(17);
+
+      // Verify each skill dir has a SKILL.md
+      for (const dir of skillDirs) {
+        expect(existsSync(join(skillsDir, dir, 'SKILL.md'))).toBe(true);
+      }
+    });
+
+    it('should include all expected skill names', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+      const skillDirs = readdirSync(skillsDir).sort();
+
+      expect(skillDirs).toEqual([
+        'brain-debrief',
+        'brainstorming',
+        'code-patrol',
+        'context-resume',
+        'executing-plans',
+        'fix-and-learn',
+        'health-check',
+        'knowledge-harvest',
+        'onboard-me',
+        'retrospective',
+        'second-opinion',
+        'systematic-debugging',
+        'test-driven-development',
+        'vault-capture',
+        'vault-navigator',
+        'verification-before-completion',
+        'writing-plans',
+      ]);
+    });
+
+    it('should have YAML frontmatter in all skills', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+      const skillDirs = readdirSync(skillsDir);
+
+      for (const dir of skillDirs) {
+        const content = readFileSync(join(skillsDir, dir, 'SKILL.md'), 'utf-8');
+        expect(content).toMatch(/^---\nname: /);
+        expect(content).toContain('description:');
+      }
+    });
+
+    it('should substitute YOUR_AGENT_core with agent ID in all skills', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+      const allSkills = readdirSync(skillsDir);
+
+      for (const name of allSkills) {
+        const content = readFileSync(join(skillsDir, name, 'SKILL.md'), 'utf-8');
+        expect(content).not.toContain('YOUR_AGENT_core');
+        // All skills that reference agent ops should have atlas_core
+        if (content.includes('_core')) {
+          expect(content).toContain('atlas_core');
+        }
+      }
+    });
+
+    it('should include MIT attribution in superpowers-adapted skills', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+      const superpowersSkills = [
+        'test-driven-development',
+        'systematic-debugging',
+        'verification-before-completion',
+        'brainstorming',
+        'writing-plans',
+        'executing-plans',
+      ];
+
+      for (const name of superpowersSkills) {
+        const content = readFileSync(join(skillsDir, name, 'SKILL.md'), 'utf-8');
+        expect(content).toContain('MIT License');
+      }
+    });
+
+    it('should have no YOUR_AGENT_core placeholder remaining in any skill', () => {
+      scaffold(testConfig);
+      const skillsDir = join(tempDir, 'atlas', 'skills');
+      const allSkills = readdirSync(skillsDir);
+
+      for (const name of allSkills) {
+        const content = readFileSync(join(skillsDir, name, 'SKILL.md'), 'utf-8');
+        expect(content).not.toContain('YOUR_AGENT_core');
+      }
+    });
+
+    it('should include skills in preview', () => {
+      const preview = previewScaffold(testConfig);
+      const paths = preview.files.map((f) => f.path);
+      expect(paths).toContain('skills/');
+    });
+
+    it('should mention skills in scaffold summary', () => {
+      const result = scaffold(testConfig);
+      expect(result.summary).toContain('built-in skills');
+    });
+  });
+
   describe('listAgents', () => {
     it('should list scaffolded agents', () => {
       scaffold(testConfig);

package/src/scaffolder.ts

@@ -6,7 +6,7 @@ import {
   readdirSync,
   readFileSync,
 } from 'node:fs';
-import { join } from 'node:path';
+import { join, dirname } from 'node:path';
 import { homedir } from 'node:os';
 import type { AgentConfig, ScaffoldResult, ScaffoldPreview, AgentInfo } from './types.js';
 
@@ -21,6 +21,7 @@ import { generateInjectClaudeMd } from './templates/inject-claude-md.js';
 import { generateActivate } from './templates/activate.js';
 import { generateReadme } from './templates/readme.js';
 import { generateSetupScript } from './templates/setup-script.js';
+import { generateSkills } from './templates/skills.js';
 
 /**
  * Preview what scaffold will create without writing anything.
@@ -75,6 +76,11 @@ export function previewScaffold(config: AgentConfig): ScaffoldPreview {
       path: 'scripts/setup.sh',
       description: 'Automated setup — Node.js check, build, Claude Code MCP registration',
     },
+    {
+      path: 'skills/',
+      description:
+        '17 built-in skills — TDD, debugging, planning, vault, brain, code patrol, retrospective, onboarding',
+    },
   ];
 
   if (config.hookPacks?.length) {
@@ -295,6 +301,7 @@ export function scaffold(config: AgentConfig): ScaffoldResult {
   const dirs = [
     '',
     'scripts',
+    'skills',
     'src',
     'src/intelligence',
     'src/intelligence/data',
@@ -358,6 +365,15 @@ export function scaffold(config: AgentConfig): ScaffoldResult {
     filesCreated.push(path);
   }
 
+  // Generate skill files
+  const skillFiles = generateSkills(config);
+  for (const [path, content] of skillFiles) {
+    const skillDir = join(agentDir, dirname(path));
+    mkdirSync(skillDir, { recursive: true });
+    writeFileSync(join(agentDir, path), content, 'utf-8');
+    filesCreated.push(path);
+  }
+
   const totalOps = config.domains.length * 5 + 61; // 5 per domain + 56 core (from createCoreOps) + 5 agent-specific
 
   // Register the agent as an MCP server in ~/.claude.json
@@ -370,6 +386,7 @@ export function scaffold(config: AgentConfig): ScaffoldResult {
     `Intelligence layer (Brain) — TF-IDF scoring, auto-tagging, duplicate detection`,
     `Activation system included — say "Hello, ${config.name}!" to activate`,
     `1 test suite — facades (vault, brain, planner, llm tests provided by @soleri/core)`,
+    `${skillFiles.length} built-in skills (TDD, debugging, planning, vault, brain debrief)`,
   ];
 
   if (config.hookPacks?.length) {

package/src/skills/brain-debrief.md

@@ -0,0 +1,186 @@
+---
+name: brain-debrief
+description: Use when the user asks "what have I learned", "brain stats", "pattern strengths", "cross-project insights", "intelligence report", "show me patterns", "what's working", "learning summary", or wants to explore accumulated knowledge and see what the brain has learned.
+---
+
+# Brain Debrief — Intelligence Report
+
+Surface what the brain has learned across sessions and projects. This turns raw vault data into actionable intelligence.
+
+## When to Use
+
+When the user wants to understand what patterns have proven valuable, what anti-patterns keep recurring, how knowledge is distributed across projects, or wants a "state of intelligence" report.
+
+## Orchestration by Query Type
+
+### "What have I learned?" (General debrief)
+
+1. Get the big picture:
+   ```
+   YOUR_AGENT_core op:brain_stats
+   ```
+   Total sessions, patterns captured, quality scores, coverage gaps.
+
+2. Get patterns ranked by proven strength:
+   ```
+   YOUR_AGENT_core op:brain_strengths
+   ```
+   Focus on strength >= 70 and successRate >= 0.7.
+
+3. Check memory landscape:
+   ```
+   YOUR_AGENT_core op:memory_topics
+   ```
+   Shows how knowledge clusters by topic.
+
+4. Check for stale knowledge:
+   ```
+   YOUR_AGENT_core op:vault_age_report
+   ```
+   Find entries that haven't been updated recently — candidates for review.
+
+5. Run a curator health audit:
+   ```
+   YOUR_AGENT_core op:curator_health_audit
+   ```
+   Vault quality score, tag normalization status, duplicate density.
+
+6. Present: top 5 strongest patterns, top 3 recurring anti-patterns, stale entries needing refresh, and coverage gaps.
+
+### "What's working across projects?" (Cross-project intelligence)
+
+1. Get patterns promoted to the global pool:
+   ```
+   YOUR_AGENT_core op:brain_global_patterns
+   ```
+
+2. Get recommendations based on project similarity:
+   ```
+   YOUR_AGENT_core op:brain_recommend
+     params: { projectName: "<current project>" }
+   ```
+
+3. Check linked projects:
+   ```
+   YOUR_AGENT_core op:project_linked_projects
+   ```
+
+4. Search across all projects for relevant patterns:
+   ```
+   YOUR_AGENT_core op:memory_cross_project_search
+     params: { query: "<topic>", crossProject: true }
+   ```
+
+5. Present: patterns from other projects that would apply here, ranked by relevance.
+
+### "Am I getting smarter?" (Learning velocity)
+
+1. Recent stats:
+   ```
+   YOUR_AGENT_core op:brain_stats
+     params: { since: "<7 days ago>" }
+   ```
+
+2. Longer period for comparison:
+   ```
+   YOUR_AGENT_core op:brain_stats
+     params: { since: "<30 days ago>" }
+   ```
+
+3. Memory stats:
+   ```
+   YOUR_AGENT_core op:memory_stats
+   ```
+
+4. Vault analytics:
+   ```
+   YOUR_AGENT_core op:admin_vault_analytics
+   ```
+
+5. Search insights — what queries are people running, what's missing:
+   ```
+   YOUR_AGENT_core op:admin_search_insights
+   ```
+
+6. Present: new patterns captured, strength changes, domains growing vs stagnant, search miss analysis.
+
+### "Build fresh intelligence" (Rebuild)
+
+1. Run the full pipeline:
+   ```
+   YOUR_AGENT_core op:brain_build_intelligence
+   ```
+   Compute strengths, update global registry, refresh project profiles.
+
+2. Consolidate vault (curator cleanup):
+   ```
+   YOUR_AGENT_core op:curator_consolidate
+   ```
+
+3. Show updated metrics:
+   ```
+   YOUR_AGENT_core op:brain_stats
+   ```
+
+4. Present: what changed after the rebuild.
+
+### "Export what I know" (Portability)
+
+Export brain intelligence:
+```
+YOUR_AGENT_core op:brain_export
+```
+
+Export memory:
+```
+YOUR_AGENT_core op:memory_export
+```
+
+Export vault as backup:
+```
+YOUR_AGENT_core op:vault_backup
+```
+
+These can be imported into another vault:
+```
+YOUR_AGENT_core op:brain_import
+YOUR_AGENT_core op:memory_import
+YOUR_AGENT_core op:vault_import
+```
+
+## Presenting Intelligence
+
+Format as a report:
+- **Strengths**: Top patterns with strength scores and domains
+- **Risks**: Recurring anti-patterns that keep appearing
+- **Gaps**: Domains with low coverage or stale knowledge
+- **Stale**: Entries needing refresh (from age report)
+- **Quality**: Curator health audit score
+- **Recommendations**: What to focus on learning next
+- **Search Misses**: What people are looking for but not finding
+
+## Exit Criteria
+
+Debrief is complete when the user's specific question has been answered with data from the brain. For general debriefs, present stats + strengths + gaps + stale entries at minimum.
+
+## Agent Tools Reference
+
+| Op | When to Use |
+|----|-------------|
+| `brain_stats` | Aggregate metrics — sessions, patterns, quality |
+| `brain_strengths` | Patterns ranked by proven strength |
+| `brain_global_patterns` | Cross-project promoted patterns |
+| `brain_recommend` | Project-similarity recommendations |
+| `brain_build_intelligence` | Rebuild full intelligence pipeline |
+| `brain_export` / `brain_import` | Portable intelligence transfer |
+| `memory_topics` | Knowledge clusters by topic |
+| `memory_stats` | Memory statistics |
+| `memory_export` / `memory_import` | Memory portability |
+| `memory_cross_project_search` | Search across linked projects |
+| `vault_age_report` | Find stale entries needing refresh |
+| `vault_backup` / `vault_import` | Vault backup and restore |
+| `curator_health_audit` | Vault quality score and status |
+| `curator_consolidate` | Full vault cleanup pipeline |
+| `admin_vault_analytics` | Overall knowledge quality metrics |
+| `admin_search_insights` | Search miss analysis — what's not found |
+| `project_linked_projects` | See connected projects |

package/src/skills/brainstorming.md

@@ -0,0 +1,170 @@
+---
+name: brainstorming
+description: "You MUST use this before any creative work - creating features, building components, adding functionality, or modifying behavior. Explores user intent, requirements and design before implementation."
+---
+
+<!-- Adapted from superpowers (MIT License) -->
+
+# Brainstorming Ideas Into Designs
+
+## Overview
+
+Help turn ideas into fully formed designs and specs through natural collaborative dialogue.
+
+Start by understanding the current project context, then ask questions one at a time to refine the idea. Once you understand what you're building, present the design and get user approval.
+
+<HARD-GATE>
+Do NOT invoke any implementation skill, write any code, scaffold any project, or take any implementation action until you have presented a design and the user has approved it. This applies to EVERY project regardless of perceived simplicity.
+</HARD-GATE>
+
+## Anti-Pattern: "This Is Too Simple To Need A Design"
+
+Every project goes through this process. A todo list, a single-function utility, a config change — all of them. "Simple" projects are where unexamined assumptions cause the most wasted work. The design can be short (a few sentences for truly simple projects), but you MUST present it and get approval.
+
+## Checklist
+
+You MUST create a task for each of these items and complete them in order:
+
+1. **Classify intent** — understand what type of work this is
+2. **Search vault for prior art** — check if something similar was built, decided, or rejected before
+3. **Search web for existing solutions** — don't build what already exists
+4. **Explore project context** — check files, docs, recent commits
+5. **Ask clarifying questions** — one at a time, understand purpose/constraints/success criteria
+6. **Propose 2-3 approaches** — with trade-offs and your recommendation
+7. **Present design** — in sections scaled to their complexity, get user approval after each section
+8. **Capture design decision** — persist the decision to the vault
+9. **Write design doc** — save to `docs/plans/YYYY-MM-DD-<topic>-design.md` and commit
+10. **Transition to implementation** — invoke writing-plans skill to create implementation plan
+
+## Step 0: Classify Intent
+
+Before anything else, understand the type of work:
+
+```
+YOUR_AGENT_core op:route_intent
+  params: { prompt: "<the user's request>" }
+```
+
+This returns the intent type (BUILD, FIX, VALIDATE, DESIGN, IMPROVE, DELIVER) and routing guidance. Use this to focus the brainstorming — a FIX intent needs different questions than a BUILD intent.
+
+## Step 1: Search Before Designing — Vault, Then Web
+
+**BEFORE asking any questions or exploring code**, search for existing knowledge. Follow this order:
+
+### Vault First
+```
+YOUR_AGENT_core op:search_intelligent
+  params: { query: "<the feature or idea the user described>" }
+```
+
+Look for:
+- **Previous designs** — was this discussed or attempted before?
+- **Architectural decisions** — are there constraints from past decisions?
+- **Patterns** — established approaches in this codebase
+- **Anti-patterns** — approaches that were tried and failed
+
+Browse the knowledge landscape for related context:
+
+```
+YOUR_AGENT_core op:vault_tags
+YOUR_AGENT_core op:vault_domains
+```
+
+Check what the brain says about proven patterns in this domain:
+
+```
+YOUR_AGENT_core op:brain_strengths
+```
+
+Check if other linked projects have solved this:
+
+```
+YOUR_AGENT_core op:memory_cross_project_search
+  params: { query: "<the feature>", crossProject: true }
+```
+
+### Web Search Second
+If the vault doesn't have prior art, search the web for:
+- **Existing libraries/tools** that solve this problem (don't build what exists)
+- **Reference implementations** in similar projects
+- **Best practices** and established patterns for this type of feature
+- **Known pitfalls** that others have documented
+
+### Present Findings
+Present vault + web findings to the user: "Before we design this, here's what I found..." This informs the design conversation and prevents reinventing solutions.
+
+## The Process
+
+**Understanding the idea:**
+- Check out the current project state first (files, docs, recent commits)
+- Ask questions one at a time to refine the idea
+- Prefer multiple choice questions when possible, but open-ended is fine too
+- Only one question per message
+- Focus on understanding: purpose, constraints, success criteria
+
+**Exploring approaches:**
+- Propose 2-3 different approaches with trade-offs
+- Present options conversationally with your recommendation and reasoning
+- Lead with your recommended option and explain why
+- **Reference vault patterns** — if the vault has a proven approach, lead with it
+- **Reference web findings** — if an existing library solves this, recommend it over custom code
+
+**Presenting the design:**
+- Once you understand what you're building, present the design
+- Scale each section to its complexity
+- Ask after each section whether it looks right so far
+- Cover: architecture, components, data flow, error handling, testing
+
+## After the Design
+
+**Capture the design decision to the vault:**
+
+```
+YOUR_AGENT_core op:capture_knowledge
+  params: {
+    title: "<feature name> — design decision",
+    description: "<chosen approach, rationale, rejected alternatives>",
+    type: "decision",
+    category: "<relevant domain>",
+    tags: ["<relevant>", "<tags>", "design-decision"]
+  }
+```
+
+This ensures future brainstorming sessions can reference what was decided and why.
+
+**Documentation:**
+- Write the validated design to `docs/plans/YYYY-MM-DD-<topic>-design.md`
+- Commit the design document to git
+
+**Implementation:**
+- Invoke the writing-plans skill to create a detailed implementation plan
+- Do NOT invoke any other skill. writing-plans is the next step.
+
+## Process Flow
+
+**The terminal state is invoking writing-plans.** Do NOT invoke any other implementation skill. The ONLY skill you invoke after brainstorming is writing-plans.
+
+## Key Principles
+
+- **Classify first** — understand intent before diving in
+- **Vault first** — don't reinvent what's been decided or solved before
+- **Web second** — don't build what already exists as a library
+- **One question at a time** — don't overwhelm with multiple questions
+- **Multiple choice preferred** — easier to answer than open-ended when possible
+- **YAGNI ruthlessly** — remove unnecessary features from all designs
+- **Explore alternatives** — always propose 2-3 approaches before settling
+- **Incremental validation** — present design, get approval before moving on
+- **Capture decisions** — every design decision gets persisted to the vault
+- **Cross-project learning** — check if other projects solved this already
+- **Be flexible** — go back and clarify when something doesn't make sense
+
+## Agent Tools Reference
+
+| Op | When to Use |
+|----|-------------|
+| `route_intent` | Classify the type of work (BUILD, FIX, etc.) |
+| `search_intelligent` | Search vault for prior art |
+| `vault_tags` / `vault_domains` | Browse knowledge landscape |
+| `brain_strengths` | Check proven patterns |
+| `memory_cross_project_search` | Check if other projects solved this |
+| `capture_knowledge` | Persist design decision to vault |