@solana/web3.js 1.87.6 → 1.89.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solana/web3.js",
-  "version": "1.87.6",
+  "version": "1.89.0",
   "description": "Solana Javascript API",
   "keywords": [
     "api",
@@ -54,11 +54,11 @@
     "test:unit:node": "cross-env NODE_ENV=test TS_NODE_COMPILER_OPTIONS='{ \"module\": \"commonjs\", \"target\": \"es2019\" }' ts-mocha --require esm './test/**/*.test.ts'"
   },
   "dependencies": {
-    "@babel/runtime": "^7.23.2",
+    "@babel/runtime": "^7.23.4",
     "@noble/curves": "^1.2.0",
-    "@noble/hashes": "^1.3.1",
-    "@solana/buffer-layout": "^4.0.0",
-    "agentkeepalive": "^4.3.0",
+    "@noble/hashes": "^1.3.2",
+    "@solana/buffer-layout": "^4.0.1",
+    "agentkeepalive": "^4.5.0",
     "bigint-buffer": "^1.1.5",
     "bn.js": "^5.2.1",
     "borsh": "^0.7.0",
@@ -66,57 +66,57 @@
     "buffer": "6.0.3",
     "fast-stable-stringify": "^1.0.0",
     "jayson": "^4.1.0",
-    "node-fetch": "^2.6.12",
+    "node-fetch": "^2.7.0",
     "rpc-websockets": "^7.5.1",
     "superstruct": "^0.14.2"
   },
   "devDependencies": {
-    "@babel/core": "^7.23.2",
-    "@babel/plugin-transform-class-properties": "^7.22.5",
-    "@babel/plugin-transform-private-methods": "^7.22.5",
-    "@babel/plugin-transform-private-property-in-object": "^7.22.11",
-    "@babel/plugin-transform-runtime": "^7.23.3",
+    "@babel/core": "^7.23.7",
+    "@babel/plugin-transform-class-properties": "^7.23.3",
+    "@babel/plugin-transform-private-methods": "^7.23.3",
+    "@babel/plugin-transform-private-property-in-object": "^7.23.4",
+    "@babel/plugin-transform-runtime": "^7.23.7",
     "@babel/preset-env": "^7.23.3",
-    "@babel/preset-typescript": "^7.23.2",
+    "@babel/preset-typescript": "^7.23.3",
     "@rollup/plugin-alias": "^4.0.3",
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-commonjs": "^25.0.4",
-    "@rollup/plugin-json": "^6.0.0",
+    "@rollup/plugin-json": "^6.0.1",
     "@rollup/plugin-multi-entry": "^6.0.0",
-    "@rollup/plugin-node-resolve": "^15.2.1",
+    "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-replace": "^5.0.2",
     "@rollup/plugin-terser": "^0.4.3",
     "@solana/spl-token": "^0.3.8",
     "@types/bn.js": "^5.1.1",
     "@types/bs58": "^4.0.1",
     "@types/chai": "^4.3.5",
-    "@types/chai-as-promised": "^7.1.3",
-    "@types/express-serve-static-core": "^4.17.35",
-    "@types/mocha": "^10.0.1",
+    "@types/chai-as-promised": "^7.1.8",
+    "@types/express-serve-static-core": "^4.17.41",
+    "@types/mocha": "^10.0.6",
     "@types/mz": "^2.7.4",
-    "@types/node": "^20.6.0",
+    "@types/node": "18.11.19",
     "@types/node-fetch": "2",
     "@types/sinon": "^10.0.16",
-    "@types/sinon-chai": "^3.2.9",
-    "@typescript-eslint/eslint-plugin": "^6.7.0",
+    "@types/sinon-chai": "^3.2.12",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
     "@typescript-eslint/parser": "^6.3.0",
     "chai": "^4.3.7",
     "chai-as-promised": "^7.1.1",
     "cross-env": "7.0.3",
     "eslint": "^8.45.0",
-    "eslint-config-prettier": "^9.0.0",
-    "eslint-plugin-import": "^2.28.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-import": "^2.29.0",
     "eslint-plugin-mocha": "^10.1.0",
-    "eslint-plugin-prettier": "^5.0.0",
+    "eslint-plugin-prettier": "^5.0.1",
     "esm": "^3.2.25",
     "mocha": "^10.2.0",
-    "mockttp": "^3.9.2",
+    "mockttp": "^3.10.0",
     "mz": "^2.7.0",
     "node-abort-controller": "^3.0.1",
-    "prettier": "^2.8",
-    "rimraf": "5.0.1",
-    "rollup": "^3.27.2",
-    "rollup-plugin-dts": "^6.0.1",
+    "prettier": "^3.1",
+    "rimraf": "5.0.5",
+    "rollup": "^4.7.0",
+    "rollup-plugin-dts": "^6.1.0",
     "rollup-plugin-node-polyfills": "^0.2.1",
     "semantic-release": "^21.0.7",
     "sinon": "^15.2.0",
@@ -126,7 +126,7 @@
     "ts-node": "^10.9.1",
     "tsconfig": "workspace:*",
     "tslib": "^2.6.2",
-    "typedoc": "^0.24.8",
+    "typedoc": "^0.25.4",
     "typescript": "^5.1.6"
   }
 }

package/src/connection.ts

@@ -5711,9 +5711,8 @@ export class Connection {
     } else {
       let disableCache = this._disableBlockhashCaching;
       for (;;) {
-        const latestBlockhash = await this._blockhashWithExpiryBlockHeight(
-          disableCache,
-        );
+        const latestBlockhash =
+          await this._blockhashWithExpiryBlockHeight(disableCache);
         transaction.lastValidBlockHeight = latestBlockhash.lastValidBlockHeight;
         transaction.recentBlockhash = latestBlockhash.blockhash;
 
@@ -5839,9 +5838,8 @@ export class Connection {
     } else {
       let disableCache = this._disableBlockhashCaching;
       for (;;) {
-        const latestBlockhash = await this._blockhashWithExpiryBlockHeight(
-          disableCache,
-        );
+        const latestBlockhash =
+          await this._blockhashWithExpiryBlockHeight(disableCache);
         transaction.lastValidBlockHeight = latestBlockhash.lastValidBlockHeight;
         transaction.recentBlockhash = latestBlockhash.blockhash;
         transaction.sign(...signers);

package/src/programs/stake.ts

@@ -734,7 +734,7 @@ export class StakeProgram {
     if (custodianPubkey) {
       keys.push({
         pubkey: custodianPubkey,
-        isSigner: false,
+        isSigner: true,
         isWritable: false,
       });
     }
@@ -776,7 +776,7 @@ export class StakeProgram {
     if (custodianPubkey) {
       keys.push({
         pubkey: custodianPubkey,
-        isSigner: false,
+        isSigner: true,
         isWritable: false,
       });
     }
@@ -903,7 +903,7 @@ export class StakeProgram {
     if (custodianPubkey) {
       keys.push({
         pubkey: custodianPubkey,
-        isSigner: false,
+        isSigner: true,
         isWritable: false,
       });
     }

package/src/transaction/legacy.ts

@@ -13,6 +13,12 @@ import type {Blockhash} from '../blockhash';
 import type {CompiledInstruction} from '../message';
 import {sign, verify} from '../utils/ed25519';
 
+/** @internal */
+type MessageSignednessErrors = {
+  invalid?: PublicKey[];
+  missing?: PublicKey[];
+};
+
 /**
  * Transaction signature as base-58 encoded string
  */
@@ -757,32 +763,34 @@ export class Transaction {
    *
    * @param {boolean} [requireAllSignatures=true] Require a fully signed Transaction
    */
-  verifySignatures(requireAllSignatures?: boolean): boolean {
-    return this._verifySignatures(
+  verifySignatures(requireAllSignatures: boolean = true): boolean {
+    const signatureErrors = this._getMessageSignednessErrors(
       this.serializeMessage(),
-      requireAllSignatures === undefined ? true : requireAllSignatures,
+      requireAllSignatures,
     );
+    return !signatureErrors;
   }
 
   /**
    * @internal
    */
-  _verifySignatures(
-    signData: Uint8Array,
+  _getMessageSignednessErrors(
+    message: Uint8Array,
     requireAllSignatures: boolean,
-  ): boolean {
+  ): MessageSignednessErrors | undefined {
+    const errors: MessageSignednessErrors = {};
     for (const {signature, publicKey} of this.signatures) {
       if (signature === null) {
         if (requireAllSignatures) {
-          return false;
+          (errors.missing ||= []).push(publicKey);
         }
       } else {
-        if (!verify(signature, signData, publicKey.toBytes())) {
-          return false;
+        if (!verify(signature, message, publicKey.toBytes())) {
+          (errors.invalid ||= []).push(publicKey);
         }
       }
     }
-    return true;
+    return errors.invalid || errors.missing ? errors : undefined;
   }
 
   /**
@@ -799,11 +807,25 @@ export class Transaction {
     );
 
     const signData = this.serializeMessage();
-    if (
-      verifySignatures &&
-      !this._verifySignatures(signData, requireAllSignatures)
-    ) {
-      throw new Error('Signature verification failed');
+    if (verifySignatures) {
+      const sigErrors = this._getMessageSignednessErrors(
+        signData,
+        requireAllSignatures,
+      );
+      if (sigErrors) {
+        let errorMessage = 'Signature verification failed.';
+        if (sigErrors.invalid) {
+          errorMessage += `\nInvalid signature for public key${
+            sigErrors.invalid.length === 1 ? '' : '(s)'
+          } [\`${sigErrors.invalid.map(p => p.toBase58()).join('`, `')}\`].`;
+        }
+        if (sigErrors.missing) {
+          errorMessage += `\nMissing signature for public key${
+            sigErrors.missing.length === 1 ? '' : '(s)'
+          } [\`${sigErrors.missing.map(p => p.toBase58()).join('`, `')}\`].`;
+        }
+        throw new Error(errorMessage);
+      }
     }
 
     return this._serialize(signData);