@sola-air-ui/compiler 1.5.4 → 1.6.0

package/README.md

@@ -36,7 +36,7 @@ npx sola build App.sola
 npx sola-check src/
 ```
 
-`sola-check` validates `.sola` files on disk (pass `--json` for machine-readable output), reporting syntax errors (`SOLA000`) and unbalanced or malformed `{#if}` / `{#each}` / `{:else}` blocks (`SOLA001`).
+`sola-check` validates `.sola` files on disk (pass `--json` for machine-readable output), reporting syntax errors (`SOLA000`) and unbalanced or malformed `{#if}` / `{#each}` / `{:else}` blocks (`SOLA001`), and state written with `.set()` or `.update()` instead of assignment (`SOLA002`), which compiles but throws when it runs.
 
 ## What a `.sola` file looks like
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sola-air-ui/compiler",
-  "version": "1.5.4",
+  "version": "1.6.0",
   "description": "Compiler for Sola single-file components (.sola) \u2014 transforms template + script + style to ES modules",
   "type": "module",
   "main": "./src/index.js",

package/src/check.js

@@ -11,9 +11,52 @@ import { compile } from './index.js';
 
 export const RULES = {
   SOLA000: 'compile error',
-  SOLA001: 'unbalanced block'
+  SOLA001: 'unbalanced block',
+  SOLA002: 'state written with .set() or .update()'
 };
 
+// Text of every <script> body. Plain index search, so `</script >` and odd
+// casing are handled the same way the browser would end the element.
+function scriptBodies(source) {
+  const lower = source.toLowerCase();
+  const bodies = [];
+  let from = 0;
+  for (;;) {
+    const open = lower.indexOf('<script', from);
+    if (open < 0) break;
+    const start = lower.indexOf('>', open);
+    if (start < 0) break;
+    const end = lower.indexOf('</script', start);
+    bodies.push(source.slice(start + 1, end < 0 ? source.length : end));
+    if (end < 0) break;
+    from = end + 8;
+  }
+  return bodies.join('\n');
+}
+
+// A `$state` / `$persist` name is its signal getter, so `count.set(1)` compiles
+// to `count().set(1)` and throws when it runs. State is written by assignment.
+function checkSetterCalls(source, add) {
+  const scripts = scriptBodies(source);
+  const names = new Set();
+  for (const m of scripts.matchAll(/\b(?:let|var|const)\s+([\w$]+)\s*=\s*\$(?:state|persist)\s*\(/g)) names.add(m[1]);
+  if (!names.size) return;
+  const blank = (m) => m.replace(/[^\n]/g, ' ');
+  const code = source
+    .replace(/<style\b[^>]*>[\s\S]*?<\/style>/gi, blank)
+    .replace(/<!--[\s\S]*?-->/g, blank)
+    .replace(/\/\*[\s\S]*?\*\//g, blank)
+    .replace(/(^|[^:])\/\/[^\n]*/g, (m, pre) => pre + blank(m.slice(pre.length)));
+  const call = /(?<![\w$.])([\w$]+)(\(\))?\s*\.\s*(set|update)\s*\(/g;
+  let m;
+  while ((m = call.exec(code))) {
+    const [, name, , method] = m;
+    if (!names.has(name)) continue;
+    const fix = method === 'set' ? `${name} = value` : `${name} = fn(${name})`;
+    add(m.index, 'error', 'SOLA002', `\`${name}.${method}()\` throws at runtime: \`${name}\` is state, which is written by assignment. Use \`${fix}\`.`);
+  }
+}
+
 // Blank out <script> and <style> bodies and HTML comments, keeping newlines so
 // line numbers hold. A commented-out block is not a block.
 function maskNonTemplate(source) {
@@ -68,6 +111,8 @@ export function checkSource(source, filename = 'component.sola') {
     });
   }
 
+  checkSetterCalls(source, add);
+
   const template = maskNonTemplate(source);
   const tag = /\{(#if|#each|\/if|\/each|:else)(?![\w])/g;
   const stack = [];

package/types/check.d.ts

@@ -7,8 +7,8 @@ export interface Diagnostic {
   /** 1-based. */
   column: number;
   severity: 'error' | 'warning';
-  /** SOLA000 compile error, SOLA001 unbalanced block. */
-  code: 'SOLA000' | 'SOLA001';
+  /** SOLA000 compile error, SOLA001 unbalanced block, SOLA002 state written with .set() or .update(). */
+  code: 'SOLA000' | 'SOLA001' | 'SOLA002';
   message: string;
 }