@soimy/dingtalk 3.4.0 → 3.4.2

package/src/runtime.ts

@@ -1,14 +1,12 @@
-import type { PluginRuntime } from "openclaw/plugin-sdk";
+import type { PluginRuntime } from "openclaw/plugin-sdk/core";
+import { createPluginRuntimeStore } from "openclaw/plugin-sdk/runtime-store";
 
-let runtime: PluginRuntime | null = null;
+const runtimeStore = createPluginRuntimeStore<PluginRuntime>("DingTalk runtime not initialized");
 
 export function setDingTalkRuntime(next: PluginRuntime): void {
-  runtime = next;
+  runtimeStore.setRuntime(next);
 }
 
 export function getDingTalkRuntime(): PluginRuntime {
-  if (!runtime) {
-    throw new Error("DingTalk runtime not initialized");
-  }
-  return runtime;
+  return runtimeStore.getRuntime();
 }

package/src/send-service.ts

@@ -8,7 +8,7 @@ import {
 } from "./card-service";
 import { stripTargetPrefix } from "./config";
 import { getLogger } from "./logger-context";
-import { getVoiceDurationMs, uploadMedia as uploadMediaUtil } from "./media-utils";
+import { getVoiceDurationMs, uploadMedia as uploadMediaUtil, type UploadMediaResult } from "./media-utils";
 import { convertMarkdownTablesToPlainText, detectMarkdownAndExtractTitle } from "./message-utils";
 import { DEFAULT_MESSAGE_CONTEXT_TTL_DAYS, upsertOutboundMessageContext } from "./message-context-store";
 import { resolveOriginalPeerId } from "./peer-id-registry";
@@ -203,14 +203,16 @@ function isProactivePermissionOrScopeError(code: string | null): boolean {
 
 /**
  * Wrapper to upload media with shared getAccessToken binding.
+ * Supports sandbox/container paths via mediaLocalRoots option.
  */
 export async function uploadMedia(
   config: DingTalkConfig,
   mediaPath: string,
   mediaType: "image" | "voice" | "video" | "file",
   log?: Logger,
-): Promise<string | null> {
-  return uploadMediaUtil(config, mediaPath, mediaType, getAccessToken, log);
+  options?: { mediaLocalRoots?: string[] },
+): Promise<UploadMediaResult | null> {
+  return uploadMediaUtil(config, mediaPath, mediaType, getAccessToken, log, options);
 }
 
 export async function sendProactiveTextOrMarkdown(
@@ -341,16 +343,19 @@ export async function sendProactiveMedia(
   target: string,
   mediaPath: string,
   mediaType: "image" | "voice" | "video" | "file",
-  options: SendMessageOptions & { accountId?: string } = {},
+  options: SendMessageOptions & { accountId?: string; mediaLocalRoots?: string[] } = {},
 ): Promise<{ ok: boolean; error?: string; data?: any; messageId?: string }> {
   const log = options.log || getLogger();
 
   try {
     // Upload first, then send by media_id.
-    const mediaId = await uploadMedia(config, mediaPath, mediaType, log);
-    if (!mediaId) {
+    const uploadResult = await uploadMedia(config, mediaPath, mediaType, log, {
+      mediaLocalRoots: options.mediaLocalRoots,
+    });
+    if (!uploadResult) {
       return { ok: false, error: "Failed to upload media" };
     }
+    const { mediaId, buffer: uploadedBuffer } = uploadResult;
 
     const token = await getAccessToken(config, log);
     const { targetId, isExplicitUser } = stripTargetPrefix(target);
@@ -371,7 +376,10 @@ export async function sendProactiveMedia(
       msgParam = JSON.stringify({ photoURL: mediaId });
     } else if (mediaType === "voice") {
       msgKey = "sampleAudio";
-      const durationMs = await getVoiceDurationMs(mediaPath, mediaType, log);
+      // Reuse buffer from upload to avoid reading the file twice
+      const durationMs = await getVoiceDurationMs(mediaPath, mediaType, log, {
+        preReadBuffer: uploadedBuffer,
+      });
       msgParam = JSON.stringify({ mediaId, duration: String(durationMs) });
     } else {
       // sampleVideo requires picMediaId; fallback to sampleFile for broader compatibility.
@@ -497,14 +505,20 @@ export async function sendBySession(
 
   // Session webhook supports native media messages; prefer that when media info is available.
   if (options.mediaPath && options.mediaType) {
-    const mediaId = await uploadMedia(config, options.mediaPath, options.mediaType, log);
-    if (mediaId) {
+    const uploadResult = await uploadMedia(config, options.mediaPath, options.mediaType, log, {
+      mediaLocalRoots: options.mediaLocalRoots,
+    });
+    if (uploadResult) {
+      const { mediaId, buffer: uploadedBuffer } = uploadResult;
       let body: any;
 
       if (options.mediaType === "image") {
         body = { msgtype: "image", image: { media_id: mediaId } };
       } else if (options.mediaType === "voice") {
-        const durationMs = await getVoiceDurationMs(options.mediaPath, options.mediaType, log);
+        // Reuse buffer from upload to avoid reading the file twice
+        const durationMs = await getVoiceDurationMs(options.mediaPath, options.mediaType, log, {
+          preReadBuffer: uploadedBuffer,
+        });
         body = { msgtype: "voice", voice: { media_id: mediaId, duration: String(durationMs) } };
       } else if (options.mediaType === "video") {
         body = { msgtype: "video", video: { media_id: mediaId } };

package/src/targeting/agent-name-matcher.ts

@@ -4,7 +4,7 @@
  * Matches @mentions to agent IDs based on name and id fields in agents.list config.
  */
 
-import type { OpenClawConfig } from "openclaw/plugin-sdk";
+import type { OpenClawConfig } from "openclaw/plugin-sdk/core";
 import type { AtMention, AgentNameMatch } from "../types";
 
 interface AgentConfig {

package/src/targeting/agent-routing.ts

@@ -7,7 +7,7 @@
  * (channel + accountId + peer), not content-based dynamic routing.
  */
 
-import type { OpenClawConfig } from "openclaw/plugin-sdk";
+import type { OpenClawConfig } from "openclaw/plugin-sdk/core";
 import { resolveAtAgents } from "./agent-name-matcher";
 import { parseLearnCommand } from "../learning-command-service";
 import { getDingTalkRuntime } from "../runtime";

package/src/targeting/target-directory-adapter.ts

@@ -1,4 +1,5 @@
-import type { ChannelDirectoryEntry, OpenClawConfig } from "openclaw/plugin-sdk";
+import type { OpenClawConfig } from "openclaw/plugin-sdk/core";
+import type { ChannelDirectoryEntry } from "openclaw/plugin-sdk/directory-runtime";
 import { getConfig, stripTargetPrefix } from "../config";
 import { resolveOriginalPeerId } from "../peer-id-registry";
 import { getDingTalkRuntime } from "../runtime";

package/src/types.ts

@@ -10,13 +10,15 @@
  */
 
 import type {
+  ChannelPlugin as SDKChannelPlugin,
   OpenClawConfig,
-  OpenClawPluginApi,
-  ChannelLogSink as SDKChannelLogSink,
+} from "openclaw/plugin-sdk/core";
+import type {
   ChannelAccountSnapshot as SDKChannelAccountSnapshot,
   ChannelGatewayContext as SDKChannelGatewayContext,
-  ChannelPlugin as SDKChannelPlugin,
-} from "openclaw/plugin-sdk";
+  ChannelLogSink as SDKChannelLogSink,
+} from "openclaw/plugin-sdk/channel-runtime";
+import type { ChannelSetupWizard } from "openclaw/plugin-sdk/setup";
 import { mergeAccountWithDefaults } from "./config";
 
 export type AckReactionMode = "off" | "emoji" | "kaomoji";
@@ -24,14 +26,6 @@ export type AckReactionMode = "off" | "emoji" | "kaomoji";
 // explicit modes remain: "off" | "emoji" | "kaomoji".
 export type AckReactionConfigValue = string;
 
-export interface DingtalkPluginModule {
-  id: string;
-  name: string;
-  description?: string;
-  configSchema?: unknown;
-  register?: (api: OpenClawPluginApi) => void | Promise<void>;
-}
-
 /**
  * DingTalk channel configuration (extends base OpenClaw config)
  */
@@ -393,6 +387,8 @@ export interface SendMessageOptions {
   /** Force markdown/text delivery even when messageType is "card". Bypasses card
    *  creation while preserving journal writes and other side-effects. */
   forceMarkdown?: boolean;
+  /** Allowed local roots for sandbox/container media path resolution. */
+  mediaLocalRoots?: string[];
 }
 
 export interface DingTalkTrackingMetadata {
@@ -579,7 +575,9 @@ export interface GatewayStopResult {
 /**
  * DingTalk channel plugin definition
  */
-export type DingTalkChannelPlugin = SDKChannelPlugin<ResolvedAccount & { configured: boolean }>;
+export type DingTalkChannelPlugin = SDKChannelPlugin<ResolvedAccount & { configured: boolean }> & {
+  setupWizard?: ChannelSetupWizard;
+};
 
 /**
  * Result of target resolution validation