@softwear/latestcollectioncore 1.0.68 → 1.0.69

package/dist/buildPropertyMappingFn.js

@@ -2,9 +2,12 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const index_1 = require("./index");
 // The order of the following mappingPairs is significant.
-// The ERM mapping relies on the Gender and ProductGroup mapping to have been evaluated first
+// - If no mapping is available, we prefer colorFamily to be copied from colorSupplier, not colorCodeSupplier.
+//   Hence the order and mustMatch values of the first two lines.
+//
+// - The ERM mapping relies on the Gender and ProductGroup mapping to have been evaluated first
 const mappingPairs = [
-    { category: 'ColorCode', from: 'colorCodeSupplier', to: 'colorFamily' },
+    { category: 'ColorCode', from: 'colorCodeSupplier', to: 'colorFamily', mustMatch: true },
     { category: 'ColorDescription', from: 'colorSupplier', to: 'colorFamily' },
     { category: 'ProductGroup', from: 'articleGroupSupplier', to: 'articleGroup' },
     { category: 'BTEGroup', from: 'articleGroupSupplier', to: 'BTEGROUP', mustMatch: true },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@softwear/latestcollectioncore",
-  "version": "1.0.68",
+  "version": "1.0.69",
   "description": "Core functions for LatestCollections applications",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/buildPropertyMappingFn.ts

@@ -1,9 +1,12 @@
 import { hashBrand, SkuI, BrandSettingI, mappingStrategyE } from './index'
 
 // The order of the following mappingPairs is significant.
-// The ERM mapping relies on the Gender and ProductGroup mapping to have been evaluated first
+// - If no mapping is available, we prefer colorFamily to be copied from colorSupplier, not colorCodeSupplier.
+//   Hence the order and mustMatch values of the first two lines.
+//
+// - The ERM mapping relies on the Gender and ProductGroup mapping to have been evaluated first
 const mappingPairs = [
-  { category: 'ColorCode', from: 'colorCodeSupplier', to: 'colorFamily' },
+  { category: 'ColorCode', from: 'colorCodeSupplier', to: 'colorFamily', mustMatch: true },
   { category: 'ColorDescription', from: 'colorSupplier', to: 'colorFamily' },
   { category: 'ProductGroup', from: 'articleGroupSupplier', to: 'articleGroup' },
   { category: 'BTEGroup', from: 'articleGroupSupplier', to: 'BTEGROUP', mustMatch: true },

package/test/applyPreferedPropertyMappings.spec.js

@@ -176,7 +176,6 @@ describe('applyPreferedPropertyMappings', () => {
       collectionSupplier: 'SUMMER 2022',
       colorCodeSupplier: '100',
       size: 'S',
-      colorFamily: '100',
       collection: 'User defined value wins',
     })
   })

package/test/applyPropertyMapping.spec.js

@@ -16,6 +16,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '100',
+    colorSupplier: 'Black',
     size: 'S',
     sizeSupplier: 'S',
     articleGroupSupplier: '10000',
@@ -25,6 +26,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '100',
+    colorSupplier: 'Black',
     size: 'M',
     sizeSupplier: 'M',
     articleGroupSupplier: '10000',
@@ -34,6 +36,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '100',
+    colorSupplier: 'Black',
     size: 'L',
     sizeSupplier: 'L',
     articleGroupSupplier: '10000',
@@ -43,6 +46,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     size: 'S',
     sizeSupplier: 'S',
     articleGroupSupplier: '10000',
@@ -52,6 +56,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     size: 'M',
     sizeSupplier: 'M',
     articleGroupSupplier: '10000',
@@ -61,6 +66,7 @@ const skus = [
     brand: 'levis',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     size: 'L',
     sizeSupplier: 'L',
     articleGroupSupplier: '10000',
@@ -72,6 +78,7 @@ const skus = [
     collectionSupplier: 'SUMMER 2022',
     collection: 'User defined value wins',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     colorFamily: 'Blue',
     size: 'S',
     sizeSupplier: 'S',
@@ -82,6 +89,7 @@ const skus = [
     brand: 'gstar',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     colorFamily: 'Blue',
     size: 'M',
     sizeSupplier: 'M',
@@ -92,6 +100,7 @@ const skus = [
     brand: 'gstar',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     colorFamily: 'Blue',
     size: 'L',
     sizeSupplier: 'L',
@@ -102,6 +111,7 @@ const skus = [
     brand: 'gstar',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     size: 'M',
     sizeSupplier: 'M',
     collection: '22zomer',
@@ -113,6 +123,7 @@ const skus = [
     brand: 'gstar',
     collectionSupplier: 'SUMMER 2022',
     colorCodeSupplier: '200',
+    colorSupplier: 'Navy',
     colorFamily: 'Blue',
     size: 'L',
     sizeSupplier: 'L',
@@ -244,7 +255,8 @@ describe('applyPropertyMapping', () => {
       colorCodeSupplier: '100',
       size: 'S',
       sizeSupplier: 'S',
-      colorFamily: '100',
+      colorFamily: 'Black',
+      colorSupplier: 'Black',
       collection: 'SUMMER 2022',
       _customsize: 'S',
       articleGroup: '10000',
@@ -366,7 +378,7 @@ describe('applyPropertyMapping', () => {
     expect(mappedSkus[0]['_erm-code']).to.equal('10000 - Women - Dresses')
   })
 
-  it('returns mapped skus on a default mapping rules', function () {
+  it('returns mapped skus on default mapping rules', function () {
     const mappedSkus = applyPropertyMapping(deepCopy(skus), fallbackMapping)
     expect(mappedSkus[0].colorFamily).to.equal('fallbackMapping')
     expect(mappedSkus[1].colorFamily).to.equal('fallbackMapping')
@@ -391,4 +403,9 @@ describe('applyPropertyMapping', () => {
     expect(mappedSkus[6].articleGroup).to.equal('TENANT-articleGroupMapping')
     expect(mappedSkus[10].articleGroup).to.equal('LAT-articleGroupMapping')
   })
+
+  it('returns colorFamily copied from colorSupplier on a articlegroup mapping', function () {
+    const mappedSkus = applyPropertyMapping(deepCopy(skus), articleGroupMapping)
+    expect(mappedSkus[0].colorFamily).to.equal('Black')
+  })
 })