@softspark/ai-toolkit 2.9.0 → 2.10.1

package/scripts/emission.py

@@ -147,7 +147,7 @@ def generate_general_guidelines() -> str:
     lines = [
         "## General Guidelines",
         "",
-        '- Apply "Safety First": no data loss, no blind execution, max 3 loop iterations',
+        '- Apply "Safety First": no data loss, no blind execution, max 5 loop iterations',
         "- Research before acting: check existing code and context before proposing changes",
         "- Use structured commits: feat/fix/docs/refactor/test/chore prefixes",
         "- Quality gates: lint must pass, types must check, tests must be green before done",
@@ -162,7 +162,7 @@ def generate_quality_standards() -> str:
     lines = [
         "## Quality Standards",
         "",
-        "Derived from the immutable safety constitution (5 articles):",
+        "Derived from the immutable safety constitution (6 articles):",
         "",
         "**Article I — Safety First**",
         "- No data loss: never delete files without backup verification"
@@ -170,7 +170,7 @@ def generate_quality_standards() -> str:
         "- No blind execution: never run LLM-generated code without"
         " static analysis or review",
         "- No infinite loops: all autonomous loops must have a maximum"
-        " iteration count (max 3)",
+        " iteration count (max 5)",
         "",
         "**Article II — Hierarchy of Truth**",
         "- The Knowledge Base (`kb/`) is the source of truth;"
@@ -196,6 +196,21 @@ def generate_quality_standards() -> str:
         " user confirmation",
         "- Operate within assigned model tiers; model tier changes"
         " require user approval",
+        "",
+        "**Article VI — Repair Discipline**",
+        "- No dead code: unused code (files, classes, functions, imports,"
+        " variables) must be removed in the same change that makes it"
+        " unused; 'pre-existing' or 'out of scope' is not a valid reason",
+        "- Fix every found bug: bugs, gaps, missing tests, or stale docs"
+        " discovered during a task must be fixed in the same change when"
+        " directly adjacent to the work; deferral requires explicit user"
+        " decision",
+        "- Tests and docs follow behavior: behavior changes must carry"
+        " matching integration and unit tests plus affected documentation"
+        " in the same change",
+        "- Verify before claiming done: re-read the diff before marking"
+        " a task complete; no orphaned references, no missing coverage,"
+        " no stale docs",
     ]
     return "\n".join(lines)
 
@@ -233,7 +248,7 @@ def generate_quality_guidelines() -> str:
         "## Quality Guidelines",
         "",
         '- **Safety First**: No data loss, no blind execution,'
-        " maximum 3 autonomous loop iterations",
+        " maximum 5 autonomous loop iterations",
         "- **No Blind Execution**: Never run LLM-generated code"
         " without static analysis or review",
         '- **Tests are Sacred**: "Green Tests" is the only definition of Done;'

package/scripts/schemas/ai-toolkit-config.schema.json

@@ -81,7 +81,7 @@
     "constitution": {
       "type": "object",
       "additionalProperties": false,
-      "description": "Constitution amendments. Articles I-V are immutable. Base articles are immutable. Projects can only ADD new articles.",
+      "description": "Constitution amendments. Articles I-VI are immutable. Base articles are immutable. Projects can only ADD new articles (7+).",
       "properties": {
         "amendments": {
           "type": "array",

package/scripts/validate.py

@@ -664,6 +664,66 @@ def _validate_version_sync(tk_dir: Path, vr: ValidationResult) -> None:
                     )
 
 
+ROMAN_NUMERALS = ["I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX", "X"]
+
+
+def validate_constitution_drift(tk_dir: Path, vr: ValidationResult) -> None:
+    """Detect article-count drift between constitution.md and downstream docs."""
+    print()
+    print("## Constitution Drift")
+
+    constitution = tk_dir / "app" / "constitution.md"
+    if not constitution.is_file():
+        return
+
+    content = constitution.read_text(encoding="utf-8")
+    matches = re.findall(r"^## Article ([IVX]+):", content, re.MULTILINE)
+    if not matches:
+        vr.error("Constitution has no '## Article <roman>:' headings")
+        return
+
+    count = len(matches)
+    if count > len(ROMAN_NUMERALS):
+        vr.error(f"Constitution has {count} articles (more than {len(ROMAN_NUMERALS)} supported)")
+        return
+    max_roman = ROMAN_NUMERALS[count - 1]
+
+    docs = [
+        tk_dir / "README.md",
+        tk_dir / "app" / "ARCHITECTURE.md",
+        tk_dir / "kb" / "reference" / "architecture-overview.md",
+        tk_dir / "kb" / "reference" / "enterprise-config-guide.md",
+    ]
+
+    count_pat = re.compile(r"\b(\d+)\s+(?:immutable\s+safety\s+)?articles?\b", re.IGNORECASE)
+    range_pat = re.compile(r"\bArticles?\s+I-([IVX]+)\b")
+    drift = 0
+    for doc in docs:
+        if not doc.is_file():
+            continue
+        text = doc.read_text(encoding="utf-8")
+        for m in count_pat.finditer(text):
+            n = int(m.group(1))
+            if 1 <= n <= len(ROMAN_NUMERALS) and n != count:
+                vr.error(
+                    f"{doc.relative_to(tk_dir)} references '{n} articles' "
+                    f"but constitution has {count}"
+                )
+                drift += 1
+        for m in range_pat.finditer(text):
+            end = m.group(1).upper()
+            if end != max_roman and end in ROMAN_NUMERALS:
+                vr.error(
+                    f"{doc.relative_to(tk_dir)} references 'Articles I-{end}' "
+                    f"but constitution has I-{max_roman}"
+                )
+                drift += 1
+
+    if drift == 0:
+        print(f"  OK: constitution has {count} articles (I-{max_roman}), docs consistent")
+    print()
+
+
 def validate_content_quality(tk_dir: Path, vr: ValidationResult) -> None:
     """Check content quality: name matches directory, non-empty body."""
     print()
@@ -709,6 +769,7 @@ def _run_all_checks(tk_dir: Path, vr: ValidationResult) -> tuple[int, int, str]:
     validate_kb_documents(tk_dir, vr)
     validate_core_files(tk_dir, vr)
     actual_tests = validate_metadata_contracts(tk_dir, agent_count, skill_count, vr)
+    validate_constitution_drift(tk_dir, vr)
     validate_content_quality(tk_dir, vr)
     return agent_count, skill_count, actual_tests