@softeria/ms-365-mcp-server 0.134.1 → 0.134.3

package/dist/__tests__/graph-tools.test.js

@@ -393,6 +393,19 @@ describe("graph-tools", () => {
       expect(schema["expand"].description).toContain("navigation");
       expect(schema["expand"].description).toContain("attachments");
     });
+    it("should describe path params it synthesizes itself", async () => {
+      const endpoint = makeEndpoint({ path: "/me/messages/:messageId" });
+      const config = makeConfig();
+      mockEndpoints.push(endpoint);
+      mockEndpointsJson = [config];
+      const server = createMockServer();
+      const { registerGraphTools } = await loadModule();
+      registerGraphTools(server, createMockGraphClient());
+      const schema = server.tools.get("test-tool").schema;
+      expect(schema["messageId"]).toBeDefined();
+      expect(schema["messageId"].description).not.toBe("Path parameter: messageId");
+      expect(schema["messageId"].description).toContain("not as 'id'");
+    });
   });
   describe("MS365_MCP_MAX_TOP", () => {
     const prevMaxTop = process.env.MS365_MCP_MAX_TOP;

package/dist/generated/hack.js

@@ -1,7 +1,12 @@
 import { z } from "zod";
+import { describePathParam } from "../lib/path-params.js";
 function makeApi(endpoints) {
   return endpoints;
 }
+function isPathParamStub(param) {
+  const description = param.description ?? param.schema?.description;
+  return typeof description === "string" && /^Path parameter: /.test(description);
+}
 class Zodios {
   constructor(baseUrlOrEndpoints, endpoints, options) {
     if (typeof baseUrlOrEndpoints === "string") {
@@ -19,17 +24,24 @@ class Zodios {
         pathParams.push(match[1]);
       }
       for (const pathParam of pathParams) {
-        const paramExists = endpoint.parameters.some(
+        const existing = endpoint.parameters.find(
           (param) => param.name === pathParam || param.name === pathParam.replace(/[$_]+/g, "")
         );
-        if (!paramExists) {
+        if (!existing) {
+          const description = describePathParam(pathParam);
           const newParam = {
             name: pathParam,
             type: "Path",
-            schema: z.string().describe(`Path parameter: ${pathParam}`),
-            description: `Path parameter: ${pathParam}`
+            schema: z.string().describe(description),
+            description
           };
           endpoint.parameters.push(newParam);
+          continue;
+        }
+        if (existing.type === "Path" && isPathParamStub(existing)) {
+          const description = describePathParam(existing.name);
+          existing.description = description;
+          existing.schema = z.string().describe(description);
         }
       }
       return endpoint;

package/dist/graph-client.js

@@ -204,7 +204,10 @@ class GraphClient {
   }
   async graphRequest(endpoint, options = {}) {
     try {
-      logger.info(`Calling ${endpoint} with options: ${JSON.stringify(options)}`);
+      const { accessToken: _redacted, ...safeOptions } = options;
+      logger.info(
+        `Calling ${endpoint} with options: ${JSON.stringify(safeOptions)}${_redacted ? " [accessToken=REDACTED]" : ""}`
+      );
       const result = await this.makeRequest(endpoint, options);
       const outputFormat = options.forceJsonOutput ? "json" : this.outputFormat;
       return this.formatJsonResponse(

package/dist/graph-tools.js

@@ -2,6 +2,7 @@ import { randomUUID } from "crypto";
 import logger from "./logger.js";
 import { auditLog, getUserIdentityForAudit } from "./audit-log.js";
 import { isDestructiveOperation } from "./lib/destructive-ops.js";
+import { describePathParam } from "./lib/path-params.js";
 import {
   getEndpointScopeGroups,
   getMissingAllowedScopesForGroups,
@@ -1002,7 +1003,7 @@ function registerGraphTools(server, graphClient, readOnly = false, enabledToolsP
     for (const match of pathParamMatches) {
       const pathParamName = match[1];
       if (!(pathParamName in paramSchema)) {
-        paramSchema[pathParamName] = z.string().describe(`Path parameter: ${pathParamName}`);
+        paramSchema[pathParamName] = z.string().describe(describePathParam(pathParamName));
       }
     }
     if (isFetchAllPagesApplicable(tool)) {

package/dist/lib/path-params.js

@@ -0,0 +1,16 @@
+function describePathParam(pathParamName) {
+  const match = /^(.*?)Id(\d*)$/.exec(pathParamName);
+  if (match && match[1]) {
+    const base = `Value for the '${pathParamName}' path segment. Pass it under the name '${pathParamName}', not as 'id'. `;
+    if (match[2]) {
+      return base + `It identifies a different resource from the similarly named parameter without the number; check the tool's path to see which.`;
+    }
+    const resource = match[1].replace(/([a-z0-9])([A-Z])/g, "$1 $2").toLowerCase();
+    const noun = /(^|\s)object$/.test(resource) ? resource : `${resource} object`;
+    return base + `Use the 'id' field of the ${noun} as returned by Microsoft Graph.`;
+  }
+  return `Value for the '${pathParamName}' path segment.`;
+}
+export {
+  describePathParam
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@softeria/ms-365-mcp-server",
-  "version": "0.134.1",
+  "version": "0.134.3",
   "description": " A Model Context Protocol (MCP) server for interacting with Microsoft 365 and Office services through the Graph API",
   "type": "module",
   "main": "dist/index.js",

package/src/generated/hack.ts

@@ -1,10 +1,17 @@
 import { Endpoint, Parameter } from './endpoint-types.js';
 import { z } from 'zod';
+import { describePathParam } from '../lib/path-params.js';
 
 export function makeApi(endpoints: Endpoint[]) {
   return endpoints;
 }
 
+/** True when a path parameter carries only the generated `Path parameter: x` placeholder. */
+function isPathParamStub(param: Parameter): boolean {
+  const description = param.description ?? param.schema?.description;
+  return typeof description === 'string' && /^Path parameter: /.test(description);
+}
+
 export class Zodios {
   endpoints: Endpoint[];
 
@@ -26,18 +33,30 @@ export class Zodios {
       }
 
       for (const pathParam of pathParams) {
-        const paramExists = endpoint.parameters.some(
+        const existing = endpoint.parameters.find(
           (param) => param.name === pathParam || param.name === pathParam.replace(/[$_]+/g, '')
         );
 
-        if (!paramExists) {
+        if (!existing) {
+          const description = describePathParam(pathParam);
           const newParam: Parameter = {
             name: pathParam,
             type: 'Path',
-            schema: z.string().describe(`Path parameter: ${pathParam}`),
-            description: `Path parameter: ${pathParam}`,
+            schema: z.string().describe(description),
+            description,
           };
           endpoint.parameters.push(newParam);
+          continue;
+        }
+
+        // Some operations arrive with the path parameter already declared, but described
+        // only as `Path parameter: drive-id` — no more use to the model than nothing, and
+        // spelled in kebab-case so it does not even match the name callers must send.
+        // Upgrade those; any real upstream description is left alone.
+        if (existing.type === 'Path' && isPathParamStub(existing)) {
+          const description = describePathParam(existing.name);
+          existing.description = description;
+          existing.schema = z.string().describe(description);
         }
       }