@snowtop/ent 0.1.0-alpha6 → 0.1.0-alpha9

package/core/clause.js

@@ -19,10 +19,12 @@ var __importStar = (this && this.__importStar) || function (mod) {
     return result;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.sensitiveValue = exports.In = exports.Or = exports.And = exports.LessEq = exports.GreaterEq = exports.Less = exports.Greater = exports.NotEq = exports.Eq = void 0;
+exports.sensitiveValue = exports.TsVectorWebsearchToTsQuery = exports.TsVectorPhraseToTsQuery = exports.TsVectorPlainToTsQuery = exports.TsVectorColTsQuery = exports.WebsearchToTsQuery = exports.PhraseToTsQuery = exports.PlainToTsQuery = exports.TsQuery = exports.In = exports.Or = exports.AndOptional = exports.And = exports.LessEq = exports.GreaterEq = exports.Less = exports.Greater = exports.NotEq = exports.Eq = exports.ArrayLessEq = exports.ArrayGreaterEq = exports.ArrayLess = exports.ArrayGreater = exports.ArrayNotEq = exports.ArrayEq = void 0;
 const db_1 = __importStar(require("./db"));
 function isSensitive(val) {
-    return (typeof val === "object" && val.logValue !== undefined);
+    return (val !== null &&
+        typeof val === "object" &&
+        val.logValue !== undefined);
 }
 function rawValue(val) {
     if (isSensitive(val)) {
@@ -31,17 +33,105 @@ function rawValue(val) {
     return val;
 }
 class simpleClause {
-    constructor(col, value, op) {
+    constructor(col, value, op, handleSqliteNull) {
         this.col = col;
         this.value = value;
         this.op = op;
+        this.handleSqliteNull = handleSqliteNull;
     }
     clause(idx) {
+        const sqliteClause = this.sqliteNull();
+        if (sqliteClause) {
+            return sqliteClause.clause(idx);
+        }
         if (db_1.default.getDialect() === db_1.Dialect.Postgres) {
             return `${this.col} ${this.op} $${idx}`;
         }
         return `${this.col} ${this.op} ?`;
     }
+    sqliteNull() {
+        if (!this.handleSqliteNull || this.value !== null) {
+            return;
+        }
+        if (db_1.default.getDialect() !== db_1.Dialect.SQLite) {
+            return;
+        }
+        return this.handleSqliteNull;
+    }
+    values() {
+        const sqliteClause = this.sqliteNull();
+        if (sqliteClause) {
+            return sqliteClause.values();
+        }
+        if (isSensitive(this.value)) {
+            return [this.value.value()];
+        }
+        return [this.value];
+    }
+    logValues() {
+        const sqliteClause = this.sqliteNull();
+        if (sqliteClause) {
+            return sqliteClause.logValues();
+        }
+        if (isSensitive(this.value)) {
+            return [this.value.logValue()];
+        }
+        return [this.value];
+    }
+    instanceKey() {
+        const sqliteClause = this.sqliteNull();
+        if (sqliteClause) {
+            return sqliteClause.instanceKey();
+        }
+        return `${this.col}${this.op}${rawValue(this.value)}`;
+    }
+}
+class isNullClause {
+    constructor(col) {
+        this.col = col;
+    }
+    clause(idx) {
+        return `${this.col} IS NULL`;
+    }
+    values() {
+        return [];
+    }
+    logValues() {
+        return [];
+    }
+    instanceKey() {
+        return `${this.col} IS NULL`;
+    }
+}
+class isNotNullClause {
+    constructor(col) {
+        this.col = col;
+    }
+    clause(idx) {
+        return `${this.col} IS NOT NULL`;
+    }
+    values() {
+        return [];
+    }
+    logValues() {
+        return [];
+    }
+    instanceKey() {
+        return `${this.col} IS NOT NULL`;
+    }
+}
+class arraySimpleClause {
+    constructor(col, value, op) {
+        this.col = col;
+        this.value = value;
+        this.op = op;
+    }
+    clause(idx) {
+        if (db_1.default.getDialect() === db_1.Dialect.Postgres) {
+            return `$${idx} ${this.op} ANY(${this.col})`;
+        }
+        return `${this.col} ${this.op} ?`;
+    }
     values() {
         if (isSensitive(this.value)) {
             return [this.value.value()];
@@ -145,12 +235,100 @@ class compositeClause {
         return keys.join(this.sep);
     }
 }
+class tsQueryClause {
+    constructor(col, val, tsVectorCol) {
+        this.col = col;
+        this.val = val;
+        this.tsVectorCol = tsVectorCol;
+    }
+    isTsQuery(val) {
+        return typeof val !== "string";
+    }
+    getInfo() {
+        if (this.isTsQuery(this.val)) {
+            return { value: this.val.value, language: this.val.language };
+        }
+        return {
+            language: "english",
+            value: this.val,
+        };
+    }
+    clause(idx) {
+        const { language } = this.getInfo();
+        if (db_1.Dialect.Postgres === db_1.default.getDialect()) {
+            if (this.tsVectorCol) {
+                return `to_tsvector(${this.col}) @@ ${this.getFunction()}('${language}', $${idx})`;
+            }
+            return `${this.col} @@ ${this.getFunction()}('${language}', $${idx})`;
+        }
+        // FYI this doesn't actually work for sqlite since different
+        return `${this.col} @@ ${this.getFunction()}('${language}', ?)`;
+    }
+    values() {
+        const { value } = this.getInfo();
+        return [value];
+    }
+    logValues() {
+        const { value } = this.getInfo();
+        return [value];
+    }
+    getFunction() {
+        return "to_tsquery";
+    }
+    instanceKey() {
+        const { language, value } = this.getInfo();
+        if (this.tsVectorCol) {
+            return `to_tsvector(${this.col})@@${this.getFunction()}:${language}:${value}`;
+        }
+        return `${this.col}@@${this.getFunction()}:${language}:${value}`;
+    }
+}
+class plainToTsQueryClause extends tsQueryClause {
+    getFunction() {
+        return "plainto_tsquery";
+    }
+}
+class phraseToTsQueryClause extends tsQueryClause {
+    getFunction() {
+        return "phraseto_tsquery";
+    }
+}
+class websearchTosQueryClause extends tsQueryClause {
+    getFunction() {
+        return "websearch_to_tsquery";
+    }
+}
+// TODO we need to check sqlite version...
+function ArrayEq(col, value) {
+    return new arraySimpleClause(col, value, "=");
+}
+exports.ArrayEq = ArrayEq;
+function ArrayNotEq(col, value) {
+    return new arraySimpleClause(col, value, "!=");
+}
+exports.ArrayNotEq = ArrayNotEq;
+function ArrayGreater(col, value) {
+    return new arraySimpleClause(col, value, ">");
+}
+exports.ArrayGreater = ArrayGreater;
+function ArrayLess(col, value) {
+    return new arraySimpleClause(col, value, "<");
+}
+exports.ArrayLess = ArrayLess;
+function ArrayGreaterEq(col, value) {
+    return new arraySimpleClause(col, value, ">=");
+}
+exports.ArrayGreaterEq = ArrayGreaterEq;
+function ArrayLessEq(col, value) {
+    return new arraySimpleClause(col, value, "<=");
+}
+exports.ArrayLessEq = ArrayLessEq;
 function Eq(col, value) {
-    return new simpleClause(col, value, "=");
+    return new simpleClause(col, value, "=", new isNullClause(col));
 }
 exports.Eq = Eq;
 function NotEq(col, value) {
-    return new simpleClause(col, value, "!=");
+    return new simpleClause(col, value, "!=", new isNotNullClause(col));
 }
 exports.NotEq = NotEq;
 function Greater(col, value) {
@@ -173,6 +351,15 @@ function And(...args) {
     return new compositeClause(args, " AND ");
 }
 exports.And = And;
+function AndOptional(...args) {
+    // @ts-ignore
+    let filtered = args.filter((v) => v !== undefined);
+    if (filtered.length === 1) {
+        return filtered[0];
+    }
+    return And(...filtered);
+}
+exports.AndOptional = AndOptional;
 function Or(...args) {
     return new compositeClause(args, " OR ");
 }
@@ -182,6 +369,60 @@ function In(col, ...values) {
     return new inClause(col, values);
 }
 exports.In = In;
+// if string defaults to english
+// https://www.postgresql.org/docs/current/textsearch-controls.html#TEXTSEARCH-PARSING-QUERIES
+// to_tsquery
+// plainto_tsquery
+// phraseto_tsquery;
+// websearch_to_tsquery
+function TsQuery(col, val) {
+    return new tsQueryClause(col, val);
+}
+exports.TsQuery = TsQuery;
+function PlainToTsQuery(col, val) {
+    return new plainToTsQueryClause(col, val);
+}
+exports.PlainToTsQuery = PlainToTsQuery;
+function PhraseToTsQuery(col, val) {
+    return new phraseToTsQueryClause(col, val);
+}
+exports.PhraseToTsQuery = PhraseToTsQuery;
+function WebsearchToTsQuery(col, val) {
+    return new websearchTosQueryClause(col, val);
+}
+exports.WebsearchToTsQuery = WebsearchToTsQuery;
+// TsVectorColTsQuery is used when the column is not a tsvector field e.g.
+// when there's an index just on the field and is not a combination of multiple fields
+function TsVectorColTsQuery(col, val) {
+    return new tsQueryClause(col, val, true);
+}
+exports.TsVectorColTsQuery = TsVectorColTsQuery;
+// TsVectorPlainToTsQuery is used when the column is not a tsvector field e.g.
+// when there's an index just on the field and is not a combination of multiple fields
+// TODO do these 4 need TsQuery because would be nice to have language?
+// it seems to default to the config of the column
+function TsVectorPlainToTsQuery(col, val) {
+    return new plainToTsQueryClause(col, val, true);
+}
+exports.TsVectorPlainToTsQuery = TsVectorPlainToTsQuery;
+// TsVectorPhraseToTsQuery is used when the column is not a tsvector field e.g.
+// when there's an index just on the field and is not a combination of multiple fields
+function TsVectorPhraseToTsQuery(col, val) {
+    return new phraseToTsQueryClause(col, val, true);
+}
+exports.TsVectorPhraseToTsQuery = TsVectorPhraseToTsQuery;
+// TsVectorWebsearchToTsQuery is used when the column is not a tsvector field e.g.
+// when there's an index just on the field and is not a combination of multiple fields
+function TsVectorWebsearchToTsQuery(col, val) {
+    return new websearchTosQueryClause(col, val, true);
+}
+exports.TsVectorWebsearchToTsQuery = TsVectorWebsearchToTsQuery;
+// TODO would be nice to support this with building blocks but not supporting for now
+// AND: foo & bar,
+// OR: foo | bar
+// followed by: foo <-> bar
+// NOT: !foo
+// starts_with: theo:*
 // wrap a query in the db with this to ensure that it doesn't show up in the logs
 // e.g. if querying for password, SSN, etc
 // we'll pass the right fields to query and log something along the lines of `****`

package/core/config.d.ts

@@ -1,12 +1,25 @@
 /// <reference types="node" />
 import { Database, DBDict } from "./db";
 declare type logType = "query" | "warn" | "info" | "error" | "debug";
+declare enum graphqlMutationName {
+    NOUN_VERB = "NounVerb",
+    VERB_NOUN = "VerbNoun"
+}
+declare enum graphQLFieldFormat {
+    LOWER_CAMEL = "lowerCamel",
+    SNAKE_CASE = "snake_case"
+}
+declare enum fieldPrivacyEvaluated {
+    AT_ENT_LOAD = "at_ent_load",
+    ON_DEMAND = "on_demand"
+}
 export interface Config {
     dbConnectionString?: string;
     dbFile?: string;
     db?: Database | DBDict;
     log?: logType | logType[];
     codegen?: CodegenConfig;
+    customGraphQLJSONPath?: string;
 }
 interface CodegenConfig {
     defaultEntPolicy?: PrivacyConfig;
@@ -17,6 +30,11 @@ interface CodegenConfig {
     generatedHeader?: string;
     disableBase64Encoding?: boolean;
     generateRootResolvers?: boolean;
+    defaultGraphQLMutationName?: graphqlMutationName;
+    defaultGraphQLFieldFormat?: graphQLFieldFormat;
+    schemaSQLFilePath?: boolean;
+    databaseToCompareTo?: string;
+    fieldPrivacyEvaluated?: fieldPrivacyEvaluated;
 }
 interface PrettierConfig {
     custom?: boolean;

package/core/config.js

@@ -28,6 +28,23 @@ const js_yaml_1 = require("js-yaml");
 const db_1 = __importDefault(require("./db"));
 const path = __importStar(require("path"));
 const logger_1 = require("./logger");
+// ent.config.ts eventually. for now ent.yml
+// or ent.yml?
+var graphqlMutationName;
+(function (graphqlMutationName) {
+    graphqlMutationName["NOUN_VERB"] = "NounVerb";
+    graphqlMutationName["VERB_NOUN"] = "VerbNoun";
+})(graphqlMutationName || (graphqlMutationName = {}));
+var graphQLFieldFormat;
+(function (graphQLFieldFormat) {
+    graphQLFieldFormat["LOWER_CAMEL"] = "lowerCamel";
+    graphQLFieldFormat["SNAKE_CASE"] = "snake_case";
+})(graphQLFieldFormat || (graphQLFieldFormat = {}));
+var fieldPrivacyEvaluated;
+(function (fieldPrivacyEvaluated) {
+    fieldPrivacyEvaluated["AT_ENT_LOAD"] = "at_ent_load";
+    fieldPrivacyEvaluated["ON_DEMAND"] = "on_demand";
+})(fieldPrivacyEvaluated || (fieldPrivacyEvaluated = {}));
 function setConfig(cfg) {
     if (cfg.log) {
         (0, logger_1.setLogLevels)(cfg.log);

package/core/db.d.ts

@@ -1,5 +1,5 @@
-import { Pool, ClientConfig, PoolClient } from "pg";
-export interface Database {
+import { Pool, PoolClient, PoolConfig } from "pg";
+export interface Database extends PoolConfig {
     database?: string;
     user?: string;
     password?: string;
@@ -16,7 +16,7 @@ export declare enum Dialect {
 }
 interface DatabaseInfo {
     dialect: Dialect;
-    config: ClientConfig;
+    config: PoolConfig;
     filePath?: string;
 }
 export default class DB {

package/core/db.js

@@ -109,6 +109,8 @@ function getClientConfig(args) {
                     host: cfg.host,
                     port: cfg.port,
                     ssl: cfg.sslmode == "enable",
+                    // max, min, etc
+                    ...cfg,
                 },
             };
         }

package/core/ent.d.ts

@@ -1,5 +1,5 @@
 import { Queryer, SyncQueryer } from "./db";
-import { Viewer, Ent, ID, LoadRowsOptions, LoadRowOptions, Data, DataOptions, QueryableDataOptions, EditRowOptions, LoadEntOptions, LoadCustomEntOptions, EdgeQueryableDataOptions, Context, SelectBaseDataOptions, CreateRowOptions, QueryDataOptions, EntConstructor } from "./base";
+import { Viewer, Ent, ID, LoadRowsOptions, LoadRowOptions, Data, DataOptions, QueryableDataOptions, EditRowOptions, LoadEntOptions, LoadCustomEntOptions, EdgeQueryableDataOptions, Context, SelectBaseDataOptions, CreateRowOptions, QueryDataOptions } from "./base";
 import { Executor } from "../action/action";
 import * as clause from "./clause";
 import { Builder } from "../action";
@@ -23,8 +23,6 @@ export declare type CustomQuery = string | rawQueryOptions | clause.Clause | Que
 export declare function loadCustomData(options: SelectBaseDataOptions, query: CustomQuery, context: Context | undefined): Promise<Data[]>;
 export declare function loadDerivedEnt<T extends Ent>(viewer: Viewer, data: Data, loader: new (viewer: Viewer, data: Data) => T): Promise<T | null>;
 export declare function loadDerivedEntX<T extends Ent>(viewer: Viewer, data: Data, loader: new (viewer: Viewer, data: Data) => T): Promise<T>;
-export declare function applyPrivacyPolicyForEnt<T extends Ent>(viewer: Viewer, ent: T | null): Promise<T | null>;
-export declare function applyPrivacyPolicyForEntX<T extends Ent>(viewer: Viewer, ent: T): Promise<T>;
 export declare function loadRowX(options: LoadRowOptions): Promise<Data>;
 export declare function loadRow(options: LoadRowOptions): Promise<Data | null>;
 export declare function performRawQuery(query: string, values: any[], logValues?: any[]): Promise<Data[]>;
@@ -52,7 +50,7 @@ export interface DataOperation<T extends Ent = Ent> {
 }
 export interface EditNodeOptions<T extends Ent> extends EditRowOptions {
     fieldsToResolve: string[];
-    ent: EntConstructor<T>;
+    loadEntOptions: LoadEntOptions<T>;
     placeholderID?: ID;
 }
 export declare class EditNodeOperation<T extends Ent> implements DataOperation {

package/core/ent.js

@@ -22,8 +22,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.applyPrivacyPolicyForRows = exports.applyPrivacyPolicyForRowX = exports.applyPrivacyPolicyForRow = exports.loadNodesByEdge = exports.loadEdgeForID2 = exports.loadRawEdgeCountX = exports.loadUniqueNode = exports.loadUniqueEdge = exports.loadCustomEdges = exports.loadEdges = exports.defaultEdgeQueryOptions = exports.DefaultLimit = exports.loadEdgeDatas = exports.loadEdgeData = exports.assocEdgeLoader = exports.AssocEdgeData = exports.getCursor = exports.AssocEdge = exports.DeleteNodeOperation = exports.deleteRowsSync = exports.deleteRows = exports.editRowSync = exports.editRow = exports.buildUpdateQuery = exports.createRowSync = exports.createRow = exports.buildInsertQuery = exports.EdgeOperation = exports.EditNodeOperation = exports.buildGroupQuery = exports.buildQuery = exports.loadRows = exports.performRawQuery = exports.loadRow = exports.loadRowX = exports.applyPrivacyPolicyForEntX = exports.applyPrivacyPolicyForEnt = exports.loadDerivedEntX = exports.loadDerivedEnt = exports.loadCustomData = exports.loadCustomEnts = exports.loadEntsFromClause = exports.loadEntsList = exports.loadEnts = exports.loadEntXFromClause = exports.loadEntFromClause = exports.loadEntXViaKey = exports.loadEntX = exports.loadEntViaKey = exports.loadEnt = void 0;
-exports.getEdgeTypeInGroup = void 0;
+exports.getEdgeTypeInGroup = exports.applyPrivacyPolicyForRows = exports.applyPrivacyPolicyForRowX = exports.applyPrivacyPolicyForRow = exports.loadNodesByEdge = exports.loadEdgeForID2 = exports.loadRawEdgeCountX = exports.loadUniqueNode = exports.loadUniqueEdge = exports.loadCustomEdges = exports.loadEdges = exports.defaultEdgeQueryOptions = exports.DefaultLimit = exports.loadEdgeDatas = exports.loadEdgeData = exports.assocEdgeLoader = exports.AssocEdgeData = exports.getCursor = exports.AssocEdge = exports.DeleteNodeOperation = exports.deleteRowsSync = exports.deleteRows = exports.editRowSync = exports.editRow = exports.buildUpdateQuery = exports.createRowSync = exports.createRow = exports.buildInsertQuery = exports.EdgeOperation = exports.EditNodeOperation = exports.buildGroupQuery = exports.buildQuery = exports.loadRows = exports.performRawQuery = exports.loadRow = exports.loadRowX = exports.loadDerivedEntX = exports.loadDerivedEnt = exports.loadCustomData = exports.loadCustomEnts = exports.loadEntsFromClause = exports.loadEntsList = exports.loadEnts = exports.loadEntXFromClause = exports.loadEntFromClause = exports.loadEntXViaKey = exports.loadEntX = exports.loadEntViaKey = exports.loadEnt = void 0;
 const db_1 = __importStar(require("./db"));
 const privacy_1 = require("./privacy");
 const clause = __importStar(require("./clause"));
@@ -140,8 +139,7 @@ async function loadEntXFromClause(viewer, options, clause) {
         context: viewer.context,
     };
     const row = await loadRowX(rowOptions);
-    const ent = new options.ent(viewer, row);
-    return await applyPrivacyPolicyForEntX(viewer, ent);
+    return await applyPrivacyPolicyForRowX(viewer, options, row);
 }
 exports.loadEntXFromClause = loadEntXFromClause;
 async function loadEnts(viewer, options, ...ids) {
@@ -212,7 +210,7 @@ async function loadCustomEnts(viewer, options, query) {
     const result = new Array(rows.length);
     await Promise.all(rows.map(async (row, idx) => {
         const ent = new options.ent(viewer, row);
-        let privacyEnt = await applyPrivacyPolicyForEnt(viewer, ent);
+        let privacyEnt = await applyPrivacyPolicyForEnt(viewer, ent, row, options);
         if (privacyEnt) {
             result[idx] = privacyEnt;
         }
@@ -258,30 +256,60 @@ exports.loadCustomData = loadCustomData;
 // Derived ents
 async function loadDerivedEnt(viewer, data, loader) {
     const ent = new loader(viewer, data);
-    return await applyPrivacyPolicyForEnt(viewer, ent);
+    return await applyPrivacyPolicyForEnt(viewer, ent, data, {
+        ent: loader,
+    });
 }
 exports.loadDerivedEnt = loadDerivedEnt;
 async function loadDerivedEntX(viewer, data, loader) {
     const ent = new loader(viewer, data);
-    return await applyPrivacyPolicyForEntX(viewer, ent);
+    return await applyPrivacyPolicyForEntX(viewer, ent, data, { ent: loader });
 }
 exports.loadDerivedEntX = loadDerivedEntX;
-async function applyPrivacyPolicyForEnt(viewer, ent) {
+// everything calls into this two so should be fine
+// TODO is there a smarter way to not instantiate two objects here?
+async function applyPrivacyPolicyForEnt(viewer, ent, data, fieldPrivacyOptions) {
     if (ent) {
         const visible = await (0, privacy_1.applyPrivacyPolicy)(viewer, ent.privacyPolicy, ent);
-        if (visible) {
-            return ent;
+        if (!visible) {
+            return null;
         }
+        return doFieldPrivacy(viewer, ent, data, fieldPrivacyOptions);
     }
     return null;
 }
-exports.applyPrivacyPolicyForEnt = applyPrivacyPolicyForEnt;
-async function applyPrivacyPolicyForEntX(viewer, ent) {
+async function applyPrivacyPolicyForEntX(viewer, ent, data, options) {
     // this will throw
     await (0, privacy_1.applyPrivacyPolicyX)(viewer, ent.privacyPolicy, ent);
+    return doFieldPrivacy(viewer, ent, data, options);
+}
+async function doFieldPrivacy(viewer, ent, data, options) {
+    if (!options.fieldPrivacy) {
+        return ent;
+    }
+    const promises = [];
+    let somethingChanged = false;
+    for (const [k, policy] of options.fieldPrivacy) {
+        promises.push((async () => {
+            // don't do anything if key is null or for some reason missing
+            const curr = data[k];
+            if (curr === null || curr === undefined) {
+                return;
+            }
+            const r = await (0, privacy_1.applyPrivacyPolicy)(viewer, policy, ent);
+            if (!r) {
+                data[k] = null;
+                somethingChanged = true;
+            }
+        })());
+    }
+    await Promise.all(promises);
+    if (somethingChanged) {
+        // have to create new instance
+        return new options.ent(viewer, data);
+    }
     return ent;
 }
-exports.applyPrivacyPolicyForEntX = applyPrivacyPolicyForEntX;
 function logQuery(query, logValues) {
     (0, logger_1.log)("query", {
         query: query,
@@ -327,6 +355,8 @@ async function loadRow(options) {
         return res.rows[0];
     }
     catch (e) {
+        // an example of an error being suppressed
+        // another one. TODO https://github.com/lolopinto/ent/issues/862
         (0, logger_1.log)("error", e);
         return null;
     }
@@ -439,6 +469,8 @@ class EditNodeOperation {
         };
         if (this.existingEnt) {
             if (this.hasData(options.fields)) {
+                // even this with returning * may not always work if transformed...
+                // we can have a transformed flag to see if it should be returned?
                 this.row = await editRow(queryer, options, this.existingEnt.id, "RETURNING *");
             }
             else {
@@ -450,20 +482,36 @@ class EditNodeOperation {
         }
     }
     reloadRow(queryer, id, options) {
+        // TODO this isn't always an ObjectLoader. should throw or figure out a way to get query
+        // and run this on its own...
+        const loader = this.options.loadEntOptions.loaderFactory.createLoader(options.context);
+        const opts = loader.getOptions();
+        let cls = clause.Eq(options.key, id);
+        if (opts.clause) {
+            let optionClause;
+            if (typeof opts.clause === "function") {
+                optionClause = opts.clause();
+            }
+            else {
+                optionClause = opts.clause;
+            }
+            if (optionClause) {
+                cls = clause.And(optionClause, cls);
+            }
+        }
         const query = buildQuery({
-            fields: ["*"],
+            fields: opts.fields.length ? opts.fields : ["*"],
             tableName: options.tableName,
-            clause: clause.Eq(options.key, id),
+            clause: cls,
         });
         // special case log here because we're not going through any of the normal
         // methods here because those are async and this is sync
         // this is the only place we're doing this so only handling here
         logQuery(query, [id]);
         const r = queryer.querySync(query, [id]);
-        if (r.rows.length !== 1) {
-            throw new Error(`couldn't reload row for ${id}`);
+        if (r.rows.length === 1) {
+            this.row = r.rows[0];
         }
-        this.row = r.rows[0];
     }
     performWriteSync(queryer, context) {
         let options = {
@@ -492,7 +540,7 @@ class EditNodeOperation {
         if (!this.row) {
             return null;
         }
-        return new this.options.ent(viewer, this.row);
+        return new this.options.loadEntOptions.ent(viewer, this.row);
     }
 }
 exports.EditNodeOperation = EditNodeOperation;
@@ -1146,20 +1194,19 @@ async function applyPrivacyPolicyForRow(viewer, options, row) {
         return null;
     }
     const ent = new options.ent(viewer, row);
-    return await applyPrivacyPolicyForEnt(viewer, ent);
+    return await applyPrivacyPolicyForEnt(viewer, ent, row, options);
 }
 exports.applyPrivacyPolicyForRow = applyPrivacyPolicyForRow;
 async function applyPrivacyPolicyForRowX(viewer, options, row) {
     const ent = new options.ent(viewer, row);
-    return await applyPrivacyPolicyForEntX(viewer, ent);
+    return await applyPrivacyPolicyForEntX(viewer, ent, row, options);
 }
 exports.applyPrivacyPolicyForRowX = applyPrivacyPolicyForRowX;
 async function applyPrivacyPolicyForRows(viewer, rows, options) {
     let m = new Map();
     // apply privacy logic
     await Promise.all(rows.map(async (row) => {
-        const ent = new options.ent(viewer, row);
-        let privacyEnt = await applyPrivacyPolicyForEnt(viewer, ent);
+        let privacyEnt = await applyPrivacyPolicyForRow(viewer, options, row);
         if (privacyEnt) {
             m.set(privacyEnt.id, privacyEnt);
         }

package/core/loaders/assoc_edge_loader.d.ts

@@ -32,7 +32,7 @@ export declare class AssocEdgeLoaderFactory<T extends AssocEdge> implements Load
     name: string;
     constructor(edgeType: string, edgeCtr: AssocEdgeConstructor<T> | (() => AssocEdgeConstructor<T>));
     createLoader(context?: Context): AssocLoader<T>;
-    private isFunction;
+    private isConstructor;
     createConfigurableLoader(options: EdgeQueryableDataOptions, context?: Context): AssocLoader<T>;
 }
 export {};

package/core/loaders/assoc_edge_loader.js

@@ -161,16 +161,17 @@ class AssocEdgeLoaderFactory {
     createLoader(context) {
         return this.createConfigurableLoader({}, context);
     }
-    isFunction(edgeCtr) {
-        // not constructor
-        return !(edgeCtr.prototype && edgeCtr.prototype.constructor === edgeCtr);
+    isConstructor(edgeCtr) {
+        return (edgeCtr.prototype &&
+            edgeCtr.prototype.constructor &&
+            edgeCtr.prototype.constructor.name.length > 0);
     }
     createConfigurableLoader(options, context) {
         let edgeCtr = this.edgeCtr;
         // in generated code, the edge is not necessarily defined at the time of loading
         // so we call this as follows:
         // const loader = new AssocEdgeLoaderFactory(EdgeType.Foo, ()=>DerivedEdgeClass);
-        if (this.isFunction(edgeCtr)) {
+        if (!this.isConstructor(edgeCtr)) {
             edgeCtr = edgeCtr();
         }
         // rename to make TS happy

package/core/loaders/index_loader.js

@@ -4,6 +4,7 @@ exports.IndexLoaderFactory = void 0;
 const query_loader_1 = require("./query_loader");
 // we're keeping this for legacy reasons so as to not break existing callers
 // and to decouple the change here but all callers can safely be changed here to use QueryLoaderFactory
+// @deprecated use QueryLoaderFactory
 class IndexLoaderFactory {
     constructor(options, col, opts) {
         this.factory = new query_loader_1.QueryLoaderFactory({

package/core/loaders/object_loader.d.ts

@@ -7,17 +7,22 @@ export declare class ObjectLoader<T> implements Loader<T, Data | null> {
     private primedLoaders;
     private memoizedInitPrime;
     constructor(options: SelectDataOptions, context?: Context | undefined, toPrime?: ObjectLoaderFactory<T>[] | undefined);
+    getOptions(): SelectDataOptions;
     private initPrime;
     load(key: T): Promise<Data | null>;
     clearAll(): void;
     loadMany(keys: T[]): Promise<Data[]>;
     prime(data: Data): void;
 }
+interface ObjectLoaderOptions extends SelectDataOptions {
+    instanceKey?: string;
+}
 export declare class ObjectLoaderFactory<T> implements LoaderFactory<T, Data | null> {
-    options: SelectDataOptions;
+    options: ObjectLoaderOptions;
     name: string;
     private toPrime;
-    constructor(options: SelectDataOptions);
+    constructor(options: ObjectLoaderOptions);
     createLoader(context?: Context): ObjectLoader<T>;
     addToPrime(factory: ObjectLoaderFactory<T>): void;
 }
+export {};